FailedChanges

Summary

  1. [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API. (details)
  2. [CodeGen] Do the Simple Early Return in block-placement pass to optimize (details)
Commit bb56755f153a83387fa6c7fa0a6d7d540da41633 by grimar
[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.
urrently we have the following functions for error reporting:
-- LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg); void
reportError(Error Err, StringRef Input);  void reportWarning(Twine Msg);
void reportWarning(StringRef Input, Error Err); void warn(llvm::Error
Err); void error(std::error_code EC);
---
Problems are: naming is inconsistent, arguments order is inconsistent,
some of the functions looks excessive.
After applying this patch we have:
--- LLVM_ATTRIBUTE_NORETURN void reportError(Error Err, StringRef
Input);  LLVM_ATTRIBUTE_NORETURN void reportError(std::error_code EC,
StringRef Input); void reportWarning(Error Err, StringRef Input);
---
I'd be happy to remove reportError(std::error_code EC, StringRef Input)
too, but it is used by COFF heavily.
Test cases were updated, they show an improvement introduced.
Differential revision: https://reviews.llvm.org/D66286
llvm-svn: 369190
The file was modifiedllvm/test/tools/llvm-readobj/mips-got.test (diff)
The file was modifiedllvm/test/tools/llvm-readobj/elf-dynamic-malformed.test (diff)
The file was modifiedllvm/tools/llvm-readobj/llvm-readobj.cpp (diff)
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp (diff)
The file was modifiedllvm/test/tools/llvm-readobj/elf-malformed-pt-dynamic.test (diff)
The file was modifiedllvm/test/tools/llvm-readobj/elf-non-dynamic-in-pt-dynamic.test (diff)
The file was modifiedllvm/tools/llvm-readobj/DwarfCFIEHPrinter.h (diff)
The file was modifiedllvm/test/Object/invalid.test (diff)
The file was modifiedllvm/tools/llvm-readobj/COFFDumper.cpp (diff)
The file was modifiedllvm/tools/llvm-readobj/MachODumper.cpp (diff)
The file was modifiedllvm/test/tools/llvm-readobj/string-dump.test (diff)
The file was modifiedllvm/test/tools/llvm-readobj/elf-broken-dynsym-link.test (diff)
The file was modifiedllvm/test/tools/llvm-readobj/hex-dump.test (diff)
The file was modifiedllvm/test/tools/llvm-readobj/note-core-ntfile-bad.test (diff)
The file was modifiedllvm/tools/llvm-readobj/llvm-readobj.h (diff)
The file was modifiedllvm/test/tools/llvm-readobj/elf-dynamic-not-in-pt-dynamic.test (diff)
The file was modifiedllvm/tools/llvm-readobj/ObjDumper.cpp (diff)
Commit b3d258fc44b588f06eb35f8e4b9a6d1fc859acec by shkzhang
[CodeGen] Do the Simple Early Return in block-placement pass to optimize
the blocks
Summary:
Fix a bug of preducessors.
In `block-placement` pass, it will create some patterns for
unconditional we can do the simple early retrun. But the `early-ret`
pass is before `block-placement`, we don't want to run it again. This
patch is to do the simple early return to optimize the blocks at the
last of `block-placement`.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D63972
llvm-svn: 369191
The file was modifiedllvm/test/CodeGen/PowerPC/block-placement.mir (diff)
The file was modifiedllvm/lib/CodeGen/MachineBlockPlacement.cpp (diff)