1. Remove redundant curly braces. (details)
  2. [MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is (details)
Commit 9a0f124f26437504c50fdb78401b73d820ed3991 by Adrian Prantl
Remove redundant curly braces.
llvm-svn: 369670
The file was modifiedlldb/tools/lldb-test/lldb-test.cpp (diff)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp (diff)
Commit 5b5ee61b5fa95327ed5a57b16f22e9e52a459129 by francisvm
[MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is
Local symbols in the indirect symbol table contain the value
`INDIRECT_SYMBOL_LOCAL` and the corresponding __pointers entry must
contain the address of the target.
In r349060, I added support for local symbols in the indirect symbol
table, which was checking if the symbol `isDefined` && `!isExternal` to
determine if the symbol is local or not.
It turns out that `isDefined` will return false if the user of the
symbol comes before its definition, and we'll again generate .long 0
which will be the symbol at the adress 0x0.
Instead of doing that, use GlobalValue::hasLocalLinkage() to check if
the symbol is local.
Differential Revision:
llvm-svn: 369671
The file was modifiedllvm/include/llvm/Target/TargetLoweringObjectFile.h (diff)
The file was modifiedllvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)
The file was modifiedllvm/test/MC/MachO/cstexpr-gotpcrel-32.ll (diff)
The file was modifiedllvm/lib/Target/X86/X86TargetObjectFile.h (diff)
The file was modifiedllvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetObjectFile.cpp (diff)
The file was modifiedllvm/lib/Target/X86/X86TargetObjectFile.cpp (diff)
The file was modifiedllvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetObjectFile.h (diff)