SuccessChanges

Summary

  1. [libc][NFC] Add library of floating point test matchers. (details)
  2. [libc][NFC] Disable a loader test as ld.gold fails to link. (details)
  3. [test][DebugInfo] Adapt two tests for Sun assembler syntax on Sparc (details)
Commit db936e0e915377a58032dccc13bedbfccf0a1ca8 by sivachandra
[libc][NFC] Add library of floating point test matchers.

This eliminates UnitTest's dependency on FPUtil and hence prevents
non-math tests from depending indirectly on FPUtil. The patch
essentially moves some of the existing pieces into a library of its own.

Along the way, renamed add_math_unittest to add_fp_unittest.

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D85486
The file was modifiedlibc/test/src/math/fmin_test.cpp (diff)
The file was modifiedlibc/test/src/math/fmaxf_test.cpp (diff)
The file was modifiedlibc/utils/UnitTest/Test.h (diff)
The file was modifiedlibc/test/src/math/CMakeLists.txt (diff)
The file was modifiedlibc/utils/FPUtil/CMakeLists.txt (diff)
The file was modifiedlibc/test/src/math/fmaxl_test.cpp (diff)
The file was addedlibc/utils/FPUtil/TestHelpers.cpp
The file was addedlibc/utils/FPUtil/TestHelpers.h
The file was modifiedlibc/test/src/math/fmax_test.cpp (diff)
The file was modifiedlibc/test/src/math/fminf_test.cpp (diff)
The file was modifiedlibc/test/src/math/fminl_test.cpp (diff)
The file was modifiedlibc/utils/UnitTest/Test.cpp (diff)
Commit f6d74b29d6dc437db983aabee0b2b6d6d3c52f56 by sivachandra
[libc][NFC] Disable a loader test as ld.gold fails to link.

Will be reenabled after investigating and fixing the problem.
The file was modifiedlibc/test/loader/linux/CMakeLists.txt (diff)
Commit 0b90a08f7722980f6074c6eada8022242408cdb4 by ro
[test][DebugInfo] Adapt two tests for Sun assembler syntax on Sparc

Two DebugInfo tests currently `FAIL` on Sparc:

  LLVM :: DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll
  LLVM :: DebugInfo/Generic/array.ll

both in a similar way.  E.g.

  : 'RUN: at line 1';   /var/llvm/local-sparcv9-A/bin/llc -O2 /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll -o - | /var/llvm/local-sparcv9-A/bin/FileCheck /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll

  /vol/llvm/src/llvm-project/local/llvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll:4:10: error: CHECK: expected string not found in input
  ; CHECK: debug_info,
           ^

On `amd64-pc-solaris2.11`, the corresponding line is

  .section        .debug_info,"",@progbits

while on `sparcv9-sun-solaris2.11` we have only

  .section        .debug_info

This happens because Sparc currently emits `.section` directives using the
style of the Solaris/SPARC assembler (controlled by `SunStyleELFSectionSwitchSyntax`).

This patch takes the easy way out and allows both forms while tightening the
check to only match the `.section` directive.

Tested on `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`,
`x86_64-pc-linux-gnu`, and `x86_64-apple-darwin20.0.0`.

Differential Revision: https://reviews.llvm.org/D85414
The file was modifiedllvm/test/DebugInfo/Generic/array.ll (diff)
The file was modifiedllvm/test/DebugInfo/Generic/2010-06-29-InlinedFnLocalVar.ll (diff)