SuccessChanges

Summary

  1. [Clang] implement -fno-eliminate-unused-debug-types (details)
  2. [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang (details)
  3. python bindings: fix DeprecationWarning (details)
  4. [mlir] Fix mlir build break due to warning when NDEBUG is not set (details)
  5. [Diagnostics] Ignore structs and long text for -Wstring-concatenation (details)
Commit 4f2ad15db535873dda9bfe248a2771023b64a43c by ndesaulniers
[Clang] implement -fno-eliminate-unused-debug-types

Fixes pr/11710.
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Resubmit after breaking Windows and OSX builds.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D80242
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp (diff)
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp (diff)
The file was modifiedclang/include/clang/Basic/CodeGenOptions.h (diff)
The file was modifiedclang/lib/CodeGen/CGDebugInfo.h (diff)
The file was modifiedclang/lib/CodeGen/CGDecl.cpp (diff)
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp (diff)
The file was addedclang/test/CodeGen/debug-info-unused-types.c
The file was modifiedclang/test/Driver/debug-options.c (diff)
The file was modifiedclang/docs/UsersManual.rst (diff)
The file was modifiedclang/docs/ClangCommandLineReference.rst (diff)
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def (diff)
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp (diff)
The file was addedclang/test/CodeGen/debug-info-unused-types.cpp
The file was modifiedclang/include/clang/Driver/Options.td (diff)
The file was modifiedclang/include/clang/Basic/DebugInfoOptions.h (diff)
The file was modifiedclang/docs/CommandGuide/clang.rst (diff)
Commit fa5d22a045de543b4df9eb5edfb8d70ce43bd13a by johannes
[OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

Replace the `ident_t` handling in Clang with the methods offered by the
OMPIRBuilder. This cuts down on the clang code as well as the
differences between the two, making further transitions easier. Tests
have changed but there should not be a real functional change. The most
interesting difference is probably that we stop generating local ident_t
allocations for now and just use globals. Given that this happens only
with debug info, the location part of the `ident_t` is probably bigger
than the test anyway. As the location part is already a global, we can
avoid the allocation, memcpy, and store in favor of a constant global
that is slightly bigger. This can be revisited if there are
complications.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D80735
The file was modifiedclang/test/OpenMP/teams_distribute_parallel_for_simd_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/teams_distribute_parallel_for_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/single_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_simd_in_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/sections_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_simd_codegen.cpp (diff)
The file was modifiedllvm/lib/IR/IRBuilder.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_num_teams_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_in_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_if_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_lastprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_reduction_codegen_UDR.cpp (diff)
The file was modifiedllvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_copyin_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_for_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_in_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_simd_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_depend_codegen.cpp (diff)
The file was modifiedllvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h (diff)
The file was modifiedclang/test/OpenMP/distribute_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp (diff)
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.h (diff)
The file was modifiedclang/test/OpenMP/task_in_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_simd_depend_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_depend_codegen.cpp (diff)
The file was modifiedllvm/test/Transforms/OpenMP/deduplication.ll (diff)
The file was modifiedclang/test/OpenMP/openmp_win_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_simd_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/teams_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_firstprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_thread_limit_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_parallel_for_simd_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_parallel_for_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_linear_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/threadprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_proc_bind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/ordered_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_for_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_parallel_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/sections_reduction_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/target_depend_codegen.cpp (diff)
The file was modifiedllvm/include/llvm/IR/IRBuilder.h (diff)
The file was modifiedclang/test/OpenMP/teams_distribute_parallel_for_simd_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/sections_lastprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/single_firstprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/teams_distribute_parallel_for_num_threads_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/sections_firstprivate_codegen.cpp (diff)
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.cpp (diff)
Commit 05d74dbc3bb1d943a029e4abea211288c920f559 by ndesaulniers
python bindings: fix DeprecationWarning

Fixes observed warning running `ninja check-all`:
llvm-project/clang/bindings/python/tests/cindex/test_diagnostics.py:100:
DeprecationWarning: Please use assertRegex instead.
  self.assertRegexpMatches(children[0].spelling

Looks like unittest.assertRegexpMatches has been deprecated in favor of
unittest.assertRegex since Python 3.2, according to:
https://docs.python.org/3/library/unittest.html#deprecated-aliases

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D85692
The file was modifiedclang/bindings/python/tests/cindex/test_diagnostics.py (diff)
Commit 0de60b550b727fa3a0202a9ab5ca30520e291dd5 by thomasraoux
[mlir] Fix mlir build break due to warning when NDEBUG is not set
The file was modifiedmlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp (diff)
Commit 4b59dc77dc473bba849c1b08f3a1ab7be5733ad1 by Dávid Bolvanský
[Diagnostics] Ignore structs and long text for -Wstring-concatenation
The file was modifiedclang/test/Sema/string-concat.c (diff)
The file was modifiedclang/lib/Sema/SemaExpr.cpp (diff)