SuccessChanges

Summary

  1. [AArch64] Remove a duplicate call to setHasWinCFI. NFCI. (details)
  2. [AArch64] Don't merge sp decrement into later stores when using WinCFI (details)
  3. [clangd] Split DecisionForest Evaluate() into one func per tree. (details)
  4. Reland  rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking. (details)
Commit 51e74e21aae8b4e885e23d3f15922a58bc173c34 by martin
[AArch64] Remove a duplicate call to setHasWinCFI. NFCI.

The function already has a cleanup scope that calls the same whenever
the function is exited. When reading the code, seeing that this return
codepath has an explicit call while other return paths lack it is
confusing.

In the hypothetical case of a function having a prologue that
set the HasWinCFI flag in the MF, but the epilogue containing no
WinCFI instructions, the HasWinCFI flag in the MF would end up reset back
to false.

Differential Revision: https://reviews.llvm.org/D88636
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp (diff)
Commit f4b9dfd9bc414a316d997a314b05ac7f9258a722 by martin
[AArch64] Don't merge sp decrement into later stores when using WinCFI

This matches the corresponding existing case in
AArch64LoadStoreOpt::findMatchingUpdateInsnForward.

Both cases could also be modified to check
MBBI->getFlag(FrameSetup/FrameDestroy) instead of forbidding any
optimization involving SP, but the effect is probably pretty much
the same.

Differential Revision: https://reviews.llvm.org/D88541
The file was modifiedllvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp (diff)
The file was modifiedllvm/test/CodeGen/AArch64/arm64-windows-calls.ll (diff)
Commit 45698ac0052ae5b1c5beb739636396a5b7263966 by usx
[clangd] Split DecisionForest Evaluate() into one func per tree.

This allows us MSAN to instrument this function. Previous version is not
instrumentable due to it shear volume.

Differential Revision: https://reviews.llvm.org/D88536
The file was modifiedclang-tools-extra/clangd/quality/CompletionModelCodegen.py (diff)
Commit cb3fd715f324ff0f58dfeb7d08a88a05477cb0d5 by vyng
Reland  rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking.

This is mostly for the benefit of the LBR latency mode.
Right now, it performs no checking. If this is run on non-supported hardware, it will produce all zeroes for latency.

      Differential Revision: https://reviews.llvm.org/D85254

New change: Updated lit.local.cfg to use pass the right argument to llvm-exegesis to actually request the LBR mode.

Differential Revision: https://reviews.llvm.org/D88670
The file was modifiedllvm/tools/llvm-exegesis/lib/X86/X86Counter.h (diff)
The file was modifiedllvm/test/tools/llvm-exegesis/X86/lbr/lit.local.cfg (diff)
The file was modifiedllvm/tools/llvm-exegesis/lib/X86/Target.cpp (diff)
The file was modifiedllvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp (diff)
The file was modifiedllvm/tools/llvm-exegesis/llvm-exegesis.cpp (diff)
The file was modifiedllvm/tools/llvm-exegesis/lib/Target.h (diff)