SuccessChanges

Summary

  1. [SimplifyLibCalls] fix crash with empty function name (PR43347) (details)
  2. Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize" (details)
Commit d46bf63fbbad623d73ec8c6889f9e8efa802ce40 by spatel
[SimplifyLibCalls] fix crash with empty function name (PR43347)
...and improve some variable names while here.
https://bugs.llvm.org/show_bug.cgi?id=43347
llvm-svn: 372227
The file was modifiedllvm/test/Transforms/InstCombine/sqrt.ll (diff)
The file was modifiedllvm/lib/Transforms/Utils/SimplifyLibCalls.cpp (diff)
Commit 2f1bba7fd0777477542f7f87d485994bf00453c3 by krasimir
Revert "[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize"
Summary: This reverts commit r372204.
This change causes build bot failures under msan:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check-llvm%20msan/logs/stdio:
``` FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579)
******************** TEST 'LLVM ::
DebugInfo/AArch64/asan-stack-vars.mir' FAILED ********************
Script:
--
: 'RUN: at line 1'; 
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0
-start-before=livedebugvalues -filetype=obj -o -
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
|
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump
-v - |
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
-- Exit Code: 2
Command Output (stderr):
--
==62894==WARNING: MemorySanitizer: use-of-uninitialized-value
   #0 0xdfcafb in
llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction
const&, int, bool, unsigned int&, bool, bool) const
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3
   #1 0xdfae8a in resolveFrameIndexReference
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1580:10
   #2 0xdfae8a in
llvm::AArch64FrameLowering::getFrameIndexReference(llvm::MachineFunction
const&, int, unsigned int&) const
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1536
   #3 0x46642c1 in (anonymous
namespace)::LiveDebugValues::extractSpillBaseRegAndOffset(llvm::MachineInstr
const&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:582:21
   #4 0x4647cb3 in transferSpillOrRestoreInst
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:883:11
   #5 0x4647cb3 in process
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1079
   #6 0x4647cb3 in (anonymous
namespace)::LiveDebugValues::ExtendRanges(llvm::MachineFunction&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1361
   #7 0x463ac0e in (anonymous
namespace)::LiveDebugValues::runOnMachineFunction(llvm::MachineFunction&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1415:18
   #8 0x4854ef0 in
llvm::MachineFunctionPass::runOnFunction(llvm::Function&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:73:13
   #9 0x53b0b01 in llvm::FPPassManager::runOnFunction(llvm::Function&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1648:27
   #10 0x53b15f6 in llvm::FPPassManager::runOnModule(llvm::Module&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1685:16
   #11 0x53b298d in runOnModule
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1750:27
   #12 0x53b298d in llvm::legacy::PassManagerImpl::run(llvm::Module&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1863
   #13 0x905f21 in compileModule(char**, llvm::LLVMContext&)
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:601:8
   #14 0x8fdc4e in main
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:355:22
   #15 0x7f67673632e0 in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
   #16 0x882369 in _start
(/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc+0x882369)
MemorySanitizer: use-of-uninitialized-value
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3
in
llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction
const&, int, bool, unsigned int&, bool, bool) const Exiting error: -:
The file was not recognized as a valid object file FileCheck error: '-'
is empty. FileCheck command line:
/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck
/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir
```
Reviewers: bkramer
Reviewed By: bkramer
Subscribers: sdardis, aprantl, kristof.beyls, jrtc27, atanasyan,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67710
llvm-svn: 372228
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp (diff)
The file was modifiedllvm/test/DebugInfo/MIR/Mips/live-debug-values-reg-copy.mir (diff)
The file was modifiedllvm/lib/CodeGen/RegUsageInfoCollector.cpp (diff)
The file was modifiedllvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir (diff)
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp (diff)
The file was removedllvm/test/CodeGen/AArch64/wrong-callee-save-size-after-livedebugvariables.mir
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp (diff)
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.h (diff)
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h (diff)
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.cpp (diff)