FailedChanges

Summary

  1. [lldb][tests] Take into account all parent's categories when traverse (details)
  2. [lldb][test] NFC, re-use _getTestPath() function (details)
  3. [FPEnv] Generate constrained FP comparisons from clang (details)
Commit e4d672971030fe26dbb8237038038c3ff9ae7541 by Tatyana Krasnukha
[lldb][tests] Take into account all parent's categories when traverse
folders upwards
This is needed to not re-write parent's categories by categories of a
nested folder, e.g. commands/expression/completion specify "cmdline"
category, however it still belongs to parent's "expression" category.
The sentinel ".categories" in the test-suite root directory is no longer
needed.
Differential Revision: https://reviews.llvm.org/D71905
The file was removedlldb/packages/Python/lldbsuite/test/.categories
The file was modifiedlldb/packages/Python/lldbsuite/test/test_result.py (diff)
Commit 9ba151274869c377921a09ba0bd635412da755ef by Tatyana Krasnukha
[lldb][test] NFC, re-use _getTestPath() function
The file was modifiedlldb/packages/Python/lldbsuite/test/test_result.py (diff)
Commit 76e9c2a9870e36415eb343d28942a42296f85597 by ulrich.weigand
[FPEnv] Generate constrained FP comparisons from clang
Update the IRBuilder to generate constrained FP comparisons in
CreateFCmp when IsFPConstrained is true, similar to the other places in
the IRBuilder.
Also, add a new CreateFCmpS to emit signaling FP comparisons, and use it
in clang where comparisons are supposed to be signaling
(currently, only when emitting code for the <, <=, >, >= operators).
Note that there is currently no way to add fast-math flags to a
constrained FP comparison, since this is implemented as an intrinsic
call that returns a boolean type, and FMF are only allowed for calls
returning a floating-point type. However, given the discussion around
https://bugs.llvm.org/show_bug.cgi?id=42179, it seems that FCmp itself
really shouldn't have any FMF either, so this is probably OK.
Reviewed by: craig.topper
Differential Revision: https://reviews.llvm.org/D71467
The file was addedclang/test/CodeGen/fpconstrained-cmp-double.c
The file was modifiedclang/lib/CodeGen/CGExprScalar.cpp (diff)
The file was addedclang/test/CodeGen/fpconstrained-cmp-float.c
The file was modifiedllvm/include/llvm/IR/IRBuilder.h (diff)