FailedChanges

Summary

  1. Revert r365775 - "[Object/ELF] - Improve error reporting for notes." It broke BB: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/15419
  2. [clangd] Remove an extra ";", NFC
  3. Added mapping for pointers captured in Lambdas in OpenMP target regions, by David Truby. Summary: This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section 2.19.7.1 of the OpenMP 5 specification. Reviewers: ABataev Reviewed By: ABataev Subscribers: guansong, jdoerfert, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64558
  4. [clangd][QueryDriver] Use language from underlying database if possible Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64489
  5. [Object/ELF] - Improve error reporting for notes. This patch improves the error messages reported for note sections and phdrs and also makes a cleanup for existent test case. Differential revision: https://reviews.llvm.org/D64470
  6. [InstCombine] don't move FP negation out of a constant expression -(X * ConstExpr) becomes X * (-ConstExpr), so don't reverse that and infinite loop.
  7. [clangd] Add priorities to background index queue, extract to separate class Reviewers: kadircet Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, jfb, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64560
  8. [yaml2obj/elf-override-shsize.yaml] - An attemp to fix ppc64 bot. Failture: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/35670/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aelf-override-shsize.yaml Solution: Change `od` tool invocation to print single bytes.
  9. OpaquePtr: switch to GlobalValue::getValueType in a few places. NFC.
  10. OpaquePtr: use byval accessor instead of inspecting pointer type. NFC. The accessor can deal with both "byval(ty)" and "ty* byval" forms seamlessly.
  11. OpaquePtr: use load instruction directly for type. NFC.
  12. InstructionSimplify: Simplify InstructionSimplify. NFC. The interface predates CallBase, so both it and implementation were significantly more complicated than they needed to be. There was even some redundancy that could be eliminated. Should also help with OpaquePointers by not trying to derive a function's type from it's PointerType.
  13. [yaml2obj] - Allow overriding the sh_size field. There is no way to set broken sh_size field currently for sections. It can be usefull for writing the test cases. Differential revision: https://reviews.llvm.org/D64401
  14. [NFC] Updated tests for D64285
  15. [clangd] Remove the extra ";", NFC
  16. [clangd] Fix an assertion crash in "ExtractVariable" tweak Summary: GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should use getTypePtrOrNull instead. Reviewers: sammccall, SureYeaah Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64556
  17. [llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section. It does not make sence to stop dumping the object if the broken dynamic section was found. In this patch I changed the behavior from "report an error" to "report a warning". This matches GNU. Differential revision: https://reviews.llvm.org/D64472
  18. [InstCombine] Reorder recently added/improved pow transformations Changed cases are now faster with exp2.
  19. Revert [BitcodeReader] Validate OpNum, before accessing Record array. This reverts r365750 (git commit 8b222ecf2769ee133691f208f6166ce118c4a164) llvm-dis runs out of memory while opening invalid-fcmp-opnum.bc on llvm-hexagon-elf, probably because the bitcode file contains other suspicious values. http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/21949
  20. [clangd] Fix windows buildbots
  21. [X86] Regenerate intrinsics tests. NFCI.
  22. [AMDGPU] Regenerate idot tests. NFCI. Reduces diff in D63281.
  23. [llvm-objcopy] Don't change permissions of non-regular output files There is currently an EPERM error when a regular user executes `llvm-objcopy a.o /dev/null`. Worse, root can even change the mode bits of /dev/null. Fix it by checking if the output file is special. A new overload of llvm::sys::fs::setPermissions with FD as the parameter is added. Users should provide `perm & ~umask` as the parameter if they intend to respect umask. The existing overload of llvm::sys::fs::setPermissions may be deleted if we can find an implementation of fchmod() on Windows. fchmod() is usually better than chmod() because it saves syscalls and can avoid race condition. Reviewed By: jakehehrlich, jhenderson Differential Revision: https://reviews.llvm.org/D64236
Revision 365779 by grimar:
Revert r365775 - "[Object/ELF] - Improve error reporting for notes."

It broke BB: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/15419
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Object/ELF.hllvm.src/include/llvm/Object/ELF.h
The file was modified/llvm/trunk/test/tools/llvm-readobj/gnu-notes.testllvm.src/test/tools/llvm-readobj/gnu-notes.test
Revision 365778 by hokein:
[clangd] Remove an extra ";", NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/index/Background.hclang-tools-extra.src/clangd/index/Background.h
Revision 365777 by abataev:
Added mapping for pointers captured in Lambdas in OpenMP target regions,
by David Truby.

Summary:
This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section 2.19.7.1 of the OpenMP 5 specification.

Reviewers: ABataev

Reviewed By: ABataev

Subscribers: guansong, jdoerfert, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64558
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cppclang.src/lib/CodeGen/CGOpenMPRuntime.cpp
The file was added/cfe/trunk/test/OpenMP/nvptx_lambda_pointer_capturing.cppclang.src/test/OpenMP/nvptx_lambda_pointer_capturing.cpp
Revision 365776 by kadircet:
[clangd][QueryDriver] Use language from underlying database if possible

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64489
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/QueryDriverDatabase.cppclang-tools-extra.src/clangd/QueryDriverDatabase.cpp
Revision 365775 by grimar:
[Object/ELF] - Improve error reporting for notes.

This patch improves the error messages reported for
note sections and phdrs and also makes a cleanup for
existent test case.

Differential revision: https://reviews.llvm.org/D64470
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Object/ELF.hllvm.src/include/llvm/Object/ELF.h
The file was modified/llvm/trunk/test/tools/llvm-readobj/gnu-notes.testllvm.src/test/tools/llvm-readobj/gnu-notes.test
Revision 365774 by spatel:
[InstCombine] don't move FP negation out of a constant expression

-(X * ConstExpr) becomes X * (-ConstExpr), so don't reverse that
and infinite loop.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cppllvm.src/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/fmul.llllvm.src/test/Transforms/InstCombine/fmul.ll
Revision 365773 by sammccall:
[clangd] Add priorities to background index queue, extract to separate class

Reviewers: kadircet

Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64560
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CMakeLists.txtclang-tools-extra.src/clangd/CMakeLists.txt
The file was modified/clang-tools-extra/trunk/clangd/index/Background.cppclang-tools-extra.src/clangd/index/Background.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/Background.hclang-tools-extra.src/clangd/index/Background.h
The file was added/clang-tools-extra/trunk/clangd/index/BackgroundQueue.cppclang-tools-extra.src/clangd/index/BackgroundQueue.cpp
The file was modified/clang-tools-extra/trunk/clangd/tool/ClangdMain.cppclang-tools-extra.src/clangd/tool/ClangdMain.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/BackgroundIndexTests.cppclang-tools-extra.src/clangd/unittests/BackgroundIndexTests.cpp
Revision 365772 by grimar:
[yaml2obj/elf-override-shsize.yaml] - An attemp to fix ppc64 bot.

Failture:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/35670/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aelf-override-shsize.yaml

Solution:
Change `od` tool invocation to print single bytes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/yaml2obj/elf-override-shsize.yamlllvm.src/test/tools/yaml2obj/elf-override-shsize.yaml
Revision 365770 by Tim Northover:
OpaquePtr: switch to GlobalValue::getValueType in a few places. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/MemoryBuiltins.cppllvm.src/lib/Analysis/MemoryBuiltins.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cppllvm.src/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modified/llvm/trunk/lib/Target/Hexagon/HexagonTargetObjectFile.cppllvm.src/lib/Target/Hexagon/HexagonTargetObjectFile.cpp
Revision 365769 by Tim Northover:
OpaquePtr: use byval accessor instead of inspecting pointer type. NFC.

The accessor can deal with both "byval(ty)" and "ty* byval" forms
seamlessly.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Revision 365768 by Tim Northover:
OpaquePtr: use load instruction directly for type. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LICM.cppllvm.src/lib/Transforms/Scalar/LICM.cpp
Revision 365767 by Tim Northover:
InstructionSimplify: Simplify InstructionSimplify. NFC.

The interface predates CallBase, so both it and implementation were
significantly more complicated than they needed to be. There was even
some redundancy that could be eliminated.

Should also help with OpaquePointers by not trying to derive a
function's type from it's PointerType.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/InstructionSimplify.hllvm.src/include/llvm/Analysis/InstructionSimplify.h
The file was modified/llvm/trunk/lib/Analysis/InstructionSimplify.cppllvm.src/lib/Analysis/InstructionSimplify.cpp
Revision 365766 by grimar:
[yaml2obj] - Allow overriding the sh_size field.

There is no way to set broken sh_size field currently
for sections. It can be usefull for writing the
test cases.

Differential revision: https://reviews.llvm.org/D64401
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ObjectYAML/ELFYAML.hllvm.src/include/llvm/ObjectYAML/ELFYAML.h
The file was modified/llvm/trunk/lib/ObjectYAML/ELFYAML.cppllvm.src/lib/ObjectYAML/ELFYAML.cpp
The file was added/llvm/trunk/test/tools/yaml2obj/elf-override-shsize.yamlllvm.src/test/tools/yaml2obj/elf-override-shsize.yaml
The file was modified/llvm/trunk/tools/yaml2obj/yaml2elf.cppllvm.src/tools/yaml2obj/yaml2elf.cpp
Revision 365765 by xbolva00:
[NFC] Updated tests for D64285
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/InstCombine/ashr-lshr.llllvm.src/test/Transforms/InstCombine/ashr-lshr.ll
The file was modified/llvm/trunk/test/Transforms/InstSimplify/ashr-lshr.llllvm.src/test/Transforms/InstSimplify/ashr-lshr.ll
Revision 365764 by hokein:
[clangd] Remove the extra ";", NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/unittests/TestFS.cppclang-tools-extra.src/clangd/unittests/TestFS.cpp
Revision 365763 by hokein:
[clangd] Fix an assertion crash in "ExtractVariable" tweak

Summary:
GetTypePtr requires that the type should not be null, otherwise we hit
an assertion, we should use getTypePtrOrNull instead.

Reviewers: sammccall, SureYeaah

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64556
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/Selection.cppclang-tools-extra.src/clangd/Selection.cpp
The file was modified/clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractVariable.cppclang-tools-extra.src/clangd/refactor/tweaks/ExtractVariable.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/TweakTests.cppclang-tools-extra.src/clangd/unittests/TweakTests.cpp
Revision 365762 by grimar:
[llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section.

It does not make sence to stop dumping the object if the broken
dynamic section was found. In this patch I changed the behavior from
"report an error" to "report a warning". This matches GNU.

Differential revision: https://reviews.llvm.org/D64472
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Object/invalid.testllvm.src/test/Object/invalid.test
The file was modified/llvm/trunk/test/tools/llvm-readobj/elf-dynamic-malformed.testllvm.src/test/tools/llvm-readobj/elf-dynamic-malformed.test
The file was modified/llvm/trunk/tools/llvm-readobj/ELFDumper.cppllvm.src/tools/llvm-readobj/ELFDumper.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/llvm-readobj.cppllvm.src/tools/llvm-readobj/llvm-readobj.cpp
Revision 365758 by xbolva00:
[InstCombine] Reorder recently added/improved pow transformations

Changed cases are now faster with exp2.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cppllvm.src/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modified/llvm/trunk/test/Transforms/InstCombine/pow_fp_int.llllvm.src/test/Transforms/InstCombine/pow_fp_int.ll
Revision 365757 by fhahn:
Revert [BitcodeReader] Validate OpNum, before accessing Record array.

This reverts r365750 (git commit 8b222ecf2769ee133691f208f6166ce118c4a164)

llvm-dis runs out of memory while opening invalid-fcmp-opnum.bc on
llvm-hexagon-elf, probably because the bitcode file contains other
suspicious values.

http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/21949
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cppllvm.src/lib/Bitcode/Reader/BitcodeReader.cpp
The file was removed/llvm/trunk/test/Bitcode/Inputs/invalid-fcmp-opnum.bcllvm.src/test/Bitcode/Inputs/invalid-fcmp-opnum.bc
The file was modified/llvm/trunk/test/Bitcode/invalid.testllvm.src/test/Bitcode/invalid.test
Revision 365756 by kadircet:
[clangd] Fix windows buildbots
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/unittests/GlobalCompilationDatabaseTests.cppclang-tools-extra.src/clangd/unittests/GlobalCompilationDatabaseTests.cpp
Revision 365755 by rksimon:
[X86] Regenerate intrinsics tests. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/avx512bf16-intrinsics.llllvm.src/test/CodeGen/X86/avx512bf16-intrinsics.ll
The file was modified/llvm/trunk/test/CodeGen/X86/avx512vlvp2intersect-intrinsics.llllvm.src/test/CodeGen/X86/avx512vlvp2intersect-intrinsics.ll
The file was modified/llvm/trunk/test/CodeGen/X86/avx512vp2intersect-intrinsics.llllvm.src/test/CodeGen/X86/avx512vp2intersect-intrinsics.ll
Revision 365754 by rksimon:
[AMDGPU] Regenerate idot tests. NFCI.

Reduces diff in D63281.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/idot2.llllvm.src/test/CodeGen/AMDGPU/idot2.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/idot4s.llllvm.src/test/CodeGen/AMDGPU/idot4s.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/idot8s.llllvm.src/test/CodeGen/AMDGPU/idot8s.ll
Revision 365753 by maskray:
[llvm-objcopy] Don't change permissions of non-regular output files

There is currently an EPERM error when a regular user executes `llvm-objcopy a.o /dev/null`.
Worse, root can even change the mode bits of /dev/null.

Fix it by checking if the output file is special.

A new overload of llvm::sys::fs::setPermissions with FD as the parameter
is added. Users should provide `perm & ~umask` as the parameter if they
intend to respect umask.

The existing overload of llvm::sys::fs::setPermissions may be deleted if
we can find an implementation of fchmod() on Windows. fchmod() is
usually better than chmod() because it saves syscalls and can avoid race
condition.

Reviewed By: jakehehrlich, jhenderson

Differential Revision: https://reviews.llvm.org/D64236
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/FileSystem.hllvm.src/include/llvm/Support/FileSystem.h
The file was modified/llvm/trunk/lib/Support/Unix/Path.incllvm.src/lib/Support/Unix/Path.inc
The file was modified/llvm/trunk/lib/Support/Windows/Path.incllvm.src/lib/Support/Windows/Path.inc
The file was modified/llvm/trunk/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.testllvm.src/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test
The file was modified/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cppllvm.src/tools/llvm-objcopy/llvm-objcopy.cpp
The file was modified/llvm/trunk/unittests/Support/Path.cppllvm.src/unittests/Support/Path.cpp