FailedChanges

Summary

  1. Fix non-conformance it `std::tuple`. Previously we implemented all one trillion tuple-like constructors using a single generic overload. This worked fairly well, except that it differed in behavior from the standard version because it didn't consider both T&& and T const&. This was observable for certain types. This patch addresses that issue by splitting the generic constructor in two. We now provide both T&& and T const& versions of the tuple-like constructors (sort of).
  2. [AMDGPU] use v32f32 for 3 mfma intrinsics These should really use v32f32, but were defined as v32i32 due to the lack of the v32f32 type. Differential Revision: https://reviews.llvm.org/D64667
  3. isBytewiseValue checks ConstantVector element by element Summary: Vector of the same value with few undefs will sill be considered "Bytewise" Reviewers: eugenis, pcc, jfb Reviewed By: jfb Subscribers: dexonsmith, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64031
  4. [MemorySSA] Use SetVector to avoid nondeterminism. Summary: Use a SetVector for DeadBlockSet. Resolves PR42574. Reviewers: george.burgess.iv, uabelho, dblaikie Subscribers: jlebar, Prazek, mgrang, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64601
  5. NFC: utils/perf-training: Python 3 compatibility for lit.cfg The output of subprocess.check_output is now bytes. We need to decode it.
  6. [DirectoryWatcher][NFC] Silence warnings in release build
  7. [clang-doc] Fix failing tests on Windows Tests on Windows were failing due to path separator differences. '/' was being used as separator in the expected output, paths in expected output are now changed to their native form before comparing them to the actual output. Committed on behalf of Diego Astiazarán (diegoaat97@gmail.com). Differential Revision: https://reviews.llvm.org/D64669
  8. [DirectoryWatcher][linux] Fix use of uninitialized value
  9. [WebAssembly] refactored utilities to not depend on MachineInstr Summary: Most of these functions can work for MachineInstr and MCInst equally now. Reviewers: dschuff Subscribers: MatzeB, sbc100, jgravelle-google, aheejin, sunfish, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64643
  10. [macCatalyst] Use macCatalyst pretty name in .build_version darwin assembly command 'macCatalyst' is more readable than 'maccatalyst'. I renamed the objdump output, but the assembly should match it as well.
  11. Remove __VERSION__ Summary: It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/ad1a4c6e89594e704775ddb6b036ac982fd68cad it is probably time to remove it Reviewers: rnk, dexonsmith Reviewed By: rnk Subscribers: dschuff, aheejin, fedor.sergeev, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64062
  12. [test][AArch64] Relax the opcode tests for FP min/max instructions.
  13. Add option to disable variant narrowing conversion changes. The paper P0608R3 - "A sane variant converting constructor" disallows narrowing conversions in variant. It was meant to address this surprising problem: std::variant<std::string, bool> v = "abc"; assert(v.index() == 1); // constructs a bool. However, it also disables every potentially narrowing conversion. For example: variant<unsigned> v = 0; // ill-formed variant<string, double> v2 = 42; // ill-formed (int -> double narrows) These latter changes break code. A lot of code. Within Google it broke on the order of a hundred thousand target with thousands of root causes responsible for the breakages. Of the breakages related to the narrowing restrictions, none of them exposed outstanding bugs. However, the breakages caused by boolean conversions (~13 root causes), all but one of them were bugs. For this reasons, I am adding a flag to disable the narrowing conversion changes but not the boolean conversions one. One purpose of this flag is to allow users to opt-out of breaking changes in variant until the offending code can be cleaned up. For non-trivial variant usages the amount of cleanup may be significant. This flag is also required to support automated tooling, such as clang-tidy, that can automatically fix code broken by this change. In order for clang-tidy to know the correct alternative to construct, it must know what alternative was being constructed previously, which means running it over the old version of std::variant. Because this change breaks so much code, I will be implementing the aforementioned clang-tidy check in the very near future. Additionally I'm plan present this new information to the committee so they can re-consider if this is a breaking change we want to make. I think libc++ should very seriously consider pulling this change before the 9.0 release branch is cut. But that's a separate discussion that I will start on the lists. For now this is the minimal first step.
  14. [InstCombine] Disable fold from D64285 for non-integer types
  15. Factor out resolveFrameOffsetReference (NFC). Split AArch64FrameLowering::resolveFrameIndexReference in two parts * Finding frame offset for the index. * Finding base register and offset to that register. The second part will be used to implement a virtual frame pointer in armv8.5 MTE stack instrumentation lowering. Reviewers: pcc, vitalybuka, hctim, ostannard Subscribers: javed.absar, kristof.beyls, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64171
  16. [builtins] Fix assembly in arm sync-ops.h This assembly is part of a macro that was reformatted in D60351. The missing space between push and { results in: Error: bad instruction `push{r4, r5,r6,lr}'
  17. Revert driver: Don't warn about assembler flags being unused when not assembling This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40) and r365714. This broke some autoconf-style assembler flags checks in the Linux build: https://github.com/ClangBuiltLinux/linux/issues/598
  18. [clangd] Fix off-by-one in CodeComplete and assertion in Dex
  19. Reland [clang] DirectoryWatcher This reverts commit f561227d133224d2d6a5a016abe4be051fa75501. - DirectoryWatcher - Fix the build for platforms that don't have DW implementated. - Fix the threading dependencies (thanks to compnerd).
  20. AMDGPU: Drop remnants of byval support for shaders Before 2018, mesa used to use byval interchangably with inreg, which didn't really make sense. Fix tests still using it to avoid breaking in a future commit.
  21. Fix missing use of defined() in include guard Subscribers: arsenm, jvesely, nhaehnle, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64657
  22. [SystemZ] Fix addcarry of addcarry of const carry (PR42606) This fixes https://bugs.llvm.org/show_bug.cgi?id=42606 by extending D64213. Instead of only checking if the carry comes from a matching operation, we now check the full chain of carries. Otherwise we might custom lower the outermost addcarry, but then generically legalize an inner addcarry. Differential Revision: https://reviews.llvm.org/D64658
  23. Revert "Reland [clang] DirectoryWatcher" This reverts commit fdcb7f47e783933e0af8a5fae91132269a208268.
  24. Reland [clang] DirectoryWatcher This reverts commit abce8c457dd3de6b156756e547cc0eefb7653c79. + Fix the build for platforms that don't have DW implementated.
  25. [X86] Use MachineInstr::findRegisterDefOperand to simplify some code in optimizeCompareInstr. NFCI
  26. [DebugInfo] Add column info for inline sites The column field is missing for all inline sites, currently it's always zero. This changes populates DW_AT_call_column field for inline sites. Test case modified to cover this change. Patch by: Wenlei He Differential revision: https://reviews.llvm.org/D64033
  27. The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages. Summary: Move the logic into the assert itself. Subscribers: hiraditya, sanjoy, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64654
  28. [SystemZ] Fix build bot failure after r365932 Insert LLVM_FALLTHROUGH to avoid compiler warning.
  29. [x86] add test for bogus cmov (PR40483); NFC
  30. [AMDGPU] Extend MIMG opcode to 8 bits This is NFC, but required for future commit. Differential Revision: https://reviews.llvm.org/D64649
Revision 365973 by ericwf:
Fix non-conformance it `std::tuple`.

Previously we implemented all one trillion tuple-like constructors using
a single generic overload. This worked fairly well, except that it
differed in behavior from the standard version because it didn't
consider both T&& and T const&. This was observable for certain
types.

This patch addresses that issue by splitting the generic constructor
in two. We now provide both T&& and T const& versions of the
tuple-like constructors (sort of).
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/include/tuplelibcxx.src/include/tuple
The file was modified/libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/convert_copy.pass.cpplibcxx.src/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/convert_copy.pass.cpp
Revision 365972 by rampitec:
[AMDGPU] use v32f32 for 3 mfma intrinsics

These should really use v32f32, but were defined as v32i32
due to the lack of the v32f32 type.

Differential Revision: https://reviews.llvm.org/D64667
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/Intrinsics.tdllvm.src/include/llvm/IR/Intrinsics.td
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicsAMDGPU.tdllvm.src/include/llvm/IR/IntrinsicsAMDGPU.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelLowering.cppllvm.src/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cppllvm.src/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.tdllvm.src/lib/Target/AMDGPU/SIInstrInfo.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstructions.tdllvm.src/lib/Target/AMDGPU/SIInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.tdllvm.src/lib/Target/AMDGPU/SIRegisterInfo.td
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/agpr-register-count.llllvm.src/test/CodeGen/AMDGPU/agpr-register-count.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.mfma.llllvm.src/test/CodeGen/AMDGPU/llvm.amdgcn.mfma.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/spill-agpr.llllvm.src/test/CodeGen/AMDGPU/spill-agpr.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/spill-vgpr-to-agpr.llllvm.src/test/CodeGen/AMDGPU/spill-vgpr-to-agpr.ll
Revision 365971 by Vitaly Buka:
isBytewiseValue checks ConstantVector element by element

Summary: Vector of the same value with few undefs will sill be considered "Bytewise"

Reviewers: eugenis, pcc, jfb

Reviewed By: jfb

Subscribers: dexonsmith, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64031
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ValueTracking.cppllvm.src/lib/Analysis/ValueTracking.cpp
The file was modified/llvm/trunk/unittests/Analysis/ValueTrackingTest.cppllvm.src/unittests/Analysis/ValueTrackingTest.cpp
Revision 365970 by asbirlea:
[MemorySSA] Use SetVector to avoid nondeterminism.

Summary:
Use a SetVector for DeadBlockSet.
Resolves PR42574.

Reviewers: george.burgess.iv, uabelho, dblaikie

Subscribers: jlebar, Prazek, mgrang, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64601
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/MemorySSAUpdater.hllvm.src/include/llvm/Analysis/MemorySSAUpdater.h
The file was modified/llvm/trunk/lib/Analysis/MemorySSAUpdater.cppllvm.src/lib/Analysis/MemorySSAUpdater.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cppllvm.src/lib/Transforms/Scalar/LoopSimplifyCFG.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/SimpleLoopUnswitch.cppllvm.src/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/Local.cppllvm.src/lib/Transforms/Utils/Local.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cppllvm.src/lib/Transforms/Utils/LoopSimplify.cpp
The file was added/llvm/trunk/test/Analysis/MemorySSA/nondeterminism.llllvm.src/test/Analysis/MemorySSA/nondeterminism.ll
Revision 365969 by arphaman:
NFC: utils/perf-training: Python 3 compatibility for lit.cfg

The output of subprocess.check_output is now bytes. We need to decode it.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/utils/perf-training/lit.cfgclang.src/utils/perf-training/lit.cfg
Revision 365968 by Jan Korous:
[DirectoryWatcher][NFC] Silence warnings in release build
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cppclang.src/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
The file was modified/cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cppclang.src/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp
Revision 365967 by juliehockett:
[clang-doc] Fix failing tests on Windows

Tests on Windows were failing due to path separator differences.
'/' was being used as separator in the expected output, paths in expected
output are now changed to their native form before comparing them to the
actual output.

Committed on behalf of Diego Astiazarán (diegoaat97@gmail.com).

Differential Revision: https://reviews.llvm.org/D64669
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/unittests/clang-doc/HTMLGeneratorTest.cppclang-tools-extra.src/unittests/clang-doc/HTMLGeneratorTest.cpp
Revision 365966 by Jan Korous:
[DirectoryWatcher][linux] Fix use of uninitialized value
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cppclang.src/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
Revision 365965 by aardappel:
[WebAssembly] refactored utilities to not depend on MachineInstr

Summary:
Most of these functions can work for MachineInstr and MCInst
equally now.

Reviewers: dschuff

Subscribers: MatzeB, sbc100, jgravelle-google, aheejin, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64643
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.hllvm.src/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyArgumentMove.cppllvm.src/lib/Target/WebAssembly/WebAssemblyArgumentMove.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cppllvm.src/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cppllvm.src/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyFrameLowering.cppllvm.src/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyMCInstLower.cppllvm.src/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyPrepareForLiveIntervals.cppllvm.src/lib/Target/WebAssembly/WebAssemblyPrepareForLiveIntervals.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegNumbering.cppllvm.src/lib/Target/WebAssembly/WebAssemblyRegNumbering.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cppllvm.src/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyUtilities.cppllvm.src/lib/Target/WebAssembly/WebAssemblyUtilities.cpp
The file was modified/llvm/trunk/lib/Target/WebAssembly/WebAssemblyUtilities.hllvm.src/lib/Target/WebAssembly/WebAssemblyUtilities.h
Revision 365964 by arphaman:
[macCatalyst] Use macCatalyst pretty name in .build_version darwin
assembly command

'macCatalyst' is more readable than 'maccatalyst'. I renamed the objdump output,
but the assembly should match it as well.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/MC/MCAsmStreamer.cppllvm.src/lib/MC/MCAsmStreamer.cpp
The file was modified/llvm/trunk/lib/MC/MCParser/DarwinAsmParser.cppllvm.src/lib/MC/MCParser/DarwinAsmParser.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/macCatalyst.llllvm.src/test/CodeGen/X86/macCatalyst.ll
The file was modified/llvm/trunk/test/MC/MachO/build-version-maccatalyst.sllvm.src/test/MC/MachO/build-version-maccatalyst.s
Revision 365962 by sylvestre:
Remove __VERSION__

Summary:
It has been introduced in 2011 for gcc compat:
https://github.com/llvm-mirror/clang/commit/ad1a4c6e89594e704775ddb6b036ac982fd68cad
it is probably time to remove it


Reviewers: rnk, dexonsmith

Reviewed By: rnk

Subscribers: dschuff, aheejin, fedor.sergeev, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64062
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/LanguageExtensions.rstclang.src/docs/LanguageExtensions.rst
The file was modified/cfe/trunk/docs/ReleaseNotes.rstclang.src/docs/ReleaseNotes.rst
The file was modified/cfe/trunk/lib/Basic/Version.cppclang.src/lib/Basic/Version.cpp
The file was modified/cfe/trunk/lib/Frontend/InitPreprocessor.cppclang.src/lib/Frontend/InitPreprocessor.cpp
The file was modified/cfe/trunk/test/Index/complete-exprs.cclang.src/test/Index/complete-exprs.c
The file was modified/cfe/trunk/test/Preprocessor/init.cclang.src/test/Preprocessor/init.c
The file was modified/cfe/trunk/utils/builtin-defines.cclang.src/utils/builtin-defines.c
Revision 365961 by dyung:
[test][AArch64] Relax the opcode tests for FP min/max instructions.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mirllvm.src/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
Revision 365960 by ericwf:
Add option to disable variant narrowing conversion changes.

The paper P0608R3 - "A sane variant converting constructor" disallows
narrowing conversions in variant. It was meant to address this
surprising problem:

  std::variant<std::string, bool> v = "abc";
  assert(v.index() == 1); // constructs a bool.

However, it also disables every potentially narrowing conversion. For
example:

  variant<unsigned> v = 0; // ill-formed
  variant<string, double> v2 = 42; // ill-formed (int -> double narrows)

These latter changes break code. A lot of code. Within Google it broke
on the order of a hundred thousand target with thousands of root causes
responsible for the breakages.

Of the breakages related to the narrowing restrictions, none of them
exposed outstanding bugs. However, the breakages caused by boolean
conversions (~13 root causes), all but one of them were bugs.

For this reasons, I am adding a flag to disable the narrowing conversion
changes but not the boolean conversions one.

One purpose of this flag is to allow users to opt-out of breaking changes
in variant until the offending code can be cleaned up. For non-trivial
variant usages the amount of cleanup may be significant.

This flag is also required to support automated tooling, such as
clang-tidy, that can automatically fix code broken by this change.
In order for clang-tidy to know the correct alternative to construct,
it must know what alternative was being constructed previously, which
means running it over the old version of std::variant.

Because this change breaks so much code, I will be implementing the
aforementioned clang-tidy check in the very near future.

Additionally I'm plan present this new information to the committee so they can
re-consider if this is a breaking change we want to make.

I think libc++ should very seriously consider pulling this change
before the 9.0 release branch is cut. But that's a separate discussion
that I will start on the lists.

For now this is the minimal first step.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/include/variantlibcxx.src/include/variant
The file was modified/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp
The file was removed/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/conv.fail.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.assign/conv.fail.cpp
The file was added/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/conv.pass.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.assign/conv.pass.cpp
The file was modified/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
The file was removed/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/conv.fail.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.ctor/conv.fail.cpp
The file was added/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/conv.pass.cpplibcxx.src/test/std/utilities/variant/variant.variant/variant.ctor/conv.pass.cpp
The file was modified/libcxx/trunk/test/support/variant_test_helpers.hpplibcxx.src/test/support/variant_test_helpers.hpp
Revision 365959 by xbolva00:
[InstCombine] Disable fold from D64285 for non-integer types
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cppllvm.src/lib/Transforms/InstCombine/InstCombineSelect.cpp
Revision 365958 by eugenis:
Factor out resolveFrameOffsetReference (NFC).

Split AArch64FrameLowering::resolveFrameIndexReference in two parts
* Finding frame offset for the index.
* Finding base register and offset to that register.

The second part will be used to implement a virtual frame pointer in
armv8.5 MTE stack instrumentation lowering.

Reviewers: pcc, vitalybuka, hctim, ostannard

Subscribers: javed.absar, kristof.beyls, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64171
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64FrameLowering.cppllvm.src/lib/Target/AArch64/AArch64FrameLowering.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64FrameLowering.hllvm.src/lib/Target/AArch64/AArch64FrameLowering.h
Revision 365957 by nikic:
[builtins] Fix assembly in arm sync-ops.h

This assembly is part of a macro that was reformatted in D60351.
The missing space between push and { results in:

    Error: bad instruction `push{r4, r5,r6,lr}'
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/builtins/arm/sync-ops.hcompiler-rt.src/lib/builtins/arm/sync-ops.h
Revision 365956 by rnk:
Revert driver: Don't warn about assembler flags being unused when not assembling

This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40)
and r365714.

This broke some autoconf-style assembler flags checks in the Linux
build:
https://github.com/ClangBuiltLinux/linux/issues/598
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Driver/ToolChains/Clang.cppclang.src/lib/Driver/ToolChains/Clang.cpp
The file was modified/cfe/trunk/test/Driver/as-options.sclang.src/test/Driver/as-options.s
Revision 365955 by sammccall:
[clangd] Fix off-by-one in CodeComplete and assertion in Dex
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/CodeComplete.cppclang-tools-extra.src/clangd/CodeComplete.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/dex/Dex.cppclang-tools-extra.src/clangd/index/dex/Dex.cpp
Revision 365954 by Jan Korous:
Reland [clang] DirectoryWatcher

This reverts commit f561227d133224d2d6a5a016abe4be051fa75501.

- DirectoryWatcher
- Fix the build for platforms that don't have DW implementated.
- Fix the threading dependencies (thanks to compnerd).
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/DirectoryWatcherclang.src/include/clang/DirectoryWatcher
The file was added/cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.hclang.src/include/clang/DirectoryWatcher/DirectoryWatcher.h
The file was modified/cfe/trunk/lib/CMakeLists.txtclang.src/lib/CMakeLists.txt
The file was added/cfe/trunk/lib/DirectoryWatcherclang.src/lib/DirectoryWatcher
The file was added/cfe/trunk/lib/DirectoryWatcher/CMakeLists.txtclang.src/lib/DirectoryWatcher/CMakeLists.txt
The file was added/cfe/trunk/lib/DirectoryWatcher/DirectoryScanner.cppclang.src/lib/DirectoryWatcher/DirectoryScanner.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/DirectoryScanner.hclang.src/lib/DirectoryWatcher/DirectoryScanner.h
The file was added/cfe/trunk/lib/DirectoryWatcher/defaultclang.src/lib/DirectoryWatcher/default
The file was added/cfe/trunk/lib/DirectoryWatcher/default/DirectoryWatcher-not-implemented.cppclang.src/lib/DirectoryWatcher/default/DirectoryWatcher-not-implemented.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/linuxclang.src/lib/DirectoryWatcher/linux
The file was added/cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cppclang.src/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/macclang.src/lib/DirectoryWatcher/mac
The file was added/cfe/trunk/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cppclang.src/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp
The file was modified/cfe/trunk/unittests/CMakeLists.txtclang.src/unittests/CMakeLists.txt
The file was added/cfe/trunk/unittests/DirectoryWatcherclang.src/unittests/DirectoryWatcher
The file was added/cfe/trunk/unittests/DirectoryWatcher/CMakeLists.txtclang.src/unittests/DirectoryWatcher/CMakeLists.txt
The file was added/cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cppclang.src/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp
Revision 365953 by arsenm:
AMDGPU: Drop remnants of byval support for shaders

Before 2018, mesa used to use byval interchangably with inreg, which
didn't really make sense. Fix tests still using it to avoid breaking
in a future commit.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cppllvm.src/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/irtranslator-amdgpu_vs.llllvm.src/test/CodeGen/AMDGPU/GlobalISel/irtranslator-amdgpu_vs.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/default-fp-mode.llllvm.src/test/CodeGen/AMDGPU/default-fp-mode.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.interp.llllvm.src/test/CodeGen/AMDGPU/llvm.amdgcn.interp.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/mubuf.llllvm.src/test/CodeGen/AMDGPU/mubuf.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/ret.llllvm.src/test/CodeGen/AMDGPU/ret.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/ret_jump.llllvm.src/test/CodeGen/AMDGPU/ret_jump.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/sgpr-copy.llllvm.src/test/CodeGen/AMDGPU/sgpr-copy.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/si-scheduler.llllvm.src/test/CodeGen/AMDGPU/si-scheduler.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/si-sgpr-spill.llllvm.src/test/CodeGen/AMDGPU/si-sgpr-spill.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/split-smrd.llllvm.src/test/CodeGen/AMDGPU/split-smrd.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/unigine-liveness-crash.llllvm.src/test/CodeGen/AMDGPU/unigine-liveness-crash.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/vgpr-spill-emergency-stack-slot.llllvm.src/test/CodeGen/AMDGPU/vgpr-spill-emergency-stack-slot.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/wait.llllvm.src/test/CodeGen/AMDGPU/wait.ll
Revision 365952 by daltenty:
Fix missing use of defined() in include guard

Subscribers: arsenm, jvesely, nhaehnle, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64657
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPULibCalls.cppllvm.src/lib/Target/AMDGPU/AMDGPULibCalls.cpp
Revision 365949 by nikic:
[SystemZ] Fix addcarry of addcarry of const carry (PR42606)

This fixes https://bugs.llvm.org/show_bug.cgi?id=42606 by extending
D64213. Instead of only checking if the carry comes from a matching
operation, we now check the full chain of carries. Otherwise we might
custom lower the outermost addcarry, but then generically legalize
an inner addcarry.

Differential Revision: https://reviews.llvm.org/D64658
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/SystemZ/SystemZISelLowering.cppllvm.src/lib/Target/SystemZ/SystemZISelLowering.cpp
The file was added/llvm/trunk/test/CodeGen/SystemZ/pr42606.llllvm.src/test/CodeGen/SystemZ/pr42606.ll
Revision 365948 by Jan Korous:
Revert "Reland [clang] DirectoryWatcher"

This reverts commit fdcb7f47e783933e0af8a5fae91132269a208268.
Change TypePath in RepositoryPath in Workspace
The file was removed/cfe/trunk/include/clang/DirectoryWatcherclang.src/include/clang/DirectoryWatcher
The file was modified/cfe/trunk/lib/CMakeLists.txtclang.src/lib/CMakeLists.txt
The file was removed/cfe/trunk/lib/DirectoryWatcherclang.src/lib/DirectoryWatcher
The file was modified/cfe/trunk/unittests/CMakeLists.txtclang.src/unittests/CMakeLists.txt
The file was removed/cfe/trunk/unittests/DirectoryWatcherclang.src/unittests/DirectoryWatcher
Revision 365947 by Jan Korous:
Reland [clang] DirectoryWatcher

This reverts commit abce8c457dd3de6b156756e547cc0eefb7653c79.

+ Fix the build for platforms that don't have DW implementated.
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/DirectoryWatcherclang.src/include/clang/DirectoryWatcher
The file was added/cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.hclang.src/include/clang/DirectoryWatcher/DirectoryWatcher.h
The file was modified/cfe/trunk/lib/CMakeLists.txtclang.src/lib/CMakeLists.txt
The file was added/cfe/trunk/lib/DirectoryWatcherclang.src/lib/DirectoryWatcher
The file was added/cfe/trunk/lib/DirectoryWatcher/CMakeLists.txtclang.src/lib/DirectoryWatcher/CMakeLists.txt
The file was added/cfe/trunk/lib/DirectoryWatcher/DirectoryScanner.cppclang.src/lib/DirectoryWatcher/DirectoryScanner.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/DirectoryScanner.hclang.src/lib/DirectoryWatcher/DirectoryScanner.h
The file was added/cfe/trunk/lib/DirectoryWatcher/defaultclang.src/lib/DirectoryWatcher/default
The file was added/cfe/trunk/lib/DirectoryWatcher/default/DirectoryWatcher-not-implemented.cppclang.src/lib/DirectoryWatcher/default/DirectoryWatcher-not-implemented.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/linuxclang.src/lib/DirectoryWatcher/linux
The file was added/cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cppclang.src/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
The file was added/cfe/trunk/lib/DirectoryWatcher/macclang.src/lib/DirectoryWatcher/mac
The file was added/cfe/trunk/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cppclang.src/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp
The file was modified/cfe/trunk/unittests/CMakeLists.txtclang.src/unittests/CMakeLists.txt
The file was added/cfe/trunk/unittests/DirectoryWatcherclang.src/unittests/DirectoryWatcher
The file was added/cfe/trunk/unittests/DirectoryWatcher/CMakeLists.txtclang.src/unittests/DirectoryWatcher/CMakeLists.txt
The file was added/cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cppclang.src/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp
Revision 365946 by ctopper:
[X86] Use MachineInstr::findRegisterDefOperand to simplify some code in optimizeCompareInstr. NFCI
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.cppllvm.src/lib/Target/X86/X86InstrInfo.cpp
Revision 365945 by Jonas Devlieghere:
[DebugInfo] Add column info for inline sites

The column field is missing for all inline sites, currently it's always
zero. This changes populates DW_AT_call_column field for inline sites.
Test case modified to cover this change.

Patch by: Wenlei He

Differential revision: https://reviews.llvm.org/D64033
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cppllvm.src/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
The file was modified/llvm/trunk/test/DebugInfo/Inputs/gmlt.llllvm.src/test/DebugInfo/Inputs/gmlt.ll
The file was modified/llvm/trunk/test/DebugInfo/NVPTX/debug-info.llllvm.src/test/DebugInfo/NVPTX/debug-info.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/dbg-value-inlined-parameter.llllvm.src/test/DebugInfo/X86/dbg-value-inlined-parameter.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/fission-inline.llllvm.src/test/DebugInfo/X86/fission-inline.ll
Revision 365943 by saugustine:
The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages.

Summary: Move the logic into the assert itself.

Subscribers: hiraditya, sanjoy, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64654
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cppllvm.src/lib/Transforms/Scalar/IndVarSimplify.cpp
Revision 365942 by uweigand:
[SystemZ] Fix build bot failure after r365932

Insert LLVM_FALLTHROUGH to avoid compiler warning.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/SystemZ/SystemZInstrInfo.cppllvm.src/lib/Target/SystemZ/SystemZInstrInfo.cpp
Revision 365941 by spatel:
[x86] add test for bogus cmov (PR40483); NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/combine-sbb.llllvm.src/test/CodeGen/X86/combine-sbb.ll
Revision 365940 by rampitec:
[AMDGPU] Extend MIMG opcode to 8 bits

This is NFC, but required for future commit.

Differential Revision: https://reviews.llvm.org/D64649
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/MIMGInstructions.tdllvm.src/lib/Target/AMDGPU/MIMGInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrFormats.tdllvm.src/lib/Target/AMDGPU/SIInstrFormats.td