FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [ARM] Make cp10 and cp11 usage a warning (details)
  2. Revert "[BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles." (details)
  3. Use concrete natural type alignment for masked load/store operations instead of 0. (details)
  4. [TextAPI/MachO] Fix style issues. NFC (details)
  5. Remove Passes dependency on CodeGen (details)
  6. Revert "Use concrete natural type alignment for masked load/store operations instead of 0." (details)
  7. [NFCI] SCEV: promote ScalarEvolutionDivision into an publicly usable class (details)
  8. [InstCombine] visitBitCast(): do not crash on weird `bitcast <1 x i8*> to i8*` (details)
  9. [IR] GetUnderlyingObject(), stripPointerCastsAndOffsets(): don't crash on `bitcast <1 x i8*> to i8*` (details)
  10. [SROA] convertValue(): we can have <N x iK> to <M x iQ*> cast (details)
  11. [SROA] convertValue(): we can have <N x iK*> to <M x iQ> cast (details)
  12. [NFCI][InstSimplify] Add CHECK-LABEL to new icmp.ll test (details)
  13. [gn build] Port 1e2691fe238 (details)
  14. [MIR] Fix CFI_INSTRUCTION escape printing (details)
  15. [llvm-profdata] --hot-func-list: fix some style issues in D81800 (details)
  16. [clangd] Make background index thread count calculation clearer (details)
  17. [InlineCost] PrinterPass prints constants to which instructions are simplified (details)
  18. [unittest] Fix FrontendTests CanGenerateCC1CommandLineFlag when LLVM_DEFAULT_TARGET_TRIPLE is not normalized after D79796 (details)
  19. [lldb/API] Use std::make_unique<> (NFC) (details)
Commit b7d41a11cd31388e8b542b2d881f5c9d7130b95e by stefan
[ARM] Make cp10 and cp11 usage a warning

The ARM ARM considers p10/p11 valid arguments for MCR/MRC instructions.
MRC instructions with p10 arguments are also used in kernel code which
is shared for different architectures. Turn usage of p10/p11 to warnings
for ARMv7/ARMv8-M.

Reviewers: rengolin, olista01, t.p.northover, efriedma, psmith, simon_tatham

Reviewed By: simon_tatham

Subscribers: hiraditya, danielkiss, jcai19, tpimh, nickdesaulniers, peter.smith, javed.absar, kristof.beyls, jdoerfert, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D59733
The file was modifiedllvm/lib/Target/ARM/ARMInstrInfo.td
The file was modifiedllvm/test/MC/ARM/coprocessors.s
The file was modifiedllvm/lib/Target/ARM/ARMBaseInstrInfo.h
The file was modifiedllvm/test/MC/ARM/diagnostics.s
The file was modifiedllvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
Commit 10045cbe01928d9281723c640c03984d540f9012 by 31459023+hctim
Revert "[BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles."

Patch has a memory leak bug that broke the ASan buildbots. More info
available at: https://reviews.llvm.org/D80330

This reverts commit b5740105d270a2d76da8812cafb63e4b799ada73.
The file was modifiedllvm/lib/Bitcode/Reader/BitcodeReader.cpp
The file was removedllvm/test/Bitcode/vscale-shuffle.ll
Commit 39819ccd36b6dd61c9decd29df64fd4e8a7ee9ad by gchatelet
Use concrete natural type alignment for masked load/store operations instead of 0.
The file was modifiedllvm/include/llvm/CodeGen/BasicTTIImpl.h
Commit c6d01ed0465c77090c816f37769643edce8e3501 by maskray
[TextAPI/MachO] Fix style issues. NFC

See https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
The file was modifiedllvm/lib/TextAPI/MachO/TextStub.cpp
The file was modifiedllvm/lib/TextAPI/MachO/InterfaceFile.cpp
Commit ebc88811b5c9ed9375a681a7267831ae7ad46ba7 by Yuanfang Chen
Remove Passes dependency on CodeGen

The dependency was introduced in
5134020ea62d1e1e125fdac48d251a26b80e9781. The only functional change
from this removal would be the new PM interface for the two codegen
passes. This is not necessary since we don't have codegen pipeline using
new PM yet. This removal is to break the potential circular dependency between
Passes and CodeGen once the codegen begins to gain new PM support.
The file was modifiedllvm/lib/Passes/LLVMBuild.txt
The file was modifiedllvm/lib/Passes/PassRegistry.def
The file was modifiedllvm/test/CodeGen/X86/unreachableblockelim.ll
The file was modifiedllvm/test/Transforms/PreISelIntrinsicLowering/objc-arc.ll
The file was modifiedllvm/lib/Passes/PassBuilder.cpp
The file was modifiedllvm/test/Transforms/PreISelIntrinsicLowering/load-relative.ll
Commit 31bd860ec02f975777a8d861fab299a59f180e84 by gchatelet
Revert "Use concrete natural type alignment for masked load/store operations instead of 0."

This reverts commit 39819ccd36b6dd61c9decd29df64fd4e8a7ee9ad.
The file was modifiedllvm/include/llvm/CodeGen/BasicTTIImpl.h
Commit 1e2691fe238b9b47dd3fa2c7a8874826ead45760 by lebedev.ri
[NFCI] SCEV: promote ScalarEvolutionDivision into an publicly usable class

This makes it usable from outside of SCEV,
while previously it was internal to the ScalarEvolution.cpp

In particular, i want to use it in an WIP alloca promotion helper pass,
to analyze if some SCEV is a multiple of some other SCEV.
The file was addedllvm/lib/Analysis/ScalarEvolutionDivision.cpp
The file was modifiedllvm/lib/Analysis/CMakeLists.txt
The file was addedllvm/include/llvm/Analysis/ScalarEvolutionDivision.h
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit 381054a989ebd0b585fee46f2a01a7c5de10acf7 by lebedev.ri
[InstCombine] visitBitCast(): do not crash on weird `bitcast <1 x i8*> to i8*`

Even if we know that RHS of a bitcast is a pointer,
we can't assume LHS is, because it might be
a single-element vector of pointer.
The file was modifiedllvm/test/Transforms/InstCombine/bitcast.ll
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
Commit 2b8d706b19c0e049da3eb62572b08af72ba2e5e6 by lebedev.ri
[IR] GetUnderlyingObject(), stripPointerCastsAndOffsets(): don't crash on `bitcast <1 x i8*> to i8*`

I'm not sure how to write standalone tests for each of two changes here.
If either one of these two fixes is missing, the test fill crash.
The file was modifiedllvm/lib/Analysis/ValueTracking.cpp
The file was modifiedllvm/lib/IR/Value.cpp
The file was addedllvm/test/Transforms/InstSimplify/icmp.ll
Commit 07a23c06dd9c616fc24410f8cdbc8b4797b31cdc by lebedev.ri
[SROA] convertValue(): we can have <N x iK> to <M x iQ*> cast

Provided test case crashes otherwise.

If NewTy is already DL.getIntPtrType(NewTy),
CreateBitCast() won't actually create any bitcast,
so we are better off just doing the general thing.
The file was modifiedllvm/test/Transforms/SROA/vector-conversion.ll
The file was modifiedllvm/lib/Transforms/Scalar/SROA.cpp
Commit 8911a35180c6777188fefe0954a2451a2b91deaf by lebedev.ri
[SROA] convertValue(): we can have <N x iK*> to <M x iQ> cast

Provided test case crashes otherwise.
Much like to the opposite case.
The file was modifiedllvm/lib/Transforms/Scalar/SROA.cpp
The file was modifiedllvm/test/Transforms/SROA/vector-conversion.ll
Commit 0c221470275270abe9dbb72cced030a0251ecfb6 by lebedev.ri
[NFCI][InstSimplify] Add CHECK-LABEL to new icmp.ll test
The file was modifiedllvm/test/Transforms/InstSimplify/icmp.ll
Commit 8fe9d2a20677b3f0d01db05fc4bb9373f8ea8dc2 by llvmgnsyncbot
[gn build] Port 1e2691fe238
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Analysis/BUILD.gn
Commit 4d81aec40c62a0599a4bfbd7b45df78b302dbc3c by scott.linder
[MIR] Fix CFI_INSTRUCTION escape printing

Summary:
The printer seems to intend to not print the trailing comma but has a
copy-paste error for the last value in the escape, and the parser
enforces having no trailing comma, but somehow a test was never included
to actually confirm it.

Reviewers: thegameg, arsenm

Reviewed By: thegameg, arsenm

Subscribers: wdng, arsenm, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D82478
The file was modifiedllvm/lib/CodeGen/MachineOperand.cpp
The file was addedllvm/test/CodeGen/MIR/Generic/cfi-escape.mir
The file was modifiedllvm/test/CodeGen/MIR/AArch64/cfi.mir
Commit 546be0883784838be5d07a82f39ec4390f49e19e by maskray
[llvm-profdata] --hot-func-list: fix some style issues in D81800

Reviewed By: wenlei, hoyFB

Differential Revision: https://reviews.llvm.org/D82500
The file was modifiedllvm/test/tools/llvm-profdata/sample-hot-func-list.test
The file was modifiedllvm/tools/llvm-profdata/llvm-profdata.cpp
The file was modifiedllvm/include/llvm/ProfileData/SampleProf.h
Commit 3c5745cb1f3c501e551a8fa63b8f1d564c35016d by sam.mccall
[clangd] Make background index thread count calculation clearer

Summary:
This confusion was inadvertently introduced in a change to the
heavyweight_hardware_concurrency API: 8404aeb56a73ab24f9b295111de3b37a37f0b841

- don't indirect through the rebuilder policy when building the thread pool
- document that rebuilder thresholds are exposed for testing only
- don't use 0 as a sentinel value for "all threads", as we use it as a
  sentinel value for "synchronous" (though unsupported for BackgroundIndex)
- rather than pick some new sentinel value, just always use 4 threads for tests

Reviewers: kadircet, aganea

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D82352
The file was modifiedclang-tools-extra/clangd/index/Background.h
The file was modifiedclang-tools-extra/clangd/index/BackgroundRebuild.h
The file was modifiedclang-tools-extra/clangd/index/Background.cpp
Commit 7f094f7f9d3e3c529afcfd553cee3b64419e72f2 by knaumov
[InlineCost] PrinterPass prints constants to which instructions are simplified

This patch enables printing of constants to see which instructions were
constant-folded. Needed for tests and better visiual analysis of
inliner's work.

Reviewers: apilipenko, mtrofin, davidxl, fedor.sergeev

Reviewed By: mtrofin

Differential Revision: https://reviews.llvm.org/D81024
The file was modifiedllvm/lib/Analysis/InlineCost.cpp
The file was addedllvm/test/Transforms/Inline/simplified_to.ll
Commit 6330653547f492646c92553738dab6a99d7d9710 by maskray
[unittest] Fix FrontendTests CanGenerateCC1CommandLineFlag when LLVM_DEFAULT_TARGET_TRIPLE is not normalized after D79796

`TargetOpts->Triple` is initialized as llvm::sys::getDefaultTargetTriple() which may not be normalized.
If LLVM_DEFAULT_TARGET_TRIPLE is powerpc64le-linux-gnu, we should check
check `-triple powerpc64le-linux-gnu`, instead of (normalized) `-triple powerpc64le-unknown-linux-gnu`
The file was modifiedclang/unittests/Frontend/CompilerInvocationTest.cpp
Commit 1c0bbe4341ac0ffbaf2e1f482239b45166607f2d by Jonas Devlieghere
[lldb/API] Use std::make_unique<> (NFC)

I was holding off on this change until we moved to C++14 as to not have
to convert llvm::make_unique to std::make_unique. That happened a while
ago so here's the first patch for the API which had a bunch of raw
`new`s.
The file was modifiedlldb/source/API/SBCommandInterpreterRunOptions.cpp
The file was modifiedlldb/source/API/SBType.cpp
The file was modifiedlldb/source/API/SBTypeSummary.cpp
The file was modifiedlldb/source/API/SBVariablesOptions.cpp
The file was modifiedlldb/source/API/SBAddress.cpp
The file was modifiedlldb/source/API/SBProcessInfo.cpp
The file was modifiedlldb/source/API/SBTypeEnumMember.cpp
The file was modifiedlldb/source/API/SBDeclaration.cpp
The file was modifiedlldb/source/API/SBSourceManager.cpp
The file was modifiedlldb/source/API/SBValueList.cpp
The file was modifiedlldb/source/API/SBStringList.cpp
The file was modifiedlldb/source/API/SBBreakpointName.cpp
The file was modifiedlldb/source/API/SBError.cpp
The file was modifiedlldb/source/API/SBLineEntry.cpp
The file was modifiedlldb/source/API/SBStream.cpp
The file was modifiedlldb/source/API/SBSymbolContext.cpp