FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-zorg.git)

Summary

  1. new win32 buildbot (details)
Commit ac4c27ddd9bf6b75f4430476a1f63a3377b38f2c by kuhnel
new win32 buildbot

Summary: Added new buildbot for 32bit Windows multi-stage

Subscribers: aaron.ballman

Differential Revision: https://reviews.llvm.org/D82758
The file was modifiedbuildbot/osuosl/master/config/slaves.py
The file was modifiedbuildbot/osuosl/master/config/builders.py

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [BPF] Fix a bug for __builtin_preserve_field_info() processing (details)
  2. [AMDGPU][NFC] Remove redundant condition (details)
  3. [Hexagon][NFC] Remove redundant condition (details)
  4. [LLDB][NFC] Remove redundant condition (details)
  5. [LLDB][Clang Integration][NFC] Remove redundant condition (details)
  6. [Sema][NFC] Remove Redundant Condition (details)
  7. [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop` (details)
  8. [Analyzer] Fix errors in iterator modeling (details)
  9. [Analyzer] Handle pointer implemented as iterators in iterator checkers (details)
  10. [gn build] Port 4da65c2920b (details)
  11. [clang][CrossTU] Invalidate parent map after get cross TU definition. (details)
Commit 7f6bc84a97f617f9cf148a96ce72567cfa6066f9 by yhs
[BPF] Fix a bug for __builtin_preserve_field_info() processing

Andrii discovered a problem where a simple case similar to below
will generate wrong relocation kind:
  enum { FIELD_EXISTENCE = 2, };
  struct s1 { int a1; };
  int test() {
    struct s1 *v = 0;
    return __builtin_preserve_field_info(v[0], FIELD_EXISTENCE);
  }
The expected relocation kind should be FIELD_EXISTENCE, but
recorded reloc kind in the final object file is FIELD_BYTE_OFFSET,
which is incorrect.

This exposed a bug in generating access strings from intrinsics.
The current access string generation has two steps:
  step 1: find the base struct/union type,
  step 2: traverse members in the base type.

The current implementation relies on at lease one member access
in step 2 to get the correct relocation kind, which is true
in typical cases. But if there is no member accesses, the current
implementation falls to the default info kind FIELD_BYTE_OFFSET.
This is incorrect, we should still record the reloc kind
based on the user input. This patch fixed this issue by properly
recording the reloc kind in such cases.

Differential Revision: https://reviews.llvm.org/D82932
The file was addedllvm/test/CodeGen/BPF/CORE/intrinsic-array-2.ll
The file was modifiedllvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp
Commit 71c6a36018dd3e3a8f709d4a6f81a6d3ce56d780 by adam.balogh
[AMDGPU][NFC] Remove redundant condition

Condition `LiteralCount` is checked both in an outer and in an inner
`if` statement in `SIInstrInfo::verifyInstruction()`. This patch removes
the redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82555
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit ec5ba353fab79d2201f63485117682756da31d46 by adam.balogh
[Hexagon][NFC] Remove redundant condition

Condition `secondReg` is checked both in an outer and in an inner `if`
statement in static function `canCompareBeNewValueJump()` in file
`HexagonNewValueJump.cpp`. This patch removes the redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82556
The file was modifiedllvm/lib/Target/Hexagon/HexagonNewValueJump.cpp
Commit 1b2d2d70e1ec161878a78d880fb8972550b88185 by adam.balogh
[LLDB][NFC] Remove redundant condition

Condition `auto_advance_pc` is checked both in an outer and in an
inner `if` statement in `EmulateInstructionARM::EvaluateInstruction()`,
`EmulateInstructionARM64::EvaluateInstruction()` and
`EmulateInstructionPPC64::EvaluateInstruction()`. This patch removes the
redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82558
The file was modifiedlldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
The file was modifiedlldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
The file was modifiedlldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.cpp
Commit ff2d09148c91784c35b43c52f14b1501f38dd4c5 by adam.balogh
[LLDB][Clang Integration][NFC] Remove redundant condition

Condition `omit_empty_base_classes` is checked both in an outer and
in an inner `if` statement in `TypeSystemClang::GetNumBaseClasses()`.
This patch removes the redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82559
The file was modifiedlldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
Commit 40c50bdee443dd48424ac7d724ced8874c40ee33 by adam.balogh
[Sema][NFC] Remove Redundant Condition

Condition `TypeQuals` is checked both in an outer and in an inner `if`
statement in static function `ConvertDeclSpecToType()` in file
`SemaType.cpp`. This patch removes the redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82563
The file was modifiedclang/lib/Sema/SemaType.cpp
Commit 4da65c2920b68a1cf47054a7d655cc2a19a4aa28 by adam.balogh
[clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

Function `hasPtrOrReferenceInfFunc()` of `bugprone-infinite-loop` is a
generic function which could be reused in another checks. This patch
moves this function into a newly created utility module.

Differential Revision: https://reviews.llvm.org/D81396
The file was modifiedclang-tools-extra/clang-tidy/utils/CMakeLists.txt
The file was addedclang-tools-extra/clang-tidy/utils/Aliasing.cpp
The file was modifiedclang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp
The file was addedclang-tools-extra/clang-tidy/utils/Aliasing.h
Commit ea563daae5232a03e08e43e68da813f76548f36a by adam.balogh
[Analyzer] Fix errors in iterator modeling

There is major a bug found in iterator modeling: upon adding a value
to or subtracting a value from an iterator the position of the original
iterator is also changed beside the result. This patch fixes this bug.

To catch such bugs in the future we also changed the tests to look for
regular expressions including an end-of-line symbol (`$`) so we can
prevent false matches where only the tested prefix matches.

Another minor bug is that when printing the state, all the iterator
positions are printed in a single line. This patch also fixes this.

Differential Revision: https://reviews.llvm.org/D82385
The file was modifiedclang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp
The file was modifiedclang/test/Analysis/iterator-modeling.cpp
Commit 9e63b190af76c798b06b1e3b75216abfdeb1bce3 by adam.balogh
[Analyzer] Handle pointer implemented as iterators in iterator checkers

Iterators are an abstraction of pointers and in some data structures
iterators may be implemented by pointers. This patch adds support for
iterators implemented as pointers in all the iterator checkers
(including iterator modeling).

Differential Revision: https://reviews.llvm.org/D82185
The file was modifiedclang/test/Analysis/mismatched-iterator.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/InvalidatedIteratorChecker.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/Iterator.h
The file was modifiedclang/lib/StaticAnalyzer/Checkers/IteratorRangeChecker.cpp
The file was modifiedclang/test/Analysis/iterator-range.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/Iterator.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp
The file was modifiedclang/test/Analysis/iterator-modeling.cpp
The file was modifiedclang/test/Analysis/invalidated-iterator.cpp
Commit 52e0582440c134fc8ac59e82fe05bb9baef96a66 by llvmgnsyncbot
[gn build] Port 4da65c2920b
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/utils/BUILD.gn
Commit f3b34466104877b024e168cac054bded6b9279a0 by 1.int32
[clang][CrossTU] Invalidate parent map after get cross TU definition.

Summary:
Parent map of ASTContext is built once. If this happens and later
the TU is modified by getCrossTUDefinition the parent map does not
contain the newly imported objects and has to be re-created.

Invalidation of the parent map is added to the CrossTranslationUnitContext.
It could be added to ASTImporter as well but for now this task remains the
responsibility of the user of ASTImporter. Reason for this is mostly that
ASTImporter calls itself recursively.

Reviewers: gamesh411, martong

Reviewed By: gamesh411

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, martong, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D82568
The file was modifiedclang/unittests/CrossTU/CrossTranslationUnitTest.cpp
The file was modifiedclang/lib/CrossTU/CrossTranslationUnit.cpp