FailedChanges

Summary

  1. [lldb/Reproducers] Add instrumentation to SBEnvironment (details)
  2. [clang-format] Set of unit test to begin to validate that we don't change defaults (details)
  3. Give microsoftDemangle() an outparam for how many input bytes were consumed. (details)
Commit 690993a09a0df0d54a5cec7f06fffb6e2210ab8b by Jonas Devlieghere
[lldb/Reproducers] Add instrumentation to SBEnvironment

This class should've been instrumented when it landed. Whether the class
is "highly mutable" or not doesn't affect that.

With this patch TestSBEnvironment.py now passes when replayed.
The file was modifiedlldb/source/API/SBEnvironment.cpp
The file was modifiedlldb/source/API/SBReproducer.cpp
Commit 166ebefd27ac71e3f911f3d7ba0e168464d372af by mydeveloperday
[clang-format] Set of unit test to begin to validate that we don't change defaults

Summary:
This revision is to complement {D75791} so we can be sure that we don't change any default behavior.

For now just add rules to cover AfterExternBlock, but in the future we should add cases to cover the other BraceWrapping rules for each style. This will help guard us when we change code inside of the various getXXXStyle() functions to ensure we are not breaking everyone.

Reviewed By: MarcusJohnson91

Subscribers: cfe-commits

Tags: #clang, #clang-format

Differential Revision: https:
The file was modifiedclang/unittests/Format/FormatTest.cpp
Commit bc1c3655bfd67a0b4ccece465729c39d769e9707 by thakis
Give microsoftDemangle() an outparam for how many input bytes were consumed.

Demangling Itanium symbols either consumes the whole input or fails,
but Microsoft symbols can be successfully demangled with just some
of the input.

Add an outparam that enables clients to know how much of the input was
consumed, and use this flag to give llvm-undname an opt-in warning
on partially consumed symbols.

Differential Revision: https://reviews.llvm.org/D80173
The file was modifiedlldb/source/Core/Mangled.cpp
The file was modifiedllvm/tools/llvm-objdump/COFFDump.cpp
The file was modifiedllvm/lib/DebugInfo/Symbolize/Symbolize.cpp
The file was modifiedllvm/lib/Demangle/Demangle.cpp
The file was modifiedllvm/lib/Demangle/MicrosoftDemangle.cpp
The file was addedllvm/test/Demangle/warn-trailing.test
The file was modifiedllvm/tools/llvm-microsoft-demangle-fuzzer/llvm-microsoft-demangle-fuzzer.cpp
The file was modifiedllvm/tools/llvm-undname/llvm-undname.cpp
The file was modifiedllvm/include/llvm/Demangle/Demangle.h