FailedChanges

Summary

  1. [Win64] Handle FP arguments more gracefully under -mno-sse (details)
  2. Allow /D flags absent during PCH creation under msvc-compat (details)
Commit 40cd26c7008183e01d8276396339aea2a99d83d7 by rnk
[Win64] Handle FP arguments more gracefully under -mno-sse
Pass small FP values in GPRs or stack memory according the the normal
convention. This is what gcc -mno-sse does on Win64.
I adjusted the conditions under which we emit an error to check if the
argument or return value would be passed in an XMM register when SSE is
disabled. This has a side effect of no longer emitting an error for FP
arguments marked 'inreg' when targetting x86 with SSE disabled. Our
calling convention logic was already assigning it to FP0/FP1, and then
we emitted this error. That seems unnecessary, we can ignore 'inreg' and
compile it without SSE.
Reviewers: jyknight, aemerson
Differential Revision: https://reviews.llvm.org/D70465
The file was modifiedllvm/lib/Target/X86/X86CallingConv.td
The file was addedllvm/test/CodeGen/X86/no-sse-x86.ll
The file was addedllvm/test/CodeGen/X86/no-sse-win64.ll
The file was removedllvm/test/CodeGen/X86/nosse-error2.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b by rnk
Allow /D flags absent during PCH creation under msvc-compat
Summary: Before this patch adding a new /D flag when compiling a source
file that consumed a PCH with clang-cl would issue a diagnostic and then
fail.  With the patch, the diagnostic is still issued but the definition
is accepted.  This matches the msvc behavior.  The fuzzy-pch-msvc.c is a
clone of the existing fuzzy-pch.c tests with some msvc specific rework.
msvc diagnostic:
warning C4605: '/DBAR=int' specified on current command line, but was
not specified when precompiled header was built
Output of the CHECK-BAR test prior to the code change:
<built-in>(1,9): warning: definition of macro 'BAR' does not match
definition in precompiled header [-Wclang-cl-pch]
#define BAR int
         ^
D:\repos\llvm\llvm-project\clang\test\PCH\fuzzy-pch-msvc.c(12,1):
error: unknown type name 'BAR'
BAR bar = 17;
^
D:\repos\llvm\llvm-project\clang\test\PCH\fuzzy-pch-msvc.c(23,4):
error: BAR was not defined
#  error BAR was not defined
    ^
1 warning and 2 errors generated.
Reviewers: rnk, thakis, hans, zturner
Subscribers: mikerice, aganea, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72405
The file was modifiedclang/lib/Lex/PPDirectives.cpp
The file was addedclang/test/PCH/ms-pch-macro.c

Summary

  1. [zorg] Pass "-DLLVM_POLLY_LINK_INTO_TOOLS=ON" in getPollyBuildFactory (details)
Commit 6ad01600c4e27d7238564346976df22204a5014b by efriedma
[zorg] Pass "-DLLVM_POLLY_LINK_INTO_TOOLS=ON" in getPollyBuildFactory
The default here was changed recently, and the
aosp-O3-polly-before-vectorizer-unprofitable builder assumes polly is
linked into clang.
Differential Revision: https://reviews.llvm.org/D72646
The file was modifiedzorg/buildbot/builders/PollyBuilder.py