Started 6 days 17 hr ago
Took 1 hr 14 min on green-dragon-18

Success Build rL:362938 - C:362924 - #57399 (Jun 10, 2019 7:28:26 AM)

  • : 362938
  • : 362924
  • : 362859
  • : 362745
  • : 362851
  • : 362866
  • : 362939
  1. [clangd] Revamp textDocument/onTypeFormatting.

    The existing implementation (which triggers on }) is fairly simple and
    has flaws:
    - doesn't trigger frequently/regularly enough (particularly in editors that type the }
    for you)
    - often reformats too much code around the edit
    - has jarring cases that I don't have clear ideas for fixing

    This implementation is designed to trigger on newline, which feels to me more
    intuitive than } or ;.
    It does have allow for reformatting after other characters - it has a
    basic behavior and a model for adding specialized behavior for
    particular characters. But at least initially I'd stick to advertising
    \n in the capabilities.

    This also handles comment splitting: when you insert a line break inside
    a line comment, it will make the new line into an aligned line comment.

    Working on tests, but want people to patch it in and try it - it's hard to
    see if "feel" is right purely by looking at a test.

    Reviewers: ilya-biryukov, hokein

    Subscribers: mgorny, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits

    Tags: #clang

    Differential Revision: (detail/ViewSVN)
    by sammccall
  2. [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field.

    This is

    GNU readelf allows to dump the objects in that case,
    but llvm-readobj/llvm-readelf reports an error and stops.

    The patch fixes that.

    Differential revision: (detail/ViewSVN)
    by grimar

Started by an SCM change (2 times)

This run spent:

  • 10 min waiting;
  • 1 hr 14 min build duration;
  • 1 hr 25 min total from scheduled to completion.
LLVM/Clang Warnings: 1 warning.
    Test Result (no failures)