FailedChanges

Summary

  1. [Attributor][NFC][AAPotentialValues] Change interface of PotentialValuesState (details)
  2. Re-enable OpenBSD PowerPC64 tests. (details)
  3. [mlir][drr] Make error easier to understand (details)
  4. [BuildLibCalls] Add noundef to standard I/O functions (details)
  5. [docs] Fix typos (details)
  6. [TableGen] Pull the increment of a variable out of an assert. (details)
  7. Add override to fix -Winconsistent-missing-override warning. (details)
Commit ff1002aab0911c585a9850fe7315b1e604c271f9 by okuraofvegetable
[Attributor][NFC][AAPotentialValues] Change interface of PotentialValuesState

Previously `PotentialValuesState` inherited `BooleanState`.
We have to add `getAssumed` to the state in order to use `clampStateAndIndicateChange` (which will be used in `AAPotentialValuesArgument`).
However `BooleanState::getAssumed` is not a virtual function and we cannot override it.
Therefore, I changed the state not to inherit `BooleanState` and add `getAssumed` to it.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D85610
The file was modifiedllvm/include/llvm/Transforms/IPO/Attributor.h (diff)
Commit f5fdb6141c5e7a76a10ea702d6fc046692827c43 by brad
Re-enable OpenBSD PowerPC64 tests.
The file was modifiedclang/test/Preprocessor/init.c (diff)
Commit 4b211b94d71386d249e2004c817a9bb659634c2b by jpienaar
[mlir][drr] Make error easier to understand

Changes error from
  error: referencing unbound symbol ''
to
  error: raw string not supported as argument
The file was modifiedmlir/tools/mlir-tblgen/RewriterGen.cpp (diff)
Commit ef018cb65c98fdb517930b762b3b3a3c0dd4dbdd by aqjune
[BuildLibCalls] Add noundef to standard I/O functions

This patch adds noundef to return value and arguments of standard I/O functions.
With this patch, passing undef or poison to the functions becomes undefined
behavior in LLVM IR. Since undef/poison is lowered from operations having UB in C/C++,
passing undef to them was already UB in source.

With this patch, the functions cannot return undef or poison anymore as well.
According to C17 standard, ungetc/ungetwc/fgetpos/ftell can generate unspecified
value; 3.19.3 says unspecified value is a valid value of the relevant type,
and using unspecified value is unspecified behavior, which is not UB, so it
cannot be undef (using undef is UB when e.g. it is used at branch condition).

— The value of the file position indicator after a successful call to the ungetc function for a text stream, or the ungetwc function for any stream, until all pushed-back characters are read or discarded (7.21.7.10, 7.29.3.10).
— The details of the value stored by the fgetpos function (7.21.9.1).
— The details of the value returned by the ftell function for a text stream (7.21.9.4).

In the long run, most of the functions listed in BuildLibCalls should have noundefs; to remove redundant diffs which will anyway disappear in the future, I added noundef to a few more non-I/O functions as well.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D85345
The file was modifiedclang/test/CodeGen/PR3589-freestanding-libcalls.c (diff)
The file was modifiedllvm/test/Transforms/InferFunctionAttrs/annotate.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/no-plt-libcalls.ll (diff)
The file was modifiedllvm/lib/Transforms/Utils/BuildLibCalls.cpp (diff)
The file was modifiedllvm/docs/AliasAnalysis.rst (diff)
The file was modifiedllvm/docs/BugLifeCycle.rst (diff)
The file was modifiedllvm/docs/MemorySSA.rst (diff)
The file was modifiedllvm/docs/Phabricator.rst (diff)
The file was modifiedllvm/docs/CMake.rst (diff)
The file was modifiedllvm/docs/GlobalISel/GMIR.rst (diff)
The file was modifiedllvm/docs/HowToSetUpLLVMStyleRTTI.rst (diff)
The file was modifiedllvm/docs/Security.rst (diff)
The file was modifiedllvm/docs/TestSuiteGuide.md (diff)
The file was modifiedllvm/docs/ExceptionHandling.rst (diff)
The file was modifiedllvm/docs/LangRef.rst (diff)
The file was modifiedllvm/docs/CommandGuide/llvm-extract.rst (diff)
The file was modifiedllvm/docs/AMDGPUUsage.rst (diff)
The file was modifiedllvm/docs/GlobalISel/GenericOpcode.rst (diff)
The file was modifiedllvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst (diff)
Commit 1675f8a2516d0a6f90744aef1066482ee072bbc8 by craig.topper
[TableGen] Pull the increment of a variable out of an assert.

The variable is only used by the assert so the code was fine
before, but it was flagged in PR47072.
The file was modifiedllvm/utils/TableGen/RegisterInfoEmitter.cpp (diff)
Commit b529c5270c99e0ca18e3cbd9a5f50eb0970e560a by echristo
Add override to fix -Winconsistent-missing-override warning.
The file was modifiedlldb/include/lldb/Target/ThreadPlanPython.h (diff)