SuccessChanges

Summary

  1. [X86] Correct the scheduler classes for TAILJMP and TCRETURN CodeGenOnly (details)
  2. [Object] Add tapi files to object (details)
  3. [TSan] #include header instead of forward declaring interceptees (details)
  4. [Object] FIX: update PlatformKind name in TapiFile (details)
  5. gn build: Merge r369600 (details)
  6. [analyzer] TrackConstraintBRVisitor: Do not track unknown values (details)
  7. [analyzer] CastValueChecker: Store the dynamic types and casts (details)
  8. [GWP-ASan] Remove c++ standard lib dependency. (details)
  9. [analyzer] CastValueChecker: Rewrite dead header hotfix (details)
  10. gn build: Merge r369605 (details)
  11. [analyzer] CastValueChecker: Try to fix the buildbots (details)
  12. [COFF] Fix section name for constants larger than 64 bits on Windows (details)
  13. The g_format_infos table needs to be updated in concert with the enum (details)
  14. [X86] Making X86OptimizeLEAs pass public. NFC (details)
  15. [analyzer] Don't track the condition of foreach loops (details)
  16. [FormatManager] Add static_assert to keep formats in sync. (details)
  17. [analyzer] CastValueChecker: Model isa(), isa_and_nonnull() (details)
  18. [analyzer] Enable control dependency condition tracking by default (details)
  19. [FormatManage] Fix the format info order (details)
  20. [lldb] Replace std::once_flag with llvm::once_flag. (details)
  21. [OpenMP] Permit map with DSA on combined directive (details)
  22. [lit] Diagnose insufficient args to internal env (details)
  23. [debugserver] Switch back to std::once_flag (details)
Commit 78e6507b0af7d14dd2cdd6347608055cd452796b by craig.topper
[X86] Correct the scheduler classes for TAILJMP and TCRETURN CodeGenOnly
instructions.
We had an odd combination of WriteJump applied to some memory
instructions and WriteJumpLd applied to register and immediate
instructions.
Thsi should hopefully assign them all correctly.
llvm-svn: 369599
The file was modifiedllvm/lib/Target/X86/X86InstrControl.td (diff)
Commit c20d1f90b53ae53aee3cac86a84e79d596b5711e by cyndy_ishida
[Object] Add tapi files to object
Summary: The intention for this is to allow reading and printing symbols
out from llvm-nm. Tapi file, and Tapi universal follow a similiar format
to their respective MachO Object format.
The tests are dependent on llvm-nm processing tbd files which is why its
in D66160
Reviewers: ributzka, steven_wu, lhames
Reviewed By: ributzka, lhames
Subscribers: mgorny, hiraditya, dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66159
llvm-svn: 369600
The file was addedllvm/lib/Object/TapiUniversal.cpp
The file was modifiedllvm/include/llvm/Object/Binary.h (diff)
The file was addedllvm/include/llvm/Object/TapiFile.h
The file was modifiedllvm/lib/Object/Binary.cpp (diff)
The file was addedllvm/include/llvm/Object/TapiUniversal.h
The file was modifiedllvm/lib/Object/CMakeLists.txt (diff)
The file was addedllvm/lib/Object/TapiFile.cpp
The file was modifiedllvm/lib/Object/LLVMBuild.txt (diff)
Commit 894abb46f891cba2e0ef581650f27f512a7824b4 by jlettner
[TSan] #include header instead of forward declaring interceptees
llvm-svn: 369601
The file was modifiedcompiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cpp (diff)
Commit 9443d0e2c09b5d6914b5aa843b1ba8a9df594215 by cyndy_ishida
[Object] FIX: update PlatformKind name in TapiFile
Buildbots that use GCC failed to compile because overwritten namespace
with variable name
llvm-svn: 369602
The file was modifiedllvm/lib/Object/TapiFile.cpp (diff)
Commit edb08da450391e9683ec4fd71c490c9bd12e17a3 by nicolasweber
gn build: Merge r369600
llvm-svn: 369603
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Object/BUILD.gn (diff)
Commit b73a5711f63466d829f815ed0f1b14f03cef0b05 by dabis.csaba98
[analyzer] TrackConstraintBRVisitor: Do not track unknown values
Summary: -
Reviewers: NoQ, Szelethus
Reviewed By: NoQ, Szelethus
Differential Revision: https://reviews.llvm.org/D66267
llvm-svn: 369604
The file was modifiedclang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp (diff)
The file was modifiedclang/test/Analysis/cast-value.cpp (diff)
Commit 0202c3596c52d453d1e9e5a43d7533b83444df4e by dabis.csaba98
[analyzer] CastValueChecker: Store the dynamic types and casts
Summary: This patch introduces `DynamicCastInfo` similar to
`DynamicTypeInfo` which is stored in `CastSets` which are storing the
dynamic cast informations of objects based on memory regions. It could
be used to store and check the casts and prevent infeasible paths.
Reviewed By: NoQ
Differential Revision: https://reviews.llvm.org/D66325
llvm-svn: 369605
The file was modifiedclang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h (diff)
The file was addedclang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicType.h
The file was removedclang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h
The file was modifiedclang/include/clang/AST/Type.h (diff)
The file was addedclang/test/Analysis/cast-value-state-dump.cpp
The file was modifiedclang/test/Analysis/dump_egraph.cpp (diff)
The file was addedclang/test/Analysis/cast-value-logic.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/ProgramState.cpp (diff)
The file was addedclang/test/Analysis/cast-value-notes.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp (diff)
The file was addedclang/test/Analysis/Inputs/llvm.h
The file was addedclang/lib/StaticAnalyzer/Core/DynamicType.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Core/CMakeLists.txt (diff)
The file was modifiedclang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeInfo.h (diff)
The file was modifiedclang/test/Analysis/expr-inspection.c (diff)
The file was removedclang/test/Analysis/cast-value.cpp
The file was addedclang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicCastInfo.h
The file was removedclang/lib/StaticAnalyzer/Core/DynamicTypeMap.cpp
Commit 3dd22585199195d4656154205ab631b8dd406143 by phosek
[GWP-ASan] Remove c++ standard lib dependency.
Remove c++ standard library dependency for now for @phosek. They have a
complicated build system that breaks with the fuzzer target here.
Also added a todo to remedy later.
Differential Revision: https://reviews.llvm.org/D66568
llvm-svn: 369606
The file was modifiedcompiler-rt/lib/gwp_asan/CMakeLists.txt (diff)
The file was modifiedcompiler-rt/lib/gwp_asan/stack_trace_compressor_fuzzer.cpp (diff)
Commit e4bf456fcef23b7c9ec9968cdf1df36b591755ec by dabis.csaba98
[analyzer] CastValueChecker: Rewrite dead header hotfix
llvm-svn: 369607
The file was modifiedclang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Core/CallEvent.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Checkers/DynamicTypeChecker.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Checkers/DeleteWithNonVirtualDtorChecker.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Checkers/IteratorChecker.cpp (diff)
Commit 6e8b79e3080bde71948e0259fed16247d87c071e by nicolasweber
gn build: Merge r369605
llvm-svn: 369608
The file was modifiedllvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Core/BUILD.gn (diff)
Commit 22dc44ff896a34a94c7ed6d3bf7b577b98e34fbd by dabis.csaba98
[analyzer] CastValueChecker: Try to fix the buildbots
llvm-svn: 369609
The file was modifiedclang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp (diff)
Commit 246750c2a91951fc4b77ebe43d568f47843e6399 by maskray
[COFF] Fix section name for constants larger than 64 bits on Windows
APIntToHexString returns wrong value
("0000000000000000ffffffffffffffff") for integer larger than 64 bits,
and thus TargetLoweringObjectFileCOFF::getSectionForConstant returns
same section name for all numbers larger than 64 bits. This patch tries
to fix it.
Differential Revision: https://reviews.llvm.org/D66458 Patch by Senran
Zhang
llvm-svn: 369610
The file was addedllvm/test/CodeGen/X86/coff-fp-section-name.ll
The file was modifiedllvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)
Commit ca4409b4dc157bdf7a57f7c8be984492577341f4 by Jason Molenda
The g_format_infos table needs to be updated in concert with the enum
Format entries; else we can crash in a place like
FormatManager::GetFormatAsCString().  We should add  bounds checks to
prevent this more reliably, but for tonight I'm just adding this entry
to keep an address-sanitizer test run working.
llvm-svn: 369611
The file was modifiedlldb/source/DataFormatters/FormatManager.cpp (diff)
Commit 7630e24492c55cf07e43c0783997cbf9a1603f45 by pengfei.wang
[X86] Making X86OptimizeLEAs pass public. NFC
Reviewers: wxiao3, LuoYuanke, andrew.w.kaylor, craig.topper,
annita.zhang, liutianle, pengfei, xiangzhangllvm, RKSimon, spatel,
andreadb
Reviewed By: RKSimon
Subscribers: andreadb, hiraditya, llvm-commits
Tags: #llvm
Patch by Gen Pei (gpei)
Differential Revision: https://reviews.llvm.org/D65933
llvm-svn: 369612
The file was modifiedllvm/lib/Target/X86/X86.h (diff)
The file was modifiedllvm/lib/Target/X86/X86TargetMachine.cpp (diff)
The file was modifiedllvm/lib/Target/X86/X86OptimizeLEAs.cpp (diff)
Commit 58eb033a497747331477f8aac36408f24ca0f628 by dkszelethus
[analyzer] Don't track the condition of foreach loops
As discussed on the mailing list, notes originating from the tracking of
foreach loop conditions are always meaningless.
Differential Revision: https://reviews.llvm.org/D66131
llvm-svn: 369613
The file was modifiedclang/test/Analysis/track-control-dependency-conditions.cpp (diff)
The file was modifiedclang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp (diff)
Commit 12002fbd211d3197a2ccba63632937ee1e9212f4 by Jonas Devlieghere
[FormatManager] Add static_assert to keep formats in sync.
This adds a static assert that ensures that there's a format info entry
for every format enum value. This should prevent others from making the
same mistake I made and Jason kindly fixed in r369611. (Thanks!)
llvm-svn: 369614
The file was modifiedlldb/source/DataFormatters/FormatManager.cpp (diff)
Commit 4d71600c113243b0f3eb04c2308f0eda60bfccaa by dabis.csaba98
[analyzer] CastValueChecker: Model isa(), isa_and_nonnull()
Summary: -
Reviewed By: NoQ
Differential Revision: https://reviews.llvm.org/D66423
llvm-svn: 369615
The file was modifiedclang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp (diff)
The file was modifiedclang/test/Analysis/Inputs/llvm.h (diff)
The file was modifiedclang/test/Analysis/cast-value-logic.cpp (diff)
The file was modifiedclang/test/Analysis/cast-value-notes.cpp (diff)
Commit 0f9e530c0f4d2449b093f08b7d46bd2ef174578c by dkszelethus
[analyzer] Enable control dependency condition tracking by default
This patch concludes my GSoC'19 project by enabling track-conditions by
default.
Differential Revision: https://reviews.llvm.org/D66381
llvm-svn: 369616
The file was modifiedclang/test/Analysis/diagnostics/no-store-func-path-notes.m (diff)
The file was modifiedclang/test/Analysis/analyzer-config.c (diff)
The file was modifiedclang/test/Analysis/track-control-dependency-conditions.cpp (diff)
The file was modifiedclang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def (diff)
The file was modifiedclang/test/Analysis/return-value-guaranteed.cpp (diff)
Commit 2621f7bdb4d3bb377d3e9bfb7f76ae527c8ba72d by Jonas Devlieghere
[FormatManage] Fix the format info order
The format info entries need to match the order of the enum entries.
This should fix the two failing data-formatter tests.
llvm-svn: 369617
The file was modifiedlldb/source/DataFormatters/FormatManager.cpp (diff)
Commit 0a8e634b3bb939407c49f11cd724eb656ca9f2cc by davide
[lldb] Replace std::once_flag with llvm::once_flag.
Summary: The former seems like it's not working on some platforms. All
the other uses use `llvm::`, so, let's change for consistency.
Reviewers: jasonmolenda, friss
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D66566
llvm-svn: 369618
The file was modifiedlldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp (diff)
The file was modifiedlldb/include/lldb/Target/Process.h (diff)
Commit 7d5bc554333e28749554c313a207d8267da69837 by jdenny.ornl
[OpenMP] Permit map with DSA on combined directive
For `map`, the following restriction changed in OpenMP 5.0:
* OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item cannot appear in
both a map clause and a data-sharing attribute clause on the same
construct.
* OpenMP 5.0 [2.19.7.1, Restrictions]: "A list item cannot appear in
both a map clause and a data-sharing attribute clause on the same
construct unless the construct is a combined construct."
This patch removes this restriction in the case of combined constructs
and OpenMP 5.0, and it updates Sema not to capture a scalar by copy in
the target region when `firstprivate` and `map` appear for that scalar
on a combined target construct.
This patch also adds a fixme to a test that now reveals that a
diagnostic about loop iteration variables is dropped in the case of
OpenMP 5.0.  That bug exists regardless of this patch's changes.
Reviewed By: ABataev, jdoerfert, hfinkel, kkwli0
Differential Revision: https://reviews.llvm.org/D65835
llvm-svn: 369619
The file was modifiedclang/lib/Sema/SemaExpr.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_parallel_for_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/include/clang/Sema/ScopeInfo.h (diff)
The file was modifiedclang/include/clang/Sema/Sema.h (diff)
The file was modifiedclang/lib/Sema/Sema.cpp (diff)
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp (diff)
The file was modifiedclang/lib/Sema/SemaStmt.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_map_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_simd_private_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_simd_firstprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/target_teams_distribute_parallel_for_lastprivate_messages.cpp (diff)
The file was addedclang/test/OpenMP/target_teams_map_codegen.cpp
Commit 3c577bb415a59c033c1fb2fe1de6a3bbb0abfe0a by jdenny.ornl
[lit] Diagnose insufficient args to internal env
Without this patch, failing to provide a subcommand to lit's internal
`env` results in either a python `IndexError` or an attempt to execute
the final `env` argument, such as `FOO=1`, as a command.  This patch
diagnoses those cases with a more helpful message.
Reviewed By: stella.stamenova
Differential Revision: https://reviews.llvm.org/D66482
llvm-svn: 369620
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u-arg.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-args-none.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u.txt
The file was modifiedllvm/utils/lit/tests/shtest-env.py (diff)
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-assign.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py (diff)
Commit 83ee8d4463d1bb1d2248f5cc7f5577672d3ddf94 by Jonas Devlieghere
[debugserver] Switch back to std::once_flag
We cannot use llvm::once_flag in debugserver because doesn't link
against llvm.
llvm-svn: 369621
The file was modifiedlldb/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp (diff)