AbortedChanges

Summary

  1. [yaml2obj] - Fix BB after r371380 (details)
  2. GlobalISel: add combiner to form indexed loads. (details)
  3. GlobalISel: fix unused warnings in release builds. (details)
  4. [ARM] Prevent generating NEON stack accesses under MVE. (details)
  5. [AArch64][SVE] Implement abs and neg intrinsics (details)
  6. [ELF][AArch64] Apply some NFC cleanups to AArch64ErrataFix.cpp (details)
  7. [clangd] Update clangd-vscode docs to be more user-focused. (details)
  8. [clangd] Support multifile edits as output of Tweaks (details)
  9. Revert rL371198 from llvm/trunk: [DFAPacketizer] Track resources for (details)
  10. [clang-doc] sys::fs::F_None -> OF_None. NFC (details)
  11. [ARM][MVE] VCTP instruction selection (details)
  12. [clang-tidy] Fix bug in bugprone-use-after-move check (details)
  13. [Inliner][NFC] Make test less brittle. (details)
  14. [ELF] nmagic or omagic: don't allocate PT_PHDR or PF_R PT_LOAD for the (details)
  15. [DFAPacketizer] Reapply: Track resources for packetized instructions (details)
  16. compiler-rt: use fp_t instead of long double, for consistency (details)
  17. [NFC][InstCombine] Fixup test i added in rL371352. (details)
  18. [clangd] Add a new highlighting kind for typedefs (details)
  19. Merge note_ovl_builtin_candidate diagnostics; NFC (details)
Commit c11af417e0dd6c04d38bb48f0d77f0b849211ebb by grimar
[yaml2obj] - Fix BB after r371380
Just a fix for an input file name.
llvm-svn: 371383
The file was modifiedllvm/test/tools/yaml2obj/dynamic-symbols.yaml (diff)
Commit 36147adc0b14b455c6c1d738523f930d0793865c by Tim Northover
GlobalISel: add combiner to form indexed loads.
Loosely based on DAGCombiner version, but this part is slightly simpler
in GlobalIsel because all address calculation is performed by G_GEP.
That makes the inc/dec distinction moot so there's just pre/post to
think about.
No targets can handle it yet so testing is via a special flag that
overrides target hooks.
llvm-svn: 371384
The file was modifiedllvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp (diff)
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/gisel-commandline-option.ll (diff)
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir (diff)
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h (diff)
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/combiner-load-store-indexing.ll
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h (diff)
The file was modifiedllvm/include/llvm/Target/GenericOpcodes.td (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64.h (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp (diff)
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp (diff)
The file was modifiedllvm/include/llvm/Support/TargetOpcodes.def (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpp (diff)
Commit 06d93e0a25df040e6ee8727a4730898842274e31 by Tim Northover
GlobalISel: fix unused warnings in release builds.
llvm-svn: 371385
The file was modifiedllvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp (diff)
Commit d936a6301bd34ef991ff5630d06607315f34e6e7 by david.green
[ARM] Prevent generating NEON stack accesses under MVE.
We should not be generating Neon stack loads/stores even for these large
registers.
No test here because my understanding is we will only generate these
QQPR regs for intrinsics and VLDn's. The tests will follow once those
are available.
Differential revision: https://reviews.llvm.org/D67169
llvm-svn: 371386
The file was modifiedllvm/lib/Target/ARM/ARMBaseInstrInfo.cpp (diff)
Commit 55244beeee8ad0fd21c0f6a98996ff11301e397c by cullen.rhodes
[AArch64][SVE] Implement abs and neg intrinsics
Summary: This patch implements two arithmetic intrinsics:
      * int_aarch64_sve_abs
     * int_aarch64_sve_neg
testing the support for scalable vector types in intrinsics added in
D65930.
Reviewed By: greened
Differential Revision: https://reviews.llvm.org/D65931
llvm-svn: 371388
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td (diff)
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td (diff)
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td (diff)
The file was addedllvm/test/CodeGen/AArch64/sve-intrinsics-int-arith.ll
Commit 298c7a09de33229e63cf35e5fed17bca10479a33 by maskray
[ELF][AArch64] Apply some NFC cleanups to AArch64ErrataFix.cpp
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D67310
llvm-svn: 371389
The file was modifiedlld/ELF/AArch64ErrataFix.cpp (diff)
Commit 7c5697c8b24c6a1288f9682ba627182bdfb914f7 by sam.mccall
[clangd] Update clangd-vscode docs to be more user-focused.
Summary: Relegate "updating the extension" docs to a separate file.
Reviewers: hokein, kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67092
llvm-svn: 371390
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/DEVELOPING.md
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/symbolsearch.png
The file was modifiedclang-tools-extra/clangd/clients/clangd-vscode/README.md (diff)
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/complete.png
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/extract.png
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/format.png
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/include.png
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/xrefs.png
The file was addedclang-tools-extra/clangd/clients/clangd-vscode/doc-assets/diagnostics.png
Commit 5b270932cc6ee39d977d397bafc363e9c5df040f by kadircet
[clangd] Support multifile edits as output of Tweaks
Summary: First patch for propogating multifile changes from tweak
outputs to LSP WorkspaceEdits.
Uses SM to convert tooling::Replacements to TextEdits. Errors out if
there are any inconsistencies between the draft version and the version
generated the edits.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66637
llvm-svn: 371392
The file was modifiedclang-tools-extra/clangd/refactor/Tweak.h (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/ExpandMacro.cpp (diff)
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/Tweak.cpp (diff)
The file was modifiedclang-tools-extra/clangd/unittests/TweakTesting.cpp (diff)
The file was modifiedclang-tools-extra/clangd/ClangdServer.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/SwapIfBranches.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/RawStringLiteral.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp (diff)
The file was modifiedclang-tools-extra/clangd/SourceCode.h (diff)
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp (diff)
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/ExpandAutoType.cpp (diff)
The file was modifiedclang-tools-extra/clangd/SourceCode.cpp (diff)
Commit 462e3d8050faf6442b678a9089933542b7c0e84c by llvm-dev
Revert rL371198 from llvm/trunk: [DFAPacketizer] Track resources for
packetized instructions
This patch allows the DFAPacketizer to be queried after a packet is
formed to work out which resources were allocated to the packetized
instructions.
This is particularly important for targets that do their own bundle
packing - it's not sufficient to know simply that instructions can share
a packet; which slots are used is also required for encoding.
This extends the emitter to emit a side-table containing resource usage
diffs for each state transition. The packetizer maintains a set of all
possible resource states in its current state. After packetization is
complete, all remaining resource states are possible packetization
strategies.
The sidetable is only ~500K for Hexagon, but the extra tracking is
disabled by default
(most uses of the packetizer like MachinePipeliner don't care and don't
need the extra maintained state).
Differential Revision: https://reviews.llvm.org/D66936
........ Reverted as this is causing "compiler out of heap space" errors
on MSVC 2017/19 NDEBUG builds
llvm-svn: 371393
The file was removedllvm/test/CodeGen/Hexagon/packetizer-resources.ll
The file was modifiedllvm/utils/TableGen/DFAPacketizerEmitter.cpp (diff)
The file was modifiedllvm/include/llvm/CodeGen/DFAPacketizer.h (diff)
The file was modifiedllvm/lib/CodeGen/DFAPacketizer.cpp (diff)
The file was modifiedllvm/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp (diff)
Commit ff354de2944e3082c5c2f1663c9b86c4ffabc3e3 by maskray
[clang-doc] sys::fs::F_None -> OF_None. NFC
F_None, F_Text and F_Append are kept for compatibility.
llvm-svn: 371394
The file was modifiedclang-tools-extra/clang-doc/tool/ClangDocMain.cpp (diff)
The file was modifiedclang-tools-extra/clang-doc/HTMLGenerator.cpp (diff)
Commit 1ad508e8e2d5036a6356a136ab0b02251091e2a6 by sam.parker
[ARM][MVE] VCTP instruction selection
Add codegen support for vctp{8,16,32}.
Differential Revision: https://reviews.llvm.org/D67344
llvm-svn: 371395
The file was addedllvm/test/CodeGen/Thumb2/mve-vctp.ll
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td (diff)
Commit f9ce864558ab4110233e86f6391ced320dd1e07b by yitzhakm
[clang-tidy] Fix bug in bugprone-use-after-move check
Summary: The bugprone-use-after-move check exhibits false positives for
certain uses of the C++17 if/switch init statements. These false
positives are caused by a bug in the ExprSequence calculations.
This revision adds tests for the false positives and fixes the
corresponding sequence calculation.
Reviewers: gribozavr
Subscribers: xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67292
llvm-svn: 371396
The file was modifiedclang-tools-extra/clang-tidy/utils/ExprSequence.cpp (diff)
The file was modifiedclang-tools-extra/test/clang-tidy/bugprone-use-after-move.cpp (diff)
Commit 388b9794b619141d4a3bba7d82b803a499d11540 by courbet
[Inliner][NFC] Make test less brittle.
Summary: This tests inlining size thresholds, but relies on the output
of running the full O2 pipeline, making it brittle against changes in
unrelated passes.
Only run the inlining pass and set thresholds on the test RUN line
instead.
Found while investigating D60318.
Reviewers: RKSimon, qcolombet
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67349
llvm-svn: 371397
The file was modifiedllvm/test/Transforms/Inline/inline_minisize.ll (diff)
Commit e8c0d933603a2ebfd535be454824219fb7b71001 by maskray
[ELF] nmagic or omagic: don't allocate PT_PHDR or PF_R PT_LOAD for the
!hasPhdrsCommands case
``` part.phdrs = script->hasPhdrsCommands() ? script->createPhdrs() :
createPhdrs(part);
```
createPhdrs() allocates a PT_PHDR and a PF_R PT_LOAD, which will be
deleted later in LinkerScript::allocateHeaders, but leave a gap between
the program headers and the first section. Don't allocate the segments
to avoid the gap. PT_INTERP is likely not needed as well.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D67324
llvm-svn: 371398
The file was modifiedlld/test/ELF/magic-page-combo-warn.s (diff)
The file was modifiedlld/ELF/Writer.cpp (diff)
The file was modifiedlld/test/ELF/nmagic.s (diff)
The file was modifiedlld/test/ELF/segments.s (diff)
The file was modifiedlld/test/ELF/relro-omagic.s (diff)
Commit b6c7fce67add2769cb5f3e07d4a70ae09dc12836 by jmolloy
[DFAPacketizer] Reapply: Track resources for packetized instructions
Reapply with fix to reduce resources required by the compiler - use
unsigned[2] instead of std::pair. This causes clang and gcc to compile
the generated file multiple times faster, and hopefully will reduce the
resource requirements on Visual Studio also. This fix is a little ugly
but it's clearly the same issue the previous author of DFAPacketizer
faced (the previous tables use unsigned[2] rather uglily too).
This patch allows the DFAPacketizer to be queried after a packet is
formed to work out which resources were allocated to the packetized
instructions.
This is particularly important for targets that do their own bundle
packing - it's not sufficient to know simply that instructions can share
a packet; which slots are used is also required for encoding.
This extends the emitter to emit a side-table containing resource usage
diffs for each state transition. The packetizer maintains a set of all
possible resource states in its current state. After packetization is
complete, all remaining resource states are possible packetization
strategies.
The sidetable is only ~500K for Hexagon, but the extra tracking is
disabled by default
(most uses of the packetizer like MachinePipeliner don't care and don't
need the extra maintained state).
Differential Revision: https://reviews.llvm.org/D66936
llvm-svn: 371399
The file was modifiedllvm/lib/CodeGen/DFAPacketizer.cpp (diff)
The file was modifiedllvm/include/llvm/CodeGen/DFAPacketizer.h (diff)
The file was modifiedllvm/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp (diff)
The file was modifiedllvm/utils/TableGen/DFAPacketizerEmitter.cpp (diff)
The file was addedllvm/test/CodeGen/Hexagon/packetizer-resources.ll
Commit 1a3dd638c4a9173e53628b497a1aadc31c32eb50 by emaste
compiler-rt: use fp_t instead of long double, for consistency
Most builtins accepting or returning long double use the fp_t typedef.
Change the remaining few cases to do so.
Differential Revision: https://reviews.llvm.org/D35034
llvm-svn: 371400
The file was modifiedcompiler-rt/lib/builtins/divtf3.c (diff)
The file was modifiedcompiler-rt/lib/builtins/extenddftf2.c (diff)
The file was modifiedcompiler-rt/lib/builtins/addtf3.c (diff)
The file was modifiedcompiler-rt/lib/builtins/extendsftf2.c (diff)
Commit 59608c0049531758b9cbb3c400a68d597b797bf4 by lebedev.ri
[NFC][InstCombine] Fixup test i added in rL371352.
llvm-svn: 371401
The file was modifiedllvm/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll (diff)
Commit e237520a8f5006692e25d7e5da7271f1c9832491 by ibiryukov
[clangd] Add a new highlighting kind for typedefs
Summary: We still attempt to highlight them as underlying types, but
fallback to the generic 'typedef' highlighting kind if the underlying
type is too complicated.
Reviewers: hokein
Reviewed By: hokein
Subscribers: nridge, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67290
llvm-svn: 371402
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.h (diff)
The file was modifiedclang-tools-extra/clangd/test/semantic-highlighting.test (diff)
The file was modifiedclang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp (diff)
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp (diff)
Commit 783fc95f3eedfb44acbfc1f3f100a5eca83e7359 by sven.vanhaastregt
Merge note_ovl_builtin_candidate diagnostics; NFC
There is no difference between the unary and binary case, so merge them.
llvm-svn: 371403
The file was modifiedclang/lib/Sema/SemaOverload.cpp (diff)
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td (diff)