AbortedChanges

Summary

  1. [mips] Make another set of test cases more tolerant to exact symbol (details)
  2. [Reproducer] Disconnect when the replay server is out of packets. (details)
  3. Revert "[Reproducer] Add a `cont` to ModuleCXX.test" (details)
  4. LangRef: mention MSan's problem with speculative conditional branches. (details)
  5. Simplify demangler rule for lambda-expressions to match discussion on (details)
  6. [GlobalISel]: Fix a bug where we could dereference None (details)
  7. [Windows] Replace TrapUnreachable with an int3 insertion pass (details)
  8. AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC (details)
  9. PR43242: Fix crash when typo-correcting to an operator() that should not (details)
  10. Fix incorrect demangling of call operator of lambda with explicit (details)
  11. [Symbol] Give ClangASTContext a PersistentExpressionState instead of a (details)
  12. AMDGPU/GlobalISel: Fix insert point when lowering fminnum/fmaxnum (details)
  13. [Expression] Remove unused header from LLVMUserExpression (details)
  14. Remove some unnecessary REQUIRES: shell lines (details)
  15. [Utility] Replace `lldb_private::CleanUp` by `llvm::scope_exit` (details)
  16. [llvm][ADT][NFC] Add test for makeArrayRef(std::array) (details)
  17. Fix crash mangling an explicit lambda non-type template parameter pack (details)
  18. gn build: (manually) merge r371429 (details)
  19. Remove REQUIRES:shell from tests that pass for me on Windows (details)
  20. gn build: Merge r371466 (details)
  21. Revert [git-llvm] Do not reinvent `@{upstream}` (details)
Commit 2439b8b0c5f384561e005a64efe5c36b1007c6ff by simon
[mips] Make another set of test cases more tolerant to exact symbol
addresses. NFC
llvm-svn: 371458
The file was modifiedlld/test/ELF/mips-plt-n32.s (diff)
The file was modifiedlld/test/ELF/rel-addend-with-rela-input.s (diff)
The file was modifiedlld/test/ELF/mips-micro-thunks.s (diff)
The file was modifiedlld/test/ELF/mips-tls-hilo.s (diff)
The file was modifiedlld/test/ELF/mips-32.s (diff)
The file was modifiedlld/test/ELF/mips-npic-call-pic.s (diff)
The file was modifiedlld/test/ELF/mips-tls-64.s (diff)
The file was modifiedlld/test/ELF/mips-npic-call-pic-os.s (diff)
The file was modifiedlld/test/ELF/mips-tls-static.s (diff)
The file was modifiedlld/test/ELF/mips-micror6-relocs.s (diff)
The file was modifiedlld/test/ELF/mips-tls-static-64.s (diff)
The file was modifiedlld/test/ELF/mips-nonalloc.s (diff)
The file was modifiedlld/test/ELF/mips-pc-relocs.s (diff)
The file was modifiedlld/test/ELF/mips-plt-r6.s (diff)
The file was modifiedlld/test/ELF/mips-micro-relocs.s (diff)
The file was modifiedlld/test/ELF/mips-micro-plt.s (diff)
The file was modifiedlld/test/ELF/mips-plt-n64.s (diff)
The file was modifiedlld/test/ELF/mips-tls.s (diff)
The file was modifiedlld/test/ELF/mips-n32-rels.s (diff)
The file was modifiedlld/test/ELF/mips-xgot-order.s (diff)
The file was modifiedlld/test/ELF/mips-micro-cross-calls.s (diff)
The file was modifiedlld/test/ELF/mips-micro-jal.s (diff)
The file was modifiedlld/test/ELF/mips-tls-64-pic-local-variable.s (diff)
Commit 9b961cc6043a3b84195ae7d938d2816c96f76303 by Jonas Devlieghere
[Reproducer] Disconnect when the replay server is out of packets.
This is a fix for the issue described in r371144.
> On more than one occasion I've found this test got stuck during replay
> while waiting for a packet from debugserver when the debugger was in
> the process of being destroyed.
When the replay server is out of packets we should just disconnect so
the debugger doesn't have to do any cleanup that it wouldn't do during
capture.
llvm-svn: 371459
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp (diff)
Commit e0bce4e1c2abf39b27f0f0d1e771f09fd5cfa8b8 by Jonas Devlieghere
Revert "[Reproducer] Add a `cont` to ModuleCXX.test"
This should no longer be necessary after r371459.
llvm-svn: 371460
The file was modifiedlldb/lit/Reproducer/Modules/Inputs/ModuleCXX.in (diff)
Commit f0e2755b45a42a3c3284c7a3cec82147065c36a2 by eugeni.stepanov
LangRef: mention MSan's problem with speculative conditional branches.
Summary: This short blurb aims to disallow optimizations like we had to
revert
(under MSan) in
https://reviews.llvm.org/D21165
https://bugs.llvm.org/show_bug.cgi?id=28054
https://reviews.llvm.org/D67205
Reviewers: vitalybuka, efriedma
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67244
llvm-svn: 371461
The file was modifiedllvm/docs/LangRef.rst (diff)
Commit 2ca7370183a104b7769202032e9d5a41c04ed070 by richard-llvm
Simplify demangler rule for lambda-expressions to match discussion on
cxx-abi list.
llvm-svn: 371462
The file was modifiedlibcxxabi/src/demangle/ItaniumDemangle.h (diff)
The file was modifiedllvm/include/llvm/Demangle/ItaniumDemangle.h (diff)
The file was modifiedlibcxxabi/test/test_demangle.pass.cpp (diff)
Commit 5112b71126a133b744b11b50d60fcb89d005513d by aditya_nandakumar
[GlobalISel]: Fix a bug where we could dereference None
getConstantVRegVal returns None when dealing with constants > 64 bits.
Don't assume we always have a value in GISelKnownBits.
llvm-svn: 371465
The file was modifiedllvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp (diff)
Commit bf02399a852e1ff06e074c353908147d9a22b1dc by rnk
[Windows] Replace TrapUnreachable with an int3 insertion pass
This is an alternative to D66980, which was reverted. Instead of
inserting a pseudo instruction that optionally expands to nothing, add a
pass that inserts int3 when appropriate after basic block layout.
Reviewers: hans
Differential Revision: https://reviews.llvm.org/D67201
llvm-svn: 371466
The file was modifiedllvm/lib/Target/X86/X86TargetMachine.cpp (diff)
The file was modifiedllvm/test/CodeGen/X86/funclet-layout.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/br-fold.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/catchret-regmask.ll (diff)
The file was addedllvm/test/CodeGen/X86/noreturn-call-win64.ll
The file was modifiedllvm/test/DebugInfo/COFF/local-variable-gap.ll (diff)
The file was addedllvm/test/CodeGen/X86/win64-eh-empty-block.ll
The file was modifiedllvm/lib/Target/X86/CMakeLists.txt (diff)
The file was modifiedllvm/test/CodeGen/X86/wineh-coreclr.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/catchpad-lifetime.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/win64_eh.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/empty-function.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/catchpad-regmask.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/trap.ll (diff)
The file was modifiedllvm/test/CodeGen/WinEH/wineh-noret-cleanup.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/pr24374.ll (diff)
The file was modifiedllvm/test/CodeGen/X86/unreachable-trap.ll (diff)
The file was modifiedllvm/lib/Target/X86/X86.h (diff)
The file was modifiedllvm/test/CodeGen/X86/win64_call_epi.ll (diff)
The file was addedllvm/lib/Target/X86/X86AvoidTrailingCall.cpp
Commit 06c8cb03caee18241263168cf4405b629940ab84 by Austin.Kerbow
AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka,
dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67374
llvm-svn: 371467
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h (diff)
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUCallLowering.h (diff)
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp (diff)
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (diff)
Commit 245ba2c25fef704abe8caa662c02b147eab12eac by richard-llvm
PR43242: Fix crash when typo-correcting to an operator() that should not
have been visible.
llvm-svn: 371468
The file was modifiedclang/lib/Sema/SemaExpr.cpp (diff)
The file was modifiedclang/test/SemaCXX/lambda-expressions.cpp (diff)
Commit 865697f9b9add3030c1a2637aac6f755c573f781 by richard-llvm
Fix incorrect demangling of call operator of lambda with explicit
template parameters due to registering template parameters twice.
llvm-svn: 371469
The file was modifiedlibcxxabi/test/test_demangle.pass.cpp (diff)
The file was modifiedllvm/include/llvm/Demangle/ItaniumDemangle.h (diff)
The file was modifiedlibcxxabi/src/demangle/ItaniumDemangle.h (diff)
Commit 9e86561878dc470c4023cd627dd39cafc13fdc4d by apl
[Symbol] Give ClangASTContext a PersistentExpressionState instead of a
ClangPersistentVariables
ClangASTContext doesn't use m_persistent_variables in a way specific to
ClangPersistentVariables. Therefore, it should hold a unique pointer to
PersistentExpressionState instead of a ClangPersistentVariablesUP. This
also prevents you from pulling in a plugin header when including
ClangASTContext.h
Doing this exposed an implicit dependency in ObjCLanguage that was
corrected by including ClangModulesDeclVendor.h
llvm-svn: 371470
The file was modifiedlldb/include/lldb/Symbol/ClangASTContext.h (diff)
The file was modifiedlldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp (diff)
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp (diff)
Commit a91f017ae31557d13b06eaf69b7ce65c57c6849f by Matthew.Arsenault
AMDGPU/GlobalISel: Fix insert point when lowering fminnum/fmaxnum
llvm-svn: 371471
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fmaxnum.mir (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fminnum.mir (diff)
Commit 1dbee8f0437f0d6a5890c728e5847334644f8157 by apl
[Expression] Remove unused header from LLVMUserExpression
llvm-svn: 371472
The file was modifiedlldb/source/Expression/LLVMUserExpression.cpp (diff)
Commit 87d47cb7c4792cb4dbb6911b9d11e5bd9f2dc928 by rnk
Remove some unnecessary REQUIRES: shell lines
This means these tests will run on Windows. Replace one with
UNSUPPORTED: system-windows.
llvm-svn: 371473
The file was modifiedllvm/test/Linker/datalayout.ll (diff)
The file was modifiedllvm/test/tools/llvm-cov/cov-comdat.test (diff)
The file was modifiedllvm/test/MC/ELF/comp-dir.s (diff)
The file was modifiedllvm/test/tools/llvm-cov/copy_block_helper.m (diff)
The file was modifiedllvm/test/Other/lit-unicode.txt (diff)
The file was modifiedllvm/test/tools/llvm-cov/gcov47_compatibility.cpp (diff)
The file was modifiedllvm/test/tools/llvm-cov/range_based_for.cpp (diff)
The file was modifiedllvm/test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test (diff)
The file was modifiedllvm/test/MC/AsmParser/preserve-comments-crlf.s (diff)
Commit e0ea8d87eb943f89e32524d6386c4c9c4c9f1310 by Jonas Devlieghere
[Utility] Replace `lldb_private::CleanUp` by `llvm::scope_exit`
This removes the CleanUp class and replaces its usages with llvm's
ScopeExit, which has similar semantics.
Differential revision: https://reviews.llvm.org/D67378
llvm-svn: 371474
The file was modifiedlldb/source/Symbol/LocateSymbolFileMacOSX.cpp (diff)
The file was removedlldb/unittests/Utility/CleanUpTest.cpp
The file was modifiedlldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp (diff)
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (diff)
The file was modifiedlldb/tools/lldb-test/lldb-test.cpp (diff)
The file was removedlldb/include/lldb/Utility/CleanUp.h
The file was modifiedlldb/source/Host/macosx/objcxx/Host.mm (diff)
The file was modifiedlldb/unittests/Utility/CMakeLists.txt (diff)
Commit 79707ecd7d9132517831dd00a896c877c1c3916b by Jan Korous
[llvm][ADT][NFC] Add test for makeArrayRef(std::array)
llvm-svn: 371475
The file was modifiedllvm/unittests/ADT/ArrayRefTest.cpp (diff)
Commit ae6f7bcb367465ba1b97cdcb27d528b49f7b238d by richard-llvm
Fix crash mangling an explicit lambda non-type template parameter pack
that is not a pack expansion.
llvm-svn: 371476
The file was modifiedclang/test/CodeGenCXX/mangle-lambda-explicit-template-params.cpp (diff)
The file was modifiedclang/lib/AST/ItaniumMangle.cpp (diff)
Commit fcbc512f80a94516a6337a655ff1b13cbf67011e by nicolasweber
gn build: (manually) merge r371429
llvm-svn: 371477
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Remarks/BUILD.gn (diff)
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Remarks/BUILD.gn (diff)
Commit a9980f60ce083fa6d5fd03c12c58ca0b293e3d60 by rnk
Remove REQUIRES:shell from tests that pass for me on Windows
I see in the history for some of these tests REQUIRES:shell was used as
a way to disable tests on Windows because they are flaky there. I tried
not to re-enable such tests, but it's possible that I missed some and
this will re-enable flaky tests on Windows. If so, we should disable
them with UNSUPPORTED:system-windows and add a comment that they are
flaky there. So far as I can tell, the lit internal shell is capable of
running all of these tests, and we shouldn't use REQUIRES:shell as a
proxy for Windows.
llvm-svn: 371478
The file was modifiedclang/test/Modules/dependency-dump-dependent-module.m (diff)
The file was modifiedclang/test/Modules/at-import-in-framework-header.m (diff)
The file was modifiedclang/test/OpenMP/taskloop_lastprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/task_firstprivate_codegen.cpp (diff)
The file was modifiedclang/test/Frontend/dependency-gen-has-include.c (diff)
The file was modifiedclang/test/Modules/dependency-dump.m (diff)
The file was modifiedclang/test/OpenMP/task_private_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_simd_private_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_private_codegen.cpp (diff)
The file was modifiedclang/test/Driver/clang-offload-bundler.c (diff)
The file was modifiedclang/test/Index/crash-recovery-modules.m (diff)
The file was modifiedclang/test/Analysis/crash-trace.c (diff)
The file was modifiedclang/test/PCH/modified-header-error.c (diff)
The file was modifiedclang/test/Modules/implicit-invalidate-common.c (diff)
The file was modifiedclang/test/OpenMP/taskloop_firstprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp (diff)
The file was modifiedclang/test/Driver/rewrite-map-in-diagnostics.c (diff)
The file was modifiedclang/test/Modules/builtins.m (diff)
The file was modifiedclang/test/Driver/check-time-trace-sections.cpp (diff)
The file was modifiedclang/test/Format/style-on-command-line.cpp (diff)
The file was modifiedclang/test/Driver/check-time-trace.cpp (diff)
The file was modifiedclang/test/Parser/crash-report.c (diff)
The file was modifiedclang/test/CodeGen/thinlto_backend.ll (diff)
The file was modifiedclang/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp (diff)
The file was modifiedclang/test/Driver/crash-report-crashfile.m (diff)
Commit 939614341227c0c2a65860520bb82ad832d3415b by nicolasweber
gn build: Merge r371466
llvm-svn: 371479
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn (diff)
Commit daa79c5338228a746a7eba0cf2f2f356e1d45a5b by Mehdi Amini
Revert [git-llvm] Do not reinvent `@{upstream}`
This reverts r371290 (git commit
7faffd544b16f851a632d6b8f93e3c8485ff34bb)
The change wasnt NFC and broke some users' workflow. Reverting while
figuring out the best alternative to move forward.
llvm-svn: 371480
The file was modifiedllvm/utils/git-svn/git-llvm (diff)