Started 4 mo 9 days ago
Took 10 hr on green-dragon-13

Failed Build #6458 (Jul 9, 2019 9:51:48 PM)

  • : 365594
  • : 365590
  • : 365591
  • : 364589
  • : 365562
  • : 365576
  1. Fix modular build issues caused by BitCodes.h

    Consolidate llvm::BWH_* statics into an enum to fix
    module build issues. This fixes the LLVM_Bitcode module,
    getting rid of -Wmodules-ambiguous-internal-linkage.

    Differential Revision: (detail)
    by Kristina Brooks
  2. [ubsan][test] Restore float-divide-by-zero test

    Removed by rCTE365307 to fix buildbots. It can be restored now because D64317/rC365587 brought back -fsanitize=float-divide-by-zero (detail)
    by maskray
  3. [analyzer] CastValueChecker: Remove a dump()

    Summary: Fix a nit. (detail)
    by charusso
  4. [X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads.

    This seems to fix a failure reported by Jordan Rupprecht, but we
    don't have a reduced test case yet. (detail)
    by ctopper
  5. [Support] Move llvm::MemoryBuffer to sys::fs::file_t

    On Windows, Posix integer file descriptors are a compatibility layer
    over native file handles provided by the C runtime. There is a hard
    limit on the maximum number of file descriptors that a process can open,
    and the limit is 8192. LLD typically doesn't run into this limit because
    it opens input files, maps them into memory, and then immediately closes
    the file descriptor. This prevents it from running out of FDs.

    For various reasons, I'd like to open handles to every input file and
    keep them open during linking. That requires migrating MemoryBuffer over
    to taking open native file handles instead of integer FDs.

    Reviewers: aganea, Bigcheese

    Reviewed By: aganea

    Subscribers: smeenai, silvas, mehdi_amini, hiraditya, steven_wu, dexonsmith, dang, llvm-commits, zturner

    Tags: #llvm

    Differential Revision: (detail)
    by rnk
  6. [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

    D63793 removed float-divide-by-zero from the "undefined" set but it
    failed to add it to getSupportedSanitizers(), thus the sanitizer is
    rejected by the driver:

        clang-9: error: unsupported option '-fsanitize=float-divide-by-zero' for target 'x86_64-unknown-linux-gnu'

    Also, add SanitizerMask::FloatDivideByZero to a few other masks to make -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime and -fsanitize-coverage work.

    Reviewed By: rsmith, vitalybuka

    Differential Revision: (detail)
    by maskray
  7. AMDGPU/GlobalISel: Add support for wide loads >= 256-bits

    This adds support for the most commonly used wide load types:
    <8xi32>, <16xi32>, <4xi64>, and <8xi64>

    Reviewers: arsenm

    Reviewed By: arsenm

    Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, volkan, Petar.Avramovic, llvm-commits

    Tags: #llvm

    Differential Revision: (detail)
    by tstellar
  8. [analyzer] CastValueChecker: Model casts

    It models the LLVM casts:
    - `cast<>`
    - `dyn_cast<>`
    - `cast_or_null<>`
    - `dyn_cast_or_null<>`

    It has a very basic support without checking the `classof()` function.

    (It reapplies the reverted 'llvm-svn: 365582' patch with proper test file.)

    Reviewed By: NoQ

    Tags: #clang

    Differential Revision: (detail)
    by charusso
  9. Revert "[analyzer] CastValueChecker: Model casts"

    This reverts commit 27cf6664437efd640bb6db5594bafcce68fa2854. (detail)
    by charusso
  10. GlobalISel: Implement lower for G_FCOPYSIGN

    In SelectionDAG AMDGPU treated these as legal, but this was mostly
    because the bitcasts required for FP types were painful. Theoretically
    the bitpattern should eventually match to bfi, so don't bother trying
    to get the patterns to import. (detail)
    by arsenm
  11. [analyzer] CastValueChecker: Model casts

    It models the LLVM casts:
    - `cast<>`
    - `dyn_cast<>`
    - `cast_or_null<>`
    - `dyn_cast_or_null<>`

    It has a very basic support without checking the `classof()` function.

    Reviewed By: NoQ

    Tags: #clang

    Differential Revision: (detail)
    by charusso
  12. Revert [clang] DirectoryWatcher

    This reverts r365574 (git commit 31babea94a3ed38a140540f2252cf043dacec1f7) (detail)
    by rnk
  13. [Bitcode] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h

    This fixes a modules issue. (detail)
    by thegameg
  14. [MS] Treat ignored explicit calling conventions as an explicit __cdecl

    The CCCR_Ignore action is only used for Microsoft calling conventions,
    mainly because MSVC does not warn when a calling convention would be
    ignored by the current target. This behavior is actually somewhat
    important, since windows.h uses WINAPI (which expands to __stdcall)
    widely. This distinction didn't matter much before the introduction of
    __vectorcall to x64 and the ability to make that the default calling
    convention with /Gv. Now, we can't just ignore __stdcall for x64, we
    have to treat it as an explicit __cdecl annotation.

    Fixes PR42531 (detail)
    by rnk
  15. [docs][Remarks] Add documentation for remarks in LLVM

    This adds documentation that describes remarks in LLVM.

    It aims at explaining what remarks are, how to enable them, and what
    users can do with the different modes.

    It lists all the available flags in LLVM (excluding clang), and
    describes the expected YAML structure as well as the tools that support
    the YAML format today.

    Differential Revision: (detail)
    by thegameg
  16. [X86] Don't form extloads in combineExtInVec unless the load extension is legal.

    This should prevent doing this on pre-sse4.1 targets or for 256
    bit vectors without avx2.

    I don't know of a failure from this. Op legalization will probably
    take care of, but seemed better to be safe. (detail)
    by ctopper
  17. [clangd] fix assert in test after r365531.

    Unverified because CMake/ninja seems to be broken... (detail)
    by sammccall
  18. AMDGPU/GlobalISel: Fix legality for G_BUILD_VECTOR (detail)
    by arsenm
  19. [clang] DirectoryWatcher

    Asynchronously monitors specified directory for changes and passes notifications to provided callback.

    Dependency for index-while-building.

    Differential Revision: (detail)
    by Jan Korous
  20. [AMDGPU] gfx908 v_pk_fmac_f16 support

    Differential Revision: (detail)
    by rampitec
  21. gn build: Merge r365536. (detail)
    by pcc
  22. gn build: Merge r365532. (detail)
    by pcc
  23. gn build: Merge r365541. (detail)
    by pcc
  24. gn build: Merge r365531. (detail)
    by pcc
  25. Add lldb type unit support to the release notes

    Reviewers: JDevlieghere, teemperor

    Subscribers: llvm-commits, lldb-commits

    Tags: #llvm

    Differential Revision: (detail)
    by labath
  26. GlobalISel: Combine unmerge of merge with intermediate cast

    This eliminates some illegal intermediate vectors when operations are
    scalarized. (detail)
    by arsenm
  27. [Profile] Support raw/indexed profiles larger than 4GB

    rdar://45955976 (detail)
    by Vedant Kumar
  28. [llvm-objdump] Keep warning for --disassemble-functions in correct order.

    relative to normal output when dumping archive files.

    prepare for PR35351.

    Reviewers: jhenderson, grimar, MaskRay, rupprecht

    Reviewed by: MaskRay, jhenderson

    Differential Revision: (detail)
    by yuanfang
  29. [AMDGPU] gfx908 mAI instructions, MC part

    Differential Revision: (detail)
    by rampitec
  30. build: use multiple `install` rather than building up a list

    Rather than building up a list to iterate over later, just create multiple
    install commands based on the configuration. This makes it easier to see what
    is getting installed and allows for the install handling to be centralised. NFC (detail)
    by Saleem Abdulrasool
  31. Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8"

    Fix compilation errors related to `SANITIZER_GO` `#ifdef`s.

    Refine longjmp key management.  For Linux, re-implement key retrieval in
    C (instead of assembly).  Removal of `InitializeGuardPtr` and a final
    round of cleanups will be done in the next commit.

    Reviewed By: dvyukov

    Differential Revision:

    llvm-svn: 365513 (detail)
    by yln
  32. XFAIL clang/test/Headers/max_align.c on i686 (detail)
    by andusy
  33. Use the Itanium C++ ABI for the test

    Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI.
    Add a FIXME for it if anyone cares to implement it. (detail)
    by rnk
  34. De-templatize non-dependent VS macro logic, NFC

    These macro definitions don't depend on the template parameter, so they
    don't need to be part of the template. Move them to a .cpp file. (detail)
    by rnk
  35. [CXX] Exercise all paths through these tests.

    Differential Revision: (detail)
    by probinson
  36. [TSan] Refine longjmp key management on Darwin

    NFC. (detail)
    by yln
  37. [SLP] Optimize getSpillCost(); NFCI

    For a given set of live values, the spill cost will always be the
    same for each call. Compute the cost once and multiply it by the
    number of calls.

    (I'm not sure this spill cost modeling makes sense if there are
    multiple calls, as the spill cost will likely be shared across
    calls in that case. But that's how it currently works.) (detail)
    by nikic
  38. hwasan: Improve precision of checks using short granule tags.

    A short granule is a granule of size between 1 and `TG-1` bytes. The size
    of a short granule is stored at the location in shadow memory where the
    granule's tag is normally stored, while the granule's actual tag is stored
    in the last byte of the granule. This means that in order to verify that a
    pointer tag matches a memory tag, HWASAN must check for two possibilities:

    * the pointer tag is equal to the memory tag in shadow memory, or
    * the shadow memory tag is actually a short granule size, the value being loaded
      is in bounds of the granule and the pointer tag is equal to the last byte of
      the granule.

    Pointer tags between 1 to `TG-1` are possible and are as likely as any other
    tag. This means that these tags in memory have two interpretations: the full
    tag interpretation (where the pointer tag is between 1 and `TG-1` and the
    last byte of the granule is ordinary data) and the short tag interpretation
    (where the pointer tag is stored in the granule).

    When HWASAN detects an error near a memory tag between 1 and `TG-1`, it
    will show both the memory tag and the last byte of the granule. Currently,
    it is up to the user to disambiguate the two possibilities.

    Because this functionality obsoletes the right aligned heap feature of
    the HWASAN memory allocator (and because we can no longer easily test
    it), the feature is removed.

    Also update the documentation to cover both short granule tags and
    outlined checks.

    Differential Revision: (detail)
    by pcc
  39. [PoisonChecking] Flesh out complete todo list for full coverage

    Note: I don't actually plan to implement all of the cases at the moment, I'm just documenting them for completeness.  There's a couple of cases left which are practically useful for me in debugging loop transforms, and I'll probably stop there for the moment. (detail)
    by reames
  40. [X86][AMDGPU][DAGCombiner] Move call to allowsMemoryAccess into isLoadBitCastBeneficial/isStoreBitCastBeneficial to allow X86 to bypass it

    Basically the problem is that X86 doesn't set the Fast flag from
    allowsMemoryAccess on certain CPUs due to slow unaligned memory
    subtarget features. This prevents bitcasts from being folded into
    loads and stores. But all vector loads and stores of the same width
    are the same cost on X86.

    This patch merges the allowsMemoryAccess call into isLoadBitCastBeneficial to allow X86 to skip it.

    Differential Revision: (detail)
    by ctopper
  41. Fix build error for VC STL, use llvm::make_unique (detail)
    by rnk
  42. [AMDGPU] gfx908 register file changes

    Differential Revision: (detail)
    by rampitec
  43. [OpenMP] Simplify getFloatTypeSemantics

    When the float point representations are the same on the host and on the target device,
    (`&Target->getLongDoubleFormat() == &AuxTarget->getLongDoubleFormat()`),
    we can just use `AuxTarget->getLongDoubleFormat()`.

    Reviewed By: ABataev

    Differential Revision: (detail)
    by maskray
  44. [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir.

    This way the test would better match the intended usage of the header,
    plus it makes some additional testing (e.g. in CI) a bit easier to set up.

    Reviewers: morehouse

    Reviewed By: morehouse

    Subscribers: mgorny, delcypher, #sanitizers, llvm-commits

    Tags: #llvm, #sanitizers

    Differential Revision: (detail)
    by dor1s
  45. [PoisonCheker] Support for out of bounds operands on shifts + insert/extractelement

    These are sources of poison which don't come from flags, but are clearly documented in the LangRef.  Left off support for scalable vectors for the moment, but should be easy to add if anyone is interested. (detail)
    by reames
  46. Boilerplate for producing XCOFF object files from the PowerPC backend.

    Stubs out a number of the classes needed to produce a new object file format
    (XCOFF) for the powerpc-aix target. For testing input is an empty module which
    produces an object file with just a file header.

    Differential Revision: (detail)
    by sfertile
  47. [X86] LowerToHorizontalOp - use count_if to count non-UNDEF ops. NFCI. (detail)
    by rksimon
  48. [PoisonChecking] Add validation rules for "exact" on sdiv/udiv

    As directly stated in the LangRef, no ambiguity here... (detail)
    by reames
  49. [ThinLTO] only emit used or referenced CFI records to index

    distributed ThinLTO indices to implement indirect function call
    checking.  This change causes us to only emit entries for functions
    that are either defined or used by the module we're writing the index
    for (instead of all functions in the combined index), which can make
    the indices substantially smaller.

    Fixes PR42378.

    Reviewers: pcc, vitalybuka, eugenis

    Subscribers: mehdi_amini, hiraditya, dexonsmith, arphaman, llvm-commits

    Tags: #llvm

    Differential Revision: (detail)
    by inglorion
  50. Add a transform pass to make the executable semantics of poison explicit in the IR

    Implements a transform pass which instruments IR such that poison semantics are made explicit. That is, it provides a (possibly partial) executable semantics for every instruction w.r.t. poison as specified in the LLVM LangRef. There are obvious parallels to the sanitizer tools, but this pass is focused purely on the semantics of LLVM IR, not any particular source language.

    The target audience for this tool is developers working on or targetting LLVM from a frontend. The idea is to be able to take arbitrary IR (with the assumption of known inputs), and evaluate it concretely after having made poison semantics explicit to detect cases where either a) the original code executes UB, or b) a transform pass introduces UB which didn't exist in the original program.

    At the moment, this is mostly the framework and still needs to be fleshed out. By reusing existing code we have decent coverage, but there's a lot of cases not yet handled. What's here is good enough to handle interesting cases though; for instance, one of the recent LFTR bugs involved UB being triggered by integer induction variables with nsw/nuw flags would be reported by the current code.

    (See comment in PoisonChecking.cpp for full explanation and context)

    Differential Revision: (detail)
    by reames
  51. Try to appease the Windows build bots.

    Several of the conditonal operators commited in llvm-svn: 365524 fail to compile
    on the windows buildbots. Converting to an if and early return to try to fix. (detail)
    by sfertile
  52. Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8"

    This reverts commit 521f77e6351fd921f5a81027c7c72addca378989. (detail)
    by yln
  53. [BPF] Fix a typo in the file name

    Fixed the file name from BPFAbstrctMemberAccess.cpp to

    Signed-off-by: Yonghong Song <> (detail)
    by yhs
  54. [clangd] Rewrite of logic to rebuild the background index serving structures.

    Previously it was rebuilding every 5s by default, which was much too frequent
    in the long run - the goal was to provide an early build. There were also some
    bugs. There were also some bugs, and a dedicated thread was used in production
    but not tested.

    - rebuilds are triggered by #TUs built, rather than time. This should scale
       more sensibly to fast vs slow machines.
    - there are two separate indexed-TU thresholds to trigger index build: 5 TUs
       for the first build, 100 for subsequent rebuilds.
    - rebuild is always done on the regular indexing threads, and is affected by
       blockUntilIdle. This means unit/lit tests run the production configuration.
    - fixed a bug where we'd rebuild after attempting to load shards, even if there
       were no shards.
    - the BackgroundIndexTests don't really test the subtleties of the rebuild
       policy (for determinism, we call blockUntilIdle, so rebuild-on-idle is enough
       to pass the tests). Instead, we expose the rebuilder as a separate class and
       have fine-grained tests for it.

    Reviewers: kadircet

    Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, jfb, llvm-commits

    Tags: #llvm

    Differential Revision: (detail)
    by sammccall
  55. gn build: Merge r365503. (detail)
    by pcc
  56. [unittest] Add the missing bogus machine register info initialization. (detail)
    by hliao
  57. [AMDGPU] gfx908 clang target

    Differential Revision: (detail)
    by rampitec
  58. [AMDGPU] gfx908 target

    Differential Revision: (detail)
    by rampitec
  59. [Object][XCOFF] Add support for 64-bit file header and section header dumping.

    Adds a readobj dumper for 32-bit and 64-bit section header tables, and extend
    support for the file-header dumping to include 64-bit object files. Also
    refactors the binary file parsing to be done in a helper function in an attempt
    to cleanup error handeling.

    Differential Revision: (detail)
    by sfertile
  60. [InstCombine] add tests for trunc(load); NFC

    I'm not sure if transforming any of these is valid as
    a target-independent fold, but we might as well have
    a few tests here to confirm or deny our position. (detail)
    by spatel
  61. [clangd] Show documentation in hover, and fetch docs from index if needed.

    I assume showing docs is going to be part of structured hover rendering, but
    it's unclear whether that's going to make clangd 9 so this is low-hanging fruit.

    (Also fixes a bug uncovered in FormattedString's plain text output: need blank
    lines when text follows codeblocks)

    Reviewers: kadircet

    Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, llvm-commits

    Tags: #llvm

    Differential Revision: (detail)
    by sammccall
  62. AMDGPU: Fix test failing since r365512 (detail)
    by arsenm
  63. Revert "[HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()"

    This reverts commit d95557306585404893d610784edb3e32f1bfce18. (detail)
    by jsji
  64. Add lit.local.cfg to llvm-objdump tests

    Add configuration file to llvm-objdump tests to treat files with .yaml
    extension as tests. (detail)
    by steven_wu
  65. [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL


    Differential revision: (detail)
    by epilk

Started by upstream project clang-stage2-cmake-RgSan_relay build number 1174
originally caused by:

This run spent:

  • 1 ms waiting;
  • 10 hr build duration;
  • 10 hr total from scheduled to completion.
Test Result (no failures)

    Identified problems

    Regression test failed

    This build failed because a regression test in the test suite FAILed. See the test report for details.
    Indication 1

    Ninja target failed

    Below is a link to the first failed ninja target.
    Indication 2