SuccessChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [lldb/gdb-remote] Change default value of use-libraries-svr4 to true (details)
  2. [libcxx testing] Remove ALLOW_RETRIES from two futures tests (details)
  3. [LLD] [COFF] Try to fix test errors from 7f0e6c31c255303 on windows (details)
  4. [libc++] Adjust how we guard the inclusion of unistd.h (details)
  5. [clangd] Setting recovery-ast flag in buildCompilerInvocation, NFC. (details)
  6. [lldb] Use llvm::MC for register numbers in AArch64 ABIs (details)
  7. [lldb] Fix a "missing return" warning in XcodeSDK (details)
  8. [clangd] Don't create as much garbage while building Dex index. (details)
  9. [clangd] Remove extra qualification (details)
  10. [VPlan] Move emission of \\l\"+\n to dumpBasicBlock (NFC). (details)
  11. [clangd] Correct the elog message, NFC. (details)
  12. SelectionDAG.cpp - remove non-constant EXTRACT_SUBVECTOR/INSERT_SUBVECTOR handling. NFC. (details)
  13. [libcxx][span] Remove tuple interface (details)
  14. [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof. (details)
  15. [libcxx][span] Remove const_iterator from std::span (details)
Commit deea174ee508c84652785e55f54c81fd1fba492c by pavel
[lldb/gdb-remote] Change default value of use-libraries-svr4 to true

This setting was added last year, defaulting to false. There have been
no bug reports about the svr4 code path since then, and the using this
packet is definitely faster than walking the module list from lldb.

Set the default value of the setting to true, as that is a better
default. Users can still change it back if encountering problems, or we
can revert the change as well, in case of bigger issues.

I also add a note to the setting description that it is only effective
if lldb is built with xml support.
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
Commit 1858953395d2e2d13f6e2e5642b45849c3c388aa by dave
[libcxx testing] Remove ALLOW_RETRIES from two futures tests

These two tests do not use the "thread sleeps X milliseconds" pattern
that other libcxx tests use, so all we can do in order to remove
ALLOW_RETRIES workaround is remove the assumption that measuring the
"quick" return of `wait()` is possible (it is not). Let the test harness
verify overall that `wait()` does not hang.

As a bonus, have the spin-waiting threads `yield()`, which is what well
behaved code should do.
The file was modifiedlibcxx/test/std/thread/futures/futures.shared_future/wait_until.pass.cpp
The file was modifiedlibcxx/test/std/thread/futures/futures.unique_future/wait_until.pass.cpp
Commit b0969be4dfbbb81acb34c7d4c38ef158d2c27d00 by martin
[LLD] [COFF] Try to fix test errors from 7f0e6c31c255303 on windows

Just skip trying to match for the path separator explicitly (instead
of making it match either a forward or backwards slash), simplifying
the test a little.
The file was modifiedlld/test/COFF/autoimport-x86.s
Commit 4d25f4453d60dee522e905c844dde0f4b6ed9475 by john.brawn
[libc++] Adjust how we guard the inclusion of unistd.h

unistd.h isn't guaranteed to exist when the target isn't Windows, in
particular if the target is bare-metal (i.e. no operating system).
Handle this by using __has_include instead, though in
filesystem/operations.cpp we already unconditionally include it so
just remove the extra include.

Differential Revision: https://reviews.llvm.org/D79784
The file was modifiedlibcxx/src/thread.cpp
The file was modifiedlibcxx/src/chrono.cpp
The file was modifiedlibcxx/src/filesystem/operations.cpp
Commit 2045189043d4e2748ed82915dd7bdf3e96728738 by hokein.wu
[clangd] Setting recovery-ast flag in buildCompilerInvocation, NFC.

This saves some duplicated code (in buildPreamble and buildAST).
The file was modifiedclang-tools-extra/clangd/ParsedAST.cpp
The file was modifiedclang-tools-extra/clangd/Preamble.cpp
The file was modifiedclang-tools-extra/clangd/Compiler.cpp
Commit 638efe3929cd3f62590462434d6397c150ad78ed by pavel
[lldb] Use llvm::MC for register numbers in AArch64 ABIs

Summary:
This is equivalent to previous patches (e.g. 07355c1c0) for the x86 ABIs.

One name fixup is needed -- lldb refers to the floating/vector registers by
their vector name (vN). Llvm does not use this name, so we map it to qN,
representing the register as a single 128 bit value (this choice is fairly
arbitrary -- any other name would also work fine as they all have the same
DWARF number).

Reviewers: JDevlieghere, jasonmolenda, omjavaid

Reviewed By: omjavaid

Subscribers: clayborg, danielkiss, aprantl, kristof.beyls, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D75607
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABIAArch64.h
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp
The file was modifiedlldb/source/Plugins/ABI/AArch64/ABISysV_arm64.h
Commit dac6e9ca2190b7ece67ab7b62ea113d3ade5067a by pavel
[lldb] Fix a "missing return" warning in XcodeSDK
The file was modifiedlldb/source/Utility/XcodeSDK.cpp
Commit 735ab46cb4148c92d636c912832a32509252b579 by sam.mccall
[clangd] Don't create as much garbage while building Dex index.

Summary:
The Token objects are relatively expensive and we were spending a lot of
CPU creating them for each trigram emitted. Instead, use a tiny trigram
structure until we're ready to finalize the index.

This improves the new BuildDex benchmark by 20%. This code is hot and on
the critical path in clangd: it runs after a new preamble is built.

Reviewers: kbobyrev

Subscribers: ilya-biryukov, MaskRay, jkorous, mgrang, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79918
The file was modifiedclang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
The file was modifiedclang-tools-extra/clangd/index/dex/Trigram.cpp
The file was modifiedclang-tools-extra/clangd/index/dex/Dex.cpp
The file was modifiedclang-tools-extra/clangd/test/Inputs/requests.json
The file was modifiedclang-tools-extra/clangd/index/dex/Trigram.h
The file was modifiedclang-tools-extra/clangd/unittests/DexTests.cpp
Commit 17ba631d1317f294460036cc430d0000d158ad3d by sam.mccall
[clangd] Remove extra qualification
The file was modifiedclang-tools-extra/clangd/index/dex/Trigram.h
Commit 4c8285c750bc957f2064e591720241d0047c69f5 by flo
[VPlan] Move emission of \\l\"+\n to dumpBasicBlock (NFC).

The patch standardizes printing of VPRecipes a bit, by hoisting out the
common emission of \\l\"+\n. It simplifies the code and is also a first
step towards untangling printing from DOT format output, with the goal
of making the DOT output optional and to provide a more concise debug
output if DOT output is disabled.

Reviewers: gilr, Ayal, rengolin

Reviewed By: gilr

Differential Revision: https://reviews.llvm.org/D78883
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
Commit 0e5706d018762f4ab4d895ba268bb6444ae04884 by hokein.wu
[clangd] Correct the elog message, NFC.
The file was modifiedclang-tools-extra/clangd/CodeComplete.cpp
Commit 80715b71249e7a63f990ac676483278f34a7b7e9 by llvm-dev
SelectionDAG.cpp - remove non-constant EXTRACT_SUBVECTOR/INSERT_SUBVECTOR handling. NFC.

Now that D79814 has landed, we can assume that subvector ops use constant, in-range indices.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Commit c73a491d10b8f0258c02385fe14ad0626e8c8efd by Louis Dionne
[libcxx][span] Remove tuple interface

This implements P2116 by removing the tuple interface from std::span.

Differential Revision: https://reviews.llvm.org/D75640
The file was removedlibcxx/test/std/containers/views/span.tuple/get.pass.cpp
The file was removedlibcxx/test/std/containers/views/span.tuple/tuple_size.pass.cpp
The file was modifiedlibcxx/include/span
The file was removedlibcxx/test/std/containers/views/span.tuple/tuple_size.fail.cpp
The file was modifiedlibcxx/www/cxx2a_status.html
The file was removedlibcxx/test/std/containers/views/span.tuple/tuple_element.fail.cpp
The file was removedlibcxx/test/std/containers/views/span.tuple/get.fail.cpp
The file was removedlibcxx/test/std/containers/views/span.tuple/tuple_element.pass.cpp
Commit cb1eeb42c03c31d4dadd00dbaec693e6d7516099 by 1.int32
[Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

Summary:
The check of VLA size was done previously for variable declarations
(of VLA type) only. Now it is done for typedef (and type-alias)
and sizeof expressions with VLA too.

Reviewers: Szelethus, martong

Reviewed By: Szelethus, martong

Subscribers: rnkovacs, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, ASDenysPetrov, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79072
The file was modifiedclang/test/Analysis/vla.c
The file was modifiedclang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp
The file was modifiedclang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
Commit c5ff4031c6d1dd20e9b9a4929f537a1e50bcf76c by Louis Dionne
[libcxx][span] Remove const_iterator from std::span

This implements the resolution to LWG-3320.

Differential Revision: https://reviews.llvm.org/D75642
The file was modifiedlibcxx/www/cxx2a_status.html
The file was modifiedlibcxx/include/span
The file was modifiedlibcxx/test/std/containers/views/span.iterators/begin.pass.cpp
The file was modifiedlibcxx/test/std/containers/views/span.iterators/rbegin.pass.cpp
The file was modifiedlibcxx/test/std/containers/views/span.iterators/rend.pass.cpp
The file was modifiedlibcxx/test/std/containers/views/types.pass.cpp
The file was modifiedlibcxx/test/std/containers/views/span.iterators/end.pass.cpp