FailedChanges

Summary

  1. [Wdocumentation] improve wording of a warning message Based on @davezarzycki remarks in D64696 improved the wording of the warning message. Differential Revision: https://reviews.llvm.org/D66700 Patch by Mark de Wever.
  2. [X86][DAGCombiner] Teach narrowShuffle to use concat_vectors instead of inserting into undef Summary: Concat_vectors is more canonical during early DAG combine. For example, its what's used by SelectionDAGBuilder when converting IR shuffles into SelectionDAG shuffles when element counts between inputs and mask don't match. We also have combines in DAGCombiner than can pull concat_vectors through a shuffle. See partitionShuffleOfConcats. So it seems like concat_vectors is a better operation to use here. I had to teach DAGCombiner's SimplifyVBinOp to also handle concat_vectors with undef. I haven't checked yet if we can remove the INSERT_SUBVECTOR version in there or not. I didn't want to mess with the other caller of getShuffleHalfVectors that's used during shuffle lowering where insert_subvector probably is what we want to produce so I've enabled this via a boolean passed to the function. Reviewers: spatel, RKSimon Reviewed By: RKSimon Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66504
  3. [X86] Add test case for inserting/extracting from two shuffled vectors. NFC
  4. [X86] Add test case for inserting/extracting from shuffled vectors. NFC
  5. [PowerPC][AIX] Adds support for writing the .data section in assembly files Summary: Adds support for generating the .data section in assembly files for global variables with a non-zero initialization. The support for writing the .data section in XCOFF object files will be added in a follow-on patch. Any relocations are not included in this patch. Reviewers: hubert.reinterpretcast, sfertile, jasonliu, daltenty, Xiangling_L Reviewed by: hubert.reinterpretcast Subscribers: nemanjai, hiraditya, kbarton, MaskRay, jsji, wuzish, shchenz, DiggerLin, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66154
  6. [AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC 5 happy
  7. Fixup in test/DebugInfo/X86/live-debug-vars-discard-invalid.mir The test case used invalid source operands as input to BTS64rr instructions (feeding register operands with immediates). This patch changes those instruction into using BTS64ri8 instead, which seems to better match the operand types. Fixes problems seen in https://reviews.llvm.org/D63973.
  8. [TableGen] Correct comments for end of namespace. NFC Summary: Update end-of-namespace comments generated by tablegen emitters to fulfill the rules setup by clang-tidy's llvm-namespace-comment checker. Fixed a few end-of-namespace comments in the tablegen source code as well. Reviewers: craig.topper Reviewed By: craig.topper Subscribers: craig.topper, stoklund, dschuff, sbc100, jgravelle-google, aheejin, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66396
  9. [SDAG] Fold umul_lohi with 0 or 1 multiplicand These can turn up during multiplication legalization. In principle these should also apply to smul_lohi, but I wasn't able to figure out how to produce those with the necessary operands. Differential Revision: https://reviews.llvm.org/D66380
  10. [X86] Teach -Os immediate sharing code to not count constant uses that will become INC/DEC. INC/DEC don't use an immediate so we don't need to count it. We also shouldn't use the custom isel for it. Fixes PR42998.
  11. [X86] Add test cases for PR42998. NFC
  12. FileManager: Factor duplicated code in getBufferForFile, NFC Incidentally, this also unifies the two versions (removing an unnecessary call to `SmallString::c_str`).
  13. Removing block comments from CodeView records in assembly files & related code cleanup
Revision 369873 by gribozavr:
[Wdocumentation] improve wording of a warning message

Based on @davezarzycki remarks in D64696 improved the wording of the warning
message.

Differential Revision: https://reviews.llvm.org/D66700

Patch by Mark de Wever.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td (diff)clang.src/include/clang/Basic/DiagnosticCommentKinds.td
The file was modified/cfe/trunk/test/Sema/warn-documentation.cpp (diff)clang.src/test/Sema/warn-documentation.cpp
Revision 369872 by ctopper:
[X86][DAGCombiner] Teach narrowShuffle to use concat_vectors instead of inserting into undef

Summary:
Concat_vectors is more canonical during early DAG combine. For example, its what's used by SelectionDAGBuilder when converting IR shuffles into SelectionDAG shuffles when element counts between inputs and mask don't match. We also have combines in DAGCombiner than can pull concat_vectors through a shuffle. See partitionShuffleOfConcats. So it seems like concat_vectors is a better operation to use here. I had to teach DAGCombiner's SimplifyVBinOp to also handle concat_vectors with undef. I haven't checked yet if we can remove the INSERT_SUBVECTOR version in there or not.

I didn't want to mess with the other caller of getShuffleHalfVectors that's used during shuffle lowering where insert_subvector probably is what we want to produce so I've enabled this via a boolean passed to the function.

Reviewers: spatel, RKSimon

Reviewed By: RKSimon

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66504
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 369871 by deadalnix:
[X86] Add test case for inserting/extracting from two shuffled vectors. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/vector-shuffle-combining.ll (diff)llvm.src/test/CodeGen/X86/vector-shuffle-combining.ll
Revision 369870 by deadalnix:
[X86] Add test case for inserting/extracting from shuffled vectors. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/vector-shuffle-combining.ll (diff)llvm.src/test/CodeGen/X86/vector-shuffle-combining.ll
Revision 369869 by xingxue:
[PowerPC][AIX] Adds support for writing the .data section in assembly files

Summary:
Adds support for generating the .data section in assembly files for global variables with a non-zero initialization. The support for writing the .data section in XCOFF object files will be added in a follow-on patch. Any relocations are not included in this patch.

Reviewers: hubert.reinterpretcast, sfertile, jasonliu, daltenty, Xiangling_L

Reviewed by: hubert.reinterpretcast

Subscribers: nemanjai, hiraditya, kbarton, MaskRay, jsji, wuzish, shchenz, DiggerLin, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66154
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/AsmPrinter.h (diff)llvm.src/include/llvm/CodeGen/AsmPrinter.h
The file was modified/llvm/trunk/include/llvm/MC/MCAsmInfo.h (diff)llvm.src/include/llvm/MC/MCAsmInfo.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp (diff)llvm.src/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
The file was modified/llvm/trunk/lib/MC/MCAsmInfoXCOFF.cpp (diff)llvm.src/lib/MC/MCAsmInfoXCOFF.cpp
The file was modified/llvm/trunk/lib/MC/MCAsmStreamer.cpp (diff)llvm.src/lib/MC/MCAsmStreamer.cpp
The file was modified/llvm/trunk/lib/MC/MCObjectFileInfo.cpp (diff)llvm.src/lib/MC/MCObjectFileInfo.cpp
The file was modified/llvm/trunk/lib/MC/MCSectionXCOFF.cpp (diff)llvm.src/lib/MC/MCSectionXCOFF.cpp
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp (diff)llvm.src/lib/Target/PowerPC/PPCAsmPrinter.cpp
The file was added/llvm/trunk/test/CodeGen/PowerPC/aix-xcoff-data.llllvm.src/test/CodeGen/PowerPC/aix-xcoff-data.ll
Revision 369867 by d0k:
[AMDGPU] Downgrade from StringLiteral to const char* in an attempt to make GCC 5 happy
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPULibFunc.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPULibFunc.cpp
Revision 369866 by bjope:
Fixup in test/DebugInfo/X86/live-debug-vars-discard-invalid.mir

The test case used invalid source operands as input
to BTS64rr instructions (feeding register operands with
immediates). This patch changes those instruction into
using BTS64ri8 instead, which seems to better match the
operand types.

Fixes problems seen in https://reviews.llvm.org/D63973.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/DebugInfo/X86/live-debug-vars-discard-invalid.mir (diff)llvm.src/test/DebugInfo/X86/live-debug-vars-discard-invalid.mir
Revision 369865 by bjope:
[TableGen] Correct comments for end of namespace. NFC

Summary:
Update end-of-namespace comments generated by
tablegen emitters to fulfill the rules setup by
clang-tidy's llvm-namespace-comment checker.

Fixed a few end-of-namespace comments in the
tablegen source code as well.

Reviewers: craig.topper

Reviewed By: craig.topper

Subscribers: craig.topper, stoklund, dschuff, sbc100, jgravelle-google, aheejin, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66396
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp (diff)llvm.src/utils/TableGen/AsmMatcherEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/CodeGenMapTable.cpp (diff)llvm.src/utils/TableGen/CodeGenMapTable.cpp
The file was modified/llvm/trunk/utils/TableGen/DAGISelMatcherGen.cpp (diff)llvm.src/utils/TableGen/DAGISelMatcherGen.cpp
The file was modified/llvm/trunk/utils/TableGen/DFAPacketizerEmitter.cpp (diff)llvm.src/utils/TableGen/DFAPacketizerEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/DisassemblerEmitter.cpp (diff)llvm.src/utils/TableGen/DisassemblerEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/FixedLenDecoderEmitter.cpp (diff)llvm.src/utils/TableGen/FixedLenDecoderEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/InstrDocsEmitter.cpp (diff)llvm.src/utils/TableGen/InstrDocsEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp (diff)llvm.src/utils/TableGen/InstrInfoEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/SubtargetEmitter.cpp (diff)llvm.src/utils/TableGen/SubtargetEmitter.cpp
The file was modified/llvm/trunk/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp (diff)llvm.src/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp
Revision 369864 by nikic:
[SDAG] Fold umul_lohi with 0 or 1 multiplicand

These can turn up during multiplication legalization. In principle
these should also apply to smul_lohi, but I wasn't able to figure
out how to produce those with the necessary operands.

Differential Revision: https://reviews.llvm.org/D66380
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/i128-mul.ll (diff)llvm.src/test/CodeGen/X86/i128-mul.ll
The file was modified/llvm/trunk/test/CodeGen/X86/imul.ll (diff)llvm.src/test/CodeGen/X86/imul.ll
The file was modified/llvm/trunk/test/CodeGen/X86/mul-i1024.ll (diff)llvm.src/test/CodeGen/X86/mul-i1024.ll
The file was modified/llvm/trunk/test/CodeGen/X86/mul-i256.ll (diff)llvm.src/test/CodeGen/X86/mul-i256.ll
The file was modified/llvm/trunk/test/CodeGen/X86/mul-i512.ll (diff)llvm.src/test/CodeGen/X86/mul-i512.ll
The file was modified/llvm/trunk/test/CodeGen/X86/mul128.ll (diff)llvm.src/test/CodeGen/X86/mul128.ll
The file was modified/llvm/trunk/test/CodeGen/X86/overflow.ll (diff)llvm.src/test/CodeGen/X86/overflow.ll
The file was modified/llvm/trunk/test/CodeGen/X86/umulo-128-legalisation-lowering.ll (diff)llvm.src/test/CodeGen/X86/umulo-128-legalisation-lowering.ll
Revision 369863 by ctopper:
[X86] Teach -Os immediate sharing code to not count constant uses that will become INC/DEC.

INC/DEC don't use an immediate so we don't need to count it. We
also shouldn't use the custom isel for it.

Fixes PR42998.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelDAGToDAG.cpp (diff)llvm.src/lib/Target/X86/X86ISelDAGToDAG.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/pr42998.ll (diff)llvm.src/test/CodeGen/X86/pr42998.ll
Revision 369862 by ctopper:
[X86] Add test cases for PR42998. NFC
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/CodeGen/X86/pr42998.llllvm.src/test/CodeGen/X86/pr42998.ll
Revision 369861 by Duncan P. N. Exon Smith:
FileManager: Factor duplicated code in getBufferForFile, NFC

Incidentally, this also unifies the two versions (removing an
unnecessary call to `SmallString::c_str`).
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/FileManager.h (diff)clang.src/include/clang/Basic/FileManager.h
The file was modified/cfe/trunk/lib/Basic/FileManager.cpp (diff)clang.src/lib/Basic/FileManager.cpp
Revision 369860 by nilanjana_basu:
Removing block comments from CodeView records in assembly files & related code cleanup
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h (diff)llvm.src/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/TypeVisitorCallbackPipeline.h (diff)llvm.src/include/llvm/DebugInfo/CodeView/TypeVisitorCallbackPipeline.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/CVTypeVisitor.cpp (diff)llvm.src/lib/DebugInfo/CodeView/CVTypeVisitor.cpp
The file was modified/llvm/trunk/test/DebugInfo/COFF/array-odr-violation.ll (diff)llvm.src/test/DebugInfo/COFF/array-odr-violation.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/class-options-common.ll (diff)llvm.src/test/DebugInfo/COFF/class-options-common.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/inlining.ll (diff)llvm.src/test/DebugInfo/COFF/inlining.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/pr37492.ll (diff)llvm.src/test/DebugInfo/COFF/pr37492.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/synthetic.ll (diff)llvm.src/test/DebugInfo/COFF/synthetic.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/types-basic.ll (diff)llvm.src/test/DebugInfo/COFF/types-basic.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/types-data-members.ll (diff)llvm.src/test/DebugInfo/COFF/types-data-members.ll