SuccessChanges

Summary

  1. Revert r374657: "[lit] Try again to fix new tests that fail on Windows (details)
  2. [lit] Try yet again to fix new tests that fail on Windows bots (details)
  3. [lit] Adjust error handling for decode introduced by r374665 (details)
  4. [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. (details)
  5. Fix cppcheck shadow variable name warnings. NFCI. (details)
  6. Replace for-loop of SmallVector::push_back with SmallVector::append. (details)
  7. [NFC][LoopIdiom] Adjust FIXME to be self-explanatory (details)
  8. [lit] Try errors="ignore" for decode introduced by r374665 (details)
  9. SymbolRecord - fix uninitialized variable warnings. NFCI. (details)
  10. SymbolRecord - consistently use explicit for single operand constructors (details)
  11. [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings (details)
  12. Revert r374671: "[lit] Try errors="ignore" for decode introduced by (details)
  13. Revert r374666: "[lit] Adjust error handling for decode introduced by (details)
  14. Revert r374665: "[lit] Try yet again to fix new tests that fail on (details)
  15. Revert r374653: "[lit] Fix a few oversights in r374651 that broke some (details)
  16. Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use (details)
  17. Revert 374651: "Reland r374392: [lit] Extend internal diff to support (details)
  18. Revert r374650: "Reland r374390: [lit] Extend internal diff to support (details)
  19. Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding (details)
  20. Revert r374648: "Reland r374388: [lit] Make internal diff work in (details)
  21. [libc++][test] Silence MSVC warning in std::optional test (details)
Commit 8259f7ca120734b6fba0e67ae445492009f9871d by jdenny.ornl
Revert r374657: "[lit] Try again to fix new tests that fail on Windows
bots"
llvm-svn: 374664
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit a271acbf79326da83cab36a02938fc6cd5740b1b by jdenny.ornl
[lit] Try yet again to fix new tests that fail on Windows bots
I seem to have misread the bot logs on my last attempt.  When lit's
internal diff runs on Windows under Python 2.7, it's text diffs not
binary diffs that need decoding to avoid this error when writing the
diff to stdout:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
There is no `decode` attribute in this case under Python 3.6.8 under
Ubuntu, so this patch checks for the `decode` attribute before using it
here.  Hopefully nothing else is needed when `decode` isn't available.
It might take a couple more attempts to figure out what error handling,
if any, is needed for this decoding.
llvm-svn: 374665
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 64c00893fae650bdfd1ae05136de3216f70c69b4 by jdenny.ornl
[lit] Adjust error handling for decode introduced by r374665
On that decode, Windows bots fail with:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
That's the same error as before r374665 except it's now at the decode
before the write to stdout.
llvm-svn: 374666
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 6446079add805b3e0478f8709a30fd6b0434b4e1 by llvm-dev
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers.
NFCI.
llvm-svn: 374667
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 37041c7d226621b19492bb54da959f3374658727 by llvm-dev
Fix cppcheck shadow variable name warnings. NFCI.
llvm-svn: 374668
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 66417a9f036d1b653298fae9d541b71cfcfd3447 by llvm-dev
Replace for-loop of SmallVector::push_back with SmallVector::append.
NFCI.
llvm-svn: 374669
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit c8ac97edc899515fe676dea89b828cbd9630e6c1 by lebedev.ri
[NFC][LoopIdiom] Adjust FIXME to be self-explanatory
llvm-svn: 374670
The file was modifiedllvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
Commit 1e98a6c57a0f71b5a5b06c7d6de5f35d89fd102d by jdenny.ornl
[lit] Try errors="ignore" for decode introduced by r374665
Still trying to fix the same error as in r374666.
llvm-svn: 374671
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 936c6b57be163b621056a0e11c3bcc540d0dcb8a by llvm-dev
SymbolRecord - fix uninitialized variable warnings. NFCI.
llvm-svn: 374672
The file was modifiedllvm/include/llvm/DebugInfo/CodeView/SymbolRecord.h
Commit 5f2543f8dc09268a7844e4731076f8073376517b by llvm-dev
SymbolRecord - consistently use explicit for single operand constructors
llvm-svn: 374673
The file was modifiedllvm/include/llvm/DebugInfo/CodeView/SymbolRecord.h
Commit 6716512670396634e73861eb291b59ab2ea1e588 by llvm-dev
[X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
llvm-svn: 374674
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.h
Commit 459a93659a9b3a34027e9e0dac7be5d80914c122 by jdenny.ornl
Revert r374671: "[lit] Try errors="ignore" for decode introduced by
r374665"
This series of patches still breaks a Windows bot.
llvm-svn: 374675
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit b005d9e86ffcc2cf3a3403106b6342e5ede27429 by jdenny.ornl
Revert r374666: "[lit] Adjust error handling for decode introduced by
r374665"
This series of patches still breaks a Windows bot.
llvm-svn: 374676
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit e9d3b8192ed63127a60b9dc7657f5157536d4fbd by jdenny.ornl
Revert r374665: "[lit] Try yet again to fix new tests that fail on
Windows bots"
This series of patches still breaks a Windows bot.
llvm-svn: 374677
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit 9abfa5817116d04439773586b8dcd41a8540baba by jdenny.ornl
Revert r374653: "[lit] Fix a few oversights in r374651 that broke some
bots"
This series of patches still breaks a Windows bot.
llvm-svn: 374678
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/test/MC/ARM/preserve-comments-arm.s
Commit 57046e8fd9b9dd91358b92862d0591c6ac717750 by jdenny.ornl
Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use
it"
This series of patches still breaks a Windows bot.
llvm-svn: 374679
The file was modifiedllvm/test/tools/llvm-cxxmap/remap.test
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/test/tools/llvm-profdata/sample-remap.test
The file was modifiedllvm/test/MC/AsmParser/preserve-comments.s
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.unix
The file was modifiedllvm/test/tools/llvm-profdata/profile-symbol-list.test
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.dos
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/test/tools/llvm-profdata/roundtrip.test
Commit b3f157a90087858fb45de4ecdafcae9d4246fb62 by jdenny.ornl
Revert 374651: "Reland r374392: [lit] Extend internal diff to support
-U"
This series of patches still breaks a Windows bot.
llvm-svn: 374680
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
Commit f6210fc24f2160fa36e8980e74418ff7535e4b9f by jdenny.ornl
Revert r374650: "Reland r374390: [lit] Extend internal diff to support
`-` argument"
This series of patches still breaks a Windows bot.
llvm-svn: 374681
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit 199f5cd8636dbc6571c5eb4a147a210f372a8e37 by jdenny.ornl
Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding
handling"
This series of patches still breaks a Windows bot.
llvm-svn: 374682
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
Commit 3049748e15b76465ad21e1d68c48fc1dcf7def09 by jdenny.ornl
Revert r374648: "Reland r374388: [lit] Make internal diff work in
pipelines"
This series of patches still breaks a Windows bot.
llvm-svn: 374683
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was removedllvm/utils/lit/lit/builtin_commands/diff.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
Commit e198823b87b20c8dacb1bc950e9c44f1ce46f702 by Casey
[libc++][test] Silence MSVC warning in std::optional test
`make_optional<string>(4, 'X')` passes `4` (an `int`) as the first
argument to `string`'s `(size_t, charT)` constructor, triggering a
signed/unsigned mismatch warning when compiling with MSVC at `/W4`. The
incredibly simple fix is to instead use an unsigned literal (`4u`).
llvm-svn: 374684
The file was modifiedlibcxx/test/std/utilities/optional/optional.specalg/make_optional_explicit.pass.cpp