FailedChanges

Summary

  1. [clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir (details)
  2. Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes (details)
  3. Revert "llvm-reduce: Add pass to reduce parameters" (details)
  4. Emit -Wmicrosoft-enum-value warning instead of error in MS ABI (details)
  5. Skip a test in TestProcessIO.py when running against ios devices. (details)
  6. Ah, only skip this for embedded darwin targets. (details)
  7. clang-misexpect: Profile Guided Validation of Performance Annotations in (details)
  8. [llvm-nm] Fix -DBUILD_SHARED_LIBS=ON builds after D66160/r371576 (details)
  9. [CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver (details)
Commit 9607f5d8020228eb90065eb6d0fb81bb0b98698e by Jan Korous
[clang-scan-deps][NFC] Fix tests - prevent FileCheck matching test dir
path
Differential Revision: https://reviews.llvm.org/D67379
llvm-svn: 371578
The file was modifiedclang/test/ClangScanDeps/vfsoverlay.cpp
The file was modifiedclang/test/ClangScanDeps/symlink.cpp
The file was modifiedclang/test/ClangScanDeps/header_stat_before_open.m
The file was modifiedclang/test/ClangScanDeps/regular_cdb.cpp
The file was modifiedclang/test/ClangScanDeps/subframework_header_dir_symlink.m
The file was modifiedclang/test/ClangScanDeps/Inputs/symlink_cdb.json
The file was modifiedclang/test/ClangScanDeps/no-werror.cpp
The file was modifiedclang/test/ClangScanDeps/Inputs/subframework_header_dir_symlink_cdb.json
The file was modifiedclang/test/ClangScanDeps/Inputs/no-werror.json
The file was modifiedclang/test/ClangScanDeps/error.cpp
The file was modifiedclang/test/ClangScanDeps/Inputs/header_stat_before_open_cdb.json
The file was modifiedclang/test/ClangScanDeps/Inputs/vfsoverlay_cdb.json
The file was modifiedclang/test/ClangScanDeps/Inputs/regular_cdb.json
Commit c856eb0b76b46efba6602f6fc8229ad2bf37ec1d by phosek
Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes
builds."
This reverts commit r371566: this doesn't correctly handle the case
where LLVM_ENABLE_RUNTIMES contains a list of values.
llvm-svn: 371579
The file was modifiedllvm/runtimes/CMakeLists.txt
Commit 068b3628149884ba3cbf98a843ac7b7297423d21 by dblaikie
Revert "llvm-reduce: Add pass to reduce parameters"
Looks to be failing on asan buildbots
This reverts commit r371567.
llvm-svn: 371580
The file was removedllvm/test/Reduce/remove-args.ll
The file was modifiedllvm/tools/llvm-reduce/DeltaManager.h
The file was removedllvm/test/Reduce/Inputs/remove-args.py
The file was removedllvm/tools/llvm-reduce/deltas/ReduceArguments.cpp
The file was modifiedllvm/tools/llvm-reduce/CMakeLists.txt
The file was removedllvm/tools/llvm-reduce/deltas/ReduceArguments.h
Commit 7b4237d3ccb6bb84d2d6d411b6bd654f1c932b52 by rnk
Emit -Wmicrosoft-enum-value warning instead of error in MS ABI
Summary: The first NFC change is to replace a getCXXABI().isMicrosoft()
check with getTriple().isWindowsMSVCEnvironment(). This code takes
effect in non-C++ compilations, so it doesn't make sense to check the
C++ ABI. In the MS ABI, enums are always considered to be "complete"
because the underlying type of an unfixed enum will always be 'int'.
This behavior was moved from -fms-compatibility to MS ABI back in
r249656.
The second change is functional, and it downgrades an error to a warning
when the MS ABI is used rather than only under -fms-compatibility. The
reasoning is that it's unreasonable for the following code to reject the
following code for all MS ABI targets with -fno-ms-compatibility:
enum Foo { Foo_Val = 0xDEADBEEF }; This is valid code for any other
target, but in the MS ABI, Foo_Val just happens to be negative. With
this change, clang emits a
-Wmicrosoft-enum-value warning on this code, but compiles it without
error.
Fixes PR38478
Reviewers: hans, rsmith, STL_MSFT
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67304
llvm-svn: 371581
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was modifiedclang/test/Sema/MicrosoftCompatibility.c
Commit f0321c094d952ca10a18752d7ce5ae8946f53cb2 by Jason Molenda
Skip a test in TestProcessIO.py when running against ios devices.
llvm-svn: 371582
The file was modifiedlldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py
Commit 9b27586e83476dca7d1f9a2179c23fc72ff6911f by Jason Molenda
Ah, only skip this for embedded darwin targets.
llvm-svn: 371583
The file was modifiedlldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py
Commit 394a8ed8f1adb405b55eb5189620da4f62127ac7 by phosek
clang-misexpect: Profile Guided Validation of Performance Annotations in
LLVM
This patch contains the basic functionality for reporting potentially
incorrect usage of __builtin_expect() by comparing the developer's
annotation against a collected PGO profile. A more detailed proposal and
discussion appears on the CFE-dev mailing list
(http://lists.llvm.org/pipermail/cfe-dev/2019-July/062971.html) and a
prototype of the initial frontend changes appear here in D65300
We revised the work in D65300 by moving the misexpect check into the
LLVM backend, and adding support for IR and sampling based profiles, in
addition to frontend instrumentation.
We add new misexpect metadata tags to those instructions directly
influenced by the llvm.expect intrinsic (branch, switch, and select)
when lowering the intrinsics. The misexpect metadata contains
information about the expected target of the intrinsic so that we can
check against the correct PGO counter when emitting diagnostics, and the
compiler's values for the LikelyBranchWeight and UnlikelyBranchWeight.
We use these branch weight values to determine when to emit the
diagnostic to the user.
A future patch should address the comment at the top of
LowerExpectIntrisic.cpp to hoist the LikelyBranchWeight and
UnlikelyBranchWeight values into a shared space that can be accessed
outside of the LowerExpectIntrinsic pass. Once that is done, the
misexpect metadata can be updated to be smaller.
In the long term, it is possible to reconstruct portions of the
misexpect metadata from the existing profile data. However, we have
avoided this to keep the code simple, and because some kind of metadata
tag will be required to identify which branch/switch/select instructions
are influenced by the use of llvm.expect
Patch By: paulkirth Differential Revision:
https://reviews.llvm.org/D66324
llvm-svn: 371584
The file was addedllvm/test/Transforms/PGOProfile/Inputs/misexpect-switch-correct.proftext
The file was modifiedllvm/include/llvm/IR/MDBuilder.h
The file was modifiedclang/lib/CodeGen/CodeGenAction.cpp
The file was addedclang/test/Profile/Inputs/misexpect-switch-default.proftext
The file was modifiedllvm/include/llvm/IR/DiagnosticInfo.h
The file was addedllvm/test/Transforms/PGOProfile/misexpect-branch-stripped.ll
The file was addedclang/test/Profile/Inputs/misexpect-switch-nonconst.proftext
The file was addedclang/test/Profile/misexpect-switch-default.c
The file was addedllvm/test/Transforms/PGOProfile/Inputs/misexpect-branch.proftext
The file was addedllvm/test/Transforms/PGOProfile/misexpect-switch.ll
The file was addedclang/test/Profile/misexpect-branch.c
The file was modifiedllvm/include/llvm/IR/FixedMetadataKinds.def
The file was modifiedllvm/lib/Transforms/IPO/SampleProfile.cpp
The file was addedclang/test/Profile/misexpect-switch.c
The file was addedllvm/test/Transforms/PGOProfile/misexpect-branch-correct.ll
The file was addedclang/test/Profile/misexpect-branch-cold.c
The file was addedclang/test/Profile/Inputs/misexpect-branch-nonconst-expect-arg.proftext
The file was addedclang/test/Profile/misexpect-branch-nonconst-expected-val.c
The file was addedllvm/test/Transforms/PGOProfile/Inputs/misexpect-branch-correct.proftext
The file was addedcompiler-rt/lib/profile/xxhash.c
The file was addedllvm/test/Transforms/PGOProfile/misexpect-branch-unpredictable.ll
The file was addedllvm/include/llvm/Transforms/Utils/MisExpect.h
The file was modifiedclang/include/clang/Basic/DiagnosticGroups.td
The file was addedclang/test/Profile/Inputs/misexpect-switch.proftext
The file was modifiedllvm/lib/IR/DiagnosticInfo.cpp
The file was modifiedllvm/test/ThinLTO/X86/lazyload_metadata.ll
The file was addedclang/test/Profile/Inputs/misexpect-switch-default-only.proftext
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedllvm/test/Transforms/LowerExpectIntrinsic/basic.ll
The file was modifiedclang/include/clang/Basic/DiagnosticFrontendKinds.td
The file was modifiedllvm/lib/IR/MDBuilder.cpp
The file was modifiedllvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
The file was modifiedllvm/lib/Transforms/Utils/CMakeLists.txt
The file was addedllvm/test/Transforms/PGOProfile/misexpect-branch.ll
The file was addedclang/test/Profile/Inputs/misexpect-branch.proftext
The file was addedclang/test/Profile/misexpect-switch-nonconst.c
The file was modifiedllvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp
The file was addedclang/test/Profile/misexpect-switch-only-default-case.c
The file was addedllvm/lib/Transforms/Utils/MisExpect.cpp
The file was addedllvm/test/Transforms/PGOProfile/misexpect-switch-default.ll
The file was addedcompiler-rt/lib/profile/xxhash.h
The file was addedclang/test/Profile/misexpect-branch-unpredictable.c
The file was addedllvm/test/Transforms/PGOProfile/Inputs/misexpect-switch.proftext
Commit 56a34f4541cb6ca70f41f6229911894db18ff113 by maskray
[llvm-nm] Fix -DBUILD_SHARED_LIBS=ON builds after D66160/r371576
llvm-svn: 371585
The file was modifiedllvm/tools/llvm-nm/CMakeLists.txt
Commit 9ca1b94a6d3f491f26ccbeacf910342e6861fc7f by maskray
[CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver
linkage type
Multi-versioned functions defined by cpu_dispatch and implemented with
IFunc can not be called outside the translation units where they are
defined due to lack of symbols. This patch add function aliases for
these functions and thus make them visible outside.
Differential Revision: https://reviews.llvm.org/D67058 Patch by Senran
Zhang
llvm-svn: 371586
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-inalloca.cpp
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-member-funcs.cpp
The file was modifiedclang/test/CodeGen/attr-target-mv.c
The file was modifiedclang/test/CodeGen/attr-cpuspecific.c
The file was modifiedclang/test/CodeGen/attr-target-mv-func-ptrs.c
The file was modifiedclang/test/CodeGen/attr-target-mv-va-args.c
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-modules.cpp
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-overloads.cpp
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-diff-ns.cpp
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
The file was modifiedclang/test/CodeGenCXX/attr-cpuspecific.cpp
The file was modifiedclang/test/CodeGenCXX/attr-target-mv-out-of-line-defs.cpp