FailedChanges

Summary

  1. [StackSafety] Skip non-pointer parameters (details)
  2. [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming (details)
  3. Revert "[WebAssembly] Eliminate range checks on br_tables" (details)
  4. [gn build] Port 755a8959152 (details)
  5. [AMDGPU/MemOpsCluster] Code clean-up around accessing of memory operand width (details)
  6. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (details)
  7. [StackSafety,NFC] Rename internal class (details)
  8. [StackSafety,NFC] Convert to template internal stuff (details)
  9. Revert "[Support] Add file lock/unlock functions" (details)
  10. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix) (details)
  11. Syntax tree: ignore implicit expressions at the top level of statements (details)
  12. Split syntax tree tests into more granular ones (details)
  13. [CSInfo][MIPS][DwarfDebug] Add support for delay slots (details)
  14. [NFC,StackSafety] Fix template arg name (details)
  15. [llvm] Fix unused variable warnings (details)
  16. [mlir][Linalg] NFC - Make markers use Identifier instead of StringRef (details)
  17. TargetFrameLowering.h - remove unnecessary includes. NFC. (details)
  18. Fix MSVC "not all control paths return a value" warning. NFC. (details)
  19. [clang-tidy] add new check readability-use-anyofallof (details)
  20. [LangRef] Fix description of shape args for matrix.multiply. (details)
  21. [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (details)
  22. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix tests) (details)
  23. [lldb] Pass fewer parameters by non-const reference to DWARFASTParserClang::ParseSingleMember (details)
  24. attempt to fix build after add51e152aa (details)
  25. [gn build] Port add51e152aa (details)
  26. [VPlan] Support extracting lanes for defs managed in VPTransformState. (details)
  27. [LLDB] skip TestCreateDuringInstructionStep on arm/linux (details)
  28. [Scalar] Fix assignment operator for long long. (details)
  29. [lldb/cmake] Tweak descriptions of swig rules (details)
  30. Revert "[Dexter] Add DexLimitSteps command and ConditionalController" (details)
  31. [clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions. (details)
  32. [DAG] GetDemandedBits - don't bother asserting for a non-null cast<> result. NFC. (details)
  33. Fix gcc "enumeral and non-enumeral type in conditional expression" warning. NFCI. (details)
  34. [VE] Support a basic disassembler for Aurora VE target (details)
Commit d3b7f90d00fc23f5e5576e28fe4290b5f1dd0a9d by Vitaly Buka
[StackSafety] Skip non-pointer parameters

Summary: Depends on D80908.

Reviewers: eugenis, pcc

Reviewed By: eugenis

Subscribers: hiraditya, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80956
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/memintrin.ll
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/ipa.ll
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
The file was modifiedllvm/test/Analysis/StackSafetyAnalysis/local.ll
Commit 65fa0a9f7f3e6090e335c14f9edea19358d87613 by n.james93
[clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

Updates the docs to include `MacroDefinition` documentation. The docs are still missing `ObjCIVar` however I don't have a clue about how that looks in code. If someone wants to show the code block needed for the example I'll add that in too.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D80877
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
Commit 755a89591528b692315ad0325347e2fd4637271b by tlively
Revert "[WebAssembly] Eliminate range checks on br_tables"

This reverts commit f99d5f8c32a822580a732d15a34e8197da55d22b.
The change was causing UBSan and other failures on some bots.
The file was removedllvm/test/CodeGen/WebAssembly/switch-unreachable-default.ll
The file was modifiedllvm/lib/Target/WebAssembly/CMakeLists.txt
The file was removedllvm/lib/Target/WebAssembly/WebAssemblyFixBrTableDefaults.cpp
The file was modifiedllvm/test/CodeGen/WebAssembly/cfg-stackify.ll
The file was modifiedllvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
The file was modifiedllvm/test/CodeGen/WebAssembly/stack-insts.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssembly.h
The file was modifiedllvm/test/CodeGen/WebAssembly/indirectbr.ll
The file was modifiedllvm/test/CodeGen/WebAssembly/switch.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
Commit f2f3a80fd853fba0c7bd763a92c0d445052693a8 by llvmgnsyncbot
[gn build] Port 755a8959152
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/WebAssembly/BUILD.gn
Commit 29c17ed96ed53399279c3358cffde51224178e72 by mahesha.comp
[AMDGPU/MemOpsCluster] Code clean-up around accessing of memory operand width

Summary:
Clean-up the width computing logic given a memory operand, and re-arrange code to avoid
code duplication.

Reviewers: foad, rampitec, arsenm, vpykhtin, javedabsar

Reviewed By: foad

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80946
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit c823cfde21b20c60f8cf02e28af234e01964469a by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics

Differential Revision: https://reviews.llvm.org/D80702
The file was modifiedllvm/lib/Analysis/ConstantFolding.cpp
The file was addedllvm/test/Analysis/ConstantFolding/AMDGPU/cos.ll
The file was addedllvm/test/Analysis/ConstantFolding/AMDGPU/sin.ll
Commit a019579fe56819688a36ba718afc8c7c4f3b04b1 by Vitaly Buka
[StackSafety,NFC] Rename internal class
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 6e51a080f744013eaaff6be2f4864afd0882acfa by Vitaly Buka
[StackSafety,NFC] Convert to template internal stuff

It's going to be usefull for ThinLTO.
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 8577595e03faf740ee0cfae1bbb2d0ff6f4e4516 by sepavloff
Revert "[Support] Add file lock/unlock functions"

This reverts commit f51bc4fb60fbcef26d18eff549fc68307fd46489.
It broke the Solaris buildbots (Builder clang-solaris11-sparcv9 Build #5494
<http://lab.llvm.org:8014/builders/clang-solaris11-sparcv9/builds/54).
The file was modifiedllvm/include/llvm/Support/FileSystem.h
The file was modifiedllvm/unittests/Support/Path.cpp
The file was modifiedllvm/lib/Support/Windows/Path.inc
The file was modifiedllvm/lib/Support/Unix/Path.inc
Commit 7c7941fb4bd884ee7dce96fdfdf657c0fdb608dd by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix)

Try to fix Windows buildbots.
The file was modifiedllvm/lib/Analysis/ConstantFolding.cpp
Commit b34b7691facd89022e7fee174debdbd2bf7920f3 by gribozavr
Syntax tree: ignore implicit expressions at the top level of statements

Summary:
I changed `markStmtChild` to ignore implicit expressions the same way as
`markExprChild` does it already. The test that I modified crashes
without this change.

Reviewers: hlopko, eduucaldas

Reviewed By: hlopko, eduucaldas

Subscribers: gribozavr2, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81019
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
Commit d7d5dd31fc6f05daf4758e1523c86401aa4e3f2a by gribozavr
Split syntax tree tests into more granular ones

Summary:
Doing so allows us to increase test coverage by removing unnecessary
language restrictions.

Reviewers: hlopko, eduucaldas

Reviewed By: hlopko, eduucaldas

Subscribers: gribozavr2, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81040
The file was modifiedclang/unittests/Tooling/Syntax/TreeTest.cpp
Commit dd1bc59b729a31d6c0fe3aecc8559b9349363bf9 by djordje.todorovic
[CSInfo][MIPS][DwarfDebug] Add support for delay slots

This adds call site info support for call instructions with delay slot.
Search for instructions inside call delay slot, which load value
into parameter forwarding registers.
Return address of the call points to instruction after call delay slot,
which is not the one, immediately after the call instruction.

Patch by Nikola Tesic

Differential revision: https://reviews.llvm.org/D78107
The file was addedllvm/test/DebugInfo/MIR/Mips/dbg-call-site-delay-slot-interpretation.mir
The file was addedllvm/test/DebugInfo/MIR/Mips/dbg-call-site-delay-slot-interpretation-64bit.mir
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was addedllvm/test/DebugInfo/Mips/dbg-call-site-low-pc.ll
Commit 264d435ee10c699b12562eea695793199ff757f5 by Vitaly Buka
[NFC,StackSafety] Fix template arg name
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit c5468253aa555c2df98bd1f49d1e9d44b0150a2e by kadircet
[llvm] Fix unused variable warnings
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit e349fb70a23f3a39e058605e4e2db66da5e5ea4a by ntv
[mlir][Linalg] NFC - Make markers use Identifier instead of StringRef

Summary: This removes string ownership worries by putting everything into the context and allows more constructing identifiers programmatically.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D81027
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
The file was modifiedmlir/test/Dialect/Linalg/transform-patterns.mlir
The file was modifiedmlir/test/lib/Transforms/TestLinalgTransforms.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
Commit 7a96c181d0f09aae3ebe50c1eea71aa1b11d5789 by llvm-dev
TargetFrameLowering.h - remove unnecessary includes. NFC.

Move TargetFrameLowering.h include to the top of the TargetFrameLoweringImpl.cpp includes (clang-format doesn't do this by default as the filenames don't match).
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
Commit e6ba0a55fd39b600f3f431308f4a7e36e48f91ae by llvm-dev
Fix MSVC "not all control paths return a value" warning. NFC.

Add llvm_unreachable after switch statement for CheckerRegistry::StateFromCmdLine enum
The file was modifiedclang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
Commit add51e152aa6dc3aa7a51901a099b2ebe8cfe377 by gehre.matthias
[clang-tidy] add new check readability-use-anyofallof

Summary:
Finds range-based for loops that can be replaced by a call to ``std::any_of`` or
``std::all_of``. In C++ 20 mode, suggests ``std::ranges::any_of`` or
``std::ranges::all_of``.
For now, no fixits are produced.

Reviewers: aaron.ballman, alexfh, hokein

Subscribers: mgorny, xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77572
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof-cpp20.cpp
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.h
The file was modifiedclang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
The file was addedclang-tools-extra/docs/clang-tidy/checks/readability-use-anyofallof.rst
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was modifiedclang-tools-extra/clang-tidy/readability/CMakeLists.txt
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof.cpp
Commit 90e291912ac7e3caf9251969a5c47310c6aa01ff by flo
[LangRef] Fix description of shape args for matrix.multiply.

Currently all code instances within the matrix lowering pass consider
matrix A to be MxN and B to be NxK, producing C which is MxK. Anyone
interacting with this API after reading the docs but without reading the pass
would expect A: MxK, B: KxN, and C: MxN. These changes bring the documentation
in line with the implementation.

One point of concern with this, the original signature as described in the docs
may be better or at least more expected. The interface as it was written
reflected other common matrix multiplication interfaces such as BLAS'[1], where
the matrices are MxK, KxN, MxN respectively. Choosing to honor this requires
changing code and tests instead, but should be mostly just renaming of variables.

Patch by Braedy Kuzma <braedy@ualberta.ca>

[1] http://www.netlib.org/lapack/explore-html/db/dc9/group__single__blas__level3_gafe51bacb54592ff5de056acabd83c260.html#gafe51bacb54592ff5de056acabd83c260

Reviewers: anemet, LuoYuanke, nicolasvasilache, fhahn

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D80663
The file was modifiedllvm/docs/LangRef.rst
Commit 8beaba13b8a61697008854b82ed3b45377af9d9d by lucas.prates
[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

Summary:
During CodeGen for AArch64 Neon intrinsics, Clang was incorrectly
assuming all the pointers from which loads were being generated for vld1
intrinsics were aligned according to the intrinsics result type, causing
alignment faults on the code generated by the backend.

This patch updates vld1 intrinsics' CodeGen to properly capture the
correct load alignment based on the type of the pointer provided as
input for the intrinsic.

Reviewers: t.p.northover, ostannard, pcc, efriedma

Reviewed By: ostannard, efriedma

Subscribers: echristo, plotfi, nickdesaulniers, efriedma, kristof.beyls, danielkiss, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79721
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/test/CodeGen/aarch64-neon-intrinsics.c
Commit c27214c23446e423ec2e7eb8650a65cc5f0a16aa by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix tests)

Try to fix Windows buildbots.
The file was modifiedllvm/test/Analysis/ConstantFolding/AMDGPU/sin.ll
The file was modifiedllvm/test/Analysis/ConstantFolding/AMDGPU/cos.ll
Commit c0ccb582c35f29df55ccc421dd5d03a7220456cf by Raphael Isemann
[lldb] Pass fewer parameters by non-const reference to DWARFASTParserClang::ParseSingleMember

These parameters are only passed on by value or const reference, so we should
do the same when calling this function.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
Commit fd2740143e626ca32432aac0b51b2880a3b1e0bc by thakis
attempt to fix build after add51e152aa
The file was modifiedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
Commit 99b8f3570a3f0d725a6111ceeed015d302bd4bc7 by llvmgnsyncbot
[gn build] Port add51e152aa
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn
Commit 211596c94e92d179e095734b23899d877c8fc3e5 by flo
[VPlan] Support extracting lanes for defs managed in VPTransformState.

Currently extracting a lane for a VPValue def is not supported, if it is
managed directly by VPTransformState (e.g. because it is created by a
VPInstruction or an external VPValue def).

For now, simply extract the requested lane. In the future, we should
also cache the extracted scalar values, similar to LV.

Reviewers: Ayal, rengolin, gilr, SjoerdMeijer

Reviewed By: SjoerdMeijer

Differential Revision: https://reviews.llvm.org/D80787
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
Commit 884aaf7f645a27239923e21112c9817836c696df by omair.javaid
[LLDB] skip TestCreateDuringInstructionStep on arm/linux

There are sporadic failures in this test on arm. I am marking it
skipped as labath suggested flaky decorators no longer work.
The file was modifiedlldb/test/API/linux/thread/create_during_instruction_step/TestCreateDuringInstructionStep.py
Commit 798644e0a4524e73e1f95202951f10f2086217c3 by pavel
[Scalar] Fix assignment operator for long long.

Summary:
Assignment operator `operator=(long long)` currently allocates `sizeof(long)`.
On some platforms it works as they have `sizeof(long) == sizeof(long long)`,
but on others (e.g. Windows) it's not the case.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D80995
The file was modifiedlldb/unittests/Utility/ScalarTest.cpp
The file was modifiedlldb/source/Utility/Scalar.cpp
Commit a48c76cf43806c30bab5e8eacd5a08058c83c578 by pavel
[lldb/cmake] Tweak descriptions of swig rules

This descriptions are printed while running the command, and so the
continuous tense is more appropriate and consistent.
The file was modifiedlldb/bindings/CMakeLists.txt
Commit 05eabb52045f3a20e137ff217b6fc1d5bd1155b4 by Tom.Weaver
Revert "[Dexter] Add DexLimitSteps command and ConditionalController"

This reverts commit 81e836a5a675f6a3d9d35560fddbbb87fdf66201.

Accidentally committed a diff file.
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_value.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py
The file was modifieddebuginfo-tests/dexter/Commands.md
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_check_json_step_count.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
The file was removeddebuginfo-tests/dexter/dex/command/commands/DexLimitSteps.py
The file was removeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_same_line_conditional.cpp
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_loop.cpp
The file was removeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
The file was modifieddebuginfo-tests/dexter/dex/tools/test/Tool.py
The file was modifieddebuginfo-tests/dexter/dex/command/ParseCommand.py
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_overlapping_ranges.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerBase.py
The file was removedd.diff
The file was modifieddebuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
Commit a2f32bfcc7cd6828785011ce90f6e0314d096e89 by riccibrun
[clang][Sema] SequenceChecker: C++17 sequencing rule for call expressions.

In C++17 the postfix-expression of a call expression is sequenced before
each expression in the expression-list and any default argument.

Differential Revision: https://reviews.llvm.org/D58579

Reviewed By: rsmith
The file was modifiedclang/test/SemaCXX/warn-unsequenced.cpp
The file was modifiedclang/lib/Sema/SemaChecking.cpp
Commit c438b257f19cb4a8adbb8eb377f84b10052ea7c5 by llvm-dev
[DAG] GetDemandedBits - don't bother asserting for a non-null cast<> result. NFC.

cast<> will assert on failure anyhow.

This lets us fold the cast<> with the getAPIntValue() that uses it.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Commit 8e058feae0b0d07cd86257f0aa3154acfa887fe0 by llvm-dev
Fix gcc "enumeral and non-enumeral type in conditional expression" warning. NFCI.
The file was modifiedllvm/lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp
Commit 82aac878beb48cd326b4684918b7ff2375fae439 by simon.moll
[VE] Support a basic disassembler for Aurora VE target

Summary:
Add a basic disassember and regression tests of LEA/LD/ST
instructions.  This patch also removes DecoderMethod declarations for
branch and call since those are not implemented in this patch.  They
will be added again later.  This patch also corrects DecoderMethod for
LD/ST instructions for one byte or two.

Differential Revision: https://reviews.llvm.org/D80912
The file was addedllvm/lib/Target/VE/Disassembler/CMakeLists.txt
The file was addedllvm/lib/Target/VE/Disassembler/LLVMBuild.txt
The file was modifiedllvm/test/MC/VE/LEA.s
The file was modifiedllvm/test/MC/VE/LD.s
The file was addedllvm/lib/Target/VE/Disassembler/VEDisassembler.cpp
The file was modifiedllvm/lib/Target/VE/LLVMBuild.txt
The file was modifiedllvm/lib/Target/VE/CMakeLists.txt
The file was modifiedllvm/test/MC/VE/ST.s
The file was modifiedllvm/lib/Target/VE/VEInstrInfo.td