FailedChanges

Summary

  1. [test] Fix no-wrap-symbolic-becount.ll under NPM (details)
  2. [c++20] For P0732R2 / P1907R1: Basic frontend support for class types as (details)
  3. Add more test coverage for APValue serialization / deserialization and (details)
  4. [mlir] Add missing dependency for MLIRSCFTransforms (details)
  5. [test] Fix alloca-offset-lifetime.ll under NPM (details)
  6. [test] Fix quadradic-exit-value.ll under NPM (details)
  7. Simple fix to basic-block-sections to replace emit-obj with emit-llvm (details)
  8. [spirv] Fix legalize standard to spir-v for transfer ops (details)
  9. [libc++] Fix compiler-rt build by copying libc++ headers to <build>/include (details)
  10. [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (details)
  11. [c++20] For P0732R2: Give class NTTPs the proper type when examined with 'decltype'. (details)
  12. Always allow std::function to be copied. (details)
  13. [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable. Added documentation. (details)
  14. [libc++][ci] Also install the library in the CI scripts (details)
  15. [libc++] Fix the benchmarks build (details)
  16. [c++20] For P0732R2: permit class template argument deduction for non-type template parameters. (details)
  17. [ValueTracking] Interpret GEPs as a series of adds multiplied by the related scaling factor (details)
  18. Revert several changes related to llvm-symbolizer exiting non-zero on failure. (details)
  19. [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register (details)
Commit 1d1217c4ea115ac204f666a31686787503623dfa by aeubanks
[test] Fix no-wrap-symbolic-becount.ll under NPM
The file was modifiedllvm/test/Analysis/ScalarEvolution/no-wrap-symbolic-becount.ll
Commit ba4768c966581658465f7366df9b0811f468a2d7 by richard
[c++20] For P0732R2 / P1907R1: Basic frontend support for class types as
non-type template parameters.

Create a unique TemplateParamObjectDecl instance for each such value,
representing the globally unique template parameter object to which the
template parameter refers.

No IR generation support yet; that will follow in a separate patch.
The file was modifiedclang/lib/Serialization/ASTReaderDecl.cpp
The file was modifiedclang/lib/Serialization/ASTWriterDecl.cpp
The file was modifiedclang/test/CXX/drs/dr3xx.cpp
The file was modifiedclang/include/clang/AST/ASTContext.h
The file was addedclang/test/CXX/temp/temp.param/p8-cxx20.cpp
The file was modifiedclang/lib/AST/ASTContext.cpp
The file was modifiedclang/lib/AST/ASTDiagnostic.cpp
The file was modifiedclang/include/clang/Sema/Initialization.h
The file was modifiedclang/lib/CodeGen/CGDecl.cpp
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/lib/Sema/SemaTemplateInstantiateDecl.cpp
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/lib/AST/MicrosoftMangle.cpp
The file was modifiedclang/lib/AST/DeclTemplate.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/include/clang/Sema/Sema.h
The file was modifiedclang/lib/CodeGen/CGExpr.cpp
The file was modifiedclang/tools/libclang/CIndex.cpp
The file was modifiedclang/include/clang/AST/RecursiveASTVisitor.h
The file was modifiedclang/lib/CodeGen/CGExprConstant.cpp
The file was modifiedclang/lib/Serialization/ASTCommon.cpp
The file was modifiedclang/lib/AST/ExprClassification.cpp
The file was modifiedclang/lib/AST/ItaniumMangle.cpp
The file was modifiedclang/lib/AST/StmtPrinter.cpp
The file was modifiedclang/lib/AST/TemplateBase.cpp
The file was modifiedclang/lib/Sema/SemaTemplate.cpp
The file was modifiedclang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
The file was modifiedclang/include/clang/Serialization/ASTBitCodes.h
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp
The file was modifiedclang/lib/CodeGen/CodeGenModule.h
The file was modifiedclang/lib/AST/ExprConstant.cpp
The file was modifiedclang/include/clang/Basic/DeclNodes.td
The file was addedclang/test/PCH/cxx20-template-args.cpp
The file was modifiedclang/lib/AST/DeclBase.cpp
The file was modifiedclang/test/SemaCXX/cxx17-compat.cpp
The file was modifiedclang/include/clang/AST/DeclTemplate.h
The file was modifiedclang/lib/Sema/SemaInit.cpp
The file was modifiedclang/lib/Sema/SemaTemplateDeduction.cpp
Commit 0c417d4bef1e78b0716c546101462f6d8962f358 by richard
Add more test coverage for APValue serialization / deserialization and
fix a few exposed bugs.
The file was modifiedclang/lib/AST/ExprConstant.cpp
The file was modifiedclang/include/clang/AST/DeclTemplate.h
The file was modifiedclang/lib/Sema/SemaTemplate.cpp
The file was modifiedclang/lib/Serialization/ASTReader.cpp
The file was modifiedclang/lib/Serialization/ASTWriter.cpp
The file was modifiedclang/lib/AST/APValue.cpp
The file was modifiedclang/include/clang/AST/APValue.h
The file was modifiedclang/test/PCH/cxx20-template-args.cpp
Commit cb5ab3e90e9b7f2e2f00d558e2f5cc095f0c7926 by antiagainst
[mlir] Add missing dependency for MLIRSCFTransforms

MLIRTransforms is needed to provide BufferizeTypeConverter
definitions.
The file was modifiedmlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
Commit e045d844e635b985adc52514ac15cfb753c2bda5 by aeubanks
[test] Fix alloca-offset-lifetime.ll under NPM
The file was modifiedllvm/test/Instrumentation/AddressSanitizer/alloca-offset-lifetime.ll
Commit 7d6c3e509a430997b20e96422356695ecdec447e by aeubanks
[test] Fix quadradic-exit-value.ll under NPM
The file was modifiedllvm/test/Analysis/IVUsers/quadradic-exit-value.ll
Commit eef2e67d2326e7d4027fddb29eefdb69371dc24a by tmsriram
Simple fix to basic-block-sections to replace emit-obj with emit-llvm

emit-obj is unnecessary here and further wasn't redirected to /dev/null.
The file was modifiedclang/test/CodeGen/basic-block-sections.c
Commit ac2cf07195b5833a888dc6878a9a3cb377ef59ac by thomasraoux
[spirv] Fix legalize standard to spir-v for transfer ops

Forward missing attributes when creating the new transfer op otherwise the
builder would use default values.

Differential Revision: https://reviews.llvm.org/D89907
The file was modifiedmlir/lib/Conversion/StandardToSPIRV/LegalizeStandardForSPIRV.cpp
The file was modifiedmlir/test/Conversion/StandardToSPIRV/legalization.mlir
Commit 69c2087283cf7b17ca75f69daebf4ffc158b754a by Louis Dionne
[libc++] Fix compiler-rt build by copying libc++ headers to <build>/include

This commit should really be named "Workaround external projects depending
on libc++ build system implementation details". It seems that the compiler-rt
build (and perhaps other projects) is relying on the fact that we copy libc++
and libc++abi headers to `<build-root>/include/c++/v1`. This was changed
by 5d796645, which moved the headers to `<build-root>/projects/libcxx/include/c++/v1`
and broke the compiler-rt build.

I'm committing this workaround to fix the compiler-rt build, but we should
remove reliance on implementation details like that. The correct way to
setup the compiler-rt build would be to "link" against the `cxx-headers`
target in CMake, or to run `install-cxx-headers` using an appropriate
installation prefix, and then manually add a `-I` path to that location.
The file was modifiedlibcxx/cmake/Modules/HandleLibCXXABI.cmake
The file was modifiedlibcxx/CMakeLists.txt
The file was modifiedlibcxx/include/CMakeLists.txt
The file was modifiedlibcxxabi/test/libcxxabi/test/config.py
Commit cd4a4ae97a7ccfa381e06936cd0981cb7d978ec1 by jhuber6
[OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

The changes made in D88594 caused the test OpenMP/driver.c to fail on a 32-bit host becuase it was offloading to a 64-bit architecture by default. The offloading test was moved to a new file and a feature was added to the lit config to check for a 64-bit host.

Reviewed By: daltenty

Differential Revision: https://reviews.llvm.org/D89904
The file was modifiedclang/test/lit.cfg.py
The file was modifiedclang/test/OpenMP/driver-openmp-target.c
Commit caf30e7f03566f20c45e5d0895e71c4bff9056ef by richard
[c++20] For P0732R2: Give class NTTPs the proper type when examined with 'decltype'.

This requires that we track enough information to determine the original
type of the parameter in a substituted non-type template parameter, to
distinguish the reference-to-class case from the class case.
The file was modifiedclang/lib/Serialization/ASTReaderStmt.cpp
The file was modifiedclang/lib/AST/ExprCXX.cpp
The file was modifiedclang/lib/Sema/SemaTemplateInstantiate.cpp
The file was modifiedclang/lib/Serialization/ASTWriterStmt.cpp
The file was modifiedclang/lib/Sema/SemaType.cpp
The file was addedclang/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.decltype/p1.cpp
The file was modifiedclang/include/clang/AST/ExprCXX.h
The file was modifiedclang/lib/AST/ASTImporter.cpp
Commit 1c1f794c2b645ba33a98f0359bc9d30bbef89920 by flx
Always allow std::function to be copied.

Since its call operator is const but can modify the state of its underlying
functor we cannot tell whether the copy is necessary or not.

This avoids false positives.

Reviewed-by: aaron.ballman, gribozavr2

Differential Revision: https://reviews.llvm.org/D89332
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp
The file was modifiedclang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
Commit 281e0f3636a3169df88965632579701b101be51f by rdzhabarov
[mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable. Added documentation.

This https://reviews.llvm.org/D89254 diff introduced implicit matching between same name operands.

Differential Revision: https://reviews.llvm.org/D89598
The file was modifiedmlir/include/mlir/IR/OpBase.td
The file was modifiedmlir/lib/Dialect/Shape/IR/ShapeCanonicalization.td
The file was modifiedmlir/docs/DeclarativeRewrites.md
Commit 1913bb622cbc735b31ae5d529442c79b5e6fef75 by Louis Dionne
[libc++][ci] Also install the library in the CI scripts

It's good to run the installation step to make sure it works properly,
as build system changes can break that.
The file was modifiedlibcxx/utils/ci/run-buildbot.sh
Commit 28270234f1478047e35879f4ba8838b47edfcc14 by Louis Dionne
[libc++] Fix the benchmarks build
The file was modifiedlibcxx/benchmarks/CMakeLists.txt
Commit e97e9851b227e98e39c27c4c8f5558e331cde8b4 by richard
[c++20] For P0732R2: permit class template argument deduction for non-type template parameters.
The file was modifiedclang/lib/Sema/SemaTemplateDeduction.cpp
The file was modifiedclang/test/SemaTemplate/deduction.cpp
The file was modifiedclang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp
The file was addedclang/test/CXX/temp/temp.arg/temp.arg.nontype/p1-cxx20.cpp
The file was addedclang/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p2.cpp
The file was modifiedclang/lib/Sema/SemaType.cpp
The file was modifiedclang/lib/Sema/SemaTemplate.cpp
Commit ee6abef5323d59b983129bf3514ef6775d1d6cd5 by qcolombet
[ValueTracking] Interpret GEPs as a series of adds multiplied by the related scaling factor

Prior to this patch, computeKnownBits would only try to deduce trailing zeros
bits for getelementptrs. This patch adds the logic to treat geps as a series
of add * scaling factor.

Thanks to this patch, using a gep or performing an address computation
directly "by hand" (ptrtoint followed by adds and mul followed by inttoptr)
offers the same computeKnownBits information.

Previously, the "by hand" approach would have given more information.

This is related to https://llvm.org/PR47241.

Differential Revision: https://reviews.llvm.org/D86364
The file was modifiedllvm/lib/Analysis/ValueTracking.cpp
The file was modifiedllvm/test/Transforms/InstCombine/constant-fold-address-space-pointer.ll
The file was modifiedllvm/test/Transforms/InstCombine/constant-fold-gep.ll
The file was modifiedllvm/unittests/Analysis/ValueTrackingTest.cpp
Commit a67d164a82bc535025bb65736ee4e5f381500ed8 by dblaikie
Revert several changes related to llvm-symbolizer exiting non-zero on failure.

Seems users have enough different uses of the symbolizer where they
might have unknown binaries and offsets such that "best effort" behavior
is all that's expected of llvm-symbolizer - so even erroring on unknown
executables and out of bounds offsets might not be suitable.

This reverts commit 1de0199748ef2a20cd146c100ea1b8e6726c4767.
This reverts commit a7b209a6d40d77b43a38664b1fe64513587f24c6.
This reverts commit 338dd138ea4a70b52ab48e0c8aa38ec152b3569a.
The file was modifiedllvm/test/DebugInfo/symbolize-missing-file.test
The file was modifiedllvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
The file was modifiedllvm/lib/DebugInfo/Symbolize/Symbolize.cpp
The file was modifiedllvm/test/tools/llvm-symbolizer/sym.test
The file was modifiedllvm/test/DebugInfo/symbolize-macho-universal-unknown-arch.test
The file was modifiedllvm/test/tools/llvm-symbolizer/input-base.test
The file was removedllvm/test/tools/llvm-symbolizer/invalid-dwarf.s
The file was modifiedllvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
Commit 4634ad6c0bf8d6837cbbeea034cca387054207ea by gjn
[NFC] Set return type of getStackPointerRegisterToSaveRestore to Register

Differential Revision: https://reviews.llvm.org/D89858
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedllvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
The file was modifiedllvm/lib/Target/Lanai/LanaiISelLowering.cpp
The file was modifiedllvm/lib/Target/SystemZ/SystemZISelLowering.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/lib/CodeGen/ShrinkWrap.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp