FailedChanges

Summary

  1. one (details)
  2. [NFC][Sanitizer] Try to increase file limits on bot (details)
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_android.sh (diff)
Commit 605f441f4892c7c930b0e2a7c5aee7ab3462d072 by Vitaly Buka
[NFC][Sanitizer] Try to increase file limits on bot
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_functions.sh (diff)

Summary

  1. Fix includes in llvm/Support/FileSystem/UniqueID.h after 23ed570af1cc165afea1b70a533a4a39d6656501 (details)
  2. gn build: Define HWASAN_WITH_INTERCEPTORS=1 for hwasan_new_delete.cpp as well. (details)
  3. Reland "hwasan: Disable operator {new,delete} interceptors when interceptors are disabled." (details)
  4. [NFC] Use [MC]Register in CSE & LICM (details)
  5. ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC (details)
  6. [Sema] adds basic -Wfree-nonheap-object functionality (details)
  7. Make the post-commit review expectations more explicit with respect to revert (details)
  8. [AMDGPU] Add Reset function to GCNHazardRecognizer (details)
  9. Recommit "[CodeView] Emit static data members as S_CONSTANTs." (details)
  10. [VE] Add vector mask operation instructions (details)
  11. Revert "[AppleObjCRuntimeV2] Force lazily allocated class names to be resolved." (details)
  12. [llvm][StringExtras] Add a fail-able version of `fromHex` (details)
  13. [llvm][StringExtras] Use a lookup table for `hexDigitValue` (details)
  14. [mlir] Optimize the parsing of ElementsAttr hex strings (details)
  15. [mlir] Convert raw data in dense element attributes for big-endian machines. (details)
  16. [WebAssembly] Add support for DWARF type units (details)
  17. [ThinLTO] Fix .llvmcmd emission (details)
  18. Revert "[DebugInfo] Shorten legacy [s|z]ext dwarf expressions" (details)
  19. Revert "[DebugInfo] Fix legacy ZExt emission when FromBits >= 64 (PR47927)" (details)
  20. [Debugify] Move global namespace functions into llvm:: (details)
  21. [NFC][AVR] Improve device list (details)
  22. [NFC][clang][AVR] Add more devices (details)
  23. [mlir][Inliner] Add a new hook for checking if it is legal to inline a callable into a call (details)
  24. [mlir][Inliner] Add a `wouldBeCloned` flag to each of the `isLegalToInline` hooks. (details)
  25. [mlir][SymbolTable] Small optimization to walking symbol references (details)
Commit 44d65efd95b353eeb26440ad2ef9f3bd05f5a927 by Duncan P. N. Exon Smith
Fix includes in llvm/Support/FileSystem/UniqueID.h after 23ed570af1cc165afea1b70a533a4a39d6656501

Not sure why this worked for me, but some of the bots pointed out I
copied the wrong includes from FileSystem.h in
23ed570af1cc165afea1b70a533a4a39d6656501. Fixed.
The file was modifiedllvm/include/llvm/Support/FileSystem/UniqueID.h
Commit 19cfe5a6debb59e976dd0ee7020d1b8873ad54dd by peter
gn build: Define HWASAN_WITH_INTERCEPTORS=1 for hwasan_new_delete.cpp as well.
The file was modifiedllvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn
Commit 864b3a336b609f8261e727e332235ccedd2e825e by peter
Reland "hwasan: Disable operator {new,delete} interceptors when interceptors are disabled."

There was a discrepancy in the gn build which is now fixed.

Differential Revision: https://reviews.llvm.org/D89827
The file was modifiedcompiler-rt/lib/hwasan/hwasan.h
Commit f719fd7adee10c037554117f4492917ee3f5282f by gjn
[NFC] Use [MC]Register in CSE & LICM

Differential Revision: https://reviews.llvm.org/D90327
The file was modifiedllvm/lib/CodeGen/MachineRegisterInfo.cpp
The file was modifiedllvm/lib/CodeGen/MachineLICM.cpp
The file was modifiedllvm/lib/CodeGen/MachineCSE.cpp
Commit 946406aebce298725b07097934cb39b1e5bee656 by Duncan P. N. Exon Smith
ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

Differential Revision: https://reviews.llvm.org/D89835
The file was modifiedclang/lib/Serialization/ModuleManager.cpp
Commit 425a83a5f069eb1a692145d2c92e6d3bfe564a62 by George Burgess IV
[Sema] adds basic -Wfree-nonheap-object functionality

Checks to make sure that stdlib's (std::)free is being appropriately
used. Presently checks for the following misuses:

- free(&stack_object)
- free(stack_array)

Differential Revision: https://reviews.llvm.org/D89988
The file was addedclang/test/Sema/warn-free-nonheap-object.cpp
The file was addedclang/test/Sema/warn-free-nonheap-object.c
The file was modifiedclang/lib/AST/Decl.cpp
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/include/clang/Basic/Builtins.def
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/include/clang/Sema/Sema.h
Commit 7d3e9578cac168181d0072144ed6561ee049d789 by joker.eph
Make the post-commit review expectations more explicit with respect to revert

See  http://lists.llvm.org/pipermail/llvm-dev/2016-March/096529.html for
context.

Reviewed By: silvas, rengolin, echristo, dexonsmith, gribozavr2

Differential Revision: https://reviews.llvm.org/D89995
The file was modifiedllvm/docs/CodeReview.rst
Commit de518673436ecea229076827ee1f3131482d8f41 by Austin.Kerbow
[AMDGPU] Add Reset function to GCNHazardRecognizer

Reset the tracked emitted instructions when starting scheduling on a new
region.

Reviewed By: rampitec

Differential Revision: https://reviews.llvm.org/D90347
The file was modifiedllvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/llvm.amdgcn.mov.dpp.ll
The file was modifiedllvm/lib/Target/AMDGPU/GCNHazardRecognizer.h
The file was addedllvm/test/CodeGen/AMDGPU/post-ra-sched-reset.mir
Commit 7669f3c0f69db78cdd3deef066abc99f60fc580d by akhuang
Recommit "[CodeView] Emit static data members as S_CONSTANTs."

We used to only emit static const data members in CodeView as
S_CONSTANTS when they were used; this patch makes it so they are always emitted.

This changes CodeViewDebug.cpp to find the static const members from the
class debug info instead of creating DIGlobalVariables in the IR
whenever a static const data member is used.

Bug: https://bugs.llvm.org/show_bug.cgi?id=47580

Differential Revision: https://reviews.llvm.org/D89072

This reverts commit 504615353f31136dd6bf7a971b6c236fd70582be.
The file was modifiedllvm/include/llvm/CodeGen/DebugHandlerBase.h
The file was modifiedclang/test/CodeGenCXX/debug-info-static-member.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
The file was modifiedllvm/test/DebugInfo/COFF/types-array-unsized.ll
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modifiedllvm/test/DebugInfo/COFF/global-constants.ll
The file was modifiedllvm/lib/DebugInfo/CodeView/CodeViewRecordIO.cpp
Commit 794296019966901a1d244c1012641dc8bf8d0b8f by marukawa
[VE] Add vector mask operation instructions

Add VFMK/VFMS/VFMF/ANDM/ORM/XORM/EQVM/NNDM/NEGM/PCVM/LZVM/TOVM
isntructions.  Add regression tests too.  Also add new patterns
to parse VFMK/VFMS/VFMF mnemonics.

Reviewed By: simoll

Differential Revision: https://reviews.llvm.org/D90297
The file was addedllvm/test/MC/VE/VFMF.s
The file was addedllvm/test/MC/VE/NEGM.s
The file was addedllvm/test/MC/VE/NNDM.s
The file was addedllvm/test/MC/VE/TOVM.s
The file was addedllvm/test/MC/VE/ANDM.s
The file was modifiedllvm/lib/Target/VE/VEInstrVec.td
The file was modifiedllvm/lib/Target/VE/AsmParser/VEAsmParser.cpp
The file was addedllvm/test/MC/VE/ORM.s
The file was addedllvm/test/MC/VE/EQVM.s
The file was addedllvm/test/MC/VE/VFMS.s
The file was addedllvm/test/MC/VE/VFMK.s
The file was addedllvm/test/MC/VE/PCVM.s
The file was addedllvm/test/MC/VE/XORM.s
The file was addedllvm/test/MC/VE/LZVM.s
Commit 49c84fd5a4bd88cbf61ac6888a66c5da07705c5e by Jonas Devlieghere
Revert "[AppleObjCRuntimeV2] Force lazily allocated class names to be resolved."

We're no longer convinced that this is needed and we have no test
coverage to disprove that. Backing out of this change until we're
convinced otherwise.
The file was modifiedlldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Commit 1095419b10ff222c3cc362be27d97ff561a2181b by riddleriver
[llvm][StringExtras] Add a fail-able version of `fromHex`

This revision adds a fail-able/checked version of `fromHex` that fails when the input string contains a non-hex character. This removes the need for users to have a separate check for if the string contains all hex digits. This becomes very costly for large hex strings given that checking if a string contains only hex digits is effectively the same as just converting it in the first place.

Context: In MLIR we use hex strings to represent very large constants in the textual format of the IR. These changes lead to a large decrease in compile time when parsing these constants (2 seconds -> 1 second).

Differential Revision: https://reviews.llvm.org/D90265
The file was modifiedllvm/include/llvm/ADT/StringExtras.h
The file was modifiedllvm/unittests/ADT/StringExtrasTest.cpp
Commit f6a6f27edb3991154393976e9e8f7b88542d406c by riddleriver
[llvm][StringExtras] Use a lookup table for `hexDigitValue`

This method is at the core of the conversion from hex to binary, and using a lookup table great improves the compile time of hex conversions.

Context: In MLIR we use hex strings to represent very large constants in the textual format of the IR. These changes lead to a large decrease in compile time when parsing these constants (>1 second -> 350 miliseconds).

Differential Revision: https://reviews.llvm.org/D90320
The file was modifiedllvm/include/llvm/ADT/StringExtras.h
Commit bf0440be91a6ea18fc8c1601f7ce6bcc8e6d2300 by riddleriver
[mlir] Optimize the parsing of ElementsAttr hex strings

This revision optimizes the parsing of hex strings by using the checked variant of llvm::fromHex, and adding a specialized method to Token for extracting hex strings. This leads a large decrease in compile time when parsing large hex constants (one example: 2.6 seconds -> 370 miliseconds)

Differential Revision: https://reviews.llvm.org/D90266
The file was modifiedmlir/lib/Parser/Token.cpp
The file was modifiedmlir/lib/Parser/AttributeParser.cpp
The file was modifiedmlir/test/IR/invalid.mlir
The file was modifiedmlir/lib/Parser/Token.h
The file was modifiedmlir/test/IR/dense-elements-hex.mlir
Commit a66e334cebec0c54ec357436563ddf78e3caab72 by riddleriver
[mlir] Convert raw data in dense element attributes for big-endian machines.

This patch fixes a bug [[ https://bugs.llvm.org/show_bug.cgi?id=46091 | 46091 ]]

Raw data for the `dense-element attribute` is written in little endian (LE) format.
This commit converts the format to big endian (BE) in ʻAttribute Parser` on the
BE machine. Also, when outputting on a BE machine, the BE format is converted
to LE in "AsmPrinter".

Differential Revision: https://reviews.llvm.org/D80695
The file was modifiedmlir/lib/IR/AsmPrinter.cpp
The file was modifiedmlir/include/mlir/IR/Attributes.h
The file was modifiedmlir/lib/IR/Attributes.cpp
The file was modifiedmlir/lib/Parser/AttributeParser.cpp
The file was modifiedmlir/test/IR/dense-elements-hex.mlir
Commit 77973f8dee6d4d6f1b7c2a026249c1f7068f267b by dschuff
    [WebAssembly] Add support for DWARF type units

    Since Wasm comdat sections work similarly to ELF, we can use that mechanism
    to eliminate duplicate dwarf type information in the same way.

    Differential Revision: https://reviews.llvm.org/D88603
The file was modifiedclang/test/Driver/debug-options.c
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedllvm/lib/MC/MCObjectFileInfo.cpp
The file was modifiedllvm/lib/MC/WasmObjectWriter.cpp
The file was addedllvm/test/DebugInfo/WebAssembly/dwarf-headers.ll
Commit 735ab4be35695df9f9da7ae8b584cec28eabf1fe by mtrofin
[ThinLTO] Fix .llvmcmd emission

llvm::EmbedBitcodeInModule needs (what used to be called) EmbedMarker
set, in order to emit .llvmcmd. EmbedMarker is really about embedding the
command line, so renamed the parameter accordingly, too.

This was not caught at test because the check-prefix was incorrect, but
FileCheck does not report that when multiple prefixes are provided. A
separate patch will address that.

Differential Revision: https://reviews.llvm.org/D90278
The file was modifiedllvm/lib/Bitcode/Writer/BitcodeWriter.cpp
The file was modifiedllvm/include/llvm/Bitcode/BitcodeWriter.h
The file was modifiedclang/test/CodeGen/thinlto_embed_bitcode.ll
The file was modifiedllvm/lib/LTO/LTOBackend.cpp
Commit 4fe81b6b6a732d17101ef03eb24925c965164901 by Vedant Kumar
Revert "[DebugInfo] Shorten legacy [s|z]ext dwarf expressions"

This reverts commit 2ce36ebca544dd71075a7818ff4070da5667603b. It depends
on https://reviews.llvm.org/D89838, which needs to be reverted.
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
The file was modifiedllvm/test/DebugInfo/X86/convert-inlined.ll
The file was modifiedllvm/test/DebugInfo/X86/convert-debugloc.ll
Commit ffba94a9acff76e51ce64c331b500f7b1a44840f by Vedant Kumar
Revert "[DebugInfo] Fix legacy ZExt emission when FromBits >= 64 (PR47927)"

This reverts commit 99053462216cf835eb3ae063942c618d9609de87.

It breaks the compiler-rt build, see https://reviews.llvm.org/D89838
The file was removedllvm/test/DebugInfo/X86/legacy-zext.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
Commit 39856d5d0b6547c4ab605d505322678d5e84e7fe by i
[Debugify] Move global namespace functions into llvm::

Also move exportDebugifyStats from tools/opt to Debugify.cpp
The file was modifiedllvm/lib/Transforms/Utils/Debugify.cpp
The file was modifiedllvm/tools/opt/opt.cpp
The file was modifiedllvm/include/llvm/Transforms/Utils/Debugify.h
Commit 076a8d915bea098d168226e607e8d526c4435082 by powerman1st
[NFC][AVR] Improve device list

Reviewed By: dylanmckay

https://reviews.llvm.org/D87968
The file was modifiedllvm/lib/Target/AVR/AVRDevices.td
Commit 5be50d79c0b8e01e7085a668aa5cac1e20807c30 by powerman1st
[NFC][clang][AVR] Add more devices

Reviewed By: dylanmckay

Differential Revision: https://reviews.llvm.org/D88352
The file was modifiedclang/test/Misc/target-invalid-cpu-note.c
The file was modifiedclang/lib/Basic/Targets/AVR.cpp
Commit 501fda0167341f2db0da5198f70defb017a36178 by riddleriver
[mlir][Inliner] Add a new hook for checking if it is legal to inline a callable into a call

In certain situations it isn't legal to inline a call operation, but this isn't something that is possible(at least not easily) to prevent with the current hooks. This revision adds a new hook so that dialects with call operations that shouldn't be inlined can prevent it.

Differential Revision: https://reviews.llvm.org/D90359
The file was modifiedmlir/examples/toy/Ch6/mlir/Dialect.cpp
The file was modifiedmlir/examples/toy/Ch7/mlir/Dialect.cpp
The file was modifiedmlir/include/mlir/Transforms/InliningUtils.h
The file was modifiedmlir/examples/toy/Ch5/mlir/Dialect.cpp
The file was modifiedmlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
The file was modifiedmlir/docs/Tutorials/Toy/Ch-4.md
The file was modifiedmlir/lib/Transforms/Utils/InliningUtils.cpp
The file was modifiedmlir/test/lib/Dialect/Test/TestDialect.cpp
The file was modifiedmlir/examples/toy/Ch4/mlir/Dialect.cpp
The file was modifiedmlir/include/mlir/IR/Operation.h
The file was modifiedmlir/lib/Dialect/StandardOps/IR/Ops.cpp
The file was modifiedmlir/test/Transforms/inlining.mlir
Commit fa4174792a19072e415ea4ba6e7d91af046817c8 by riddleriver
[mlir][Inliner] Add a `wouldBeCloned` flag to each of the `isLegalToInline` hooks.

Often times the legality of inlining can change depending on if the callable is going to be inlined in-place, or cloned. For example, some operations are not allowed to be duplicated and can only be inlined if the original callable will cease to exist afterwards. The new `wouldBeCloned` flag allows for dialects to hook into this when determining legality.

Differential Revision: https://reviews.llvm.org/D90360
The file was modifiedmlir/lib/Dialect/StandardOps/IR/Ops.cpp
The file was modifiedmlir/examples/toy/Ch7/mlir/Dialect.cpp
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgTypes.cpp
The file was modifiedmlir/docs/Tutorials/Toy/Ch-4.md
The file was modifiedmlir/test/lib/Dialect/Test/TestDialect.cpp
The file was modifiedmlir/examples/toy/Ch5/mlir/Dialect.cpp
The file was modifiedmlir/examples/toy/Ch6/mlir/Dialect.cpp
The file was modifiedmlir/lib/Dialect/Affine/IR/AffineOps.cpp
The file was modifiedmlir/lib/Dialect/Shape/IR/Shape.cpp
The file was modifiedmlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
The file was modifiedmlir/examples/toy/Ch4/mlir/Dialect.cpp
The file was modifiedmlir/include/mlir/Transforms/InliningUtils.h
The file was modifiedmlir/lib/Transforms/Utils/InliningUtils.cpp
The file was modifiedmlir/lib/Dialect/SCF/SCF.cpp
Commit 73547b08de59d1be0e65d8dbc989e9c186295fcd by riddleriver
[mlir][SymbolTable] Small optimization to walking symbol references

* Check region count for unknown symbol tables first, as it is a faster check
* Add an accessor to MutableDictionaryAttr to get the internal dictionary without creating a new one if it is empty. This avoids an otherwise unnecessary lookup of an MLIRContext.
The file was modifiedmlir/lib/IR/SymbolTable.cpp
The file was modifiedmlir/include/mlir/IR/Attributes.h

Summary

  1. one (details)
  2. [NFC][Sanitizer] Try to increase file limits on bot (details)
Commit cfc055848cee7b30a3326458eaba257f79988191 by Vitaly Buka
one
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_android.sh
Commit 605f441f4892c7c930b0e2a7c5aee7ab3462d072 by Vitaly Buka
[NFC][Sanitizer] Try to increase file limits on bot
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_functions.sh