SuccessChanges

Summary

  1. Standardize on MSVC behavior for triples with no environment Summary: This makes it so that IR files using triples without an environment work out of the box, without normalizing them. Typically, the MSVC behavior is more desirable. For example, it tends to enable things like constant merging, use of associative comdats, etc. Addresses PR42491 Reviewers: compnerd Subscribers: hiraditya, dexonsmith, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64109
  2. llvm-profdata] Handle the cases of overlapping input file and output file Currently llvm-profdata does not expect the same file name for the input profile and the output profile. >llvm-profdata merge A.profraw B.profraw -o B.profraw The above command runs successfully but the resulted B.profraw is not correct. This patch fixes the issue by moving the initialization of writer after loading the profile. For the show command, the following will report a confusing error of "Empty raw profile file": >llvm-profdata show B.profraw -o B.profraw It's harder to fix as we need to output something before loading the input profile. I don't think that a fix for this is worth the effort. I just make the error explicit for the show command. Differential Revision: https://reviews.llvm.org/D64360
Revision 365387 by rnk:
Standardize on MSVC behavior for triples with no environment

Summary:
This makes it so that IR files using triples without an environment work
out of the box, without normalizing them.

Typically, the MSVC behavior is more desirable. For example, it tends to
enable things like constant merging, use of associative comdats, etc.

Addresses PR42491

Reviewers: compnerd

Subscribers: hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64109
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpptrunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpptrunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpptrunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
The file was modified/llvm/trunk/lib/IR/Mangler.cpptrunk/lib/IR/Mangler.cpp
The file was modified/llvm/trunk/lib/MC/MCWinCOFFStreamer.cpptrunk/lib/MC/MCWinCOFFStreamer.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.htrunk/lib/Target/X86/X86Subtarget.h
The file was modified/llvm/trunk/test/CodeGen/X86/win_cst_pool.lltrunk/test/CodeGen/X86/win_cst_pool.ll
The file was modified/llvm/trunk/unittests/ADT/TripleTest.cpptrunk/unittests/ADT/TripleTest.cpp
Revision 365386 by xur:
llvm-profdata] Handle the cases of overlapping input file and output file

Currently llvm-profdata does not expect the same file name for the input profile
and the output profile.
>llvm-profdata merge A.profraw B.profraw -o B.profraw
The above command runs successfully but the resulted B.profraw is not correct.
This patch fixes the issue by moving the initialization of writer after loading
the profile.

For the show command, the following will report a confusing error of
"Empty raw profile file":
>llvm-profdata show B.profraw -o B.profraw
It's harder to fix as we need to output something before loading the input profile.
I don't think that a fix for this is worth the effort. I just make the error explicit for
the show command.

Differential Revision: https://reviews.llvm.org/D64360
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/tools/llvm-profdata/Inputs/same-name-1.proftexttrunk/test/tools/llvm-profdata/Inputs/same-name-1.proftext
The file was added/llvm/trunk/test/tools/llvm-profdata/Inputs/same-name-2.proftexttrunk/test/tools/llvm-profdata/Inputs/same-name-2.proftext
The file was added/llvm/trunk/test/tools/llvm-profdata/Inputs/same-name-3.proftexttrunk/test/tools/llvm-profdata/Inputs/same-name-3.proftext
The file was added/llvm/trunk/test/tools/llvm-profdata/Inputs/same-name-4.proftexttrunk/test/tools/llvm-profdata/Inputs/same-name-4.proftext
The file was added/llvm/trunk/test/tools/llvm-profdata/same-filename.testtrunk/test/tools/llvm-profdata/same-filename.test
The file was modified/llvm/trunk/tools/llvm-profdata/llvm-profdata.cpptrunk/tools/llvm-profdata/llvm-profdata.cpp

Summary

  1. Revert "[sanitizers][windows] Rtl-Heap Interception and tests" Causes build failure on clang-ppc64be-linux-lnt: compiler-rt/lib/asan/asan_malloc_win.cc:23:2: error: #error "Missing arch or unsupported platform for Windows." #error "Missing arch or unsupported platform for Windows." ^~~~~ compiler-rt/lib/asan/asan_malloc_win.cc:25:10: fatal error: heapapi.h: No such file or directory #include <heapapi.h> ^~~~~~~~~~~ compilation terminated. [39/1151] Building CXX object projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_debugging.cc.o [40/1151] Building CXX object projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o FAILED: projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o /usr/bin/c++ -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/asan -Icompiler-rt/lib/asan -Iinclude -I/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/include -Icompiler-rt/lib/asan/.. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unused-parameter -O2 -UNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fvisibility=hidden -fno-lto -O3 -g -Wno-variadic-macros -Wno-non-virtual-dtor -fno-rtti -MD -MT projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o -MF projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o.d -o projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o -c compiler-rt/lib/asan/asan_malloc_win.cc compiler-rt/lib/asan/asan_malloc_win.cc:23:2: error: #error "Missing arch or unsupported platform for Windows." #error "Missing arch or unsupported platform for Windows." ^~~~~ compiler-rt/lib/asan/asan_malloc_win.cc:25:10: fatal error: heapapi.h: No such file or directory #include <heapapi.h> ^~~~~~~~~~~
Revision 365384 by jfb:
Revert "[sanitizers][windows] Rtl-Heap Interception and tests"

Causes build failure on clang-ppc64be-linux-lnt:

compiler-rt/lib/asan/asan_malloc_win.cc:23:2: error: #error "Missing arch or unsupported platform for Windows."
#error "Missing arch or unsupported platform for Windows."
  ^~~~~
compiler-rt/lib/asan/asan_malloc_win.cc:25:10: fatal error: heapapi.h: No such file or directory
#include <heapapi.h>
          ^~~~~~~~~~~
compilation terminated.
[39/1151] Building CXX object projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_debugging.cc.o
[40/1151] Building CXX object projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o
FAILED: projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o
/usr/bin/c++  -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/asan -Icompiler-rt/lib/asan -Iinclude -I/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/include -Icompiler-rt/lib/asan/.. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unused-parameter -O2    -UNDEBUG  -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fvisibility=hidden -fno-lto -O3 -g -Wno-variadic-macros -Wno-non-virtual-dtor -fno-rtti -MD -MT projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o -MF projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o.d -o projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64.dir/asan_malloc_win.cc.o -c compiler-rt/lib/asan/asan_malloc_win.cc
compiler-rt/lib/asan/asan_malloc_win.cc:23:2: error: #error "Missing arch or unsupported platform for Windows."
#error "Missing arch or unsupported platform for Windows."
  ^~~~~
compiler-rt/lib/asan/asan_malloc_win.cc:25:10: fatal error: heapapi.h: No such file or directory
#include <heapapi.h>
          ^~~~~~~~~~~
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_flags.inctrunk/lib/asan/asan_flags.inc
The file was modified/compiler-rt/trunk/lib/asan/asan_malloc_win.cctrunk/lib/asan/asan_malloc_win.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_win.cctrunk/lib/asan/asan_win.cc
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/dll_host.cctrunk/test/asan/TestCases/Windows/dll_host.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/dll_unload.cctrunk/test/asan/TestCases/Windows/dll_unload.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc.cctrunk/test/asan/TestCases/Windows/heapalloc.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_dll_double_free.cctrunk/test/asan/TestCases/Windows/heapalloc_dll_double_free.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_dll_unload_realloc_uaf.cctrunk/test/asan/TestCases/Windows/heapalloc_dll_unload_realloc_uaf.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_doublefree.cctrunk/test/asan/TestCases/Windows/heapalloc_doublefree.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_flags_fallback.cctrunk/test/asan/TestCases/Windows/heapalloc_flags_fallback.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_huge.cctrunk/test/asan/TestCases/Windows/heapalloc_huge.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cctrunk/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_sanity.cctrunk/test/asan/TestCases/Windows/heapalloc_sanity.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_transfer.cctrunk/test/asan/TestCases/Windows/heapalloc_transfer.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_uaf.cctrunk/test/asan/TestCases/Windows/heapalloc_uaf.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heapalloc_zero_size.cctrunk/test/asan/TestCases/Windows/heapalloc_zero_size.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heaprealloc.cctrunk/test/asan/TestCases/Windows/heaprealloc.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cctrunk/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cc
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/heaprealloc_zero_size.cctrunk/test/asan/TestCases/Windows/heaprealloc_zero_size.cc
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/queue_user_work_item_report.cctrunk/test/asan/TestCases/Windows/queue_user_work_item_report.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/rtlallocateheap.cctrunk/test/asan/TestCases/Windows/rtlallocateheap.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cctrunk/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cctrunk/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cctrunk/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Windows/rtlallocateheap_zero.cctrunk/test/asan/TestCases/Windows/rtlallocateheap_zero.cc