SuccessChanges

Summary

  1. [ADT] Enable ArrayRef/StringRef is_assignable tests on MSVC Now that we've dropped VS2015 support (D64326) we can enable these static_asserts on MSVC builds as VS2017+ correctly handles them
  2. [NFC][AsmPrinter] Fix the formatting for the rL365467 In addition, fix the build failure for the 'unused' variable. The variable was used inside the 'LLVM_DEBUG()'.
  3. OpaquePtr: add Type parameter to Loads analysis API. This makes the functions in Loads.h require a type to be specified independently of the pointer Value so that when pointers have no structure other than address-space, it can still do its job. Most callers had an obvious memory operation handy to provide this type, but a SROA and ArgumentPromotion were doing more complicated analysis. They get updated to merge the properties of the various instructions they were considering.
  4. [DwarfDebug] Dump call site debug info Dump the DWARF information about call sites and call site parameters into debug info sections. The patch also provides an interface for the interpretation of instructions that could load values of a call site parameters in order to generate DWARF about the call site parameters. ([13/13] Introduce the debug entry values.) Co-authored-by: Ananth Sowda <asowda@cisco.com> Co-authored-by: Nikola Prica <nikola.prica@rt-rk.com> Co-authored-by: Ivan Baev <ibaev@cisco.com> Differential Revision: https://reviews.llvm.org/D60716
Revision 365471 by rksimon:
[ADT] Enable ArrayRef/StringRef is_assignable tests on MSVC

Now that we've dropped VS2015 support (D64326) we can enable these static_asserts on MSVC builds as VS2017+ correctly handles them
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/unittests/ADT/ArrayRefTest.cpptrunk/unittests/ADT/ArrayRefTest.cpp
The file was modified/llvm/trunk/unittests/ADT/StringRefTest.cpptrunk/unittests/ADT/StringRefTest.cpp
Revision 365469 by djtodoro:
[NFC][AsmPrinter] Fix the formatting for the rL365467

In addition, fix the build failure for the 'unused'
variable. The variable was used inside the 'LLVM_DEBUG()'.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpptrunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpptrunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Revision 365468 by Tim Northover:
OpaquePtr: add Type parameter to Loads analysis API.

This makes the functions in Loads.h require a type to be specified
independently of the pointer Value so that when pointers have no structure
other than address-space, it can still do its job.

Most callers had an obvious memory operation handy to provide this type, but a
SROA and ArgumentPromotion were doing more complicated analysis. They get
updated to merge the properties of the various instructions they were
considering.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/Loads.htrunk/include/llvm/Analysis/Loads.h
The file was modified/llvm/trunk/lib/Analysis/Loads.cpptrunk/lib/Analysis/Loads.cpp
The file was modified/llvm/trunk/lib/Analysis/MemDerefPrinter.cpptrunk/lib/Analysis/MemDerefPrinter.cpp
The file was modified/llvm/trunk/lib/Analysis/ValueTracking.cpptrunk/lib/Analysis/ValueTracking.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpptrunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/ArgumentPromotion.cpptrunk/lib/Transforms/IPO/ArgumentPromotion.cpp
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpptrunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpptrunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LICM.cpptrunk/lib/Transforms/Scalar/LICM.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/MergeICmps.cpptrunk/lib/Transforms/Scalar/MergeICmps.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/SROA.cpptrunk/lib/Transforms/Scalar/SROA.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/TailRecursionElimination.cpptrunk/lib/Transforms/Scalar/TailRecursionElimination.cpp
Revision 365467 by djtodoro:
[DwarfDebug] Dump call site debug info

Dump the DWARF information about call sites and call site parameters into
debug info sections.

The patch also provides an interface for the interpretation of instructions
that could load values of a call site parameters in order to generate DWARF
about the call site parameters.

([13/13] Introduce the debug entry values.)

Co-authored-by: Ananth Sowda <asowda@cisco.com>
Co-authored-by: Nikola Prica <nikola.prica@rt-rk.com>
Co-authored-by: Ivan Baev <ibaev@cisco.com>

Differential Revision: https://reviews.llvm.org/D60716
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/LangRef.rsttrunk/docs/LangRef.rst
The file was modified/llvm/trunk/include/llvm/CodeGen/TargetInstrInfo.htrunk/include/llvm/CodeGen/TargetInstrInfo.h
The file was modified/llvm/trunk/include/llvm/CodeGen/TargetRegisterInfo.htrunk/include/llvm/CodeGen/TargetRegisterInfo.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpptrunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.htrunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpptrunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.htrunk/lib/CodeGen/AsmPrinter/DwarfDebug.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpptrunk/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfExpression.htrunk/lib/CodeGen/AsmPrinter/DwarfExpression.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpptrunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.htrunk/lib/CodeGen/AsmPrinter/DwarfUnit.h
The file was modified/llvm/trunk/lib/CodeGen/TargetInstrInfo.cpptrunk/lib/CodeGen/TargetInstrInfo.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetRegisterInfo.cpptrunk/lib/CodeGen/TargetRegisterInfo.cpp
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFDie.cpptrunk/lib/DebugInfo/DWARF/DWARFDie.cpp
The file was modified/llvm/trunk/lib/IR/DebugInfoMetadata.cpptrunk/lib/IR/DebugInfoMetadata.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.cpptrunk/lib/Target/X86/X86InstrInfo.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.htrunk/lib/Target/X86/X86InstrInfo.h
The file was added/llvm/trunk/test/DebugInfo/MIR/X86/dbgcall-site-interpretation.mirtrunk/test/DebugInfo/MIR/X86/dbgcall-site-interpretation.mir
The file was added/llvm/trunk/test/DebugInfo/MIR/X86/dbgcall-site-lea-interpretation.mirtrunk/test/DebugInfo/MIR/X86/dbgcall-site-lea-interpretation.mir
The file was added/llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mirtrunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir
The file was modified/llvm/trunk/test/DebugInfo/X86/dwarf-callsite-related-attrs.lltrunk/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll
The file was added/llvm/trunk/test/tools/llvm-dwarfdump/X86/stats-dbg-callsite-info.lltrunk/test/tools/llvm-dwarfdump/X86/stats-dbg-callsite-info.ll
The file was modified/llvm/trunk/tools/llvm-dwarfdump/Statistics.cpptrunk/tools/llvm-dwarfdump/Statistics.cpp

Summary

  1. Reland r365355: [Syntax] Introduce syntax trees With a fix to a PS4 buildbot crash.
  2. Revert rL365355 : [Syntax] Introduce syntax trees Summary: A tooling-focused alternative to the AST. This commit focuses on the memory-management strategy and the structure of the AST. More to follow later: - Operations to mutate the syntax trees and corresponding textual replacements. - Mapping between clang AST nodes and syntax tree nodes. - More node types corresponding to the language constructs. Reviewers: sammccall Reviewed By: sammccall Subscribers: llvm-commits, mgorny, cfe-commits Tags: #clang, #llvm Differential Revision: https://reviews.llvm.org/D61637 ........ Fixes buildbots which were crashing on SyntaxTests.exe
  3. [ASTImporter] Added visibility context check for EnumDecl. Summary: ASTImporter makes now difference between enums with same name in different translation units if these are not visible outside. ("Scoped enums" are not handled yet.) Reviewers: martong, a.sidorin, shafik, a_sidorin Reviewed By: a_sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D62484
Revision 365466 by ibiryukov:
Reland r365355: [Syntax] Introduce syntax trees

With a fix to a PS4 buildbot crash.
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/Tooling/Syntax/BuildTree.htrunk/include/clang/Tooling/Syntax/BuildTree.h
The file was added/cfe/trunk/include/clang/Tooling/Syntax/Nodes.htrunk/include/clang/Tooling/Syntax/Nodes.h
The file was added/cfe/trunk/include/clang/Tooling/Syntax/Tree.htrunk/include/clang/Tooling/Syntax/Tree.h
The file was added/cfe/trunk/lib/Tooling/Syntax/BuildTree.cpptrunk/lib/Tooling/Syntax/BuildTree.cpp
The file was modified/cfe/trunk/lib/Tooling/Syntax/CMakeLists.txttrunk/lib/Tooling/Syntax/CMakeLists.txt
The file was added/cfe/trunk/lib/Tooling/Syntax/Nodes.cpptrunk/lib/Tooling/Syntax/Nodes.cpp
The file was added/cfe/trunk/lib/Tooling/Syntax/Tree.cpptrunk/lib/Tooling/Syntax/Tree.cpp
The file was modified/cfe/trunk/unittests/Tooling/Syntax/CMakeLists.txttrunk/unittests/Tooling/Syntax/CMakeLists.txt
The file was added/cfe/trunk/unittests/Tooling/Syntax/TreeTest.cpptrunk/unittests/Tooling/Syntax/TreeTest.cpp
Revision 365465 by rksimon:
Revert rL365355 : [Syntax] Introduce syntax trees

Summary:
A tooling-focused alternative to the AST. This commit focuses on the
memory-management strategy and the structure of the AST.

More to follow later:
  - Operations to mutate the syntax trees and corresponding textual
    replacements.
  - Mapping between clang AST nodes and syntax tree nodes.
  - More node types corresponding to the language constructs.

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: llvm-commits, mgorny, cfe-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D61637
........
Fixes buildbots which were crashing on SyntaxTests.exe
Change TypePath in RepositoryPath in Workspace
The file was removed/cfe/trunk/include/clang/Tooling/Syntax/BuildTree.htrunk/include/clang/Tooling/Syntax/BuildTree.h
The file was removed/cfe/trunk/include/clang/Tooling/Syntax/Nodes.htrunk/include/clang/Tooling/Syntax/Nodes.h
The file was removed/cfe/trunk/include/clang/Tooling/Syntax/Tree.htrunk/include/clang/Tooling/Syntax/Tree.h
The file was removed/cfe/trunk/lib/Tooling/Syntax/BuildTree.cpptrunk/lib/Tooling/Syntax/BuildTree.cpp
The file was modified/cfe/trunk/lib/Tooling/Syntax/CMakeLists.txttrunk/lib/Tooling/Syntax/CMakeLists.txt
The file was removed/cfe/trunk/lib/Tooling/Syntax/Nodes.cpptrunk/lib/Tooling/Syntax/Nodes.cpp
The file was removed/cfe/trunk/lib/Tooling/Syntax/Tree.cpptrunk/lib/Tooling/Syntax/Tree.cpp
The file was modified/cfe/trunk/unittests/Tooling/Syntax/CMakeLists.txttrunk/unittests/Tooling/Syntax/CMakeLists.txt
The file was removed/cfe/trunk/unittests/Tooling/Syntax/TreeTest.cpptrunk/unittests/Tooling/Syntax/TreeTest.cpp
Revision 365464 by balazske:
[ASTImporter] Added visibility context check for EnumDecl.

Summary:
ASTImporter makes now difference between enums with same name in different translation
units if these are not visible outside.
("Scoped enums" are not handled yet.)

Reviewers: martong, a.sidorin, shafik, a_sidorin

Reviewed By: a_sidorin

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D62484
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ASTImporter.cpptrunk/lib/AST/ASTImporter.cpp
The file was modified/cfe/trunk/unittests/AST/ASTImporterVisibilityTest.cpptrunk/unittests/AST/ASTImporterVisibilityTest.cpp

Summary

  1. Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters. Summary: Currently it fails on cases like '\001'. Note: Since `StringLiteral::outputString` dumps most nonprintable characters in octal value, the exact string literal format isn't preserved, e.g. `"\x01"` becomes `'\001'`. Reviewers: gribozavr Reviewed By: gribozavr Subscribers: lebedev.ri, Eugene.Zelenko, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64151 Patch by Xiaoyi Zhang.
Revision 365463 by gribozavr:
Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

Summary:
Currently it fails on cases like '\001'.

Note: Since `StringLiteral::outputString` dumps most nonprintable
characters in octal value, the exact string literal format isn't preserved,
e.g. `"\x01"` becomes `'\001'`.

Reviewers: gribozavr

Reviewed By: gribozavr

Subscribers: lebedev.ri, Eugene.Zelenko, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64151

Patch by Xiaoyi Zhang.
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpptrunk/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/abseil-faster-strsplit-delimiter.cpptrunk/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp