SuccessChanges

Summary

  1. gn build: Merge r365585
  2. [docs][llvm-symbolizer] Fix grammar
  3. [X86] EltsFromConsecutiveLoads - cleanup Zero/Undef/Load element collection. NFCI.
  4. [MIPS GlobalISel] Select float and double phi Select float and double phi for MIPS32. Differential Revision: https://reviews.llvm.org/D64420
  5. [MIPS GlobalISel] Select float and double load and store Select float and double load and store for MIPS32. Differential Revision: https://reviews.llvm.org/D64419
  6. [FileCheck] Simplify numeric variable interface Summary: This patch simplifies 2 aspects in the FileCheckNumericVariable code. First, setValue() method is turned into a void function since being called only on undefined variable is an invariant and is now asserted rather than returned. This remove the assert from the callers. Second, clearValue() method is also turned into a void function since the only caller does not check its return value since it may be trying to clear the value of variable that is already cleared without this being noteworthy. Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk Subscribers: JonChesterfield, rogfer01, hfinkel, kristina, rnk, tra, arichardson, grimar, dblaikie, probinson, llvm-commits, hiraditya Tags: #llvm Differential Revision: https://reviews.llvm.org/D64231 llvm-svn: 365249
  7. [FileCheck] Fix @LINE value after match failure Summary: The value of the FileCheckNumericVariable class instance representing the @LINE numeric variable is set and cleared respectively before and after substitutions are made, if any. However, when a substitution fails, the value is not cleared. This causes the next substitution of @LINE later on to give the wrong value since setValue is a nop if the value is already set. This is what caused failures after commit r365249. Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield Tags: #llvm Differential Revision: https://reviews.llvm.org/D64449
  8. [NFC][ARM] Convert lambdas to static helpers Break up and convert some of the lambdas in ARMLowOverheadLoops into static functions.
  9. [X86] EltsFromConsecutiveLoads - LDBase is non-null. NFCI. Don't bother checking for LDBase != null - it should be (and we assert that it is).
  10. [DAGCombine] visitINSERT_SUBVECTOR - use uint64_t subvector index. NFCI. Keep the uint64_t type from getZExtValue() to stop truncation/extension overflow warnings in MSVC in subvector index math.
Revision 365633 by nico:
gn build: Merge r365585
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gntrunk/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn
Revision 365630 by jhenderson:
[docs][llvm-symbolizer] Fix grammar
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-symbolizer.rsttrunk/docs/CommandGuide/llvm-symbolizer.rst
Revision 365628 by rksimon:
[X86] EltsFromConsecutiveLoads - cleanup Zero/Undef/Load element collection. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 365627 by petar.avramovic:
[MIPS GlobalISel] Select float and double phi

Select float and double phi for MIPS32.

Differential Revision: https://reviews.llvm.org/D64420
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsInstructionSelector.cpptrunk/lib/Target/Mips/MipsInstructionSelector.cpp
The file was modified/llvm/trunk/test/CodeGen/Mips/GlobalISel/instruction-select/phi.mirtrunk/test/CodeGen/Mips/GlobalISel/instruction-select/phi.mir
The file was modified/llvm/trunk/test/CodeGen/Mips/GlobalISel/llvm-ir/phi.lltrunk/test/CodeGen/Mips/GlobalISel/llvm-ir/phi.ll
Revision 365626 by petar.avramovic:
[MIPS GlobalISel] Select float and double load and store

Select float and double load and store for MIPS32.

Differential Revision: https://reviews.llvm.org/D64419
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsInstructionSelector.cpptrunk/lib/Target/Mips/MipsInstructionSelector.cpp
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/instruction-select/load.mirtrunk/test/CodeGen/Mips/GlobalISel/instruction-select/load.mir
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/instruction-select/store.mirtrunk/test/CodeGen/Mips/GlobalISel/instruction-select/store.mir
The file was modified/llvm/trunk/test/CodeGen/Mips/GlobalISel/llvm-ir/load.lltrunk/test/CodeGen/Mips/GlobalISel/llvm-ir/load.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/GlobalISel/llvm-ir/store.lltrunk/test/CodeGen/Mips/GlobalISel/llvm-ir/store.ll
Revision 365625 by thopre:
[FileCheck] Simplify numeric variable interface

Summary:
This patch simplifies 2 aspects in the FileCheckNumericVariable code.

First, setValue() method is turned into a void function since being
called only on undefined variable is an invariant and is now asserted
rather than returned. This remove the assert from the callers.

Second, clearValue() method is also turned into a void function since
the only caller does not check its return value since it may be trying
to clear the value of variable that is already cleared without this
being noteworthy.

Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk

Subscribers: JonChesterfield, rogfer01, hfinkel, kristina, rnk, tra, arichardson, grimar, dblaikie, probinson, llvm-commits, hiraditya

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64231

llvm-svn: 365249
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/FileCheck.htrunk/include/llvm/Support/FileCheck.h
The file was modified/llvm/trunk/lib/Support/FileCheck.cpptrunk/lib/Support/FileCheck.cpp
The file was modified/llvm/trunk/unittests/Support/FileCheckTest.cpptrunk/unittests/Support/FileCheckTest.cpp
Revision 365624 by thopre:
[FileCheck] Fix @LINE value after match failure

Summary:
The value of the FileCheckNumericVariable class instance representing
the @LINE numeric variable is set and cleared respectively before and
after substitutions are made, if any. However, when a substitution
fails, the value is not cleared. This causes the next substitution of
@LINE later on to give the wrong value since setValue is a nop if the
value is already set. This is what caused failures after commit r365249.

Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk

Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64449
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Support/FileCheck.cpptrunk/lib/Support/FileCheck.cpp
The file was modified/llvm/trunk/unittests/Support/FileCheckTest.cpptrunk/unittests/Support/FileCheckTest.cpp
Revision 365623 by sam_parker:
[NFC][ARM] Convert lambdas to static helpers

Break up and convert some of the lambdas in ARMLowOverheadLoops into
static functions.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/ARM/ARMLowOverheadLoops.cpptrunk/lib/Target/ARM/ARMLowOverheadLoops.cpp
Revision 365622 by rksimon:
[X86] EltsFromConsecutiveLoads - LDBase is non-null. NFCI.

Don't bother checking for LDBase != null - it should be (and we assert that it is).
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 365621 by rksimon:
[DAGCombine] visitINSERT_SUBVECTOR - use uint64_t subvector index. NFCI.

Keep the uint64_t type from getZExtValue() to stop truncation/extension overflow warnings in MSVC in subvector index math.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpptrunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Summary

  1. Loop pragma parsing. NFC. I would like to add some pragma handling here, but couldn't resist a little NFC and tidy up first. Differential Revision: https://reviews.llvm.org/D64471
Revision 365629 by sjoerdmeijer:
Loop pragma parsing. NFC.

I would like to add some pragma handling here, but couldn't resist a little NFC
and tidy up first.

Differential Revision: https://reviews.llvm.org/D64471
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaStmtAttr.cpptrunk/lib/Sema/SemaStmtAttr.cpp

Summary

  1. [clangd] Trim spaces around parsed include in include extractor
  2. [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements. Summary: This would allow clangd embedders to use the ClangdServer::rename for other purposes (highlighting all the occurrences of the symbol in prepare stage). Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64481
Revision 365632 by kadircet:
[clangd] Trim spaces around parsed include in include extractor
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/QueryDriverDatabase.cpptrunk/clangd/QueryDriverDatabase.cpp
Revision 365631 by hokein:
[clangd] Add a flag to clangdServer rename function to control whether we want format the replacements.

Summary:
This would allow clangd embedders to use the ClangdServer::rename for other
purposes (highlighting all the occurrences of the symbol in prepare
stage).

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64481
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/ClangdLSPServer.cpptrunk/clangd/ClangdLSPServer.cpp
The file was modified/clang-tools-extra/trunk/clangd/ClangdServer.cpptrunk/clangd/ClangdServer.cpp
The file was modified/clang-tools-extra/trunk/clangd/ClangdServer.htrunk/clangd/ClangdServer.h
The file was modified/clang-tools-extra/trunk/clangd/unittests/SyncAPI.cpptrunk/clangd/unittests/SyncAPI.cpp