SuccessChanges

Summary

  1. [llvm-objcopy] Fix SHT_GROUP ordering. Summary: When llvm-objcopy sorts sections during finalization, it only sorts based on the offset, which can cause the group section to come after the sections it contains. This causes link failures when using gold to link objects created by llvm-objcopy. Fix this for now by copying GNU objcopy's behavior of placing SHT_GROUP sections first. In the future, we may want to remove this sorting entirely to more closely preserve the input file layout. This fixes https://bugs.llvm.org/show_bug.cgi?id=42052. Reviewers: jakehehrlich, jhenderson, MaskRay, espindola, alexshap Reviewed By: MaskRay Subscribers: phuongtrang148993, emaste, arichardson, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D62620
Revision 362973 by rupprecht:
[llvm-objcopy] Fix SHT_GROUP ordering.

Summary:
When llvm-objcopy sorts sections during finalization, it only sorts based on the offset, which can cause the group section to come after the sections it contains. This causes link failures when using gold to link objects created by llvm-objcopy.

Fix this for now by copying GNU objcopy's behavior of placing SHT_GROUP sections first. In the future, we may want to remove this sorting entirely to more closely preserve the input file layout.

This fixes https://bugs.llvm.org/show_bug.cgi?id=42052.

Reviewers: jakehehrlich, jhenderson, MaskRay, espindola, alexshap

Reviewed By: MaskRay

Subscribers: phuongtrang148993, emaste, arichardson, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62620
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.testtrunk/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib-gnu.test
The file was modified/llvm/trunk/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.testtrunk/test/tools/llvm-objcopy/ELF/compress-debug-sections-zlib.test
The file was added/llvm/trunk/test/tools/llvm-objcopy/ELF/group-reorder.testtrunk/test/tools/llvm-objcopy/ELF/group-reorder.test
The file was modified/llvm/trunk/test/tools/llvm-objcopy/ELF/strip-dwo-groups.testtrunk/test/tools/llvm-objcopy/ELF/strip-dwo-groups.test
The file was modified/llvm/trunk/tools/llvm-objcopy/ELF/Object.cpptrunk/tools/llvm-objcopy/ELF/Object.cpp