FailedChanges

Summary

  1. Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline." With a fix for sanitizer breakage (see explanation in D60318).
  2. [yaml2obj] Set p_align to the maximum sh_addralign of contained sections The address difference between two sections in a PT_LOAD is a constant. Consider a hypothetical case (pagesize can be very small, say, 4). ``` .text sh_addralign=4 .text.hot sh_addralign=16 ``` If we set p_align to 4, the PT_LOAD will be loaded at an address which is a multiple of 4. The address of .text.hot is guaranteed to be a multiple of 4, but not necessarily a multiple of 16. This patch deletes the constraint if (SHeader->sh_offset == PHeader.p_offset) Reviewed By: grimar, jhenderson Differential Revision: https://reviews.llvm.org/D67260
  3. [DWARF] Add a unit test for DWARFUnit::getLength(). This is a follow-up of rL369529, where the return value of DWARFUnit::getLength() was changed from uint32_t to uint64_t. The test checks that a unit header with Length > 4G can be successfully parsed and the value of the Length field is not truncated. Differential Revision: https://reviews.llvm.org/D67276
  4. [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this patch for the introduction of the type: https://reviews.llvm.org/D64790 Reviewers: courbet Subscribers: sdardis, nemanjai, hiraditya, kbarton, jrtc27, MaskRay, atanasyan, jsji, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D67288
  5. Revert Remove REQUIRES:shell from tests that pass for me on Windows This reverts r371478 (git commit a9980f60ce083fa6d5fd03c12c58ca0b293e3d60)
Revision 371502 by courbet:
Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline."

With a fix for sanitizer breakage (see explanation in D60318).
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/Passes.h (diff)llvm.src/include/llvm/CodeGen/Passes.h
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/PassManagerBuilder.h (diff)llvm.src/include/llvm/Transforms/IPO/PassManagerBuilder.h
The file was modified/llvm/trunk/include/llvm/Transforms/Scalar.h (diff)llvm.src/include/llvm/Transforms/Scalar.h
The file was modified/llvm/trunk/lib/CodeGen/CMakeLists.txt (diff)llvm.src/lib/CodeGen/CMakeLists.txt
The file was modified/llvm/trunk/lib/CodeGen/CodeGen.cpp (diff)llvm.src/lib/CodeGen/CodeGen.cpp
The file was removed/llvm/trunk/lib/CodeGen/ExpandMemCmp.cppllvm.src/lib/CodeGen/ExpandMemCmp.cpp
The file was modified/llvm/trunk/lib/CodeGen/TargetPassConfig.cpp (diff)llvm.src/lib/CodeGen/TargetPassConfig.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (diff)llvm.src/lib/Transforms/IPO/PassManagerBuilder.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/CMakeLists.txt (diff)llvm.src/lib/Transforms/Scalar/CMakeLists.txt
The file was added/llvm/trunk/lib/Transforms/Scalar/ExpandMemCmp.cppllvm.src/lib/Transforms/Scalar/ExpandMemCmp.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/MergeICmps.cpp (diff)llvm.src/lib/Transforms/Scalar/MergeICmps.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/Scalar.cpp (diff)llvm.src/lib/Transforms/Scalar/Scalar.cpp
The file was modified/llvm/trunk/test/CodeGen/AArch64/O3-pipeline.ll (diff)llvm.src/test/CodeGen/AArch64/O3-pipeline.ll
The file was removed/llvm/trunk/test/CodeGen/AArch64/bcmp-inline-small.llllvm.src/test/CodeGen/AArch64/bcmp-inline-small.ll
The file was modified/llvm/trunk/test/CodeGen/ARM/O3-pipeline.ll (diff)llvm.src/test/CodeGen/ARM/O3-pipeline.ll
The file was modified/llvm/trunk/test/CodeGen/Generic/llc-start-stop.ll (diff)llvm.src/test/CodeGen/Generic/llc-start-stop.ll
The file was removed/llvm/trunk/test/CodeGen/PowerPC/memCmpUsedInZeroEqualityComparison.llllvm.src/test/CodeGen/PowerPC/memCmpUsedInZeroEqualityComparison.ll
The file was removed/llvm/trunk/test/CodeGen/PowerPC/memcmp-mergeexpand.llllvm.src/test/CodeGen/PowerPC/memcmp-mergeexpand.ll
The file was removed/llvm/trunk/test/CodeGen/PowerPC/memcmp.llllvm.src/test/CodeGen/PowerPC/memcmp.ll
The file was removed/llvm/trunk/test/CodeGen/PowerPC/memcmpIR.llllvm.src/test/CodeGen/PowerPC/memcmpIR.ll
The file was modified/llvm/trunk/test/CodeGen/X86/O3-pipeline.ll (diff)llvm.src/test/CodeGen/X86/O3-pipeline.ll
The file was removed/llvm/trunk/test/CodeGen/X86/memcmp-mergeexpand.llllvm.src/test/CodeGen/X86/memcmp-mergeexpand.ll
The file was removed/llvm/trunk/test/CodeGen/X86/memcmp-optsize.llllvm.src/test/CodeGen/X86/memcmp-optsize.ll
The file was removed/llvm/trunk/test/CodeGen/X86/memcmp.llllvm.src/test/CodeGen/X86/memcmp.ll
The file was modified/llvm/trunk/test/Other/opt-O2-pipeline.ll (diff)llvm.src/test/Other/opt-O2-pipeline.ll
The file was modified/llvm/trunk/test/Other/opt-O3-pipeline.ll (diff)llvm.src/test/Other/opt-O3-pipeline.ll
The file was modified/llvm/trunk/test/Other/opt-Os-pipeline.ll (diff)llvm.src/test/Other/opt-Os-pipeline.ll
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/AArch64llvm.src/test/Transforms/ExpandMemCmp/AArch64
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/AArch64/memcmp.llllvm.src/test/Transforms/ExpandMemCmp/AArch64/memcmp.ll
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/PowerPCllvm.src/test/Transforms/ExpandMemCmp/PowerPC
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/PowerPC/lit.local.cfgllvm.src/test/Transforms/ExpandMemCmp/PowerPC/lit.local.cfg
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/PowerPC/memcmpIR.llllvm.src/test/Transforms/ExpandMemCmp/PowerPC/memcmpIR.ll
The file was modified/llvm/trunk/test/Transforms/ExpandMemCmp/X86/memcmp.ll (diff)llvm.src/test/Transforms/ExpandMemCmp/X86/memcmp.ll
The file was added/llvm/trunk/test/Transforms/ExpandMemCmp/X86/pr36421.llllvm.src/test/Transforms/ExpandMemCmp/X86/pr36421.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/PowerPCllvm.src/test/Transforms/PhaseOrdering/PowerPC
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/PowerPC/lit.local.cfgllvm.src/test/Transforms/PhaseOrdering/PowerPC/lit.local.cfg
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/PowerPC/memCmpUsedInZeroEqualityComparison.llllvm.src/test/Transforms/PhaseOrdering/PowerPC/memCmpUsedInZeroEqualityComparison.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/PowerPC/memcmp-mergeexpand.llllvm.src/test/Transforms/PhaseOrdering/PowerPC/memcmp-mergeexpand.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/PowerPC/memcmp.llllvm.src/test/Transforms/PhaseOrdering/PowerPC/memcmp.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/X86llvm.src/test/Transforms/PhaseOrdering/X86
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/X86/lit.local.cfgllvm.src/test/Transforms/PhaseOrdering/X86/lit.local.cfg
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/X86/memcmp-mergeexpand.llllvm.src/test/Transforms/PhaseOrdering/X86/memcmp-mergeexpand.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/X86/memcmp.llllvm.src/test/Transforms/PhaseOrdering/X86/memcmp.ll
The file was added/llvm/trunk/test/Transforms/PhaseOrdering/X86/pr36421.llllvm.src/test/Transforms/PhaseOrdering/X86/pr36421.ll
The file was modified/llvm/trunk/tools/opt/opt.cpp (diff)llvm.src/tools/opt/opt.cpp
The file was modified/llvm/trunk/utils/gn/secondary/llvm/lib/CodeGen/BUILD.gn (diff)llvm.src/utils/gn/secondary/llvm/lib/CodeGen/BUILD.gn
The file was modified/llvm/trunk/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn (diff)llvm.src/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn
Revision 371501 by maskray:
[yaml2obj] Set p_align to the maximum sh_addralign of contained sections

The address difference between two sections in a PT_LOAD is a constant.
Consider a hypothetical case (pagesize can be very small, say, 4).

```
.text     sh_addralign=4
.text.hot sh_addralign=16
```

If we set p_align to 4, the PT_LOAD will be loaded at an address which
is a multiple of 4. The address of .text.hot is guaranteed to be a
multiple of 4, but not necessarily a multiple of 16.

This patch deletes the constraint

  if (SHeader->sh_offset == PHeader.p_offset)

Reviewed By: grimar, jhenderson

Differential Revision: https://reviews.llvm.org/D67260
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ObjectYAML/ELFEmitter.cpp (diff)llvm.src/lib/ObjectYAML/ELFEmitter.cpp
The file was modified/llvm/trunk/test/tools/yaml2obj/program-header-align.yaml (diff)llvm.src/test/tools/yaml2obj/program-header-align.yaml
Revision 371499 by ikudrin:
[DWARF] Add a unit test for DWARFUnit::getLength().

This is a follow-up of rL369529, where the return value of
DWARFUnit::getLength() was changed from uint32_t to uint64_t.
The test checks that a unit header with Length > 4G can be successfully
parsed and the value of the Length field is not truncated.

Differential Revision: https://reviews.llvm.org/D67276
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp (diff)llvm.src/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
Revision 371498 by gchatelet:
[Alignment] Use Align for TargetLowering::MinStackArgumentAlignment

Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Reviewers: courbet

Subscribers: sdardis, nemanjai, hiraditya, kbarton, jrtc27, MaskRay, atanasyan, jsji, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67288
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/TargetLowering.h (diff)llvm.src/include/llvm/CodeGen/TargetLowering.h
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (diff)llvm.src/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (diff)llvm.src/lib/Target/ARM/ARMISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (diff)llvm.src/lib/Target/Mips/MipsISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (diff)llvm.src/lib/Target/PowerPC/PPCISelLowering.cpp
Revision 371497 by jhenderson:
Revert Remove REQUIRES:shell from tests that pass for me on Windows

This reverts r371478 (git commit a9980f60ce083fa6d5fd03c12c58ca0b293e3d60)
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Analysis/crash-trace.c (diff)clang.src/test/Analysis/crash-trace.c
The file was modified/cfe/trunk/test/CodeGen/thinlto_backend.ll (diff)clang.src/test/CodeGen/thinlto_backend.ll
The file was modified/cfe/trunk/test/Driver/check-time-trace-sections.cpp (diff)clang.src/test/Driver/check-time-trace-sections.cpp
The file was modified/cfe/trunk/test/Driver/check-time-trace.cpp (diff)clang.src/test/Driver/check-time-trace.cpp
The file was modified/cfe/trunk/test/Driver/clang-offload-bundler.c (diff)clang.src/test/Driver/clang-offload-bundler.c
The file was modified/cfe/trunk/test/Driver/crash-report-crashfile.m (diff)clang.src/test/Driver/crash-report-crashfile.m
The file was modified/cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c (diff)clang.src/test/Driver/rewrite-map-in-diagnostics.c
The file was modified/cfe/trunk/test/Format/style-on-command-line.cpp (diff)clang.src/test/Format/style-on-command-line.cpp
The file was modified/cfe/trunk/test/Frontend/dependency-gen-has-include.c (diff)clang.src/test/Frontend/dependency-gen-has-include.c
The file was modified/cfe/trunk/test/Index/crash-recovery-modules.m (diff)clang.src/test/Index/crash-recovery-modules.m
The file was modified/cfe/trunk/test/Modules/at-import-in-framework-header.m (diff)clang.src/test/Modules/at-import-in-framework-header.m
The file was modified/cfe/trunk/test/Modules/builtins.m (diff)clang.src/test/Modules/builtins.m
The file was modified/cfe/trunk/test/Modules/dependency-dump-dependent-module.m (diff)clang.src/test/Modules/dependency-dump-dependent-module.m
The file was modified/cfe/trunk/test/Modules/dependency-dump.m (diff)clang.src/test/Modules/dependency-dump.m
The file was modified/cfe/trunk/test/Modules/implicit-invalidate-common.c (diff)clang.src/test/Modules/implicit-invalidate-common.c
The file was modified/cfe/trunk/test/OpenMP/task_firstprivate_codegen.cpp (diff)clang.src/test/OpenMP/task_firstprivate_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/task_private_codegen.cpp (diff)clang.src/test/OpenMP/task_private_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_firstprivate_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_firstprivate_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_lastprivate_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_lastprivate_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_private_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_private_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_simd_firstprivate_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_simd_lastprivate_codegen.cpp
The file was modified/cfe/trunk/test/OpenMP/taskloop_simd_private_codegen.cpp (diff)clang.src/test/OpenMP/taskloop_simd_private_codegen.cpp
The file was modified/cfe/trunk/test/PCH/modified-header-error.c (diff)clang.src/test/PCH/modified-header-error.c
The file was modified/cfe/trunk/test/Parser/crash-report.c (diff)clang.src/test/Parser/crash-report.c