Started 2 mo 29 days ago
Took 1 hr 33 min on green-dragon-22

Success Build rL:371873 - C:371878 - #582 (Sep 13, 2019 10:54:13 AM)

Revisions
  • http://llvm.org/svn/llvm-project/llvm/trunk : 371873
  • http://llvm.org/svn/llvm-project/cfe/trunk : 371878
  • http://llvm.org/svn/llvm-project/compiler-rt/trunk : 371872
  • http://llvm.org/svn/llvm-project/debuginfo-tests/trunk : 364589
  • http://llvm.org/svn/llvm-project/zorg/trunk : 371835
  • http://llvm.org/svn/llvm-project/libcxx/trunk : 371874
  • http://llvm.org/svn/llvm-project/clang-tools-extra/trunk : 371773
Changes
  1. Reland r371785: Add -Wpoison-system-directories warning

    When using clang as a cross-compiler, we should not use system
    headers to do the compilation.
    This CL adds support of a new warning flag -Wpoison-system-directories which
    emits warnings if --sysroot is set and headers from common host system location
    are used.
    By default the warning is disabled.

    The intention of the warning is to catch bad includes which are usually
    generated by third party build system not targeting cross-compilation.
    Such cases happen in Chrome OS when someone imports a new package or upgrade
    one to a newer version from upstream.

    This is reland of r371785 with a fix to test file.

    Patch by: denik (Denis Nikitin) (detail/ViewSVN)
    by manojgupta
  2. Fix build error in 371875

    Apparently Clang complains about the name hiding here in a way that my
    GCC build does not, so a shocking number of buildbots decided to tell me
    about it.  Change the name of the variable to prevent the name hiding
    and hope we don't have to fix this again. (detail/ViewSVN)
    by erichkeane
  3. [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

    In order to enable future improvements to our attribute diagnostics,
    this moves info from ParsedAttr into CommonAttributeInfo, then makes
    this type the base of the *Attr and ParsedAttr types. Quite a bit of
    refactoring took place, including removing a bunch of redundant Spelling
    Index propogation.

    Differential Revision: https://reviews.llvm.org/D67368 (detail/ViewSVN)
    by erichkeane
  4. Fix failing negative compilation test for some versions of Clang (detail/ViewSVN)
    by ericwf
  5. Revert for: [AMDGPU]: PHI Elimination hooks added for custom COPY insertion. (detail/ViewSVN)
    by alex-t
  6. Fix bug in `darwin_test_archs()` when the cache variable is set but empty.

    Summary:
    If the cache variable named in `${valid_archs}` (e.g. `DARWIN_osx_BUILTIN_ARCHS`)
    is set in the cache but is empty then the cache check
    `if(${valid_archs})` will be false so the function will probe the
    compiler but the `set(...)` command at the end of the function to update
    the cache variable will be a no-op. This is because `set(...)` will not
    update an existing cache variable unless the `FORCE` argument is
    provided.

    To fix this this patch adds `FORCE` so the cache is always updated.

    rdar://problem/55323665

    Reviewers: vsk, kubamracek

    Subscribers: mgorny, #sanitizers, llvm-commits

    Tags: #llvm, #sanitizers

    Differential Revision: https://reviews.llvm.org/D67530 (detail/ViewSVN)
    by delcypher
  7. [CMake] Separate the detection Darwin platforms architectures for the
    built-ins from the rest of compiler-rt.

    The detection of supported platform (os) architectures for Darwin relies
    on the `darwin_test_archs()` CMake function. This is used both for
    building the builtins (`builtin-config-ix.cmake`) and for the rest of
    the compiler-rt (`config-ix.cmake`).

    `darwin_test_archs()`  implements a cache, presumably to speed up CMake
    re-configures.  Unfortunately this caching is buggy because it depends
    on external global state (i.e. the `TEST_COMPILE_ONLY` variable) and
    this is not taken into account. For `config-ix.cmake`
    `TEST_COMPILE_ONLY` is not set and for `builtin-config-ix.cmake`
    `TEST_COMPILE_ONLY` is set to `On`.  This makes the
    `darwin_test_archs()` function racey in the sense that a call from one
    calling context will poison the cache for the other calling context.

    This is actually an issue George Karpenkov discovered a while back
    and had an incomplete patch for (https://reviews.llvm.org/D45337)
    but this was never merged.

    To workaround this, this patch switches to using a different set of
    variables for the platform architecture builtins, i.e.
    `DARWIN_<OS>_ARCHS` -> `DARWIN_<OS>_BUILTIN_ARCHS`. This avoids the
    cache poisoning problem because the cached variable names are different.
    This also has the advantage that the the configured architectures for
    builtins and the rest of the compiler-rt are now independent and
    can be set differently if necessary.

    Note in `darwin_test_archs()` we also now pass `-w` to the compiler
    because `try_compile_only()` treats compiler warnings as errors.  This
    was extremely fragile because compiler warnings (can easily appear due
    to a buggy compiler or SDK headers) would cause compiler-rt to think an
    architecture on Darwin wasn't supported.

    rdar://problem/48637491 (detail/ViewSVN)
    by delcypher
  8. [Remarks][NFC] Forward declare ParsedStringTable (detail/ViewSVN)
    by thegameg
  9. [Remarks][NFC] Use StringLiteral for magic numbers (detail/ViewSVN)
    by thegameg

Started by an SCM change (3 times)

This run spent:

  • 1 hr 7 min waiting;
  • 1 hr 33 min build duration;
  • 2 hr 40 min total from scheduled to completion.
LLVM/Clang Warnings: 1 warning.
    Test Result (no failures)