SuccessChanges

Summary

  1. [ARM][ParallelDSP] Fix for sext input (details)
  2. [clangd] Improve output of semantic highlighting tests in case of (details)
  3. [ARM][MVE] Decoding of uqrshl and sqrshl accepts unpredictable encodings (details)
  4. [clangd] Replace HighlightingKind::NumKinds with LastKind. NFC (details)
  5. [clangd] Highlight typedefs to template parameters as template (details)
  6. [lib/ObjectYAML] - Improve and cleanup error reporting in ELFState<ELFT> (details)
  7. [yaml2obj] - Fix BB after r371380 (details)
  8. GlobalISel: add combiner to form indexed loads. (details)
Commit c363deb575019c6cb28a6d1c92826e36ea8bb07c by sam.parker
[ARM][ParallelDSP] Fix for sext input
The incoming accumulator value can be discovered through a sext, in
which case there will be a mismatch between the input and the result. So
sign extend the accumulator input if we're performing a 64-bit mac.
Differential Revision: https://reviews.llvm.org/D67220
llvm-svn: 371370
The file was modifiedllvm/lib/Target/ARM/ARMParallelDSP.cpp
The file was modifiedllvm/test/CodeGen/ARM/ParallelDSP/blocks.ll
The file was addedllvm/test/CodeGen/ARM/ParallelDSP/sext-acc.ll
Commit ad3841fcae6392cb315e2ab39e6d49887d5ef449 by ibiryukov
[clangd] Improve output of semantic highlighting tests in case of
failures
Summary: Instead of matching lists of highlightings, we annotate input
code with resulting highlightings and diff it against the expected
annotated input.
In case of failures, this produces much nicer output in form of
text-based diffs.
Reviewers: hokein
Reviewed By: hokein
Subscribers: nridge, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67274
llvm-svn: 371373
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.h
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
Commit 6b9aedaec6815b819c626c5ba8d6fbbff9c6028c by oliver.stannard
[ARM][MVE] Decoding of uqrshl and sqrshl accepts unpredictable encodings
Specify the Unpredictable bits, and return softfails when appropriate.
Patch by Mark Murray!
Differential revision: https://reviews.llvm.org/D66939
llvm-svn: 371374
The file was modifiedllvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
The file was addedllvm/test/MC/Disassembler/ARM/mve-scalar-shift-unpredictable.txt
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
Commit 63d5d162377e1290990221560c9cd2e571491d6a by ibiryukov
[clangd] Replace HighlightingKind::NumKinds with LastKind. NFC
Summary: The latter simplifies the client code by avoiding the need to
handle it as a separate case statement.
Reviewers: hokein
Reviewed By: hokein
Subscribers: nridge, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67277
llvm-svn: 371375
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.h
Commit d5588293a8c8093e0014229401e541edc7acf5d5 by ibiryukov
[clangd] Highlight typedefs to template parameters as template
parameters
Summary: Template parameters were handled outside `addType`, this led to
lack of highlightings for typedefs to template types.
This was never desirable, we want to highlight our typedefs as their
underlying type. Note that typedefs to more complicated types, like
pointers and references are still not highlighted.
Original patch by Johan Vikström.
Reviewers: hokein, jvikstrom
Reviewed By: hokein
Subscribers: nridge, javed.absar, kristof.beyls, MaskRay, jkorous,
arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66516
llvm-svn: 371379
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
Commit 3212ecfea8ca60dc0046b10da9e456e512ccea84 by grimar
[lib/ObjectYAML] - Improve and cleanup error reporting in ELFState<ELFT>
class.
The aim of this patch is to refactor how we handle and report error.
I suggest to use the same approach we use in LLD: delayed error
reporting. For that I introduced 'HasError' flag which triggers when we
report an error. Now we do not exit instantly on any error. The benefits
are:
1) There are no more 'exit(1)' calls in the library code. 2) Code was
simplified significantly in a few places. 3) It is now possible to print
multiple errors instead of only one.
Also, I changed the messages to be lower case and removed a full stop.
Differential revision: https://reviews.llvm.org/D67182
llvm-svn: 371380
The file was modifiedllvm/test/tools/yaml2obj/elf-comdat-broken-info.yaml
The file was modifiedllvm/test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml
The file was addedllvm/test/tools/yaml2obj/elf-comdat-broken-members.yaml
The file was modifiedllvm/test/tools/yaml2obj/elf-custom-null-section.yaml
The file was modifiedllvm/test/tools/yaml2obj/reloc-sec-info.yaml
The file was modifiedllvm/test/tools/yaml2obj/duplicate-section-names.test
The file was modifiedllvm/test/tools/yaml2obj/duplicate-symbol-names.test
The file was modifiedllvm/test/tools/yaml2obj/program-header.yaml
The file was modifiedllvm/test/tools/yaml2obj/relocation-missing-symbol.yaml
The file was modifiedllvm/test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml
The file was modifiedllvm/test/tools/yaml2obj/section-link.yaml
The file was modifiedllvm/lib/ObjectYAML/ELFEmitter.cpp
The file was modifiedllvm/test/tools/yaml2obj/dynamic-section-raw-content.yaml
The file was modifiedllvm/test/tools/yaml2obj/dynamic-symbols.yaml
Commit c11af417e0dd6c04d38bb48f0d77f0b849211ebb by grimar
[yaml2obj] - Fix BB after r371380
Just a fix for an input file name.
llvm-svn: 371383
The file was modifiedllvm/test/tools/yaml2obj/dynamic-symbols.yaml
Commit 36147adc0b14b455c6c1d738523f930d0793865c by Tim Northover
GlobalISel: add combiner to form indexed loads.
Loosely based on DAGCombiner version, but this part is slightly simpler
in GlobalIsel because all address calculation is performed by G_GEP.
That makes the inc/dec distinction moot so there's just pre/post to
think about.
No targets can handle it yet so testing is via a special flag that
overrides target hooks.
llvm-svn: 371384
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
The file was modifiedllvm/include/llvm/Target/GenericOpcodes.td
The file was modifiedllvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/gisel-commandline-option.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64.h
The file was modifiedllvm/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpp
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp
The file was modifiedllvm/include/llvm/CodeGen/TargetLowering.h
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/combiner-load-store-indexing.ll
The file was modifiedllvm/include/llvm/Support/TargetOpcodes.def