FailedChanges

Summary

  1. [X86][SSE] LowerVectorAllZero - add support for masked OR-reductions (details)
  2. [lldb/Test] Introduce "assertSuccess" (details)
  3. [ASTMatcher] Fix a performance regression: memorize the child match. (details)
  4. [DWARFYAML][MachO] Remove endianness related tests. (details)
  5. [libc++] Remove dead code since the removal of the old testing format (details)
  6. [runtimes] Rename newformat to just format, now that the old format has been removed (details)
  7. [AST][RecoveryExpr] Avoid spurious 'missing typename' diagnostic when the NNS contains errors. (details)
  8. [SystemZ] Simplify knownbits.ll test (details)
  9. [NFC] Remove dead code (details)
Commit 82de01895455c2ac0f2aa7397414ca96757bea06 by llvm-dev
[X86][SSE] LowerVectorAllZero - add support for masked OR-reductions

If we're masking the result of an OR-reduction before comparing against zero, we can fold this into the PTEST() / MOVMSK(CMPEQ()) codegen by pre-masking the source value.

This works particularly well on PTEST which performs the AND as part of its operation, but the MOVMSK variant also benefits for non-V2I64 cases.

Fixes PR44781
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-reduce-or-cmp.ll
Commit 35674976f09ec99e74d0d28b4a64b6bce360c128 by pavel
[lldb/Test] Introduce "assertSuccess"

Summary:
A lot of our tests do 'self.assertTrue(error.Success()'. The problem
with that is that when this fails, it produces a completely useless
error message (False is not True) and the most important piece of
information -- the actual error message -- is completely hidden.

Sometimes we mitigate that by including the error message in the "msg"
argument, but this has two additional problems:
- as the msg argument is evaluated unconditionally, one needs to be
  careful to not trigger an exception when the operation was actually
  successful.
- it requires more typing, which means we often don't do it

assertSuccess solves these problems by taking the entire SBError object
as an argument. If the operation was unsuccessful, it can format a
reasonable error message itself. The function still accepts a "msg"
argument, which can include any additional context, but this context now
does not need to include the error message.

To demonstrate usage, I replace a number of existing assertTrue
assertions with the new function. As this process is not easily
automatable, I have just manually updated a representative sample. In
some cases, I did not update the code to use assertSuccess, but I went
for even higher-level assertion apis (runCmd, expect_expr), as these are
even shorter, and can produce even better failure messages.

Reviewers: teemperor, JDevlieghere

Subscribers: arphaman, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D82759
The file was modifiedlldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
The file was modifiedlldb/test/API/commands/expression/options/TestExprOptions.py
The file was modifiedlldb/test/API/commands/expression/timeout/TestCallWithTimeout.py
The file was modifiedlldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
The file was modifiedlldb/test/API/python_api/hello_world/TestHelloWorld.py
The file was modifiedlldb/test/API/commands/expression/call-throws/TestCallThatThrows.py
The file was modifiedlldb/test/API/commands/expression/fixits/TestFixIts.py
The file was modifiedlldb/test/API/commands/expression/pr35310/TestExprsBug35310.py
The file was modifiedlldb/test/API/commands/register/register/register_command/TestRegisters.py
The file was modifiedlldb/test/API/commands/expression/scoped_enums/TestScopedEnumType.py
The file was modifiedlldb/packages/Python/lldbsuite/test/lldbtest.py
The file was modifiedlldb/test/API/commands/expression/result_numbering/TestResultNumbering.py
The file was modifiedlldb/test/API/commands/expression/unwind_expression/TestUnwindExpression.py
The file was modifiedlldb/test/API/commands/expression/context-object/TestContextObject.py
The file was modifiedlldb/test/API/commands/expression/weak_symbols/TestWeakSymbols.py
The file was modifiedlldb/test/API/commands/expression/context-object-objc/TestContextObjectObjc.py
The file was modifiedlldb/test/API/commands/expression/dont_allow_jit/TestAllowJIT.py
Commit 9f865246a81759cdcb056c883e6f92fe6693b3d3 by hokein.wu
[ASTMatcher] Fix a performance regression: memorize the child match.

D80025 introduced a performance regression: in some cases, it makes
clang-tidy readability-container-size-empty ~80x slower (running on an internal
huge TU, before that patch 12s vs after 950s).

after this patch, we go back to 12s.

Differential Revision: https://reviews.llvm.org/D82771
The file was modifiedclang/lib/ASTMatchers/ASTMatchFinder.cpp
Commit 8032727a43ca678b0b923abaa04638f500a060d6 by Xing
[DWARFYAML][MachO] Remove endianness related tests.

fe08ab542bd6328a7906e38ae473cf655eb6a228 makes build bots unhappy
(http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/33624/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3ADWARF-debug_info.yaml).

This patch removes failed tests.
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml
The file was modifiedllvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml
Commit b58b61c4b78ce81a4ef974374c707163b3691bfe by Louis Dionne
[libc++] Remove dead code since the removal of the old testing format
The file was removedlibcxx/test/libcxx/selftest/test.sh.cpp
The file was removedlibcxx/utils/libcxx/test/tracing.py
The file was modifiedlibcxx/utils/libcxx/test/config.py
The file was removedlibcxx/test/libcxx/selftest/exec.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/test.pass.cpp
The file was removedlibcxx/utils/libcxx/test/executor.py
The file was removedlibcxx/utils/libcxx/test/format.py
The file was removedlibcxx/test/libcxx/selftest/test.pass.mm
The file was removedlibcxx/test/libcxx/selftest/test.arc.pass.mm
Commit 70f6389257a85a8fa7f128a05a1ccbd0dbba191c by Louis Dionne
[runtimes] Rename newformat to just format, now that the old format has been removed
The file was addedlibcxx/test/libcxx/selftest/verify.cpp/no-diagnostics.verify.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/no-diagnostics.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.cpp/run-success.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/link.pass.cpp/link-success.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/sh.cpp/werror.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/link.pass.cpp/run-error.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/run.fail.cpp/link-error.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.cpp/run-success.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/remote-substitutions.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/compile.pass.cpp/compile-error.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.pass.cpp/run-error.compile.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/additional_compile_flags/substitutes-in-compile-flags.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/no-arc.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/sh.cpp/run-error.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/sh.cpp/run-success.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/file_dependencies/absolute-and-relative-paths.sh.cpp
The file was modifiedlibunwind/test/lit.site.cfg.in
The file was addedlibcxx/test/libcxx/selftest/pass.mm/link-error.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.pass.cpp/compile-error.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/use-objective-cxx.pass.mm
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/no-diagnostics-unmarked.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.cpp/werror.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/run.fail.cpp/link-error.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.fail.cpp/compile-error.compile.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/no-diagnostics.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.fail.cpp/compile-error.link.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/compile-failure.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/verify.cpp/no-werror.verify.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.mm/use-objective-cxx.pass.mm
The file was addedlibcxx/test/libcxx/selftest/verify.cpp/no-diagnostics-unmarked.verify.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/compile-failure.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/verify.cpp/right-diagnostic.verify.cpp
The file was removedlibcxx/utils/libcxx/test/newformat.py
The file was removedlibcxx/test/libcxx/selftest/newformat/verify.cpp/no-diagnostics.verify.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/no-diagnostics-unmarked.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/shell-escape.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.mm/compile-error.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/run.fail.cpp/run-success.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/link-error.pass.mm
The file was addedlibcxx/test/libcxx/selftest/run.fail.cpp/run-error.run.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/tmpdir-exists.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/compile.pass.cpp/compile-success.compile.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.mm/no-arc.pass.mm
The file was addedlibcxx/test/libcxx/selftest/pass.mm/run-success.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/verify.cpp/wrong-diagnostic.verify.cpp
The file was addedlibcxx/test/libcxx/selftest/convenience_substitutions/build_run.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/verify.cpp/no-diagnostics-unmarked.verify.cpp
The file was addedlibcxx/test/libcxx/selftest/shell-escape-pipes.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/link.fail.cpp/compile-error.link.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.pass.cpp/link-error.link.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/sh.cpp/substitutions.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/convenience_substitutions/build_run.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/compile-success.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/sh.cpp/empty.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/compile-success.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/run.fail.cpp/compile-error.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.pass.cpp/link-success.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.cpp/link-error.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/link.fail.cpp/link-success.link.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/link.fail.cpp/link-error.link.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/compile.fail.cpp/compile-error.compile.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/run-success.pass.mm
The file was addedlibcxx/test/libcxx/selftest/additional_compile_flags/substitutes-in-run.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/right-diagnostic.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/lit.local.cfg
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/compile-error.pass.mm
The file was addedlibcxx/test/libcxx/selftest/pass.cpp/compile-error.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/verify.cpp/wrong-diagnostic.verify.cpp
The file was modifiedlibcxx/utils/libcxx/test/dsl.py
The file was addedlibcxx/test/libcxx/selftest/compile.fail.cpp/compile-success.compile.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/file_dependencies/a.txt
The file was addedlibcxx/test/libcxx/selftest/compile.pass.cpp/run-error.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.cpp/compile-error.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/sh.cpp/run-success.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/verify.cpp/no-werror.verify.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.fail.cpp/link-error.link.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/lit.local.cfg
The file was addedlibcxx/test/libcxx/selftest/compile.pass.cpp/link-error.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/wrong-diagnostic.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/tmpdir-exists.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/remote-substitutions.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/file_dependencies/substitute-in-dependencies.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/wrong-diagnostic.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.pass.cpp/run-error.link.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/sh.cpp/werror.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/file_dependencies/substitute-in-dependencies.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/shell-escape-pipes.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/shell-escape.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.fail.cpp/compile-success.compile.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/verify.cpp/right-diagnostic.verify.cpp
The file was addedlibcxx/utils/libcxx/test/format.py
The file was addedlibcxx/test/libcxx/selftest/sh.cpp/empty.sh.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.mm/run-error.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.cpp/run-error.pass.cpp
The file was modifiedlibcxxabi/test/lit.site.cfg.in
The file was addedlibcxx/test/libcxx/selftest/file_dependencies/dir/b.txt
The file was addedlibcxx/test/libcxx/selftest/pass.cpp/run-error.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/link.pass.cpp/compile-error.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/pass.mm/run-error.pass.mm
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.pass.cpp/compile-success.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/file_dependencies/dir/b.txt
The file was addedlibcxx/test/libcxx/selftest/run.fail.cpp/run-success.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/file_dependencies/absolute-and-relative-paths.sh.cpp
The file was modifiedlibcxx/test/lit.site.cfg.in
The file was removedlibcxx/test/libcxx/selftest/newformat/link.pass.cpp/compile-error.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/run.fail.cpp/compile-error.run.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/additional_compile_flags/substitutes-in-compile-flags.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/fail.cpp/right-diagnostic.fail.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/compile.pass.cpp/link-error.compile.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/file_dependencies/a.txt
The file was addedlibcxx/test/libcxx/selftest/sh.cpp/run-error.sh.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/link.fail.cpp/link-success.link.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.cpp/werror.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/link.pass.cpp/link-error.link.pass.cpp
The file was removedlibcxx/test/libcxx/selftest/newformat/run.fail.cpp/run-error.run.fail.cpp
The file was addedlibcxx/test/libcxx/selftest/pass.cpp/link-error.pass.cpp
The file was addedlibcxx/test/libcxx/selftest/fail.cpp/lit.local.cfg
The file was removedlibcxx/test/libcxx/selftest/newformat/additional_compile_flags/substitutes-in-run.sh.cpp
Commit d285f29317d6086e9ab941730f1ee5a468196a4e by hokein.wu
[AST][RecoveryExpr] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

Differential Revision: https://reviews.llvm.org/D82631
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was addedclang/test/SemaTemplate/nss-recovery.cpp
The file was modifiedclang/lib/AST/NestedNameSpecifier.cpp
The file was modifiedclang/include/clang/AST/NestedNameSpecifier.h
Commit e9c6b63d4a16c7955bf0e7d5c1ab4adbb9d385cc by ulrich.weigand
[SystemZ] Simplify knownbits.ll test

The knownbits.ll test case is somewhat fragile since:
- it relies on undef inputs; and
- it operates just at the limits of the MaxRecursionDepth

This means that optimization changes may easily cause the test
to spuriously fail.  Rewrite the test so it still validates
the same thing, but in a less fragile manner.
The file was modifiedllvm/test/CodeGen/SystemZ/knownbits.ll
Commit ce404c8b854b18ca2aaa9529986b3eced73793a3 by gchatelet
[NFC] Remove dead code

Differential Revision: https://reviews.llvm.org/D81195
The file was modifiedllvm/include/llvm/CodeGen/CallingConvLower.h