FailedChanges

Summary

  1. [lldb] Delete useless assertion (details)
  2. [lldb/test] Remove JOIN_CMD from Makefile.rules (details)
  3. CodeGenPrep: remove AssertingVH references before deleting dead instructions. (details)
  4. Revert "[lldb] Use the basename of the Python test for the log name instead of the class name" (details)
  5. [TSan] Optimize handling of racy address (details)
Commit f819d257982e6c3f1fb57de4252b46bdfaa9415a by pavel
[lldb] Delete useless assertion

It served a puprose while we were using the test name to provide a name
for the created file. Now that the files are created in memory, we don't
need that.
The file was modifiedlldb/unittests/TestingSupport/TestUtilities.cpp
Commit 313fca6520b43d95abb73e7c78a252a60ee4cf48 by pavel
[lldb/test] Remove JOIN_CMD from Makefile.rules

It's possible to achieve the same effect by providing multi-step recipe
instead of a single-step recipe where the step happens to contain
multiple commands.
The file was modifiedlldb/packages/Python/lldbsuite/test/make/Makefile.rules
Commit 37b96d51d0cfc82a64598aaae2a567fa77e44de9 by Tim Northover
CodeGenPrep: remove AssertingVH references before deleting dead instructions.

CodeGenPrepare keeps fairly close track of various instructions it's
seen, particularly GEPs, in maps and vectors. However, sometimes those
instructions become dead and get removed while it's still executing.
This triggers AssertingVH references to them in an asserts build and
could lead to miscompiles in a release build (I've only seen a later
segfault though).

So this patch adds a callback to
RecursivelyDeleteTriviallyDeadInstructions which can make sure the
instruction about to be deleted is removed from CodeGenPrepare's data
structures.
The file was modifiedllvm/include/llvm/Transforms/Utils/Local.h
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
The file was modifiedllvm/lib/CodeGen/CodeGenPrepare.cpp
The file was addedllvm/test/Transforms/CodeGenPrepare/ARM/dead-gep.ll
Commit 9c1c6a3fcca840b75a0ae818ac4e24e7460c397b by Raphael Isemann
Revert "[lldb] Use the basename of the Python test for the log name instead of the class name"

This reverts commit 29aab9b5c748b28b231e2ca0f9b95453638ade1a.

It seems on Windows the file name is just always "lldbsuite.test.lldbtest" for
all tests and that breaks pretty much everything. Reverting until we have
a better solution.
The file was modifiedlldb/test/API/CMakeLists.txt
Commit 00e3a1ddec95c0b48ce216220d7e3481dab3bc78 by protze
[TSan] Optimize handling of racy address

This patch splits the handling of racy address and racy stack into separate
functions. If a race was already reported for the address, we can avoid the
cost for collecting the involved stacks.

This patch also removes the race condition in storing the racy address / racy
stack. This race condition allowed all threads to report the race.

This patch changes the transitive suppression of reports. Previously
suppression could transitively chain memory location and racy stacks.
Now racy memory and racy stack are separate suppressions.

Reviewed by: dvyukov

Differential Revision: https://reviews.llvm.org/D83625
The file was modifiedcompiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp