SuccessChanges

Summary

  1. [Clang] Avoid whitespace in fixit note (details)
  2. [Clang] Fixed buildboit failure; bot defaults to older C++ standard (details)
  3. Change the default target CPU for OpenBSD/i386 to i586 (details)
  4. Fix MSVC "not all control paths return a value" warning. NFC. (details)
  5. [InstCombine] Use CreateVectorSplat(ElementCount) variant directly (details)
  6. [X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places (details)
  7. [X86][SSE] combineTargetShuffle - use scaleShuffleMask helper to widen shuffle mask. NFCI. (details)
  8. [FileCheckTest] Supress new warning (details)
  9. Revert "[X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places" (details)
  10. Recommit "[X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places" (details)
  11. [LLDB] Fix timeout value on expect_gdbremote_sequence (details)
  12. [X86] Remove isSafeToClobberEFLAGS helper and just inline it into the call sites. (details)
Commit 0fef780aa70b48551ae6df373955b5e4f5130fa4 by Dávid Bolvanský
[Clang] Avoid whitespace in fixit note
The file was modifiedclang/lib/Sema/SemaExpr.cpp
Commit 6cd23558d3a9fbe8bc73e96d4df4e52c8261d1b5 by Dávid Bolvanský
[Clang] Fixed buildboit failure; bot defaults to older C++ standard
The file was modifiedclang/test/Sema/string-concat.c
Commit cd5ab56bc406c3f9a6f593f98c63dafb53547ab1 by brad
Change the default target CPU for OpenBSD/i386 to i586
The file was modifiedclang/lib/Driver/ToolChains/Arch/X86.cpp
The file was modifiedclang/test/Driver/openbsd.c
Commit 090f9d5a55338ee815f5a6ef7aaa1ed712f65e05 by llvm-dev
Fix MSVC "not all control paths return a value" warning. NFC.
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
Commit f13e92d4b273db255c6955eb7f2269caf1eb60c3 by llvm-dev
[InstCombine] Use CreateVectorSplat(ElementCount) variant directly

This was introduced at rGe20223672100, and the CreateVectorSplat(unsigned NumElements) variant calls it internally
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
Commit 44b260cb0aab387d85e4d59c16fc7b8866264f5e by craig.topper
[X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places

Previously this function searched 4 instructions forwards or
backwards to determine if it was ok to clobber eflags.

This is called in 3 places: rematerialization, turning 2 operand
leas into adds or splitting 3 ops leas into an lea and add on some
CPU targets.

This patch increases the search limit to 10 instructions for
rematerialization and 2 operand lea to add. I've left the old
treshold for 3 ops lea spliting as that increases code size.

Fixes PR47024 and PR43014
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.h
The file was modifiedllvm/lib/Target/X86/X86FixupLEAs.cpp
The file was modifiedllvm/test/CodeGen/X86/optimize-max-0.ll
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.cpp
Commit cc15380f103f09bc447cd3f22bcdbedca7447b97 by llvm-dev
[X86][SSE] combineTargetShuffle - use scaleShuffleMask helper to widen shuffle mask. NFCI.

Use scaleShuffleMask helper for the shuffle(hadd,hadd) canonicalization.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 4cc914280fbe7b3e3e0f921da2b805e23a68f088 by Dávid Bolvanský
[FileCheckTest] Supress new warning
The file was modifiedllvm/unittests/Support/FileCheckTest.cpp
Commit 761f568420a5738a064a0d4203a0f2d783343102 by craig.topper
Revert "[X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places"

This reverts commit 44b260cb0aab387d85e4d59c16fc7b8866264f5e.

I messed up the bug number in the commit message so I'm reverting
to fix it.
The file was modifiedllvm/test/CodeGen/X86/optimize-max-0.ll
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.h
The file was modifiedllvm/lib/Target/X86/X86FixupLEAs.cpp
Commit 8d3ae64b0403a2718c7e9c21a6595575af040ffc by craig.topper
Recommit "[X86] Increase the number of instructions searched for isSafeToClobberEFLAGS in a couple places"

I messed up the bug numbers in the commit message before

Previously this function searched 4 instructions forwards or
backwards to determine if it was ok to clobber eflags.

This is called in 3 places: rematerialization, turning 2 operand
leas into adds or splitting 3 ops leas into an lea and add on some
CPU targets.

This patch increases the search limit to 10 instructions for
rematerialization and 2 operand lea to add. I've left the old
treshold for 3 ops lea spliting as that increases code size.

Fixes PR47024 and PR46315.
The file was modifiedllvm/test/CodeGen/X86/optimize-max-0.ll
The file was modifiedllvm/lib/Target/X86/X86FixupLEAs.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.h
The file was addedllvm/test/CodeGen/X86/pr47024.ll
Commit c888694a8edaf2794fc5960a3c1087fbed37ba92 by omair.javaid
[LLDB] Fix timeout value on expect_gdbremote_sequence

D83904 seems to have changed timeout value on expect_gdbremote_sequence which
was 120 previously. This seems to be causing intermittent failures on
lldb-aarch64-ubuntu buildbot.

This patch fixes the timeout value to see the impact on test suite.

Example:
http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/7401/steps/test/logs/stdio

Differential Revision: https://reviews.llvm.org/D85514
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Commit 815a9b256b909572c3161dab056b48b1791d8fbc by craig.topper
[X86] Remove isSafeToClobberEFLAGS helper and just inline it into the call sites.

This is just a thin wrapper around computeRegisterLivness which
we can just call directly. The only real difference is that
isSafeToClobberEFLAGS returns a bool and computeRegisterLivness
returns an enum. So we need to check for the specific enum value
that isSafeToClobberEFLAGS was hiding.

I've also adjusted which sites pass an explicit value for
Neighborhood since the default for computeRegisterLivness is 10.
The file was modifiedllvm/lib/Target/X86/X86FixupLEAs.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.h
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.cpp