SuccessChanges

Summary

  1. [RISCV] Fix ICE in isDesirableToCommuteWithShift Summary: There was an error being thrown from isDesirableToCommuteWithShift in some tests. This was tracked down to the method being called before legalisation, with an extended value type, not a machine value type. In the case I diagnosed, the error was only hit with an instruction sequence involving `i24`s in the add and shift. `i24` is not a Machine ValueType, it is instead an Extended ValueType which was causing the issue. I have added a test to cover this case, and fixed the error in the callback. Reviewers: asb, luismarques Reviewed By: asb Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64425
  2. [AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches If we have an icmp->brcond->br sequence where the brcond just branches to the next block jumping over the br, while the br takes the false edge, then we can modify the conditional branch to jump to the br's target while inverting the condition of the incoming icmp. This means we can eliminate the br as an unconditional branch to the fallthrough block. Differential Revision: https://reviews.llvm.org/D64354
  3. [mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU
  4. [mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC Support for 64-bit coprocessors on a 32-bit architecture was added in `MIPS32 R2`.
  5. [NFC] Fixed tests
  6. [DAGCombine] LoadedSlice - keep getOffsetFromBase() uint64_t offset. NFCI. Keep the uint64_t type from getOffsetFromBase() to stop truncation/extension overflow warnings in MSVC in alignment math.
  7. [BPF] Support for compile once and run everywhere Introduction ============ This patch added intial support for bpf program compile once and run everywhere (CO-RE). The main motivation is for bpf program which depends on kernel headers which may vary between different kernel versions. The initial discussion can be found at https://lwn.net/Articles/773198/. Currently, bpf program accesses kernel internal data structure through bpf_probe_read() helper. The idea is to capture the kernel data structure to be accessed through bpf_probe_read() and relocate them on different kernel versions. On each host, right before bpf program load, the bpfloader will look at the types of the native linux through vmlinux BTF, calculates proper access offset and patch the instruction. To accommodate this, three intrinsic functions preserve_{array,union,struct}_access_index are introduced which in clang will preserve the base pointer, struct/union/array access_index and struct/union debuginfo type information. Later, bpf IR pass can reconstruct the whole gep access chains without looking at gep itself. This patch did the following: . An IR pass is added to convert preserve_*_access_index to global variable who name encodes the getelementptr access pattern. The global variable has metadata attached to describe the corresponding struct/union debuginfo type. . An SimplifyPatchable MachineInstruction pass is added to remove unnecessary loads. . The BTF output pass is enhanced to generate relocation records located in .BTF.ext section. Typical CO-RE also needs support of global variables which can be assigned to different values to different hosts. For example, kernel version can be used to guard different versions of codes. This patch added the support for patchable externals as well. Example ======= The following is an example. struct pt_regs { long arg1; long arg2; }; struct sk_buff { int i; struct net_device *dev; }; #define _(x) (__builtin_preserve_access_index(x)) static int (*bpf_probe_read)(void *dst, int size, const void *unsafe_ptr) = (void *) 4; extern __attribute__((section(".BPF.patchable_externs"))) unsigned __kernel_version; int bpf_prog(struct pt_regs *ctx) { struct net_device *dev = 0; // ctx->arg* does not need bpf_probe_read if (__kernel_version >= 41608) bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg1)->dev)); else bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg2)->dev)); return dev != 0; } In the above, we want to translate the third argument of bpf_probe_read() as relocations. -bash-4.4$ clang -target bpf -O2 -g -S trace.c The compiler will generate two new subsections in .BTF.ext, OffsetReloc and ExternReloc. OffsetReloc is to record the structure member offset operations, and ExternalReloc is to record the external globals where only u8, u16, u32 and u64 are supported. BPFOffsetReloc Size struct SecLOffsetReloc for ELF section #1 A number of struct BPFOffsetReloc for ELF section #1 struct SecOffsetReloc for ELF section #2 A number of struct BPFOffsetReloc for ELF section #2 ... BPFExternReloc Size struct SecExternReloc for ELF section #1 A number of struct BPFExternReloc for ELF section #1 struct SecExternReloc for ELF section #2 A number of struct BPFExternReloc for ELF section #2 struct BPFOffsetReloc { uint32_t InsnOffset; ///< Byte offset in this section uint32_t TypeID; ///< TypeID for the relocation uint32_t OffsetNameOff; ///< The string to traverse types }; struct BPFExternReloc { uint32_t InsnOffset; ///< Byte offset in this section uint32_t ExternNameOff; ///< The string for external variable }; Note that only externs with attribute section ".BPF.patchable_externs" are considered for Extern Reloc which will be patched by bpf loader right before the load. For the above test case, two offset records and one extern record will be generated: OffsetReloc records: .long .Ltmp12 # Insn Offset .long 7 # TypeId .long 242 # Type Decode String .long .Ltmp18 # Insn Offset .long 7 # TypeId .long 242 # Type Decode String ExternReloc record: .long .Ltmp5 # Insn Offset .long 165 # External Variable In string table: .ascii "0:1" # string offset=242 .ascii "__kernel_version" # string offset=165 The default member offset can be calculated as the 2nd member offset (0 representing the 1st member) of struct "sk_buff". The asm code: .Ltmp5: .Ltmp6: r2 = 0 r3 = 41608 .Ltmp7: .Ltmp8: .loc 1 18 9 is_stmt 0 # t.c:18:9 .Ltmp9: if r3 > r2 goto LBB0_2 .Ltmp10: .Ltmp11: .loc 1 0 9 # t.c:0:9 .Ltmp12: r2 = 8 .Ltmp13: .loc 1 19 66 is_stmt 1 # t.c:19:66 .Ltmp14: .Ltmp15: r3 = *(u64 *)(r1 + 0) goto LBB0_3 .Ltmp16: .Ltmp17: LBB0_2: .loc 1 0 66 is_stmt 0 # t.c:0:66 .Ltmp18: r2 = 8 .loc 1 21 66 is_stmt 1 # t.c:21:66 .Ltmp19: r3 = *(u64 *)(r1 + 8) .Ltmp20: .Ltmp21: LBB0_3: .loc 1 0 66 is_stmt 0 # t.c:0:66 r3 += r2 r1 = r10 .Ltmp22: .Ltmp23: .Ltmp24: r1 += -8 r2 = 8 call 4 For instruction .Ltmp12 and .Ltmp18, "r2 = 8", the number 8 is the structure offset based on the current BTF. Loader needs to adjust it if it changes on the host. For instruction .Ltmp5, "r2 = 0", the external variable got a default value 0, loader needs to supply an appropriate value for the particular host. Compiling to generate object code and disassemble: 0000000000000000 bpf_prog: 0: b7 02 00 00 00 00 00 00 r2 = 0 1: 7b 2a f8 ff 00 00 00 00 *(u64 *)(r10 - 8) = r2 2: b7 02 00 00 00 00 00 00 r2 = 0 3: b7 03 00 00 88 a2 00 00 r3 = 41608 4: 2d 23 03 00 00 00 00 00 if r3 > r2 goto +3 <LBB0_2> 5: b7 02 00 00 08 00 00 00 r2 = 8 6: 79 13 00 00 00 00 00 00 r3 = *(u64 *)(r1 + 0) 7: 05 00 02 00 00 00 00 00 goto +2 <LBB0_3> 0000000000000040 LBB0_2: 8: b7 02 00 00 08 00 00 00 r2 = 8 9: 79 13 08 00 00 00 00 00 r3 = *(u64 *)(r1 + 8) 0000000000000050 LBB0_3: 10: 0f 23 00 00 00 00 00 00 r3 += r2 11: bf a1 00 00 00 00 00 00 r1 = r10 12: 07 01 00 00 f8 ff ff ff r1 += -8 13: b7 02 00 00 08 00 00 00 r2 = 8 14: 85 00 00 00 04 00 00 00 call 4 Instructions #2, #5 and #8 need relocation resoutions from the loader. Signed-off-by: Yonghong Song <yhs@fb.com> Differential Revision: https://reviews.llvm.org/D61524
  8. [ADT] Remove MSVC-only "no two-phase name lookup" typename path. Now that we've dropped VS2015 support (D64326) we can use the regular codepath as VS2017+ correctly handles it
  9. [NFC] Added tests for D64285
  10. [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable() Differential Revision: https://reviews.llvm.org/D64197
Revision 365511 by lenary:
[RISCV] Fix ICE in isDesirableToCommuteWithShift

Summary:
There was an error being thrown from isDesirableToCommuteWithShift in
some tests. This was tracked down to the method being called before
legalisation, with an extended value type, not a machine value type.

In the case I diagnosed, the error was only hit with an instruction sequence
involving `i24`s in the add and shift. `i24` is not a Machine ValueType, it is
instead an Extended ValueType which was causing the issue.

I have added a test to cover this case, and fixed the error in the callback.

Reviewers: asb, luismarques

Reviewed By: asb

Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64425
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/RISCV/RISCVISelLowering.cpptrunk/lib/Target/RISCV/RISCVISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/RISCV/add-before-shl.lltrunk/test/CodeGen/RISCV/add-before-shl.ll
Revision 365510 by aemerson:
[AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches

If we have an icmp->brcond->br sequence where the brcond just branches to the
next block jumping over the br, while the br takes the false edge, then we can
modify the conditional branch to jump to the br's target while inverting the
condition of the incoming icmp. This means we can eliminate the br as an
unconditional branch to the fallthrough block.

Differential Revision: https://reviews.llvm.org/D64354
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/GlobalISel/CombinerHelper.htrunk/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
The file was modified/llvm/trunk/include/llvm/CodeGen/MachineOperand.htrunk/include/llvm/CodeGen/MachineOperand.h
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/CombinerHelper.cpptrunk/lib/CodeGen/GlobalISel/CombinerHelper.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpptrunk/lib/Target/AArch64/AArch64PreLegalizerCombiner.cpp
The file was modified/llvm/trunk/test/CodeGen/AArch64/GlobalISel/localizer-arm64-tti.lltrunk/test/CodeGen/AArch64/GlobalISel/localizer-arm64-tti.ll
The file was added/llvm/trunk/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-br.mirtrunk/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-br.mir
The file was modified/llvm/trunk/test/CodeGen/AArch64/speculation-hardening.lltrunk/test/CodeGen/AArch64/speculation-hardening.ll
Revision 365508 by atanasyan:
[mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsSubtarget.cpptrunk/lib/Target/Mips/MipsSubtarget.cpp
The file was modified/llvm/trunk/test/CodeGen/Mips/fp64a.lltrunk/test/CodeGen/Mips/fp64a.ll
Revision 365507 by atanasyan:
[mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC

Support for 64-bit coprocessors on a 32-bit architecture
was added in `MIPS32 R2`.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/Mips/abiflags32.lltrunk/test/CodeGen/Mips/abiflags32.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/cconv/callee-saved-fpxx1.lltrunk/test/CodeGen/Mips/cconv/callee-saved-fpxx1.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/cconv/return-hard-float.lltrunk/test/CodeGen/Mips/cconv/return-hard-float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/cfi_offset.lltrunk/test/CodeGen/Mips/cfi_offset.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/fp-contract.lltrunk/test/CodeGen/Mips/fp-contract.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/fp64a.lltrunk/test/CodeGen/Mips/fp64a.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2r.lltrunk/test/CodeGen/Mips/msa/2r.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2r_vector_scalar.lltrunk/test/CodeGen/Mips/msa/2r_vector_scalar.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf.lltrunk/test/CodeGen/Mips/msa/2rf.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf_exup.lltrunk/test/CodeGen/Mips/msa/2rf_exup.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf_float_int.lltrunk/test/CodeGen/Mips/msa/2rf_float_int.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf_fq.lltrunk/test/CodeGen/Mips/msa/2rf_fq.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf_int_float.lltrunk/test/CodeGen/Mips/msa/2rf_int_float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/2rf_tq.lltrunk/test/CodeGen/Mips/msa/2rf_tq.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-a.lltrunk/test/CodeGen/Mips/msa/3r-a.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-b.lltrunk/test/CodeGen/Mips/msa/3r-b.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-c.lltrunk/test/CodeGen/Mips/msa/3r-c.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-d.lltrunk/test/CodeGen/Mips/msa/3r-d.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-i.lltrunk/test/CodeGen/Mips/msa/3r-i.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-m.lltrunk/test/CodeGen/Mips/msa/3r-m.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-p.lltrunk/test/CodeGen/Mips/msa/3r-p.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-s.lltrunk/test/CodeGen/Mips/msa/3r-s.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r-v.lltrunk/test/CodeGen/Mips/msa/3r-v.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r_4r.lltrunk/test/CodeGen/Mips/msa/3r_4r.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3r_4r_widen.lltrunk/test/CodeGen/Mips/msa/3r_4r_widen.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf.lltrunk/test/CodeGen/Mips/msa/3rf.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_4rf.lltrunk/test/CodeGen/Mips/msa/3rf_4rf.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_4rf_q.lltrunk/test/CodeGen/Mips/msa/3rf_4rf_q.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_exdo.lltrunk/test/CodeGen/Mips/msa/3rf_exdo.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_float_int.lltrunk/test/CodeGen/Mips/msa/3rf_float_int.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_int_float.lltrunk/test/CodeGen/Mips/msa/3rf_int_float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/3rf_q.lltrunk/test/CodeGen/Mips/msa/3rf_q.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/arithmetic.lltrunk/test/CodeGen/Mips/msa/arithmetic.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/arithmetic_float.lltrunk/test/CodeGen/Mips/msa/arithmetic_float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/basic_operations_float.lltrunk/test/CodeGen/Mips/msa/basic_operations_float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/bit.lltrunk/test/CodeGen/Mips/msa/bit.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/bitcast.lltrunk/test/CodeGen/Mips/msa/bitcast.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/bitwise.lltrunk/test/CodeGen/Mips/msa/bitwise.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/bmzi_bmnzi.lltrunk/test/CodeGen/Mips/msa/bmzi_bmnzi.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/compare.lltrunk/test/CodeGen/Mips/msa/compare.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/compare_float.lltrunk/test/CodeGen/Mips/msa/compare_float.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/elm_copy.lltrunk/test/CodeGen/Mips/msa/elm_copy.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/elm_cxcmsa.lltrunk/test/CodeGen/Mips/msa/elm_cxcmsa.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/elm_insv.lltrunk/test/CodeGen/Mips/msa/elm_insv.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/elm_move.lltrunk/test/CodeGen/Mips/msa/elm_move.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/elm_shift_slide.lltrunk/test/CodeGen/Mips/msa/elm_shift_slide.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/endian.lltrunk/test/CodeGen/Mips/msa/endian.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/frameindex.lltrunk/test/CodeGen/Mips/msa/frameindex.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i10.lltrunk/test/CodeGen/Mips/msa/i10.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5-a.lltrunk/test/CodeGen/Mips/msa/i5-a.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5-b.lltrunk/test/CodeGen/Mips/msa/i5-b.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5-c.lltrunk/test/CodeGen/Mips/msa/i5-c.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5-m.lltrunk/test/CodeGen/Mips/msa/i5-m.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5-s.lltrunk/test/CodeGen/Mips/msa/i5-s.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i5_ld_st.lltrunk/test/CodeGen/Mips/msa/i5_ld_st.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/i8.lltrunk/test/CodeGen/Mips/msa/i8.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/immediates-bad.lltrunk/test/CodeGen/Mips/msa/immediates-bad.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/immediates.lltrunk/test/CodeGen/Mips/msa/immediates.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/inline-asm.lltrunk/test/CodeGen/Mips/msa/inline-asm.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s1704963983.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s1704963983.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s1935737938.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s1935737938.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s2090927243-simplified.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s2090927243-simplified.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s2501752154-simplified.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s2501752154-simplified.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s2704903805.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s2704903805.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s3861334421.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s3861334421.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s3926023935.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s3926023935.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s3997499501.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s3997499501.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s449609655-simplified.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s449609655-simplified.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s525530439.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s525530439.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-s997348632.lltrunk/test/CodeGen/Mips/msa/llvm-stress-s997348632.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/llvm-stress-sz1-s742806235.lltrunk/test/CodeGen/Mips/msa/llvm-stress-sz1-s742806235.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/shift-dagcombine.lltrunk/test/CodeGen/Mips/msa/shift-dagcombine.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/shift_constant_pool.lltrunk/test/CodeGen/Mips/msa/shift_constant_pool.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/shift_no_and.lltrunk/test/CodeGen/Mips/msa/shift_no_and.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/shuffle.lltrunk/test/CodeGen/Mips/msa/shuffle.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/special.lltrunk/test/CodeGen/Mips/msa/special.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/spill.lltrunk/test/CodeGen/Mips/msa/spill.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/vec.lltrunk/test/CodeGen/Mips/msa/vec.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/msa/vecs10.lltrunk/test/CodeGen/Mips/msa/vecs10.ll
The file was modified/llvm/trunk/test/CodeGen/Mips/stack-alignment.lltrunk/test/CodeGen/Mips/stack-alignment.ll
Revision 365506 by xbolva00:
[NFC] Fixed tests
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstSimplify/ashr-lshr.lltrunk/test/Transforms/InstSimplify/ashr-lshr.ll
Revision 365504 by rksimon:
[DAGCombine] LoadedSlice - keep getOffsetFromBase() uint64_t offset. NFCI.

Keep the uint64_t type from getOffsetFromBase() to stop truncation/extension overflow warnings in MSVC in alignment math.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpptrunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Revision 365503 by yhs:
[BPF] Support for compile once and run everywhere

Introduction
============

This patch added intial support for bpf program compile once
and run everywhere (CO-RE).

The main motivation is for bpf program which depends on
kernel headers which may vary between different kernel versions.
The initial discussion can be found at https://lwn.net/Articles/773198/.

Currently, bpf program accesses kernel internal data structure
through bpf_probe_read() helper. The idea is to capture the
kernel data structure to be accessed through bpf_probe_read()
and relocate them on different kernel versions.

On each host, right before bpf program load, the bpfloader
will look at the types of the native linux through vmlinux BTF,
calculates proper access offset and patch the instruction.

To accommodate this, three intrinsic functions
   preserve_{array,union,struct}_access_index
are introduced which in clang will preserve the base pointer,
struct/union/array access_index and struct/union debuginfo type
information. Later, bpf IR pass can reconstruct the whole gep
access chains without looking at gep itself.

This patch did the following:
  . An IR pass is added to convert preserve_*_access_index to
    global variable who name encodes the getelementptr
    access pattern. The global variable has metadata
    attached to describe the corresponding struct/union
    debuginfo type.
  . An SimplifyPatchable MachineInstruction pass is added
    to remove unnecessary loads.
  . The BTF output pass is enhanced to generate relocation
    records located in .BTF.ext section.

Typical CO-RE also needs support of global variables which can
be assigned to different values to different hosts. For example,
kernel version can be used to guard different versions of codes.
This patch added the support for patchable externals as well.

Example
=======

The following is an example.

  struct pt_regs {
    long arg1;
    long arg2;
  };
  struct sk_buff {
    int i;
    struct net_device *dev;
  };

  #define _(x) (__builtin_preserve_access_index(x))
  static int (*bpf_probe_read)(void *dst, int size, const void *unsafe_ptr) =
          (void *) 4;
  extern __attribute__((section(".BPF.patchable_externs"))) unsigned __kernel_version;
  int bpf_prog(struct pt_regs *ctx) {
    struct net_device *dev = 0;

    // ctx->arg* does not need bpf_probe_read
    if (__kernel_version >= 41608)
      bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg1)->dev));
    else
      bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg2)->dev));
    return dev != 0;
  }

In the above, we want to translate the third argument of
bpf_probe_read() as relocations.

  -bash-4.4$ clang -target bpf -O2 -g -S trace.c

The compiler will generate two new subsections in .BTF.ext,
OffsetReloc and ExternReloc.
OffsetReloc is to record the structure member offset operations,
and ExternalReloc is to record the external globals where
only u8, u16, u32 and u64 are supported.

   BPFOffsetReloc Size
   struct SecLOffsetReloc for ELF section #1
   A number of struct BPFOffsetReloc for ELF section #1
   struct SecOffsetReloc for ELF section #2
   A number of struct BPFOffsetReloc for ELF section #2
   ...
   BPFExternReloc Size
   struct SecExternReloc for ELF section #1
   A number of struct BPFExternReloc for ELF section #1
   struct SecExternReloc for ELF section #2
   A number of struct BPFExternReloc for ELF section #2

  struct BPFOffsetReloc {
    uint32_t InsnOffset;    ///< Byte offset in this section
    uint32_t TypeID;        ///< TypeID for the relocation
    uint32_t OffsetNameOff; ///< The string to traverse types
  };

  struct BPFExternReloc {
    uint32_t InsnOffset;    ///< Byte offset in this section
    uint32_t ExternNameOff; ///< The string for external variable
  };

Note that only externs with attribute section ".BPF.patchable_externs"
are considered for Extern Reloc which will be patched by bpf loader
right before the load.

For the above test case, two offset records and one extern record
will be generated:
  OffsetReloc records:
        .long   .Ltmp12                 # Insn Offset
        .long   7                       # TypeId
        .long   242                     # Type Decode String
        .long   .Ltmp18                 # Insn Offset
        .long   7                       # TypeId
        .long   242                     # Type Decode String

  ExternReloc record:
        .long   .Ltmp5                  # Insn Offset
        .long   165                     # External Variable

  In string table:
        .ascii  "0:1"                   # string offset=242
        .ascii  "__kernel_version"      # string offset=165

The default member offset can be calculated as
    the 2nd member offset (0 representing the 1st member) of struct "sk_buff".

The asm code:
    .Ltmp5:
    .Ltmp6:
            r2 = 0
            r3 = 41608
    .Ltmp7:
    .Ltmp8:
            .loc    1 18 9 is_stmt 0        # t.c:18:9
    .Ltmp9:
            if r3 > r2 goto LBB0_2
    .Ltmp10:
    .Ltmp11:
            .loc    1 0 9                   # t.c:0:9
    .Ltmp12:
            r2 = 8
    .Ltmp13:
            .loc    1 19 66 is_stmt 1       # t.c:19:66
    .Ltmp14:
    .Ltmp15:
            r3 = *(u64 *)(r1 + 0)
            goto LBB0_3
    .Ltmp16:
    .Ltmp17:
    LBB0_2:
            .loc    1 0 66 is_stmt 0        # t.c:0:66
    .Ltmp18:
            r2 = 8
            .loc    1 21 66 is_stmt 1       # t.c:21:66
    .Ltmp19:
            r3 = *(u64 *)(r1 + 8)
    .Ltmp20:
    .Ltmp21:
    LBB0_3:
            .loc    1 0 66 is_stmt 0        # t.c:0:66
            r3 += r2
            r1 = r10
    .Ltmp22:
    .Ltmp23:
    .Ltmp24:
            r1 += -8
            r2 = 8
            call 4

For instruction .Ltmp12 and .Ltmp18, "r2 = 8", the number
8 is the structure offset based on the current BTF.
Loader needs to adjust it if it changes on the host.

For instruction .Ltmp5, "r2 = 0", the external variable
got a default value 0, loader needs to supply an appropriate
value for the particular host.

Compiling to generate object code and disassemble:
   0000000000000000 bpf_prog:
           0:       b7 02 00 00 00 00 00 00         r2 = 0
           1:       7b 2a f8 ff 00 00 00 00         *(u64 *)(r10 - 8) = r2
           2:       b7 02 00 00 00 00 00 00         r2 = 0
           3:       b7 03 00 00 88 a2 00 00         r3 = 41608
           4:       2d 23 03 00 00 00 00 00         if r3 > r2 goto +3 <LBB0_2>
           5:       b7 02 00 00 08 00 00 00         r2 = 8
           6:       79 13 00 00 00 00 00 00         r3 = *(u64 *)(r1 + 0)
           7:       05 00 02 00 00 00 00 00         goto +2 <LBB0_3>

    0000000000000040 LBB0_2:
           8:       b7 02 00 00 08 00 00 00         r2 = 8
           9:       79 13 08 00 00 00 00 00         r3 = *(u64 *)(r1 + 8)

    0000000000000050 LBB0_3:
          10:       0f 23 00 00 00 00 00 00         r3 += r2
          11:       bf a1 00 00 00 00 00 00         r1 = r10
          12:       07 01 00 00 f8 ff ff ff         r1 += -8
          13:       b7 02 00 00 08 00 00 00         r2 = 8
          14:       85 00 00 00 04 00 00 00         call 4

Instructions #2, #5 and #8 need relocation resoutions from the loader.

Signed-off-by: Yonghong Song <yhs@fb.com>

Differential Revision: https://reviews.llvm.org/D61524
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/BPF/BPF.htrunk/lib/Target/BPF/BPF.h
The file was added/llvm/trunk/lib/Target/BPF/BPFAbstrctMemberAccess.cpptrunk/lib/Target/BPF/BPFAbstrctMemberAccess.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFAsmPrinter.cpptrunk/lib/Target/BPF/BPFAsmPrinter.cpp
The file was added/llvm/trunk/lib/Target/BPF/BPFCORE.htrunk/lib/Target/BPF/BPFCORE.h
The file was added/llvm/trunk/lib/Target/BPF/BPFMISimplifyPatchable.cpptrunk/lib/Target/BPF/BPFMISimplifyPatchable.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BPFTargetMachine.cpptrunk/lib/Target/BPF/BPFTargetMachine.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BTF.htrunk/lib/Target/BPF/BTF.h
The file was modified/llvm/trunk/lib/Target/BPF/BTFDebug.cpptrunk/lib/Target/BPF/BTFDebug.cpp
The file was modified/llvm/trunk/lib/Target/BPF/BTFDebug.htrunk/lib/Target/BPF/BTFDebug.h
The file was modified/llvm/trunk/lib/Target/BPF/CMakeLists.txttrunk/lib/Target/BPF/CMakeLists.txt
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/binary-format.lltrunk/test/CodeGen/BPF/BTF/binary-format.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/extern-global-var.lltrunk/test/CodeGen/BPF/BTF/extern-global-var.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/filename.lltrunk/test/CodeGen/BPF/BTF/filename.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-func-ptr.lltrunk/test/CodeGen/BPF/BTF/func-func-ptr.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-non-void.lltrunk/test/CodeGen/BPF/BTF/func-non-void.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-source.lltrunk/test/CodeGen/BPF/BTF/func-source.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-typedef.lltrunk/test/CodeGen/BPF/BTF/func-typedef.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-unused-arg.lltrunk/test/CodeGen/BPF/BTF/func-unused-arg.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/func-void.lltrunk/test/CodeGen/BPF/BTF/func-void.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/local-var.lltrunk/test/CodeGen/BPF/BTF/local-var.ll
The file was added/llvm/trunk/test/CodeGen/BPF/BTF/map-def.lltrunk/test/CodeGen/BPF/BTF/map-def.ll
The file was added/llvm/trunk/test/CodeGen/BPF/BTF/ptr-prune-type.lltrunk/test/CodeGen/BPF/BTF/ptr-prune-type.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-derived-type.lltrunk/test/CodeGen/BPF/BTF/static-var-derived-type.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-inited-sec.lltrunk/test/CodeGen/BPF/BTF/static-var-inited-sec.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-inited.lltrunk/test/CodeGen/BPF/BTF/static-var-inited.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-readonly-sec.lltrunk/test/CodeGen/BPF/BTF/static-var-readonly-sec.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-readonly.lltrunk/test/CodeGen/BPF/BTF/static-var-readonly.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-sec.lltrunk/test/CodeGen/BPF/BTF/static-var-sec.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var-zerolen-array.lltrunk/test/CodeGen/BPF/BTF/static-var-zerolen-array.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/BTF/static-var.lltrunk/test/CodeGen/BPF/BTF/static-var.ll
The file was added/llvm/trunk/test/CodeGen/BPF/COREtrunk/test/CodeGen/BPF/CORE
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/offset-reloc-basic.lltrunk/test/CodeGen/BPF/CORE/offset-reloc-basic.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/offset-reloc-multilevel.lltrunk/test/CodeGen/BPF/CORE/offset-reloc-multilevel.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/offset-reloc-struct-anonymous.lltrunk/test/CodeGen/BPF/CORE/offset-reloc-struct-anonymous.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/offset-reloc-struct-array.lltrunk/test/CodeGen/BPF/CORE/offset-reloc-struct-array.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/offset-reloc-union.lltrunk/test/CodeGen/BPF/CORE/offset-reloc-union.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/patchable-extern-char.lltrunk/test/CodeGen/BPF/CORE/patchable-extern-char.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/patchable-extern-uint.lltrunk/test/CodeGen/BPF/CORE/patchable-extern-uint.ll
The file was added/llvm/trunk/test/CodeGen/BPF/CORE/patchable-extern-ulonglong.lltrunk/test/CodeGen/BPF/CORE/patchable-extern-ulonglong.ll
The file was modified/llvm/trunk/test/CodeGen/BPF/reloc-btf-2.lltrunk/test/CodeGen/BPF/reloc-btf-2.ll
Revision 365502 by rksimon:
[ADT] Remove MSVC-only "no two-phase name lookup" typename path.

Now that we've dropped VS2015 support (D64326) we can use the regular codepath as VS2017+ correctly handles it
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/unittests/ADT/DenseMapTest.cpptrunk/unittests/ADT/DenseMapTest.cpp
Revision 365501 by xbolva00:
[NFC] Added tests for D64285
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/InstSimplify/ashr-lshr.lltrunk/test/Transforms/InstSimplify/ashr-lshr.ll
Revision 365497 by shchenz:
[HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()

Differential Revision: https://reviews.llvm.org/D64197
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.htrunk/include/llvm/Analysis/TargetTransformInfo.h
The file was modified/llvm/trunk/lib/Analysis/TargetTransformInfo.cpptrunk/lib/Analysis/TargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/CodeGen/HardwareLoops.cpptrunk/lib/CodeGen/HardwareLoops.cpp

Summary

  1. Revert Revert Devirtualize destructor of final class. Revert r364359 and recommit r364100. r364100 was reverted as r364359 due to an internal test failure, but it was a false alarm.
  2. [OpenCL][Sema] Improve address space support for blocks Summary: This patch ensures that the following code is compiled identically with -cl-std=CL2.0 and -fblocks -cl-std=c++. kernel void test(void) { void (^const block_A)(void) = ^{ return; }; } A new test is not added because cl20-device-side-enqueue.cl will cover this once blocks are further improved for C++ for OpenCL. The changes to Sema::PerformImplicitConversion are based on the parts of Sema::CheckAssignmentConstraints on block pointer conversions. Reviewers: rjmccall, Anastasia Subscribers: yaxunl, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64083
  3. [OpenCL][Sema] Fix builtin rewriting This patch ensures built-in functions are rewritten using the proper parent declaration. Existing tests are modified to run in C++ mode to ensure the functionality works also with C++ for OpenCL while not increasing the testing runtime.
  4. Ignore trailing NullStmts in StmtExprs for GCC compatibility. Ignore trailing NullStmts in compound expressions when determining the result type and value. This is to match the GCC behavior which ignores semicolons at the end of compound expressions. Patch by Dominic Ferreira.
Revision 365509 by yamauchi:
Revert Revert Devirtualize destructor of final class.

Revert r364359 and recommit r364100.

r364100 was reverted as r364359 due to an internal test failure, but it was a
false alarm.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGExprCXX.cpptrunk/lib/CodeGen/CGExprCXX.cpp
The file was added/cfe/trunk/test/CodeGenCXX/devirtualize-dtor-final.cpptrunk/test/CodeGenCXX/devirtualize-dtor-final.cpp
Revision 365500 by mantognini:
[OpenCL][Sema] Improve address space support for blocks

Summary:
This patch ensures that the following code is compiled identically with
-cl-std=CL2.0 and -fblocks -cl-std=c++.

    kernel void test(void) {
      void (^const block_A)(void) = ^{
        return;
      };
    }

A new test is not added because cl20-device-side-enqueue.cl will cover
this once blocks are further improved for C++ for OpenCL.

The changes to Sema::PerformImplicitConversion are based on
the parts of Sema::CheckAssignmentConstraints on block pointer
conversions.

Reviewers: rjmccall, Anastasia

Subscribers: yaxunl, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64083
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaExprCXX.cpptrunk/lib/Sema/SemaExprCXX.cpp
Revision 365499 by mantognini:
[OpenCL][Sema] Fix builtin rewriting

This patch ensures built-in functions are rewritten using the proper
parent declaration.

Existing tests are modified to run in C++ mode to ensure the
functionality works also with C++ for OpenCL while not increasing the
testing runtime.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/Builtins.deftrunk/include/clang/Basic/Builtins.def
The file was modified/cfe/trunk/lib/Sema/SemaExpr.cpptrunk/lib/Sema/SemaExpr.cpp
The file was modified/cfe/trunk/test/CodeGenOpenCL/builtins.cltrunk/test/CodeGenOpenCL/builtins.cl
The file was modified/cfe/trunk/test/CodeGenOpenCL/pipe_builtin.cltrunk/test/CodeGenOpenCL/pipe_builtin.cl
The file was modified/cfe/trunk/test/CodeGenOpenCL/to_addr_builtin.cltrunk/test/CodeGenOpenCL/to_addr_builtin.cl
Revision 365498 by aaronballman:
Ignore trailing NullStmts in StmtExprs for GCC compatibility.

Ignore trailing NullStmts in compound expressions when determining the result type and value. This is to match the GCC behavior which ignores semicolons at the end of compound expressions.

Patch by Dominic Ferreira.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/Stmt.htrunk/include/clang/AST/Stmt.h
The file was modified/cfe/trunk/lib/CodeGen/CGStmt.cpptrunk/lib/CodeGen/CGStmt.cpp
The file was modified/cfe/trunk/lib/Parse/ParseStmt.cpptrunk/lib/Parse/ParseStmt.cpp
The file was modified/cfe/trunk/lib/Sema/SemaExpr.cpptrunk/lib/Sema/SemaExpr.cpp
The file was modified/cfe/trunk/lib/Sema/TreeTransform.htrunk/lib/Sema/TreeTransform.h
The file was modified/cfe/trunk/test/AST/ast-dump-stmt.ctrunk/test/AST/ast-dump-stmt.c
The file was modified/cfe/trunk/test/CodeGen/exprs.ctrunk/test/CodeGen/exprs.c
The file was modified/cfe/trunk/test/Sema/statements.ctrunk/test/Sema/statements.c
The file was modified/cfe/trunk/test/SemaCXX/statements.cpptrunk/test/SemaCXX/statements.cpp