FailedChanges

Summary

  1. Slightly relax restriction on exact order arguments must appear. (details)
  2. [sancov] Use LLVM Support library JSON writer in favor of individual (details)
  3. [sancov] Accommodate sancov and coverage report server for use under (details)
  4. Revert "[platform process list] add a flag for showing the processes of (details)
  5. [platform process list] add a flag for showing the processes of all (details)
  6. [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (details)
  7. recommit: [LoopVectorize][PowerPC] Estimate int and float register (details)
Commit 0bb06f6f667eb174f1cec638fc181f1f32dffb44 by douglas.yung
Slightly relax restriction on exact order arguments must appear.
llvm-svn: 374627
The file was modifiedclang/test/Driver/openmp-offload.c
Commit e8a462a01923676860ee4d7b0d191043ea4b9f63 by Vitaly Buka
[sancov] Use LLVM Support library JSON writer in favor of individual
implementation
Summary: In this diff, I've replaced the individual implementation of
`JSONWriter` with `json::OStream` provided by `llvm/Support/JSON.h`.
Important Note: The output format of the JSON is considerably different
compared to the original implementation. Important differences include:
* New line for each entry in an array (should make diffs cleaner)
* No space between keys and colon in attributed object entries.
* Attributes with empty strings will now print the attribute name and a
quote pair rather than excluding the attribute altogether
Examples of these differences can be seen in the changes to the sancov
tests which compare the JSON output.
Patch by Douglas Gliner.
Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman
Subscribers: mehdi_amini, dexonsmith, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D68752
llvm-svn: 374628
The file was modifiedllvm/test/tools/sancov/symbolize_noskip_dead_files.test
The file was modifiedllvm/tools/sancov/sancov.cpp
The file was modifiedllvm/test/tools/sancov/merge.test
The file was modifiedllvm/test/tools/sancov/symbolize.test
Commit 23aa2aec78181fa064191b8f3c1c5b3ffa1c9424 by Vitaly Buka
[sancov] Accommodate sancov and coverage report server for use under
Windows
Summary: This patch makes the following changes to SanCov and its
complementary Python script in order to resolve issues pertaining to
non-UNIX file paths in JSON symbolization information:
* Convert all paths to use forward slash.
* Update `coverage-report-server.py` to correctly handle paths to
sources which contain spaces.
* Remove Linux platform restriction for all SanCov unit tests. All
SanCov tests passed when ran on my local Windows machine.
Patch by Douglas Gliner.
Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman
Reviewed By: vitalybuka
Subscribers: vsk, Dor1s, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D51018
llvm-svn: 374629
The file was modifiedllvm/tools/sancov/coverage-report-server.py
The file was modifiedllvm/test/tools/sancov/symbolize.test
The file was modifiedllvm/test/tools/sancov/not_covered_functions.test
The file was modifiedllvm/test/tools/sancov/validation.test
The file was modifiedllvm/test/tools/sancov/covered_functions.test
The file was modifiedllvm/test/tools/sancov/print.test
The file was modifiedllvm/test/tools/sancov/merge.test
The file was modifiedllvm/test/tools/sancov/stats.test
The file was modifiedllvm/test/tools/sancov/blacklist.test
The file was modifiedllvm/tools/sancov/sancov.cpp
The file was modifiedllvm/test/tools/sancov/symbolize_noskip_dead_files.test
Commit 0f22955899870607cf868b3c4a57f60efd8df02c by a20012251
Revert "[platform process list] add a flag for showing the processes of
all users"
This reverts commit f670a5edfc70066872e1795d650ed6e1ac62b6a8.
llvm-svn: 374630
The file was modifiedlldb/source/Commands/Options.td
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
The file was removedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py
The file was modifiedlldb/source/Commands/CommandObjectPlatform.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Commit af1d27e3011ae858b67e9d43c7fd76131e6d4946 by a20012251
[platform process list] add a flag for showing the processes of all
users
Summary: For context: https://reviews.llvm.org/D68293
We need a way to show all the processes on android regardless of the
user id. When you run `platform process list`, you only see the
processes with the same user as the user that launched lldb-server.
However, it's quite useful to see all the processes, though, and it will
lay a foundation for full apk debugging support from lldb.
Before:
``` PID    PARENT USER       TRIPLE                   NAME
====== ====== ========== ========================
============================ 3234   1               
aarch64-unknown-linux-android adbd 8034   3234            
aarch64-unknown-linux-android sh 9096   3234            
aarch64-unknown-linux-android sh 9098   9096            
aarch64-unknown-linux-android lldb-server
(lldb) ^D
```
Now:
```
(lldb) platform process list -x 205 matching processes were found on
"remote-android" PID    PARENT USER       TRIPLE                   NAME
====== ====== ========== ========================
============================ 1      0                                  
      init 524    1                                          init 525  
1                                          init 531    1               
                         ueventd 568    1                              
          logd 569    1                 aarch64-unknown-linux-android
servicemanager 570    1                 aarch64-unknown-linux-android
hwservicemanager 571    1                 aarch64-unknown-linux-android
vndservicemanager 577    1                 aarch64-unknown-linux-android
qseecomd 580    577               aarch64-unknown-linux-android qseecomd
... 23816  979                                      
com.android.providers.calendar 24600  979                              
        com.verizon.mips.services 27888  979                           
           com.hualai 28043  2378                                     
com.android.chrome:sandboxed_process0 31449  979                       
               com.att.shm 31779  979                                  
    com.samsung.android.authfw 31846  979                              
        com.samsung.android.server.iris 32014  979                     
                 com.samsung.android.MtpApplication 32045  979         
                             com.samsung.InputEventApp
```
Reviewers: labath,xiaobai,aadsm,clayborg
Subscribers:
> llvm-svn: 374584
llvm-svn: 374631
The file was modifiedlldb/source/Commands/CommandObjectPlatform.cpp
The file was addedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
The file was modifiedlldb/source/Commands/Options.td
Commit c0abc2e7f2f6fa704dea6f5b521fe08a5f1d96d9 by puyan
[clang][IFS] Updating tests to pass on -fvisibility=hidden builds
(NFCi).
Special thanks to JamesNagurne who got to the bottom of this; landing
this on his behalf.
Differential Revision: https://reviews.llvm.org/D68897
llvm-svn: 374632
The file was modifiedclang/test/InterfaceStubs/object-float.c
The file was modifiedclang/test/InterfaceStubs/object.c
The file was modifiedclang/test/InterfaceStubs/merge-conflict-test.c
The file was modifiedclang/test/InterfaceStubs/externstatic.c
Commit 9802268ad3123b0ac71413fd5493606573b3544d by wuzish
recommit: [LoopVectorize][PowerPC] Estimate int and float register
pressure separately in loop-vectorize
In loop-vectorize, interleave count and vector factor depend on target
register number. Currently, it does not estimate different register
pressure for different register class separately(especially for scalar
type, float type should not be on the same position with int type), so
it's not accurate. Specifically, it causes too many times
interleaving/unrolling, result in too many register spills in loop body
and hurting performance.
So we need classify the register classes in IR level, and importantly
these are abstract register classes, and are not the target register
class of backend provided in td file. It's used to establish the mapping
between the types of IR values and the number of simultaneous live
ranges to which we'd like to limit for some set of those types.
For example, POWER target, register num is special when VSX is enabled.
When VSX is enabled, the number of int scalar register is 32(GPR), float
is 64(VSR), but for int and float vector register both are 64(VSR). So
there should be 2 kinds of register class when vsx is enabled, and 3
kinds of register class when VSX is NOT enabled.
It runs on POWER target, it makes big(+~30%) performance improvement in
one specific bmk(503.bwaves_r) of spec2017 and no other obvious
degressions.
Differential revision: https://reviews.llvm.org/D67148
llvm-svn: 374634
The file was modifiedllvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/lib/Target/X86/X86TargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/X86/X86TargetTransformInfo.h
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
The file was modifiedllvm/test/Transforms/LoopVectorize/X86/reg-usage-debug.ll
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfo.h
The file was modifiedllvm/include/llvm/CodeGen/BasicTTIImpl.h
The file was modifiedllvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCTargetTransformInfo.h
The file was modifiedllvm/lib/Target/XCore/XCoreTargetTransformInfo.h
The file was modifiedllvm/lib/Target/ARM/ARMTargetTransformInfo.h
The file was addedllvm/test/Transforms/LoopVectorize/PowerPC/reg-usage.ll
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfoImpl.h
The file was modifiedllvm/lib/Analysis/TargetTransformInfo.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/X86/reg-usage.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h