FailedChanges

Summary

  1. [lit] Make internal diff work in pipelines (details)
  2. [lit] Extend internal diff to support `-` argument (details)
  3. [clangd] Use our own relation kind. (details)
  4. [OpenCL] Preserve addrspace in CGClass (PR43145) (details)
  5. [OPENMP]Fix thread id passed to outlined region in sequential parallel (details)
  6. Revert r375116: "[lit] Extend internal diff to support `-` argument" (details)
  7. Revert r375114: "[lit] Make internal diff work in pipelines" (details)
  8. [ARC] Basic support in gdb-remote process plugin (details)
  9. [ARC] Add SystemV ABI (details)
  10. [ObjC] Add some additional test cases around pointer conversions. (details)
  11. [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object (details)
  12. [lld][test] Fix use of escape character in an lld test on Windows (details)
  13. Fix an inverted condition in test. (details)
  14. [lit] Create derived classes for serial/parallel test runs (details)
  15. [lit] Synthesize artificial deadline (details)
  16. [lit] Move computation of deadline up into base class (details)
Commit 221e418f0c56d6b4a8b188fb4d8e75e21f7b0c8d by jdenny.ornl
[lit] Make internal diff work in pipelines
When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:
```
# RUN: program | diff file -
# RUN: not diff file1 file2 | FileCheck %s
```
Such cases exist now, in `clang/test/Analysis` for example.  We are
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` cannot
currently be used in pipelines and doesn't recognize `-` as a
command-line option.
To enable pipelines, this patch moves lit's `diff` implementation into
an out-of-process script, similar to lit's `cat` implementation.  A
follow-up patch will implement `-` to mean stdin.
Reviewed By: probinson, stella.stamenova
Differential Revision: https://reviews.llvm.org/D66574
llvm-svn: 375114
The file was addedllvm/utils/lit/lit/builtin_commands/diff.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-1.txt
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-0.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit 849d67a70080982cc1261759015a67b06b25eb16 by jdenny.ornl
[lit] Extend internal diff to support `-` argument
When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:
```
# RUN: program | diff file -
```
Such cases exist now, in `clang/test/Analysis` for example.  We are
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` doesn't
recognize `-` as a command-line option.  This patch adds support for
`-` to mean stdin.
Reviewed By: probinson, rnk
Differential Revision: https://reviews.llvm.org/D67643
llvm-svn: 375116
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
Commit c8e3f43ab514bf527b2d2d01f66d4c921a2985c4 by hokein
[clangd] Use our own relation kind.
Summary: Move the RelationKind from Serialization.h to Relation.h. This
patch doesn't introduce any breaking changes.
Reviewers: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68981
llvm-svn: 375117
The file was modifiedclang-tools-extra/clangd/index/dex/Dex.cpp
The file was modifiedclang-tools-extra/clangd/index/dex/Dex.h
The file was modifiedclang-tools-extra/clangd/unittests/DexTests.cpp
The file was modifiedclang-tools-extra/clangd/index/Serialization.cpp
The file was modifiedclang-tools-extra/clangd/index/YAMLSerialization.cpp
The file was modifiedclang-tools-extra/clangd/index/Relation.h
The file was modifiedclang-tools-extra/clangd/index/Serialization.h
The file was modifiedclang-tools-extra/clangd/XRefs.cpp
The file was modifiedllvm/include/llvm/ADT/DenseMapInfo.h
The file was modifiedclang-tools-extra/clangd/unittests/FileIndexTests.cpp
The file was modifiedclang-tools-extra/clangd/index/Relation.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp
The file was modifiedclang-tools-extra/clangd/index/Index.h
The file was modifiedclang-tools-extra/clangd/index/SymbolCollector.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SerializationTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
The file was modifiedclang-tools-extra/clangd/index/MemIndex.cpp
The file was modifiedclang-tools-extra/clangd/index/MemIndex.h
The file was modifiedclang-tools-extra/clangd/unittests/IndexTests.cpp
Commit af6248cbb9e70122359a12ff16541fe510ada600 by sven.vanhaastregt
[OpenCL] Preserve addrspace in CGClass (PR43145)
PR43145 revealed two places where Clang was attempting to create a
bitcast without considering the address space of class types during C++
class code generation.
Differential Revision: https://reviews.llvm.org/D68403
llvm-svn: 375118
The file was modifiedclang/lib/CodeGen/CGClass.cpp
The file was modifiedclang/test/CodeGenOpenCLCXX/addrspace-derived-base.cl
Commit 3e0f4f8e928cabb3da9fc955321fb5142a0a0110 by a.bataev
[OPENMP]Fix thread id passed to outlined region in sequential parallel
regions.
The real global thread id must be passed to the outlined region instead
of the zero thread id.
llvm-svn: 375119
The file was modifiedclang/test/OpenMP/parallel_if_codegen.cpp
The file was modifiedclang/lib/CodeGen/CGOpenMPRuntime.cpp
Commit 5e684e8d88ba60c867b12dbde274db0730d7b517 by jdenny.ornl
Revert r375116: "[lit] Extend internal diff to support `-` argument"
This series of patches still breaks a Windows bot.
llvm-svn: 375120
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit e96e2d322723f45b052dc66e17d556e7346d4336 by jdenny.ornl
Revert r375114: "[lit] Make internal diff work in pipelines"
This series of patches still breaks a Windows bot.
llvm-svn: 375121
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-1.txt
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified-error-0.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was removedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/max-failures.py
Commit faf6b2543e4789061cbced2557f6bc7d1bd0d71d by Tatyana Krasnukha
[ARC] Basic support in gdb-remote process plugin
Differential Revision: https://reviews.llvm.org/D55718
llvm-svn: 375122
The file was modifiedlldb/source/Target/Platform.cpp
The file was modifiedlldb/source/Utility/ArchSpec.cpp
The file was modifiedlldb/source/Target/Thread.cpp
The file was modifiedlldb/include/lldb/Utility/ArchSpec.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Commit 92e498d58cf47f4c1266cedba981a0c2cee171d0 by Tatyana Krasnukha
[ARC] Add SystemV ABI
Differential Revision: https://reviews.llvm.org/D55724
llvm-svn: 375123
The file was modifiedlldb/source/API/SystemInitializerFull.cpp
The file was addedlldb/source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp
The file was modifiedlldb/source/Plugins/ABI/CMakeLists.txt
The file was addedlldb/source/Plugins/ABI/SysV-arc/CMakeLists.txt
The file was addedlldb/source/Plugins/ABI/SysV-arc/ABISysV_arc.h
Commit 1c982af0599781bdb049f898a2d512656c807485 by jyknight
[ObjC] Add some additional test cases around pointer conversions.
This is especially important for Objective-C++, which is entirely
missing this testing at the moment.
This annotates with "FIXME" the cases which I change in the next patch
-- I primarily wanted to document the current state of things so that
the effect of the code change is made clear.
Differential Revision: https://reviews.llvm.org/D67982
llvm-svn: 375124
The file was modifiedclang/test/SemaObjCXX/instancetype.mm
The file was modifiedclang/test/SemaObjC/comptypes-7.m
The file was addedclang/test/SemaObjCXX/comptypes-7.mm
The file was modifiedclang/test/SemaObjC/class-method-self.m
The file was modifiedclang/test/SemaObjC/comptypes-1.m
The file was addedclang/test/SemaObjCXX/class-method-self.mm
The file was addedclang/test/SemaObjCXX/comptypes-1.mm
Commit ccc4d83cda16bea1d9dfd0967dc7d2cfb24b8e75 by jyknight
[ObjC] Diagnose implicit type coercion from ObjC 'Class' to object
pointer types.
For example, in Objective-C mode, the initialization of 'x' in:
```
@implementation MyType
+ (void)someClassMethod {
   MyType *x = self;
}
@end
``` is correctly diagnosed with an incompatible-pointer-types warning,
but in Objective-C++ mode, it is not diagnosed at all -- even though
incompatible pointer conversions generally become an error in C++.
This patch fixes that oversight, allowing implicit conversions involving
Class only to/from unqualified-id, and between qualified and unqualified
Class, where the protocols are compatible.
Note that this does change some behaviors in Objective-C, as well, as
shown by the modified tests.
Of particular note is that assignment from from 'Class<MyProtocol>' to
'id<MyProtocol>' now warns. (Despite appearances, those are not
compatible types. 'Class<MyProtocol>' is not expected to have instance
methods defined by 'MyProtocol', while 'id<MyProtocol>' is.)
Differential Revision: https://reviews.llvm.org/D67983
llvm-svn: 375125
The file was modifiedclang/test/SemaObjCXX/class-method-self.mm
The file was modifiedclang/lib/AST/ASTContext.cpp
The file was modifiedclang/test/SemaObjC/comptypes-1.m
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/test/SemaObjCXX/comptypes-1.mm
The file was modifiedclang/test/SemaObjCXX/instancetype.mm
The file was modifiedclang/test/SemaObjCXX/comptypes-7.mm
Commit 1b6c3ca1267218b31c230815e1cc0b56aa89ddd2 by rupprecht
[lld][test] Fix use of escape character in an lld test on Windows
Summary: Glob support was improved to accept `\` as an escape character
in r375051, but reverted as r375052 due to a failure in this test on
Windows.
The reason this failure seems Windows specific is because the path
separator `\` is currently being relied on to be interpreted literally
instead of as an escape character. Per documentation on linker input
section wildcard patterns, this seems to be a bug in lld accepting `\`
as a literal instead of an escape character.
For example:
``` SECTIONS{ .foo :{ /path/to/foo.o(.foo) }} # OK: standard UNIX path
SECTIONS{ .foo :{ C:/path/to/foo.o(.foo) }} # OK: windows accepts
slashes in either direction SECTIONS{ .foo :{ C:\\path\\to\\foo.o(.foo)
}} # OK: escape character used to match a literal \ SECTIONS{ .foo :{
C:\path\to\foo.o(.foo) }} # BAD: this actually matches the path
C:pathtofoo.o(.foo)
```
This avoids the problem in the test by using `%/T` in place of `%T` to
normalize the path separator to `/`, which windows should also accept.
This patch just fixes the test, and glob support will be be relanded
separately.
For a sample buildbot error, see:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11578/steps/stage%201%20check/logs/stdio
Reviewers: evgeny777, ruiu, MaskRay, espindola
Reviewed By: ruiu, MaskRay
Subscribers: emaste, arichardson, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69074
llvm-svn: 375126
The file was modifiedlld/test/ELF/linkerscript/filename-spec.s
Commit d06a2f3ad681fc9e2126b39f1110a82cd7870356 by Adrian Prantl
Fix an inverted condition in test.
llvm-svn: 375127
The file was modifiedlldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Commit d25c766aa255662a91465662fef02ef8b5990bba by jlettner
[lit] Create derived classes for serial/parallel test runs
The hope is that with a little OO we can nicely factor out the
differences.
llvm-svn: 375128
The file was modifiedllvm/utils/lit/lit/run.py
The file was modifiedllvm/utils/lit/lit/main.py
Commit aa05e0e9729fe7236c8961c27092b780face8a85 by jlettner
[lit] Synthesize artificial deadline
We always want to use a deadline when calling `result.await`.  Let's
synthesize an artificial deadline (positive infinity) to simplify code
and do less busy waiting.
llvm-svn: 375129
The file was modifiedllvm/utils/lit/lit/run.py
Commit a660dc590a5e8dafa1ba6ed56447ede151d17bd9 by jlettner
[lit] Move computation of deadline up into base class
llvm-svn: 375130
The file was modifiedllvm/utils/lit/lit/run.py