FailedChanges

Summary

  1. [DBG][OPT] Attempt to salvage or undef debug info when removing (details)
  2. [PowerPC] Remove allow-deprecated-dag-overlap and fix broken tests (details)
  3. [Hexagon] Require PS_aligna whenever variable-sized objects are present (details)
  4. [Hexagon] Handle stack realignment in hexagon-vextract (details)
  5. [Hexagon] Convert stack object offsets to int64, NFC (details)
  6. [Hexagon] Fix vector spill expansion to use proper alignment (details)
  7. [SLP] add test for miscompile with reduction (PR43948); NFC (details)
  8. clang/Modules: Error if ReadASTBlock does not find the main module (details)
  9. [lit] Better/earlier errors for empty runs (details)
  10. Performance: Add a set of visited SymbolFiles to the other FindFiles (details)
  11. [Hexagon] Update PS_aligna with max stack alignment once isel completes (details)
Commit 41c3f76dcd0daeec60eddfcb56008a31ad6e8738 by Tom.Weaver
[DBG][OPT] Attempt to salvage or undef debug info when removing
trivially deletable instructions in the Reassociate Expression pass.
Reviewed By: aprantl, vsk
Differential revision: https://reviews.llvm.org/D69943
The file was addedllvm/test/Transforms/Reassociate/reassociate_salvages_debug_info.ll
The file was addedllvm/test/Transforms/Reassociate/undef_intrinsics_when_deleting_instructions.ll
The file was modifiedllvm/lib/Transforms/Scalar/Reassociate.cpp
Commit 228dd96c6fddad6d070c29a6830c7bd161982e3a by Jinsong Ji
[PowerPC] Remove allow-deprecated-dag-overlap and fix broken tests
Summary: This is found during review of https://reviews.llvm.org/D67088.
CHECK-DAG is non-overlapping after https://reviews.llvm.org/D47106.
-allow-deprecated-dag-overlap was introduced to temporary accept old
behavior.
But it actually hide some broken tests, eg:
`test/CodeGen/PowerPC/swaps-le-1.ll` The codegen has changed, but the
CHECK-DAG still PASS due to allowing `overlap`.
This patch remove the deprecated options, and fix the broken tests.
Reviewers: #powerpc, hfinkel, nemanjai, steven.zhang, shchenz
Reviewed By: shchenz
Subscribers: shchenz, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69733
The file was modifiedllvm/test/CodeGen/PowerPC/swaps-le-1.ll
The file was modifiedllvm/test/CodeGen/PowerPC/machine-combiner.ll
The file was modifiedllvm/test/CodeGen/PowerPC/memcpy-vec.ll
The file was modifiedllvm/test/CodeGen/PowerPC/build-vector-tests.ll
The file was modifiedllvm/test/CodeGen/PowerPC/uint-to-fp-v4i32.ll
Commit 0a58ef5eb5e1a243756f649f82834281ac3dd7ff by kparzysz
[Hexagon] Require PS_aligna whenever variable-sized objects are present
The file was modifiedllvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
Commit 67294c97fbfde6541b5f89d9d83c7fcba31c5f3b by kparzysz
[Hexagon] Handle stack realignment in hexagon-vextract
The file was modifiedllvm/lib/Target/Hexagon/HexagonVExtract.cpp
Commit e3eb10c5419d89171bc97ca21aba7c381827c45e by kparzysz
[Hexagon] Convert stack object offsets to int64, NFC
This will print [SP-56] instead of [SP+4294967240].
The file was modifiedllvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
Commit 592dd459242946593920911936aea47461e0faaa by kparzysz
[Hexagon] Fix vector spill expansion to use proper alignment
1. Add pseudos PS_vloadrv_ai and PS_vstorerv_ai: those are now used
  for single vector registers in loadRegFromStackSlot (and store...). 2.
Remove pseudos PS_vloadrwu_ai and PS_vstorerwu_ai. The alignment is
  now checked when expanding spill pseudos (both in frame lowering
  and in expand-post-ra-pseudos), and a proper instruction is generated.
3. Update MachineMemOperands when dealigning vector spill slots. 4.
Return vector predicate registers in getCallerSavedRegs.
The file was addedllvm/test/CodeGen/Hexagon/spill-vector-alignment.mir
The file was modifiedllvm/lib/Target/Hexagon/HexagonInstrInfo.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonPseudo.td
The file was modifiedllvm/lib/Target/Hexagon/HexagonRegisterInfo.cpp
The file was modifiedllvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
The file was modifiedllvm/test/CodeGen/Hexagon/v6-unaligned-spill.ll
Commit 2d06375c3fa02275c1292643216cdb00bb17c32c by spatel
[SLP] add test for miscompile with reduction (PR43948); NFC
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/reduction.ll
Commit 83dcb34b6bf4c175040b18d3e8c3c468418009fc by Duncan P. N. Exon Smith
clang/Modules: Error if ReadASTBlock does not find the main module
If ReadASTBlock does not find its top-level submodule, there's something
wrong the with the PCM.  Error in that case, to avoid hitting problems
further from the source.
Note that the Swift compiler sometimes hits a case in
CompilerInstance::loadModule where the top-level submodule mysteriously
does not have Module::IsFromModuleFile set.  That will emit a confusing
warn_missing_submodule, which was never intended for the main module.
The recent audit of error-handling in ReadAST may have rooted out the
real problem.  If not, this commit will help to clarify the real
problem, and replace a confusing warning with an error pointing at the
malformed PCM file.
We're specifically sniffing out whether the top-level submodule was
found/processed, in case there is a malformed module file that is
missing it.  If there is an error encountered during ReadSubmoduleBlock
the return status should already propagate through.  It would be nice to
detect other missing submodules around here to catch other instances of
warn_missing_submodule closer to the source, but that's left as a future
exercise.
https://reviews.llvm.org/D70063
The file was modifiedclang/include/clang/Basic/DiagnosticSerializationKinds.td
The file was modifiedclang/include/clang/Serialization/Module.h
The file was modifiedclang/lib/Serialization/ASTReader.cpp
Commit 54a9b4c02ff57e9847e0c501578e51db6f73d3be by julian.lettner
[lit] Better/earlier errors for empty runs
Fail early, when we discover no tests at all, or filter out all of them.
There is also `--allow-empty-runs` to disable test to allow workflows
like `LIT_FILTER=abc ninja check-all`.  Apparently `check-all` invokes
lit multiple times if certain projects are enabled, which would produce
unwanted "empty runs". Specify via `LIT_OPTS=--allow-empty-runs`.
There are 3 causes for empty runs: 1) No tests discovered.  This is
always an error.  Fix test suite config
  or command line. 2) All tests filtered out.  This is an error by
default, but can be
  suppressed via `--alow-empty-runs`.  Should prevent accidentally
  passing empty runs, but allow the workflow above. 3) The number of
shards is greater than the number of tests.  Currently,
  this is never an error.  Personally, I think we should consider
  making this an error by default; if this happens, you are doing
  something wrong. I added a warning but did not change the behavior,
  since this warrants more discussion.
Reviewed By: atrick, jdenny
Differential Revision: https://reviews.llvm.org/D70105
The file was modifiedllvm/utils/lit/lit/cl_arguments.py
The file was modifiedllvm/utils/lit/lit/main.py
The file was modifiedllvm/utils/lit/tests/selecting.py
The file was modifiedllvm/utils/lit/lit/run.py
Commit 3b73dcdc9656e156c4380454150b8986c5b9aad1 by Adrian Prantl
Performance: Add a set of visited SymbolFiles to the other FindFiles
variant.
This is basically the same bug as in r260434.
SymbolFileDWARF::FindTypes has exponential worst-case when digging
through dependency DAG of .pcm files because each object file and .pcm
file may depend on an already-visited .pcm file, which may again have
dependencies. Fixed here by carrying a set of already visited
SymbolFiles around.
rdar://problem/56993424
Differential Revision: https://reviews.llvm.org/D70106
The file was modifiedlldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
The file was modifiedlldb/source/Core/Module.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
The file was modifiedlldb/source/Symbol/SymbolFile.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
The file was modifiedlldb/include/lldb/Symbol/SymbolFile.h
The file was modifiedlldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
The file was modifiedlldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
The file was modifiedlldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
The file was modifiedlldb/include/lldb/Core/Module.h
The file was modifiedlldb/tools/lldb-test/lldb-test.cpp
Commit ef150e2ea51960e4a9689850d16b2dda355cdcd8 by kparzysz
[Hexagon] Update PS_aligna with max stack alignment once isel completes
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelDAGToDAG.h
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelDAGToDAG.cpp