SuccessChanges

Summary

  1. [PowerPC][NFC]Update testcases using script.
  2. [X86] ISD::INSERT_SUBVECTOR - use uint64_t index. NFCI. Keep the uint64_t type from getConstantOperandVal to stop truncation/extension overflow warnings in MSVC in subvector index math.
  3. [Triple] Add isRISCV function This matches isARM, isThumb, isAArch64 and similar helpers. Future commits which clean-up code that currently checks for Triple::riscv32 || Triple::riscv64. Differential Revision: https://reviews.llvm.org/D54215 Patch by Simon Cook. Test case added by Alex Bradbury.
  4. [InstCombine] add tests for splat shuffles; NFC
  5. [Float2Int] Add support for unary FNeg to Float2Int Differential Revision: https://reviews.llvm.org/D63941
  6. [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load Select gprb or fprb when loaded value is used by either: copy to physical register or instruction with only one mapping available for that use operand. Load of integer s64 is handled with narrowScalar when mapping is applied, produced artifacts are combined away. Manually set gprb to all register operands of instructions created during narrowScalar. Differential Revision: https://reviews.llvm.org/D64269
  7. [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store Select gprb or fprb when stored value is defined by either: copy from physical register or instruction with only one mapping available for that def operand. Store of integer s64 is handled with narrowScalar when mapping is applied, produced artifacts are combined away. Manually set gprb to all register operands of instructions created during narrowScalar. Differential Revision: https://reviews.llvm.org/D64268
  8. [AMDGPU][MC] Corrected parsing of FLAT offset modifier Summary of changes: - simplified handling of FLAT offset: offset_s13 and offset_u12 have been replaced with flat_offset; - provided information about error position for pre-gfx9 targets; - improved errors handling. Reviewers: artem.tamazov, arsenm, rampitec Differential Revision: https://reviews.llvm.org/D64244
  9. GlobalISel: widenScalar for G_BUILD_VECTOR
  10. GlobalISel: Check address space when looking up iPTR size Fixes AMDGPU patterns for 32-bit address spaces always failing. Tests will be included in future patches when additional issues are solved.
  11. Reapply [llvm-ar][test] Increase llvm-ar test coverage This change adds tests to cover existing llvm-ar functionality. Differential Revision: https://reviews.llvm.org/D63935
  12. Revert [llvm-ar][test] Increase llvm-ar test coverage Reverted due to test failures Differential Revision: https://reviews.llvm.org/D63935
  13. [llvm-ar][test] Increase llvm-ar test coverage This change adds tests to cover existing llvm-ar functionality. Differential Revision: https://reviews.llvm.org/D63935
  14. [lit] Parse command-line options from LIT_OPTS Similar to `FILECHECK_OPTS` for FileCheck, `LIT_OPTS` makes it easy to adjust lit behavior when running the test suite via ninja. For example: ``` $ LIT_OPTS='--time-tests -vv --filter=threadprivate' \ ninja check-clang-openmp ``` Reviewed By: probinson Differential Revision: https://reviews.llvm.org/D64135
  15. [docs][llvm-objcopy] Add description of binary input/output to doc We briefly referred to being able to specify --target=binary without explaining what binary input/output meant. This change adds a section on this. Reviewed by: MaskRay, abrachet Differential Revision: https://reviews.llvm.org/D64245
Revision 365330 by jsji:
[PowerPC][NFC]Update testcases using script.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/PowerPC/power9-moves-and-splats.lltrunk/test/CodeGen/PowerPC/power9-moves-and-splats.ll
Revision 365328 by rksimon:
[X86] ISD::INSERT_SUBVECTOR - use uint64_t index. NFCI.

Keep the uint64_t type from getConstantOperandVal to stop truncation/extension overflow warnings in MSVC in subvector index math.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpptrunk/lib/Target/X86/X86ISelLowering.cpp
Revision 365327 by asb:
[Triple] Add isRISCV function

This matches isARM, isThumb, isAArch64 and similar helpers. Future commits
which clean-up code that currently checks for Triple::riscv32 ||
Triple::riscv64.

Differential Revision: https://reviews.llvm.org/D54215
Patch by Simon Cook.
Test case added by Alex Bradbury.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Triple.htrunk/include/llvm/ADT/Triple.h
The file was modified/llvm/trunk/unittests/ADT/TripleTest.cpptrunk/unittests/ADT/TripleTest.cpp
Revision 365325 by spatel:
[InstCombine] add tests for splat shuffles; NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/insert-extract-shuffle.lltrunk/test/Transforms/InstCombine/insert-extract-shuffle.ll
Revision 365324 by mcinally:
[Float2Int] Add support for unary FNeg to Float2Int

Differential Revision: https://reviews.llvm.org/D63941
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/Float2Int.cpptrunk/lib/Transforms/Scalar/Float2Int.cpp
The file was modified/llvm/trunk/test/Transforms/Float2Int/basic.lltrunk/test/Transforms/Float2Int/basic.ll
Revision 365323 by petar.avramovic:
[MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load

Select gprb or fprb when loaded value is used by either:
copy to physical register or
instruction with only one mapping available for that use operand.

Load of integer s64 is handled with narrowScalar when mapping is applied,
produced artifacts are combined away. Manually set gprb to all register
operands of instructions created during narrowScalar.

Differential Revision: https://reviews.llvm.org/D64269
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsLegalizerInfo.cpptrunk/lib/Target/Mips/MipsLegalizerInfo.cpp
The file was modified/llvm/trunk/lib/Target/Mips/MipsRegisterBankInfo.cpptrunk/lib/Target/Mips/MipsRegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/Target/Mips/MipsRegisterBankInfo.htrunk/lib/Target/Mips/MipsRegisterBankInfo.h
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/legalizer/load.mirtrunk/test/CodeGen/Mips/GlobalISel/legalizer/load.mir
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/llvm-ir/load.lltrunk/test/CodeGen/Mips/GlobalISel/llvm-ir/load.ll
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/regbankselect/load.mirtrunk/test/CodeGen/Mips/GlobalISel/regbankselect/load.mir
Revision 365322 by petar.avramovic:
[MIPS GlobalISel] Register bank select for G_STORE. Select i64 store

Select gprb or fprb when stored value is defined by either:
copy from physical register or
instruction with only one mapping available for that def operand.

Store of integer s64 is handled with narrowScalar when mapping is applied,
produced artifacts are combined away. Manually set gprb to all register
operands of instructions created during narrowScalar.

Differential Revision: https://reviews.llvm.org/D64268
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Mips/MipsLegalizerInfo.cpptrunk/lib/Target/Mips/MipsLegalizerInfo.cpp
The file was modified/llvm/trunk/lib/Target/Mips/MipsRegisterBankInfo.cpptrunk/lib/Target/Mips/MipsRegisterBankInfo.cpp
The file was modified/llvm/trunk/lib/Target/Mips/MipsRegisterBankInfo.htrunk/lib/Target/Mips/MipsRegisterBankInfo.h
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/legalizer/store.mirtrunk/test/CodeGen/Mips/GlobalISel/legalizer/store.mir
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/llvm-ir/store.lltrunk/test/CodeGen/Mips/GlobalISel/llvm-ir/store.ll
The file was added/llvm/trunk/test/CodeGen/Mips/GlobalISel/regbankselect/store.mirtrunk/test/CodeGen/Mips/GlobalISel/regbankselect/store.mir
Revision 365321 by dpreobra:
[AMDGPU][MC] Corrected parsing of FLAT offset modifier

Summary of changes:

- simplified handling of FLAT offset: offset_s13 and offset_u12 have been replaced with flat_offset;
- provided information about error position for pre-gfx9 targets;
- improved errors handling.

Reviewers: artem.tamazov, arsenm, rampitec

Differential Revision: https://reviews.llvm.org/D64244
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpptrunk/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/FLATInstructions.tdtrunk/lib/Target/AMDGPU/FLATInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpptrunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.htrunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.h
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.tdtrunk/lib/Target/AMDGPU/SIInstrInfo.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpptrunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.htrunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
The file was modified/llvm/trunk/test/MC/AMDGPU/flat-gfx10.strunk/test/MC/AMDGPU/flat-gfx10.s
The file was modified/llvm/trunk/test/MC/AMDGPU/flat-gfx9.strunk/test/MC/AMDGPU/flat-gfx9.s
The file was modified/llvm/trunk/test/MC/AMDGPU/flat-global.strunk/test/MC/AMDGPU/flat-global.s
The file was modified/llvm/trunk/test/MC/AMDGPU/flat-scratch-instructions.strunk/test/MC/AMDGPU/flat-scratch-instructions.s
Revision 365320 by arsenm:
GlobalISel: widenScalar for G_BUILD_VECTOR
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpptrunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
The file was modified/llvm/trunk/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpptrunk/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
Revision 365319 by arsenm:
GlobalISel: Check address space when looking up iPTR size

Fixes AMDGPU patterns for 32-bit address spaces always failing. Tests
will be included in future patches when additional issues are solved.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.htrunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
Revision 365318 by gbreynoo:
Reapply [llvm-ar][test] Increase llvm-ar test coverage

This change adds tests to cover existing llvm-ar functionality.

Differential Revision: https://reviews.llvm.org/D63935
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/tools/llvm-ar/create.testtrunk/test/tools/llvm-ar/create.test
The file was added/llvm/trunk/test/tools/llvm-ar/dash-before-letter.testtrunk/test/tools/llvm-ar/dash-before-letter.test
The file was modified/llvm/trunk/test/tools/llvm-ar/default-add.testtrunk/test/tools/llvm-ar/default-add.test
The file was added/llvm/trunk/test/tools/llvm-ar/delete.testtrunk/test/tools/llvm-ar/delete.test
The file was added/llvm/trunk/test/tools/llvm-ar/extract.testtrunk/test/tools/llvm-ar/extract.test
The file was added/llvm/trunk/test/tools/llvm-ar/insert-after.testtrunk/test/tools/llvm-ar/insert-after.test
The file was added/llvm/trunk/test/tools/llvm-ar/insert-before.testtrunk/test/tools/llvm-ar/insert-before.test
The file was added/llvm/trunk/test/tools/llvm-ar/move-after.testtrunk/test/tools/llvm-ar/move-after.test
The file was added/llvm/trunk/test/tools/llvm-ar/move-before.testtrunk/test/tools/llvm-ar/move-before.test
The file was added/llvm/trunk/test/tools/llvm-ar/symtab.testtrunk/test/tools/llvm-ar/symtab.test
Revision 365317 by gbreynoo:
Revert [llvm-ar][test] Increase llvm-ar test coverage

Reverted due to test failures

Differential Revision: https://reviews.llvm.org/D63935
Change TypePath in RepositoryPath in Workspace
The file was removed/llvm/trunk/test/tools/llvm-ar/create.testtrunk/test/tools/llvm-ar/create.test
The file was removed/llvm/trunk/test/tools/llvm-ar/dash-before-letter.testtrunk/test/tools/llvm-ar/dash-before-letter.test
The file was modified/llvm/trunk/test/tools/llvm-ar/default-add.testtrunk/test/tools/llvm-ar/default-add.test
The file was removed/llvm/trunk/test/tools/llvm-ar/delete.testtrunk/test/tools/llvm-ar/delete.test
The file was removed/llvm/trunk/test/tools/llvm-ar/extract.testtrunk/test/tools/llvm-ar/extract.test
The file was removed/llvm/trunk/test/tools/llvm-ar/insert-after.testtrunk/test/tools/llvm-ar/insert-after.test
The file was removed/llvm/trunk/test/tools/llvm-ar/insert-before.testtrunk/test/tools/llvm-ar/insert-before.test
The file was removed/llvm/trunk/test/tools/llvm-ar/move-after.testtrunk/test/tools/llvm-ar/move-after.test
The file was removed/llvm/trunk/test/tools/llvm-ar/move-before.testtrunk/test/tools/llvm-ar/move-before.test
The file was removed/llvm/trunk/test/tools/llvm-ar/symtab.testtrunk/test/tools/llvm-ar/symtab.test
Revision 365316 by gbreynoo:
[llvm-ar][test] Increase llvm-ar test coverage

This change adds tests to cover existing llvm-ar functionality.

Differential Revision: https://reviews.llvm.org/D63935
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/tools/llvm-ar/create.testtrunk/test/tools/llvm-ar/create.test
The file was added/llvm/trunk/test/tools/llvm-ar/dash-before-letter.testtrunk/test/tools/llvm-ar/dash-before-letter.test
The file was modified/llvm/trunk/test/tools/llvm-ar/default-add.testtrunk/test/tools/llvm-ar/default-add.test
The file was added/llvm/trunk/test/tools/llvm-ar/delete.testtrunk/test/tools/llvm-ar/delete.test
The file was added/llvm/trunk/test/tools/llvm-ar/extract.testtrunk/test/tools/llvm-ar/extract.test
The file was added/llvm/trunk/test/tools/llvm-ar/insert-after.testtrunk/test/tools/llvm-ar/insert-after.test
The file was added/llvm/trunk/test/tools/llvm-ar/insert-before.testtrunk/test/tools/llvm-ar/insert-before.test
The file was added/llvm/trunk/test/tools/llvm-ar/move-after.testtrunk/test/tools/llvm-ar/move-after.test
The file was added/llvm/trunk/test/tools/llvm-ar/move-before.testtrunk/test/tools/llvm-ar/move-before.test
The file was added/llvm/trunk/test/tools/llvm-ar/symtab.testtrunk/test/tools/llvm-ar/symtab.test
Revision 365313 by jdenny:
[lit] Parse command-line options from LIT_OPTS

Similar to `FILECHECK_OPTS` for FileCheck, `LIT_OPTS` makes it easy to
adjust lit behavior when running the test suite via ninja.  For
example:

```
$ LIT_OPTS='--time-tests -vv --filter=threadprivate' \
  ninja check-clang-openmp
```

Reviewed By: probinson

Differential Revision: https://reviews.llvm.org/D64135
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/lit.rsttrunk/docs/CommandGuide/lit.rst
The file was modified/llvm/trunk/utils/lit/lit/main.pytrunk/utils/lit/lit/main.py
The file was added/llvm/trunk/utils/lit/tests/Inputs/lit-optstrunk/utils/lit/tests/Inputs/lit-opts
The file was added/llvm/trunk/utils/lit/tests/Inputs/lit-opts/lit.cfgtrunk/utils/lit/tests/Inputs/lit-opts/lit.cfg
The file was added/llvm/trunk/utils/lit/tests/Inputs/lit-opts/test.txttrunk/utils/lit/tests/Inputs/lit-opts/test.txt
The file was added/llvm/trunk/utils/lit/tests/lit-opts.pytrunk/utils/lit/tests/lit-opts.py
Revision 365312 by jhenderson:
[docs][llvm-objcopy] Add description of binary input/output to doc

We briefly referred to being able to specify --target=binary without
explaining what binary input/output meant. This change adds a section on
this.

Reviewed by: MaskRay, abrachet

Differential Revision: https://reviews.llvm.org/D64245
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-objcopy.rsttrunk/docs/CommandGuide/llvm-objcopy.rst

Summary

  1. [RISCV][NFC] Make use of Triple::isRISCV Use new helper introduced in rL365327.
  2. [ASTImporter] Fix import of lambda in function param Summary: The current import implementation fails to import the definition of a lambda class if the lambda class is defined in a function param. E.g., the lambda class below will be imported without any methods: ``` template <typename F> void f(F L = [](){}) {} ``` Reviewers: a_sidorin, a.sidorin, shafik Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D64073
  3. [analyzer] Add analyzer option to limit the number of imported TUs Summary: During CTU analysis of complex projects, the loaded AST-contents of imported TUs can grow bigger than available system memory. This option introduces a threshold on the number of TUs to be imported for a single TU in order to prevent such cases. Differential Revision: https://reviews.llvm.org/D59798
Revision 365329 by asb:
[RISCV][NFC] Make use of Triple::isRISCV

Use new helper introduced in rL365327.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Driver/ToolChains/Gnu.cpptrunk/lib/Driver/ToolChains/Gnu.cpp
The file was modified/cfe/trunk/lib/Driver/ToolChains/Linux.cpptrunk/lib/Driver/ToolChains/Linux.cpp
Revision 365315 by martong:
[ASTImporter] Fix import of lambda in function param

Summary:
The current import implementation fails to import the definition of a
lambda class if the lambda class is defined in a function param.
E.g., the lambda class below will be imported without any methods:
```
  template <typename F>
  void f(F L = [](){}) {}
```

Reviewers: a_sidorin, a.sidorin, shafik

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64073
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ASTImporter.cpptrunk/lib/AST/ASTImporter.cpp
The file was modified/cfe/trunk/unittests/AST/ASTImporterTest.cpptrunk/unittests/AST/ASTImporterTest.cpp
Revision 365314 by gamesh411:
[analyzer] Add analyzer option to limit the number of imported TUs

Summary:
During CTU analysis of complex projects, the loaded AST-contents of
imported TUs can grow bigger than available system memory. This option
introduces a threshold on the number of TUs to be imported for a single
TU in order to prevent such cases.

Differential Revision: https://reviews.llvm.org/D59798
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/CrossTU/CrossTranslationUnit.htrunk/include/clang/CrossTU/CrossTranslationUnit.h
The file was modified/cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.deftrunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
The file was modified/cfe/trunk/lib/CrossTU/CrossTranslationUnit.cpptrunk/lib/CrossTU/CrossTranslationUnit.cpp
The file was modified/cfe/trunk/test/Analysis/analyzer-config.ctrunk/test/Analysis/analyzer-config.c
The file was added/cfe/trunk/test/Analysis/ctu-import-threshold.ctrunk/test/Analysis/ctu-import-threshold.c
The file was modified/cfe/trunk/unittests/CrossTU/CrossTranslationUnitTest.cpptrunk/unittests/CrossTU/CrossTranslationUnitTest.cpp

Summary

  1. [clangd] Use xxhash instead of SHA1 for background index file digests. Summary: Currently SHA1 is about 10% of our CPU, this patch reduces it to ~1%. xxhash is a well-defined (stable) non-cryptographic hash optimized for fast checksums (like crc32). Collisions shouldn't be a problem, despite the reduced length: - for actual file content (used to invalidate bg index shards), there are only two versions that can collide (new shard and old shard). - for file paths in bg index shard filenames, we would need 2^32 files with the same filename to expect a collision. Imperfect hashing may reduce this a bit but it's well beyond what's plausible. This will invalidate shards on disk (as usual; I bumped the version), but this time the filenames are changing so the old files will stick around :-( So this is more expensive than the usual bump, but would be good to land before the v9 branch when everyone will start using bg index. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64306
Revision 365311 by sammccall:
[clangd] Use xxhash instead of SHA1 for background index file digests.

Summary:
Currently SHA1 is about 10% of our CPU, this patch reduces it to ~1%.

xxhash is a well-defined (stable) non-cryptographic hash optimized for
fast checksums (like crc32).
Collisions shouldn't be a problem, despite the reduced length:
- for actual file content (used to invalidate bg index shards), there
   are only two versions that can collide (new shard and old shard).
- for file paths in bg index shard filenames, we would need 2^32 files
   with the same filename to expect a collision. Imperfect hashing may
   reduce this a bit but it's well beyond what's plausible.

This will invalidate shards on disk (as usual; I bumped the version),
but this time the filenames are changing so the old files will stick
around :-( So this is more expensive than the usual bump, but would be
good to land before the v9 branch when everyone will start using bg index.

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64306
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clangd/SourceCode.cpptrunk/clangd/SourceCode.cpp
The file was modified/clang-tools-extra/trunk/clangd/SourceCode.htrunk/clangd/SourceCode.h
The file was modified/clang-tools-extra/trunk/clangd/index/Background.cpptrunk/clangd/index/Background.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/Background.htrunk/clangd/index/Background.h
The file was modified/clang-tools-extra/trunk/clangd/index/BackgroundIndexStorage.cpptrunk/clangd/index/BackgroundIndexStorage.cpp
The file was modified/clang-tools-extra/trunk/clangd/index/Serialization.cpptrunk/clangd/index/Serialization.cpp
The file was modified/clang-tools-extra/trunk/clangd/unittests/SerializationTests.cpptrunk/clangd/unittests/SerializationTests.cpp

Summary

  1. [libc++] Take 2: Do not cleverly link against libc++abi just because it happens to be there Summary: Otherwise, when libcxxabi is not an enabled project in the monorepo, we get a link error because we try to link against non-existent cxxabi_shared. More generally, we shouldn't change the behavior of the build based on implicit things like whether a file happens to be at a specific path or not. This is a re-application of r365222 that had been reverted in r365233 because it broke the build bots. However, the build bots now specify explicitly what ABI library they want to use (libc++abi), so this commit should now be OK to merge. Differential Revision: https://reviews.llvm.org/D63883
Revision 365326 by Louis Dionne:
[libc++] Take 2: Do not cleverly link against libc++abi just because it happens to be there

Summary:
Otherwise, when libcxxabi is not an enabled project in the monorepo, we
get a link error because we try to link against non-existent cxxabi_shared.

More generally, we shouldn't change the behavior of the build based on
implicit things like whether a file happens to be at a specific path or
not.

This is a re-application of r365222 that had been reverted in r365233
because it broke the build bots. However, the build bots now specify
explicitly what ABI library they want to use (libc++abi), so this
commit should now be OK to merge.

Differential Revision: https://reviews.llvm.org/D63883
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/CMakeLists.txttrunk/CMakeLists.txt
The file was modified/libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmaketrunk/cmake/Modules/HandleLibCXXABI.cmake