SuccessChanges

Summary

  1. [AMDGPU] Autogenerate register sequences in tuples Differential Revision: https://reviews.llvm.org/D65007
  2. [AMDGPU] Fixed occupancy calculation for gfx10 Differential Revision: https://reviews.llvm.org/D65010
  3. Revert r366610 and r366612: Expand pseudo-components before embedding in llvm-config Some targets are missing LLVMDemangle, one is adding the LLVM prefix twice, and two are hitting the very error this patch fixes for my target. Reverting while I work through the reports.
  4. [InstCombine] Fix copy/paste mistake in the test cases I added for PR42691. NFC
  5. AMDGPU: Avoid custom predicates for stores with glue
  6. Fix a latent bug discovered by r366610: nativecodegen includes X86CodeGen when X86 is not compiled I believe this to have been a latent bug as the same expansion checks for the existence of ${native_tgt}Info and ${native_tgt}Desc and only adds them if they were compiled but unconditionally adds ${native_tgt}CodeGen. This should fix llvm-clang-x86_64-win-fast which builds ARM only on an X86 host and similar builders.
  7. [InstCombine] Add test cases for PR42691. NFC
  8. Expand pseudo-components before embedding in llvm-config Summary: If you use pseudo-targets like AllTargetsCodeGens in LLVM_DYLIB_COMPONENTS then a test will fail because `./bin/llvm-config --shared-mode` can't handle these targets. We can fix this by expanding them before embedding the string into llvm-config Reviewers: bogner Reviewed By: bogner Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65011
  9. AMDGPU: Redefine setcc condition PatLeafs Avoid using custom code predicates.
  10. AMDGPU: Don't rely on m0 being -1 for GWS offsets This only works if the high bits of m0 are also 0, so m0 would have to be set to 0xffff.
  11. AMDGPU: Force s_waitcnt after GWS instructions This is apparently required to be the immediately following instruction, so force it into a bundle with a waitcnt.
  12. LiveIntervals: Fix handleMove asserting on BUNDLE The top-level BUNDLE instruction should behave as an ordinary instruction. It is supposed to have all relevant registers as implicit operands. Moving it should work as any other instruction. I believe the assert intended to avoid moving instructions inside bundles.
Revision 366619 by rampitec:
[AMDGPU] Autogenerate register sequences in tuples

Differential Revision: https://reviews.llvm.org/D65007
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIRegisterInfo.tdtrunk/lib/Target/AMDGPU/SIRegisterInfo.td
Revision 366616 by rampitec:
[AMDGPU] Fixed occupancy calculation for gfx10

Differential Revision: https://reviews.llvm.org/D65010
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpptrunk/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUSubtarget.htrunk/lib/Target/AMDGPU/AMDGPUSubtarget.h
The file was modified/llvm/trunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpptrunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.htrunk/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props-v3.lltrunk/test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props-v3.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/idot8s.lltrunk/test/CodeGen/AMDGPU/idot8s.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/nsa-reassign.lltrunk/test/CodeGen/AMDGPU/nsa-reassign.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/regbank-reassign.mirtrunk/test/CodeGen/AMDGPU/regbank-reassign.mir
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/wave32.lltrunk/test/CodeGen/AMDGPU/wave32.ll
Revision 366615 by dsanders:
Revert r366610 and r366612: Expand pseudo-components before embedding in llvm-config

Some targets are missing LLVMDemangle, one is adding the LLVM prefix twice, and two
are hitting the very error this patch fixes for my target. Reverting while I work
through the reports.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/modules/LLVM-Config.cmaketrunk/cmake/modules/LLVM-Config.cmake
The file was modified/llvm/trunk/tools/llvm-config/BuildVariables.inc.intrunk/tools/llvm-config/BuildVariables.inc.in
The file was modified/llvm/trunk/tools/llvm-config/CMakeLists.txttrunk/tools/llvm-config/CMakeLists.txt
Revision 366614 by ctopper:
[InstCombine] Fix copy/paste mistake in the test cases I added for PR42691. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/and-or-icmps.lltrunk/test/Transforms/InstCombine/and-or-icmps.ll
Revision 366613 by arsenm:
AMDGPU: Avoid custom predicates for stores with glue
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.tdtrunk/lib/Target/AMDGPU/SIInstrInfo.td
Revision 366612 by dsanders:
Fix a latent bug discovered by r366610: nativecodegen includes X86CodeGen when X86 is not compiled

I believe this to have been a latent bug as the same expansion checks for the
existence of ${native_tgt}Info and ${native_tgt}Desc and only adds them if
they were compiled but unconditionally adds ${native_tgt}CodeGen.

This should fix llvm-clang-x86_64-win-fast which builds ARM only on an X86 host and similar builders.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/modules/LLVM-Config.cmaketrunk/cmake/modules/LLVM-Config.cmake
Revision 366611 by ctopper:
[InstCombine] Add test cases for PR42691. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/and-or-icmps.lltrunk/test/Transforms/InstCombine/and-or-icmps.ll
Revision 366610 by dsanders:
Expand pseudo-components before embedding in llvm-config

Summary:
If you use pseudo-targets like AllTargetsCodeGens in LLVM_DYLIB_COMPONENTS
then a test will fail because `./bin/llvm-config --shared-mode` can't
handle these targets. We can fix this by expanding them before embedding
the string into llvm-config

Reviewers: bogner

Reviewed By: bogner

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65011
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/modules/LLVM-Config.cmaketrunk/cmake/modules/LLVM-Config.cmake
The file was modified/llvm/trunk/tools/llvm-config/BuildVariables.inc.intrunk/tools/llvm-config/BuildVariables.inc.in
The file was modified/llvm/trunk/tools/llvm-config/CMakeLists.txttrunk/tools/llvm-config/CMakeLists.txt
Revision 366609 by arsenm:
AMDGPU: Redefine setcc condition PatLeafs

Avoid using custom code predicates.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUInstructions.tdtrunk/lib/Target/AMDGPU/AMDGPUInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SOPInstructions.tdtrunk/lib/Target/AMDGPU/SOPInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/VOPCInstructions.tdtrunk/lib/Target/AMDGPU/VOPCInstructions.td
Revision 366608 by arsenm:
AMDGPU: Don't rely on m0 being -1 for GWS offsets

This only works if the high bits of m0 are also 0, so m0 would have to
be set to 0xffff.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpptrunk/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.barrier.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.barrier.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.init.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.init.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.br.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.br.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.p.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.p.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.release.all.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.release.all.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.v.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.sema.v.ll
Revision 366607 by arsenm:
AMDGPU: Force s_waitcnt after GWS instructions

This is apparently required to be the immediately following
instruction, so force it into a bundle with a waitcnt.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/DSInstructions.tdtrunk/lib/Target/AMDGPU/DSInstructions.td
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpptrunk/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIISelLowering.htrunk/lib/Target/AMDGPU/SIISelLowering.h
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpptrunk/lib/Target/AMDGPU/SIInstrInfo.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.barrier.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.barrier.ll
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.init.lltrunk/test/CodeGen/AMDGPU/llvm.amdgcn.ds.gws.init.ll
Revision 366605 by arsenm:
LiveIntervals: Fix handleMove asserting on BUNDLE

The top-level BUNDLE instruction should behave as an ordinary
instruction. It is supposed to have all relevant registers as implicit
operands. Moving it should work as any other instruction. I believe
the assert intended to avoid moving instructions inside bundles.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/LiveIntervals.cpptrunk/lib/CodeGen/LiveIntervals.cpp
The file was added/llvm/trunk/test/CodeGen/AMDGPU/scheduler-handle-move-bundle.mirtrunk/test/CodeGen/AMDGPU/scheduler-handle-move-bundle.mir

Summary

  1. Disallow most calling convention attributes on PS4 PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi". Differential Revision: https://reviews.llvm.org/D64780
Revision 366617 by ssrivastava:
Disallow most calling convention attributes on PS4

PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi".

Differential Revision: https://reviews.llvm.org/D64780
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.tdtrunk/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/include/clang/Basic/TargetInfo.htrunk/include/clang/Basic/TargetInfo.h
The file was modified/cfe/trunk/lib/Basic/Targets/OSTargets.htrunk/lib/Basic/Targets/OSTargets.h
The file was modified/cfe/trunk/lib/Sema/SemaDeclAttr.cpptrunk/lib/Sema/SemaDeclAttr.cpp
The file was added/cfe/trunk/test/Sema/no_callconv.cpptrunk/test/Sema/no_callconv.cpp
The file was modified/cfe/trunk/unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpptrunk/unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp

Summary

  1. Revert "Fix asan infinite loop on undefined symbol" This reverts commit 8e46275488ca453a24964cb26be0736172ad1db8. This was failing on sanitizer-x86_64-linux and our internal CI.
Revision 366618 by ormris:
Revert "Fix asan infinite loop on undefined symbol"

This reverts commit 8e46275488ca453a24964cb26be0736172ad1db8.

This was failing on sanitizer-x86_64-linux and our internal CI.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/interception/interception_linux.cctrunk/lib/interception/interception_linux.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Linux/dlopen-mixed-c-cxx.ctrunk/test/asan/TestCases/Linux/dlopen-mixed-c-cxx.c

Summary

  1. [libc++] Mark libcpp_deallocate.sh.cpp as UNSUPPORTED instead of XFAIL on AppleClang 9 Some minor versions of AppleClang 9 appear not to fail the test. It's such a mess that the only sane thing to do is to mark the test as UNSUPPORTED.
Revision 366606 by Louis Dionne:
[libc++] Mark libcpp_deallocate.sh.cpp as UNSUPPORTED instead of XFAIL on AppleClang 9

Some minor versions of AppleClang 9 appear not to fail the test. It's
such a mess that the only sane thing to do is to mark the test as
UNSUPPORTED.
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpptrunk/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp