SuccessChanges

Summary

  1. [NFC,StackSafety] Fix template arg name (details)
  2. [llvm] Fix unused variable warnings (details)
  3. [mlir][Linalg] NFC - Make markers use Identifier instead of StringRef (details)
  4. TargetFrameLowering.h - remove unnecessary includes. NFC. (details)
  5. Fix MSVC "not all control paths return a value" warning. NFC. (details)
  6. [clang-tidy] add new check readability-use-anyofallof (details)
  7. [LangRef] Fix description of shape args for matrix.multiply. (details)
  8. [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (details)
  9. [AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix tests) (details)
  10. [lldb] Pass fewer parameters by non-const reference to DWARFASTParserClang::ParseSingleMember (details)
  11. attempt to fix build after add51e152aa (details)
  12. [gn build] Port add51e152aa (details)
  13. [VPlan] Support extracting lanes for defs managed in VPTransformState. (details)
  14. [LLDB] skip TestCreateDuringInstructionStep on arm/linux (details)
  15. [Scalar] Fix assignment operator for long long. (details)
  16. [lldb/cmake] Tweak descriptions of swig rules (details)
  17. Revert "[Dexter] Add DexLimitSteps command and ConditionalController" (details)
Commit 264d435ee10c699b12562eea695793199ff757f5 by Vitaly Buka
[NFC,StackSafety] Fix template arg name
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit c5468253aa555c2df98bd1f49d1e9d44b0150a2e by kadircet
[llvm] Fix unused variable warnings
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit e349fb70a23f3a39e058605e4e2db66da5e5ea4a by ntv
[mlir][Linalg] NFC - Make markers use Identifier instead of StringRef

Summary: This removes string ownership worries by putting everything into the context and allows more constructing identifiers programmatically.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D81027
The file was modifiedmlir/test/lib/Transforms/TestLinalgTransforms.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
The file was modifiedmlir/test/Dialect/Linalg/transform-patterns.mlir
Commit 7a96c181d0f09aae3ebe50c1eea71aa1b11d5789 by llvm-dev
TargetFrameLowering.h - remove unnecessary includes. NFC.

Move TargetFrameLowering.h include to the top of the TargetFrameLoweringImpl.cpp includes (clang-format doesn't do this by default as the filenames don't match).
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
Commit e6ba0a55fd39b600f3f431308f4a7e36e48f91ae by llvm-dev
Fix MSVC "not all control paths return a value" warning. NFC.

Add llvm_unreachable after switch statement for CheckerRegistry::StateFromCmdLine enum
The file was modifiedclang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp
Commit add51e152aa6dc3aa7a51901a099b2ebe8cfe377 by gehre.matthias
[clang-tidy] add new check readability-use-anyofallof

Summary:
Finds range-based for loops that can be replaced by a call to ``std::any_of`` or
``std::all_of``. In C++ 20 mode, suggests ``std::ranges::any_of`` or
``std::ranges::all_of``.
For now, no fixits are produced.

Reviewers: aaron.ballman, alexfh, hokein

Subscribers: mgorny, xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77572
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof-cpp20.cpp
The file was modifiedclang-tools-extra/clang-tidy/readability/CMakeLists.txt
The file was addedclang-tools-extra/test/clang-tidy/checkers/readability-use-anyofallof.cpp
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.h
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was modifiedclang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
The file was addedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
The file was addedclang-tools-extra/docs/clang-tidy/checks/readability-use-anyofallof.rst
Commit 90e291912ac7e3caf9251969a5c47310c6aa01ff by flo
[LangRef] Fix description of shape args for matrix.multiply.

Currently all code instances within the matrix lowering pass consider
matrix A to be MxN and B to be NxK, producing C which is MxK. Anyone
interacting with this API after reading the docs but without reading the pass
would expect A: MxK, B: KxN, and C: MxN. These changes bring the documentation
in line with the implementation.

One point of concern with this, the original signature as described in the docs
may be better or at least more expected. The interface as it was written
reflected other common matrix multiplication interfaces such as BLAS'[1], where
the matrices are MxK, KxN, MxN respectively. Choosing to honor this requires
changing code and tests instead, but should be mostly just renaming of variables.

Patch by Braedy Kuzma <braedy@ualberta.ca>

[1] http://www.netlib.org/lapack/explore-html/db/dc9/group__single__blas__level3_gafe51bacb54592ff5de056acabd83c260.html#gafe51bacb54592ff5de056acabd83c260

Reviewers: anemet, LuoYuanke, nicolasvasilache, fhahn

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D80663
The file was modifiedllvm/docs/LangRef.rst
Commit 8beaba13b8a61697008854b82ed3b45377af9d9d by lucas.prates
[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

Summary:
During CodeGen for AArch64 Neon intrinsics, Clang was incorrectly
assuming all the pointers from which loads were being generated for vld1
intrinsics were aligned according to the intrinsics result type, causing
alignment faults on the code generated by the backend.

This patch updates vld1 intrinsics' CodeGen to properly capture the
correct load alignment based on the type of the pointer provided as
input for the intrinsic.

Reviewers: t.p.northover, ostannard, pcc, efriedma

Reviewed By: ostannard, efriedma

Subscribers: echristo, plotfi, nickdesaulniers, efriedma, kristof.beyls, danielkiss, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79721
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/test/CodeGen/aarch64-neon-intrinsics.c
Commit c27214c23446e423ec2e7eb8650a65cc5f0a16aa by jay.foad
[AMDGPU] Fold llvm.amdgcn.cos and llvm.amdgcn.sin intrinsics (fix tests)

Try to fix Windows buildbots.
The file was modifiedllvm/test/Analysis/ConstantFolding/AMDGPU/cos.ll
The file was modifiedllvm/test/Analysis/ConstantFolding/AMDGPU/sin.ll
Commit c0ccb582c35f29df55ccc421dd5d03a7220456cf by Raphael Isemann
[lldb] Pass fewer parameters by non-const reference to DWARFASTParserClang::ParseSingleMember

These parameters are only passed on by value or const reference, so we should
do the same when calling this function.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Commit fd2740143e626ca32432aac0b51b2880a3b1e0bc by thakis
attempt to fix build after add51e152aa
The file was modifiedclang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
Commit 99b8f3570a3f0d725a6111ceeed015d302bd4bc7 by llvmgnsyncbot
[gn build] Port add51e152aa
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn
Commit 211596c94e92d179e095734b23899d877c8fc3e5 by flo
[VPlan] Support extracting lanes for defs managed in VPTransformState.

Currently extracting a lane for a VPValue def is not supported, if it is
managed directly by VPTransformState (e.g. because it is created by a
VPInstruction or an external VPValue def).

For now, simply extract the requested lane. In the future, we should
also cache the extracted scalar values, similar to LV.

Reviewers: Ayal, rengolin, gilr, SjoerdMeijer

Reviewed By: SjoerdMeijer

Differential Revision: https://reviews.llvm.org/D80787
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
Commit 884aaf7f645a27239923e21112c9817836c696df by omair.javaid
[LLDB] skip TestCreateDuringInstructionStep on arm/linux

There are sporadic failures in this test on arm. I am marking it
skipped as labath suggested flaky decorators no longer work.
The file was modifiedlldb/test/API/linux/thread/create_during_instruction_step/TestCreateDuringInstructionStep.py
Commit 798644e0a4524e73e1f95202951f10f2086217c3 by pavel
[Scalar] Fix assignment operator for long long.

Summary:
Assignment operator `operator=(long long)` currently allocates `sizeof(long)`.
On some platforms it works as they have `sizeof(long) == sizeof(long long)`,
but on others (e.g. Windows) it's not the case.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D80995
The file was modifiedlldb/source/Utility/Scalar.cpp
The file was modifiedlldb/unittests/Utility/ScalarTest.cpp
Commit a48c76cf43806c30bab5e8eacd5a08058c83c578 by pavel
[lldb/cmake] Tweak descriptions of swig rules

This descriptions are printed while running the command, and so the
continuous tense is more appropriate and consistent.
The file was modifiedlldb/bindings/CMakeLists.txt
Commit 05eabb52045f3a20e137ff217b6fc1d5bd1155b4 by Tom.Weaver
Revert "[Dexter] Add DexLimitSteps command and ConditionalController"

This reverts commit 81e836a5a675f6a3d9d35560fddbbb87fdf66201.

Accidentally committed a diff file.
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_same_line_conditional.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py
The file was removeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py
The file was modifieddebuginfo-tests/dexter/dex/command/ParseCommand.py
The file was modifieddebuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_value.cpp
The file was modifieddebuginfo-tests/dexter/Commands.md
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_overlapping_ranges.cpp
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_check_json_step_count.cpp
The file was modifieddebuginfo-tests/dexter/dex/debugger/DebuggerBase.py
The file was removeddebuginfo-tests/dexter/feature_tests/commands/perfect/limit_steps/limit_steps_expect_loop.cpp
The file was removeddebuginfo-tests/dexter/dex/command/commands/DexLimitSteps.py
The file was removeddebuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py
The file was removedd.diff
The file was modifieddebuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
The file was modifieddebuginfo-tests/dexter/dex/tools/test/Tool.py