SuccessChanges

Summary

  1. [clang-reorder-fields] Emit warning when reordering breaks member init list dependencies This diff adds a warning emitted by clang-reorder-fields when reordering breaks dependencies in the initializer list. Patch by Sam Conrad! Differential revision: https://reviews.llvm.org/D35972
  2. CodeGenModule.cpp: [PR33810][Modules] Remove an assertion that confirms MangledDeclNames[CanonicalGD] might be still empty. FIXME: It is accepted that MangledDeclNames[CanonicalGD] is overwritten here?
  3. PR33902: Invalidate line number cache when adding more text to existing buffer. This led to crashes as the line number cache would report a bogus line number for a line of code, and we'd try to find a nonexistent column within the line when printing diagnostics.
  4. [X86] Add addsub intrinsics to the intrinsic lowering table so we have a single set of isel patterns.
  5. CodeGenModule.cpp: [PR33810][Modules] Avoid reusing FoundStr to try to fix crash. MangledDeclNames might grow up and be reallocated when it were reused by reentering CodeGenModule::getMangledName().
Revision 309505 by alexshap:
[clang-reorder-fields] Emit warning when reordering breaks member init list dependencies

This diff adds a warning emitted by clang-reorder-fields
when reordering breaks dependencies in the initializer list.

Patch by Sam Conrad!

Differential revision: https://reviews.llvm.org/D35972
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-reorder-fields/ReorderFieldsAction.cppclang-tools-extra.src/clang-reorder-fields/ReorderFieldsAction.cpp
The file was added/clang-tools-extra/trunk/test/clang-reorder-fields/ClassDerived.cppclang-tools-extra.src/test/clang-reorder-fields/ClassDerived.cpp
The file was added/clang-tools-extra/trunk/test/clang-reorder-fields/FieldDependencyWarning.cppclang-tools-extra.src/test/clang-reorder-fields/FieldDependencyWarning.cpp
The file was added/clang-tools-extra/trunk/test/clang-reorder-fields/FieldDependencyWarningDerived.cppclang-tools-extra.src/test/clang-reorder-fields/FieldDependencyWarningDerived.cpp
Revision 309504 by chapuni:
CodeGenModule.cpp: [PR33810][Modules] Remove an assertion that confirms MangledDeclNames[CanonicalGD] might be still empty.

FIXME: It is accepted that MangledDeclNames[CanonicalGD] is overwritten here?
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cppclang.src/lib/CodeGen/CodeGenModule.cpp
Revision 309503 by rsmith:
PR33902: Invalidate line number cache when adding more text to existing buffer.

This led to crashes as the line number cache would report a bogus line number
for a line of code, and we'd try to find a nonexistent column within the line
when printing diagnostics.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Lex/ScratchBuffer.cppclang.src/lib/Lex/ScratchBuffer.cpp
The file was modified/cfe/trunk/test/Misc/caret-diags-multiline.cppclang.src/test/Misc/caret-diags-multiline.cpp
Revision 309502 by ctopper:
[X86] Add addsub intrinsics to the intrinsic lowering table so we have a single set of isel patterns.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86InstrSSE.tdllvm.src/lib/Target/X86/X86InstrSSE.td
The file was modified/llvm/trunk/lib/Target/X86/X86IntrinsicsInfo.hllvm.src/lib/Target/X86/X86IntrinsicsInfo.h
Revision 309501 by chapuni:
CodeGenModule.cpp: [PR33810][Modules] Avoid reusing FoundStr to try to fix crash.

MangledDeclNames might grow up and be reallocated when it were reused by reentering CodeGenModule::getMangledName().
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cppclang.src/lib/CodeGen/CodeGenModule.cpp