SuccessChanges

Summary

  1. [X86] Extending a test cases for LEA factorization. Submitted on the behalf of Jatin Bhateja Differential Revision: https://reviews.llvm.org/D36048
  2. Fix release notes indentation from r309562 The additions in r309562 triggered a docs buildbot failure.
  3. [Cost] Rename getReductionCost() to getArithmeticReductionCost(), NFC.
  4. Document '-Wpragma-pack' in the release notes
  5. [SelectionDAG][mips] Fix PR33883 PR33883 shows that calls to intrinsic functions should not have their vector arguments or returns subject to ABI changes required by the target. This resolves PR33883. Thanks to Alex Crichton for reporting the issue! Reviewers: zoran.jovanovic, atanasyan Differential Revision: https://reviews.llvm.org/D35765
  6. -Wpragma-pack: add an additional note and fixit when warning about unterminated push directives that are followed by a reset ('#pragma pack()') This has been suggested by Hans Wennborg.
  7. [LV] Avoid redundant operations manipulating masks The Loop Vectorizer generates redundant operations when manipulating masks: AND with true, OR with false, compare equal to true. Instead of relying on a subsequent pass to clean them up, this patch avoids generating them. Use null (no-mask) to represent all-one full masks, instead of a constant all-one vector, following the convention of masked gathers and scatters. Preparing for a follow-up VPlan patch in which these mask manipulating operations are modeled using recipes. Differential Revision: https://reviews.llvm.org/D35725
  8. [CMake][Modules] libclang: Ignore _CINDEX_LIB_ and CLANG_TOOL_EXTRA_BUILD for -fmodules. CLANG_TOOL_EXTRA_BUILD doesn't affect headers. _CINDEX_LIB_ is defined when the target is SHARED. On Win32, it affects clang-c/Platform.h and it shouldn't be ignored. This is part of https://reviews.llvm.org/D35559
  9. [llvm-dlltool] Write correct weak externals Previously, the created object files for the import library were broken. Write the symbol table before the string table. Simplify the code by using a separate variable Prefix instead of duplicating a few lines. Also update the coff-weak-exports to actually check that the generated weak symbols can be found as intended. Differential Revision: https://reviews.llvm.org/D36065
  10. Guard print() functions only used by dump() functions. Summary: Since r293359, most dump() function are only defined when `!defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)` holds. print() functions only used by dump() functions are now unused in release builds, generating lots of warnings. This patch only defines some print() functions if they are used. Reviewers: MatzeB Reviewed By: MatzeB Subscribers: arsenm, mzolotukhin, nhaehnle, llvm-commits Differential Revision: https://reviews.llvm.org/D35949
  11. [Modules] llvm-config: Exclude CMAKE_CFG_INTDIR. It isn't used in headers. This is part of https://reviews.llvm.org/D35559
Revision 309565 by rksimon:
[X86] Extending a test cases for LEA factorization.

Submitted on the behalf of Jatin Bhateja

Differential Revision: https://reviews.llvm.org/D36048
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/lea-opt-cse3.llllvm.src/test/CodeGen/X86/lea-opt-cse3.ll
Revision 309564 by arphaman:
Fix release notes indentation from r309562

The additions in r309562 triggered a docs buildbot failure.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/ReleaseNotes.rstclang.src/docs/ReleaseNotes.rst
Revision 309563 by abataev:
[Cost] Rename getReductionCost() to getArithmeticReductionCost(), NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.hllvm.src/include/llvm/Analysis/TargetTransformInfo.h
The file was modified/llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.hllvm.src/include/llvm/Analysis/TargetTransformInfoImpl.h
The file was modified/llvm/trunk/include/llvm/CodeGen/BasicTTIImpl.hllvm.src/include/llvm/CodeGen/BasicTTIImpl.h
The file was modified/llvm/trunk/lib/Analysis/CostModel.cppllvm.src/lib/Analysis/CostModel.cpp
The file was modified/llvm/trunk/lib/Analysis/TargetTransformInfo.cppllvm.src/lib/Analysis/TargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cppllvm.src/lib/Target/X86/X86TargetTransformInfo.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86TargetTransformInfo.hllvm.src/lib/Target/X86/X86TargetTransformInfo.h
The file was modified/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cppllvm.src/lib/Transforms/Vectorize/SLPVectorizer.cpp
Revision 309562 by arphaman:
Document '-Wpragma-pack' in the release notes
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/docs/ReleaseNotes.rstclang.src/docs/ReleaseNotes.rst
Revision 309561 by sdardis:
[SelectionDAG][mips] Fix PR33883

PR33883 shows that calls to intrinsic functions should not have their vector
arguments or returns subject to ABI changes required by the target.

This resolves PR33883.

Thanks to Alex Crichton for reporting the issue!

Reviewers: zoran.jovanovic, atanasyan

Differential Revision: https://reviews.llvm.org/D35765
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
The file was added/llvm/trunk/test/CodeGen/Mips/cconv/pr33883.llllvm.src/test/CodeGen/Mips/cconv/pr33883.ll
Revision 309559 by arphaman:
-Wpragma-pack: add an additional note and fixit when warning
about unterminated push directives that are followed by a reset
('#pragma pack()')

This has been suggested by Hans Wennborg.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.tdclang.src/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/lib/Sema/SemaAttr.cppclang.src/lib/Sema/SemaAttr.cpp
The file was added/cfe/trunk/test/FixIt/fixit-pragma-pack.cclang.src/test/FixIt/fixit-pragma-pack.c
The file was modified/cfe/trunk/test/PCH/suspicious-pragma-pack.cclang.src/test/PCH/suspicious-pragma-pack.c
The file was modified/cfe/trunk/test/Sema/pragma-pack.cclang.src/test/Sema/pragma-pack.c
Revision 309558 by ayalz:
[LV] Avoid redundant operations manipulating masks

The Loop Vectorizer generates redundant operations when manipulating masks:
AND with true, OR with false, compare equal to true. Instead of relying on
a subsequent pass to clean them up, this patch avoids generating them.

Use null (no-mask) to represent all-one full masks, instead of a constant
all-one vector, following the convention of masked gathers and scatters.

Preparing for a follow-up VPlan patch in which these mask manipulating
operations are modeled using recipes.

Differential Revision: https://reviews.llvm.org/D35725
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/IR/IRBuilder.cppllvm.src/lib/IR/IRBuilder.cpp
The file was modified/llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cppllvm.src/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modified/llvm/trunk/test/Transforms/LoopVectorize/if-pred-non-void.llllvm.src/test/Transforms/LoopVectorize/if-pred-non-void.ll
The file was modified/llvm/trunk/test/Transforms/LoopVectorize/if-pred-stores.llllvm.src/test/Transforms/LoopVectorize/if-pred-stores.ll
Revision 309557 by chapuni:
[CMake][Modules] libclang: Ignore _CINDEX_LIB_ and CLANG_TOOL_EXTRA_BUILD for -fmodules.

CLANG_TOOL_EXTRA_BUILD doesn't affect headers.

_CINDEX_LIB_ is defined when the target is SHARED.
On Win32, it affects clang-c/Platform.h and it shouldn't be ignored.

This is part of https://reviews.llvm.org/D35559
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/libclang/CMakeLists.txtclang.src/tools/libclang/CMakeLists.txt
Revision 309555 by mstorsjo:
[llvm-dlltool] Write correct weak externals

Previously, the created object files for the import library were broken.
Write the symbol table before the string table. Simplify the code by
using a separate variable Prefix instead of duplicating a few lines.

Also update the coff-weak-exports to actually check that the generated
weak symbols can be found as intended.

Differential Revision: https://reviews.llvm.org/D36065
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Object/COFFImportFile.cppllvm.src/lib/Object/COFFImportFile.cpp
The file was modified/llvm/trunk/test/DllTool/coff-weak-exports.defllvm.src/test/DllTool/coff-weak-exports.def
Revision 309553 by fhahn:
Guard print() functions only used by dump() functions.

Summary:
Since  r293359, most dump() function are only defined when
`!defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)` holds. print() functions
only used by dump() functions are now unused in release builds,
generating lots of warnings. This patch only defines some print()
functions if they are used.

Reviewers: MatzeB

Reviewed By: MatzeB

Subscribers: arsenm, mzolotukhin, nhaehnle, llvm-commits

Differential Revision: https://reviews.llvm.org/D35949
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/CodeGenPrepare.cppllvm.src/lib/CodeGen/CodeGenPrepare.cpp
The file was modified/llvm/trunk/lib/CodeGen/LiveDebugVariables.cppllvm.src/lib/CodeGen/LiveDebugVariables.cpp
The file was modified/llvm/trunk/lib/CodeGen/MachinePipeliner.cppllvm.src/lib/CodeGen/MachinePipeliner.cpp
The file was modified/llvm/trunk/lib/CodeGen/WinEHPrepare.cppllvm.src/lib/CodeGen/WinEHPrepare.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cppllvm.src/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDILCFGStructurizer.cppllvm.src/lib/Target/AMDGPU/AMDILCFGStructurizer.cpp
The file was modified/llvm/trunk/lib/Target/Hexagon/HexagonConstPropagation.cppllvm.src/lib/Target/Hexagon/HexagonConstPropagation.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/SampleProfile.cppllvm.src/lib/Transforms/IPO/SampleProfile.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/GuardWidening.cppllvm.src/lib/Transforms/Scalar/GuardWidening.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cppllvm.src/lib/Transforms/Scalar/LoopStrengthReduce.cpp
Revision 309552 by chapuni:
[Modules] llvm-config: Exclude CMAKE_CFG_INTDIR. It isn't used in headers.

This is part of https://reviews.llvm.org/D35559
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/llvm-config/CMakeLists.txtllvm.src/tools/llvm-config/CMakeLists.txt