SuccessChanges

Summary

  1. [MathExtras] Remove unnecessary cast of a constant 1 in a subtract. Pretty sure this will automatically promoted to match the type of the other operand of the subtract. There's plenty of other similar code around here without this cast.
  2. [StackColoring] Update AliasAnalysis information in stack coloring pass Stack coloring pass need to maintain AliasAnalysis information when merging stack slots of different types. Actually, there is a FIXME comment in StackColoring.cpp // FIXME: In order to enable the use of TBAA when using AA in CodeGen, // we'll also need to update the TBAA nodes in MMOs with values // derived from the merged allocas. But, TBAA has been already enabled in CodeGen without fixing this pass. The incorrect TBAA metadata results in recent failures in bootstrap test on ppc64le (PR33928) by allowing unsafe instruction scheduling. Although we observed the problem on ppc64le, this is a platform neutral issue. This patch makes the stack coloring pass maintains AliasAnalysis information when merging multiple stack slots.
  3. [libFuzzer] implement more correct way of computing feature index for Inline8bitCounters
Revision 309653 by ctopper:
[MathExtras] Remove unnecessary cast of a constant 1 in a subtract.

Pretty sure this will automatically promoted to match the type of the other operand of the subtract. There's plenty of other similar code around here without this cast.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/MathExtras.hllvm.src/include/llvm/Support/MathExtras.h
Revision 309651 by inouehrs:
[StackColoring] Update AliasAnalysis information in stack coloring pass

Stack coloring pass need to maintain AliasAnalysis information when merging stack slots of different types.
Actually, there is a FIXME comment in StackColoring.cpp

// FIXME: In order to enable the use of TBAA when using AA in CodeGen,
// we'll also need to update the TBAA nodes in MMOs with values
// derived from the merged allocas.

But, TBAA has been already enabled in CodeGen without fixing this pass.
The incorrect TBAA metadata results in recent failures in bootstrap test on ppc64le (PR33928) by allowing unsafe instruction scheduling.
Although we observed the problem on ppc64le, this is a platform neutral issue.

This patch makes the stack coloring pass maintains AliasAnalysis information when merging multiple stack slots.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/ValueTracking.hllvm.src/include/llvm/Analysis/ValueTracking.h
The file was modified/llvm/trunk/include/llvm/CodeGen/MachineFunction.hllvm.src/include/llvm/CodeGen/MachineFunction.h
The file was modified/llvm/trunk/include/llvm/CodeGen/MachineInstr.hllvm.src/include/llvm/CodeGen/MachineInstr.h
The file was modified/llvm/trunk/lib/Analysis/ValueTracking.cppllvm.src/lib/Analysis/ValueTracking.cpp
The file was modified/llvm/trunk/lib/CodeGen/MachineFunction.cppllvm.src/lib/CodeGen/MachineFunction.cpp
The file was modified/llvm/trunk/lib/CodeGen/ScheduleDAGInstrs.cppllvm.src/lib/CodeGen/ScheduleDAGInstrs.cpp
The file was modified/llvm/trunk/lib/CodeGen/StackColoring.cppllvm.src/lib/CodeGen/StackColoring.cpp
Revision 309647 by kcc:
[libFuzzer] implement more correct way of computing feature index for Inline8bitCounters
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Fuzzer/FuzzerTracePC.hllvm.src/lib/Fuzzer/FuzzerTracePC.h
The file was modified/llvm/trunk/lib/Fuzzer/test/FuzzerUnittest.cppllvm.src/lib/Fuzzer/test/FuzzerUnittest.cpp