FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. Check result of emitStrLen before passing it to CreateGEP (details)
  2. [clang][IFS][test][NFC] Tightening up clang-ifs tests to use -cc1 more (details)
  3. [clang][IFS][test] Removing -shared, fixing triple: (details)
  4. [clang][IFS][test] Reverting driver-test.c to what it was prior to (details)
  5. [LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules (details)
  6. [lldb][NFC] Simplify IOHandler constructor/destructor setup (details)
  7. DWARFDebugLoclists: stricter base address handling (details)
  8. [ThinLTO] Add correctness check for RO/WO variable import (details)
  9. [NFC] Fix typo in ARMBaseRegisterInfo (details)
  10. [AArch64][DebugInfo] Fix incorrect call site param value produced by (details)
  11. [InstCombine] Fold PHIs with equal incoming pointers (details)
  12. [lldb] Fix that trailing backslashes in source lines break the Clang (details)
  13. Revert "[InstCombine] Fold PHIs with equal incoming pointers" (details)
  14. Fix use of add_llvm_tool in projects that build no targets (details)
  15. [NFC] Add one test for PowerPC to verify the sext_inreg for vector type. (details)
Commit 3db6783d8a7da05a5949bb18e6c8809306c9d0de by dimitry
Check result of emitStrLen before passing it to CreateGEP
Summary: This fixes PR43081, where the transformation of `strchr(p, 0)
-> p + strlen(p)` can cause a segfault, if `-fno-builtin-strlen` is
used.  In that case, `emitStrLen` returns nullptr, which CreateGEP is
not designed to handle.  Also add the minimized code from the PR as a
test case.
Reviewers: xbolva00, spatel, jdoerfert, efriedma
Reviewed By: efriedma
Subscribers: lebedev.ri, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D70143
The file was addedllvm/test/Transforms/InstCombine/pr43081.ll
The file was modifiedllvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
Commit e782192d5e6540b0cbb957a6b738d98e24c88ee3 by puyan
[clang][IFS][test][NFC] Tightening up clang-ifs tests to use -cc1 more
often.
Unless the test is explicitly testing a driver feature if clang
interface stubs I have changed the tests to use %clang_cc1. This should
make some changes I plan to make to the driver job pipeline cause fewer
test changes and breakages.
The file was modifiedclang/test/InterfaceStubs/driver-test.c
The file was modifiedclang/test/InterfaceStubs/namespace.cpp
The file was modifiedclang/test/InterfaceStubs/weak.cpp
The file was modifiedclang/test/InterfaceStubs/template-template-parm-decl.cpp
The file was modifiedclang/test/InterfaceStubs/virtual.cpp
The file was modifiedclang/test/InterfaceStubs/inline.c
The file was modifiedclang/test/InterfaceStubs/function-template-specialization.cpp
The file was modifiedclang/test/InterfaceStubs/class-template-partial-specialization.cpp
The file was modifiedclang/test/InterfaceStubs/hidden-class-inheritance.cpp
The file was modifiedclang/test/InterfaceStubs/template-namespace-function.cpp
The file was modifiedclang/test/InterfaceStubs/visibility.cpp
The file was modifiedclang/test/InterfaceStubs/windows.cpp
The file was modifiedclang/test/InterfaceStubs/object.c
The file was modifiedclang/test/InterfaceStubs/template-constexpr.cpp
The file was modifiedclang/test/InterfaceStubs/class-template-specialization.cpp
The file was modifiedclang/test/InterfaceStubs/cxx-conversion.cpp
The file was modifiedclang/test/InterfaceStubs/indirect-field-decl.cpp
The file was modifiedclang/test/InterfaceStubs/var-template-specialization-decl.cpp
The file was modifiedclang/test/InterfaceStubs/externstatic.c
The file was modifiedclang/test/InterfaceStubs/trycatch.cpp
The file was modifiedclang/test/InterfaceStubs/usings.cpp
The file was modifiedclang/test/InterfaceStubs/non-type-template-parm-decl.cpp
Commit c72aef999c3359f4305bf99116be604e16844aab by puyan
[clang][IFS][test] Removing -shared, fixing triple:
driver-test.c/windows.cpp.
Removing -shared as it is not used on a lot of targets in order to green
failing bots with this change. Also, tiding up the windows.cpp test as
the triple compile out can look slightly different that what you
specified on a windows bot.
The file was modifiedclang/test/InterfaceStubs/windows.cpp
The file was modifiedclang/test/InterfaceStubs/driver-test.c
Commit 4873319f973ba86c5d1226e87cdc3a7c085451bb by puyan
[clang][IFS][test] Reverting driver-test.c to what it was prior to
e782192d5e6
My mistake. Changes I had in this test were for code changes that are
not landed yet. I am reverting driver-test.c back to what it was
originally.
The file was modifiedclang/test/InterfaceStubs/driver-test.c
Commit f9f30f2ecba520fa1ce33ae7c27c807a0e7199be by omair.javaid
[LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules
This patch fixes whitespace/tabs mismatch in
lldb/packages/Python/lldbsuite/test/make/Makefile.rules
Legacy make files always used tabs though modern make version can work
with white-spaces I have chosen the legacy just to be safe.
Signed-off-by: Muhammad Omair Javaid <omair.javaid@linaro.org>
Differential Revision: https://reviews.llvm.org/D70154
The file was modifiedlldb/packages/Python/lldbsuite/test/make/Makefile.rules
Commit ea2ba51b0b2f5bc0bea650bf64e5cbd63476563f by Raphael Isemann
[lldb][NFC] Simplify IOHandler constructor/destructor setup
We only need a default constructor because of DISALLOW_COPY_AND_ASSIGN,
but the non-virtual destructor isn't needed.
The file was modifiedlldb/include/lldb/Core/IOHandler.h
Commit eafe0cf5fa8255257bac3923237e62382610e6d6 by pavel
DWARFDebugLoclists: stricter base address handling
Summary: This removes the use of zero as a base address in section-based
dumping. Although this will often be true for (unlinked) object files
with a single compile unit, it is not true in general. This means that
section-based dumping will not be able to resolve entries referencing
the base address (DW_LLE_offset_pair) -- it wasn't able to do that
correctly before either, but now it will be more explicit about it. One
exception to that is if the location list contains an explicit
DW_LLE_base_address entry -- in this case the dumper will pick it up,
and resolve subsequent entries normally.
The patch also removes the fallback to zero in the "inline" dumping in
case the compile unit does not contain a base address.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70115
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDie.cpp
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists_multiple.s
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
The file was modifiedllvm/test/DebugInfo/X86/dwarfdump-debug-loclists.test
Commit a2292cc537b561416c21e8d4017715d652c144cc by evgeny
[ThinLTO] Add correctness check for RO/WO variable import
This patch adds an assertion check for exported read/write-only
variables to be also in import list for module. If they aren't we may
face linker errors, because read/write-only variables are internalized
in their source modules. The patch also changes export lists to store
ValueInfo instead of GUID for performance considerations.
Differential revision: https://reviews.llvm.org/D70128
The file was modifiedllvm/lib/Transforms/Utils/FunctionImportUtils.cpp
The file was modifiedllvm/include/llvm/Transforms/IPO/WholeProgramDevirt.h
The file was modifiedllvm/include/llvm/Transforms/IPO/FunctionImport.h
The file was modifiedllvm/lib/LTO/ThinLTOCodeGenerator.cpp
The file was modifiedllvm/lib/Transforms/IPO/FunctionImport.cpp
The file was modifiedllvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
The file was modifiedllvm/include/llvm/LTO/LTO.h
The file was modifiedllvm/lib/LTO/LTO.cpp
Commit e78083929d1a949f21d7d355b3c00a2ed00efabb by anna.welker
[NFC] Fix typo in ARMBaseRegisterInfo
The file was modifiedllvm/lib/Target/ARM/ARMBaseRegisterInfo.cpp
Commit 2eb0862ed8a824f0d02c3df6ec4e05175cf8c3f1 by djordje.todorovic
[AArch64][DebugInfo] Fix incorrect call site param value produced by
MOVZXi
This resolves the problem with the truncation of the immediate operand.
Differential Revision: https://reviews.llvm.org/D70168
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was addedllvm/test/DebugInfo/MIR/AArch64/dbgcall-site-interpret-movzxi.mir
Commit a2f6ae9abffcba260c22bb235879f0576bf3b783 by suc-daniil
[InstCombine] Fold PHIs with equal incoming pointers
This is a resubmission of bbb29738b58aaf6f6518269abdcf8f64131665a9 that
was reverted due to clang tests failures. It includes the fix and
additional IR tests for the missed case.
Summary: In case when all incoming values of a PHI are equal pointers,
this transformation inserts a definition of such a pointer right after
definition of the base pointer and replaces with this value both PHI and
all it's incoming pointers. Primary goal of this transformation is
canonicalization of this pattern in order to enable optimizations that
can't handle PHIs. Non-inbounds pointers aren't currently supported.
Reviewers: spatel, RKSimon, lebedev.ri, apilipenko
Reviewed By: apilipenko
Tags: #llvm
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D68128
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombinePHI.cpp
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineInternal.h
The file was modifiedllvm/test/Transforms/InstCombine/phi-equal-incoming-pointers.ll
Commit 8715ffdf1aafbfca7c3d7f1622fe586243f31df1 by Raphael Isemann
[lldb] Fix that trailing backslashes in source lines break the Clang
highlighter
Summary: Clang's raw Lexer doesn't produce any tokens for trailing
backslashes in a line. This doesn't work with LLDB's Clang highlighter
which builds the source code to display from the list of tokens the
Lexer returns. This causes that lines with trailing backslashes are
lacking the backslash and the following newline when rendering source
code in LLDB.
This patch removes the trailing newline from the current line we are
highlighting. This way Clang doesn't drop the backslash token and we
just restore the newline after tokenising.
Fixes rdar://57091487
Reviewers: JDevlieghere, labath
Reviewed By: JDevlieghere, labath
Subscribers: labath, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70177
The file was modifiedlldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp
The file was modifiedlldb/unittests/Language/Highlighting/HighlighterTest.cpp
Commit 4c9d0da8382f176a2fb7b97298932a53d22e8627 by suc-daniil
Revert "[InstCombine] Fold PHIs with equal incoming pointers"
This reverts commit a2f6ae9abffcba260c22bb235879f0576bf3b783. It is
reverted due to clang-cmake-armv7-selfhost buildbot failure.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineInternal.h
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombinePHI.cpp
The file was modifiedllvm/test/Transforms/InstCombine/phi-equal-incoming-pointers.ll
Commit e73177ea5fd611026abcbaecc6232eee8d8d2ed8 by kevin.petit
Fix use of add_llvm_tool in projects that build no targets
Projects that set LLVM_TARGETS_TO_BUILD to an empty list can't use
add_llvm_tool (and probably other macros).
Here's the error that this change fixes:
list sub-command REMOVE_ITEM requires two or more arguments.
https://reviews.llvm.org/D70167
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
The file was modifiedllvm/cmake/modules/LLVM-Config.cmake
Commit bcb6829ee625845d841a0f949c60cc2699473cbd by qshanz
[NFC] Add one test for PowerPC to verify the sext_inreg for vector type.
The file was addedllvm/test/CodeGen/PowerPC/sext-vector-inreg.ll