FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [ADT] Move drop_begin from iterator_range.h into STLExtras. (details)
  2. [clangd] Expose value of enumerators to Hover API. (not UI yet) (details)
  3. [clangd] Ignore more implicit nodes in computing selection. (details)
  4. Improve VFS compatibility on Windows (details)
  5. [AMDGPU][HIP] Change default DWARF version to 4 (details)
  6. Use ForEachExternalModule in ParseTypeFromClangModule (NFC) (details)
  7. [LLDB] Make a clear distinction between usage & development docs (details)
  8. Rename DWO -> Clang module to avoid confusion. (NFC) (details)
  9. Convert UpdateExternalModuleListIfNeeded to use early exits. (details)
  10. Convert condition to early exit (NFC) (details)
  11. Fix incorrect comment. (details)
  12. [OPENMP]Add assignment operator in UDR test, NFC. (details)
  13. [clang-include-fixer] Skip .rc files when finding symbols (details)
  14. Make the language more consistent since I'm about to commit a content (details)
  15. [InstCombine] remove duplicate code for simplifying a shuffle; NFCI (details)
  16. Document more specifically the rounding for "llvm.round". (details)
  17. [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows (details)
  18. Replace wrongly deleted header banner, fix formatting (details)
  19. [clang-format] Fixed edge-case with SpacesInSquareBrackets with trailing (details)
  20. [ExpandReductions] Don't push all intrinsics to the worklist. Just push (details)
  21. [RISCV] Fix wrong CFI directives (details)
  22. [llvm-objcopy][COFF] Add support for extended relocation tables (details)
  23. Add support for multi-module bitcode files to llvm-dis (details)
  24. [RISCV] Use addi rather than add x0 (details)
  25. Update lit infra to detect "MemoryWithOrigins' sanitizer build. (details)
  26. [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly. (details)
  27. [Hexagon] Validate the iterators before converting them to mux. (details)
  28. [Pipeliner] Fix an assertion caused by iterator invalidation. (details)
  29. Fix up lit's tests to run in a multi-config build environment. (details)
  30. [lldb][Editline] Support ctrl+left/right arrow word navigation. (details)
Commit 058bc4c8d48a1f3644845f4795832391bc5eb9de by Lang Hames
[ADT] Move drop_begin from iterator_range.h into STLExtras.
Summary: drop_begin depends on adl_begin/adl_end, which are defined in
STLExtras.h, but we can't just #include STLExtras.h in iterator_range.h
as that would introduce a circular reference (STLExtras.h already
depends on iterator_range.h). The simplest solution is to move
drop_begin into STLExtras.h, which is a reasonable home for it anyway.
Reviewers: dblaikie
Subscribers: dexonsmith, ributzka, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70189
The file was modifiedllvm/unittests/ADT/IteratorTest.cpp
The file was modifiedllvm/include/llvm/ADT/iterator_range.h
The file was modifiedllvm/unittests/ADT/STLExtrasTest.cpp
The file was modifiedllvm/include/llvm/ADT/STLExtras.h
Commit 37abeed8145b5faf02ca9ae3ffedf46b52947f41 by sam.mccall
[clangd] Expose value of enumerators to Hover API. (not UI yet)
Summary: This is part of https://github.com/clangd/clangd/issues/180.
Reviewers: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70209
The file was modifiedclang-tools-extra/clangd/XRefs.cpp
The file was modifiedclang-tools-extra/clangd/unittests/XRefsTests.cpp
Commit bbcbb10e2d0848b611c51b1ff56c758645c55f3b by sam.mccall
[clangd] Ignore more implicit nodes in computing selection.
Summary: The DeclRefExpr for the callee of overloaded `operator()` and
`operator[]` are assigned the range of the paren/bracket lists in the
AST. These are better thought of as implicit (at least `()` - `[] is
murkier). But there's no bit on Expr for implicit, so just ignore them
on our side.
While here, deal with the case where an implicit stmt (e.g.
implicit-this) is wrapped in an implicit cast. Previously we ignored the
statement but not the cast, and so the cast ended up being selected.
Fixes https://github.com/clangd/clangd/issues/195
Reviewers: kadircet, lh123
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70194
The file was modifiedclang-tools-extra/clangd/unittests/SelectionTests.cpp
The file was modifiedclang-tools-extra/clangd/Selection.cpp
Commit 1275ab1620b665eb06231ce3c4e5068c97d9b618 by amccarth
Improve VFS compatibility on Windows
Keys in a virtual file system can be in Posix or Windows form or even a
combination of the two.  Many VFS tests (and a few Clang tests) were
XFAILed on Windows because of false negatives when comparing paths.
First, we default CaseSenstive to false on Windows.  This allows drive
letters like "D:" to match "d:".  Windows filesystems are, by default,
case insensitive, so this makes sense even beyond the drive letter.
Second, we allow slashes to match backslashes when they're used as the
root component of a path.
Both of these changes are limited to RedirectingFileSystems, so there's
little chance of affecting other path handling.
These changes allow eleven of the VFS tests to pass on Windows as well
as three other Clang tests, so they have re-enabled.
This solves the majority of PR43272.  Additional VFS test failures will
be fixed in separate patches.
Differential Revision: https://reviews.llvm.org/D69958
The file was modifiedclang/test/Modules/double-quotes.m
The file was modifiedclang/test/Index/index-module-with-vfs.m
The file was modifiedclang/test/VFS/external-names.c
The file was modifiedclang/test/VFS/include-real-from-virtual.c
The file was modifiedclang/test/VFS/umbrella-framework-import-skipnonexist.m
The file was modifiedclang/test/VFS/framework-import.m
The file was modifiedclang/test/VFS/include-virtual-from-real.c
The file was modifiedclang/test/VFS/include-mixed-real-and-virtual.c
The file was modifiedclang/test/VFS/incomplete-umbrella.m
The file was modifiedclang/test/VFS/relative-path.c
The file was modifiedclang/test/VFS/include.c
The file was modifiedclang/test/VFS/module-import.m
The file was modifiedclang/test/VFS/real-path-found-first.m
The file was modifiedclang/test/VFS/implicit-include.c
The file was modifiedllvm/include/llvm/Support/VirtualFileSystem.h
The file was modifiedclang/test/Modules/framework-public-includes-private.m
The file was modifiedllvm/lib/Support/VirtualFileSystem.cpp
Commit c9de002a2cf02b1a00abe5caaa05fd722583218a by scott.linder
[AMDGPU][HIP] Change default DWARF version to 4
Summary: Tooling around DWARF 5 is still not mature enough for this to
be a sane default, and the AMDGPU and HIP toolchains should agree on a
single default.
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, aprantl,
dstuttard, tpr, t-tye, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70191
The file was modifiedclang/test/Driver/amdgpu-toolchain.c
The file was modifiedclang/lib/Driver/ToolChains/HIP.h
The file was modifiedclang/lib/Driver/ToolChains/AMDGPU.h
The file was addedclang/test/Driver/hip-toolchain-dwarf.hip
Commit 0e45e60c6f316d095d878aea3c098202b39b5bee by Adrian Prantl
Use ForEachExternalModule in ParseTypeFromClangModule (NFC)
I wanted to further simplify ParseTypeFromClangModule by replacing the
hand-rolled loop with ForEachExternalModule, and then realized that
ForEachExternalModule also had the problem of visiting the same leaf
node an exponential number of times in the worst-case. This adds a set
of searched_symbol_files set to the function as well as the ability to
early-exit from it.
Differential Revision: https://reviews.llvm.org/D70215
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
The file was modifiedlldb/source/Symbol/CompileUnit.cpp
The file was modifiedlldb/include/lldb/Symbol/SymbolFile.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
The file was modifiedlldb/include/lldb/Symbol/CompileUnit.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
Commit 4229f70d226b381ca82b49c7f66d7e33b73be9fd by Jonas Devlieghere
[LLDB] Make a clear distinction between usage & development docs
This renames the "Goals & Status" section to "Project" and the
"Resources" section to "Development". To better match this layout I've
moved the releases page under "Project".
The file was modifiedlldb/docs/.htaccess
The file was modifiedlldb/docs/index.rst
The file was removedlldb/docs/resources/download.rst
The file was addedlldb/docs/status/releases.rst
Commit 83f5287567bcdf1b5de244229fba4e552b7d0054 by Adrian Prantl
Rename DWO -> Clang module to avoid confusion. (NFC)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Commit 0352007fdb3f6ae1eaedbff53e018ad1e364720e by Adrian Prantl
Convert UpdateExternalModuleListIfNeeded to use early exits.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Commit 268e11f95d331a6268f08bf94ce86d04efbb7baa by Adrian Prantl
Convert condition to early exit (NFC)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Commit dcb5bd91095fc2a009a777e4d7eefb127f057634 by Adrian Prantl
Fix incorrect comment.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Commit 399e29ddc600a2d91e08e7029e7dade3581c9820 by a.bataev
[OPENMP]Add assignment operator in UDR test, NFC.
Add assignment operator in the test to check that even if the operator
was declare explicitly, the constructor is called in the user-defined
reduction initializer anyway.
The file was modifiedclang/test/OpenMP/for_reduction_codegen_UDR.cpp
Commit e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 by rnk
[clang-include-fixer] Skip .rc files when finding symbols
Summary: For some reason CMake includes entries for .rc files, but
find-all-symbols handles them improperly.
See PR43993
Reviewers: sammccall, bkramer
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70196
The file was modifiedclang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py
Commit 56ae3e2692ed0381dbdc3c29a199fd047f559037 by kevin.neal
Make the language more consistent since I'm about to commit a content
change next.
The file was modifiedllvm/docs/LangRef.rst
Commit 385572ccfe5048682d76ed3053a9f41ba89d8dd3 by spatel
[InstCombine] remove duplicate code for simplifying a shuffle; NFCI
The transform is already handled by InstSimplify or earlier in
InstCombine, so trying to do it again is not necessary.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
Commit d2b6cc7ff6d8dd56358d63da8738f529ae312a65 by kevin.neal
Document more specifically the rounding for "llvm.round".
Differential Revision: https://reviews.llvm.org/D68810
The file was modifiedllvm/docs/LangRef.rst
Commit cfca818ef7b8a3659c41d741c90b38c69478598a by tstellar
[cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows
Summary: The BUILD_SHARED_LIBS=ON build fails on Windows, so prevent
users from enabling it.
Reviewers: beanz, smeenai, compnerd, phosek
Reviewed By: beanz
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70161
The file was modifiedllvm/CMakeLists.txt
Commit 5fe3f00ae2753d84ad2f9ca7c5a2b56c34344dfb by rnk
Replace wrongly deleted header banner, fix formatting
I reviewed the diff hunks of 05da2fe52162c80dfa that don't contain
'#include' lines, and found two unintended changes. I deleted a header
banner inadvertently while inserting a header, and changed the
indentation of a constructor in an odd way. Add back the banner, and
reformat the constructor.
The file was modifiedllvm/lib/CodeGen/PostRAHazardRecognizer.cpp
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
Commit 4ee70e00b509fe26bac4196df76dc7c6153f1206 by mitchell
[clang-format] Fixed edge-case with SpacesInSquareBrackets with trailing
bare "&" lambda capture.
Summary: Lambda captures allow for a lone `&` capture, so `&]` needs to
be properly handled.
`int foo = [& ]() {}` is fixed to give `int foo = [ & ]() {}`
Reviewers: MyDeveloperDay
Reviewed by: MyDeveloperDay
Subscribers: cfe-commits
Tags: #clang, #clang-format
Differential Revision: https://reviews.llvm.org/D70249
The file was modifiedclang/lib/Format/TokenAnnotator.cpp
The file was modifiedclang/unittests/Format/FormatTest.cpp
Commit 17bb2d7c803db4cc52ebfb95e627b92eeccf302a by craig.topper
[ExpandReductions] Don't push all intrinsics to the worklist. Just push
reductions.
We were previously pushing all intrinsics used in a function to the
worklist. This is wasteful for memory in a function with a lot of
intrinsics.
We also ask TTI if we should expand every intrinsic, but we only have
expansion support for the reduction intrinsics. This just wastes time
for the non-reduction intrinsics.
This patch only pushes reduction intrinsics into the worklist and skips
other intrinsics.
Differential Revision: https://reviews.llvm.org/D69470
The file was modifiedllvm/lib/CodeGen/ExpandReductions.cpp
Commit c6b09bff5671600f8e764d3847023d0996f328d9 by luismarques
[RISCV] Fix wrong CFI directives
Summary: Removes CFI CFA directives that could incorrectly propagate
beyond the basic block they were inteded for. Specifically it removes
the epilogue CFI directives. See the branch_and_tail_call test for an
example of the issue. Should fix the stack unwinding issues caused by
the incorrect directives.
Reviewers: asb, lenary, shiva0217 Reviewed By: lenary Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69723
The file was modifiedllvm/test/CodeGen/RISCV/frame-info.ll
The file was modifiedllvm/test/CodeGen/RISCV/split-offsets.ll
The file was modifiedllvm/test/CodeGen/RISCV/vararg.ll
The file was modifiedllvm/lib/Target/RISCV/RISCVFrameLowering.cpp
The file was modifiedllvm/test/DebugInfo/RISCV/relax-debug-frame.ll
The file was modifiedllvm/test/CodeGen/RISCV/large-stack.ll
The file was modifiedllvm/test/CodeGen/RISCV/exception-pointer-register.ll
Commit caa9493da85561c6a2308bf9821fe6d14323b8f5 by serguei.n.dmitriev
[llvm-objcopy][COFF] Add support for extended relocation tables
Summary: This patch adds support for COFF objects with extended
relocation tables to the llvm-objcopy tool.
Reviewers: jhenderson, MaskRay, mstorsjo, alexshap, rupprecht
Reviewed By: mstorsjo
Subscribers: jakehehrlich, abrachet, seiya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70205
The file was modifiedllvm/tools/llvm-objcopy/COFF/Reader.cpp
The file was modifiedllvm/test/tools/llvm-objcopy/COFF/add-section.test
The file was addedllvm/test/tools/llvm-objcopy/COFF/Inputs/x86_64-xrelocs.obj.gz
The file was modifiedllvm/tools/llvm-objcopy/COFF/Writer.cpp
Commit 141bb5f308fa108045400622889a21a12c4ed41c by matthew.voss
Add support for multi-module bitcode files to llvm-dis
Summary: This change allows llvm-dis to disassemble multi-module bitcode
files, including the associated module summary.
Reviewers: tejohnson, pcc, mehdi_amini
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70153
The file was modifiedllvm/test/Bitcode/invalid.test
The file was addedllvm/test/Assembler/multi-summary-disassemble.ll
The file was modifiedllvm/test/Bitcode/multi-module.ll
The file was modifiedllvm/tools/llvm-dis/llvm-dis.cpp
The file was addedllvm/test/Assembler/multi-mod-disassemble.ll
Commit 32d840d29179383a28d59d68fccd74f52f316faf by selliott
[RISCV] Use addi rather than add x0
Summary: The RISC-V backend used to generate `add <reg>, x0, <reg>` in a
few instances. It seems most places no longer generate this sequence.
This is semantically equivalent to `addi <reg>, <reg>, 0`, but the
latter has the advantage of being noted to be the canonical instruction
to be used for moves (which microarchitectures can and should recognise
as such).
The changed testcases use instruction aliases - `mv <reg>, <reg>` is an
alias for `addi <reg>, <reg>, 0`.
Reviewers: luismarques
Reviewed By: luismarques
Subscribers: hiraditya, asb, rbar, johnrusso, simoncook, apazos,
sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng,
edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX,
jocewei, psnobl, benna, Jim, s.egerton, pzheng, sameer.abuasal,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70124
The file was modifiedllvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp
The file was modifiedllvm/test/CodeGen/RISCV/atomic-rmw.ll
Commit e85a96ddbfb487aa8c8bc393a7111f0868f9b3a5 by sgundapa
Update lit infra to detect "MemoryWithOrigins' sanitizer build.
Differential Revision: https://reviews.llvm.org/D68399
The file was modifiedllvm/utils/lit/lit/llvm/config.py
Commit 9fcf4f372c7e08b7ee64a202cc09860a17da8152 by sgundapa
[Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.
Before this patch if we pass "-mcpu=hexagonv65 -march=hexagon" in this
order, the driver fails to figure out the correct cpu version. This
patch fixed this issue.
The file was modifiedclang/test/Driver/hexagon-toolchain-elf.c
The file was modifiedclang/lib/Driver/ToolChains/Hexagon.cpp
Commit fdf1ae37cfa8718c9c4f060ad1186a57a36ca3f8 by sgundapa
[Hexagon] Validate the iterators before converting them to mux.
The conditional instructions that are translated to mux instructions are
deleted and the iterators to these deleted instructions are being used
later. This patch fixed this issue.
The file was modifiedllvm/lib/Target/Hexagon/HexagonGenMux.cpp
The file was addedllvm/test/CodeGen/Hexagon/muxii-bug.ll
Commit 7c7e368a7ffc33be7c7bbf1d8149803b32b8c0a8 by sgundapa
[Pipeliner] Fix an assertion caused by iterator invalidation.
The file was modifiedllvm/lib/CodeGen/MachinePipeliner.cpp
The file was addedllvm/test/CodeGen/Hexagon/swp-crash-iter.ll
Commit baacd1891851b1ba0bd303e2a75f1d3af324fca6 by paul.robinson
Fix up lit's tests to run in a multi-config build environment.
Differential Revision: https://reviews.llvm.org/D70239
The file was addedllvm/utils/lit/tests/Inputs/lit.cfg
Commit f2e65447b3cb6340883957e033e77095a025ebdc by rupprecht
[lldb][Editline] Support ctrl+left/right arrow word navigation.
Summary: This adds several 5C/5D escape codes that allow moving
forward/backward words similar to bash command line navigation.
On my terminal, `ctrl+v ctrl+<left arrow>` prints `^[[1;5D`. However, it
seems inputrc also maps other escape variants of this to
forward/backward word, so I've included those too. Similar for 5C =
ctrl+right arrow.
Reviewers: JDevlieghere, labath
Reviewed By: JDevlieghere, labath
Subscribers: merge_guards_bot, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70137
The file was addedlldb/packages/Python/lldbsuite/test/terminal/TestEditline.py
The file was modifiedlldb/source/Host/common/Editline.cpp