Started 1 mo 11 days ago
Took 17 hr on green-dragon-08

Failed Build #5462 (Sep 4, 2019 1:37:44 AM)

Revisions
  • http://llvm.org/svn/llvm-project/llvm/trunk : 370849
  • http://llvm.org/svn/llvm-project/cfe/trunk : 370850
  • http://llvm.org/svn/llvm-project/compiler-rt/trunk : 370756
  • http://llvm.org/svn/llvm-project/debuginfo-tests/trunk : 364589
  • http://llvm.org/svn/llvm-project/libcxx/trunk : 370796
  • http://llvm.org/svn/llvm-project/clang-tools-extra/trunk : 370843
Changes
  1. Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"

    While the next Visual Studio update (16.3) will fix this issue, that hasn't
    shipped yet. Until then Clang wouldn't work with MSVC's headers which seems
    unfortunate. Let's keep this in until VS 16.3 ships. (See also PR42843.)

    > Fixes link errors with clang and the latest Visual C++ 14.21.27702
    > headers, which was reported as PR42027.
    >
    > I chose to intentionally make these things linkonce_odr, i.e.
    > discardable, so that we don't emit definitions of these things in every
    > translation unit that includes STL headers.
    >
    > Note that this is *not* what MSVC does: MSVC has not yet implemented C++
    > DR2387, so they emit fully specialized constexpr variable templates with
    > static / internal linkage.
    >
    > Reviewers: rsmith
    >
    > Differential Revision: https://reviews.llvm.org/D63175 (detail/ViewSVN)
    by hans
  2. [IRPrinting] Improve module pass printer to work better with -filter-print-funcs

    Summary: Previously module pass printer pass prints the banner even when the module doesn't include any function provided with `-filter-print-funcs` option. This introduced a lot of noise, especailly with ThinLTO. This diff addresses the issue and makes the banner printed only when the module includes functions in `-filter-print-funcs` list.

    Reviewers: fedor.sergeev

    Subscribers: mehdi_amini, hiraditya, dexonsmith, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D66560 (detail/ViewSVN)
    by twoh
  3. [GlobalISel] Fix G_SEXT narrowScalar to bail out of unsupported type combination.

    Similar to the issue with G_ZEXT that was fixed earlier, this is a quick
    to fall back if the source type is not exactly half of the dest type.

    Fixes the clang-cmake-aarch64-lld bot build. (detail/ViewSVN)
    by aemerson
  4. gn build: Merge r370843 (detail/ViewSVN)
    by nico
  5. [clangd] Split Preamble.h out of ClangdUnit.h. NFC

    Summary:
    Add comment describing use of preamble in clangd.
    Remove deps on ClangdUnit.h where possible.

    Subscribers: mgorny, ilya-biryukov, javed.absar, MaskRay, jkorous, mgrang, arphaman, kadircet, cfe-commits

    Tags: #clang

    Differential Revision: https://reviews.llvm.org/D67117 (detail/ViewSVN)
    by sammccall
  6. [Clang Interpreter] Initial patch for the constexpr interpreter

    Summary:
    This patch introduces the skeleton of the constexpr interpreter,
    capable of evaluating a simple constexpr functions consisting of
    if statements. The interpreter is described in more detail in the
    RFC. Further patches will add more features.

    Reviewers: Bigcheese, jfb, rsmith

    Subscribers: bruno, uenoku, ldionne, Tyker, thegameg, tschuett, dexonsmith, mgorny, cfe-commits

    Tags: #clang

    Differential Revision: https://reviews.llvm.org/D64146 (detail/ViewSVN)
    by nand
  7. [llvm-objcopy] Fix some identifier names in comments. NFC (detail/ViewSVN)
    by maskray
  8. [RISCV] Enable tail call opt for variadic function

    Summary: Tail call opt can treat variadic function call the same as normal function call

    Reviewers: mgrang, asb, lenary, lewis-revill

    Reviewed By: lenary

    Subscribers: luismarques, pzheng, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, s.egerton, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D66278 (detail/ViewSVN)
    by jimlin
  9. [MemorySSA] Move two verify calls under expensive checks. (detail/ViewSVN)
    by asbirlea
  10. [NFC][llvm-ifs] Adding .ifs files to the test list for llvm-ifs tool. (detail/ViewSVN)
    by zer0
  11. Revert [Windows] Disable TrapUnreachable for Win64, add SEH_NoReturn

    This reverts r370525 (git commit 0bb1630685fba255fa93def92603f064c2ffd203)
    Also reverts r370543 (git commit 185ddc08eed6542781040b8499ef7ad15c8ae9f4)

    The approach I took only works for functions marked `noreturn`. In
    general, a call that is not known to be noreturn may be followed by
    unreachable for other reasons. For example, there could be multiple call
    sites to a function that throws sometimes, and at some call sites, it is
    known to always throw, so it is followed by unreachable. We need to
    insert an `int3` in these cases to pacify the Windows unwinder.

    I think this probably deserves its own standalone, Win64-only fixup pass
    that runs after block placement. Implementing that will take some time,
    so let's revert to TrapUnreachable in the mean time. (detail/ViewSVN)
    by rnk
  12. [WebAssembly] Compare functions by names in Emscripten Sjlj

    Summary:
    This removes all string constants for function names and compares
    functions by string directly when needed. Many of these constants are
    used only once or twice so the benefit of defining them separately is
    not very clear, and this actually fixes a bug.

    When we already have a `malloc` declaration which is an alias to
    something else within the module,
    ```
    @malloc = weak hidden alias i8* (i32), i8* (i32)* @dlmalloc
    ```
    (this happens compiling with emscripten with `-s WASM_OBJECT_FILES=0`
    because all bc files are merged before being fed into `wasm-ld` which
    runs the backend optimizations as LTO)

    `Module::getFunction("malloc")` in `canLongjmp` returns `nullptr`
    because `Module::getFunction` dyncasts pointer into `Function`, but the
    alias is a `GlobalValue` but not a `Function`. This makes `canLongjmp`
    return false for `malloc` in this case, and we end up adding a lot of
    longjmp handling code around malloc. This is not only a code size
    increase but actually a bug because `malloc` is used in the entry block
    when preparing for setjmp tables for emscripten sjlj handling, and this
    makes initial setjmp preparation, which has to happen in the entry
    block, move to another split block, and this interferes with SSA update
    later.

    This also adds two more functions, `getTempRet0` and `setTempRet0`, in
    the list of not longjmp-able functions.

    Fixes https://github.com/emscripten-core/emscripten/issues/8935.

    Reviewers: sbc100

    Subscribers: mehdi_amini, jgravelle-google, hiraditya, sunfish, dexonsmith, dschuff, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67129 (detail/ViewSVN)
    by aheejin
  13. [llvm-profdata] Add mode to recover from profile read failures

    Add a mode in which profile read errors are not immediately treated as
    fatal. In this mode, merging makes forward progress and reports failure
    only if no inputs can be read.

    Differential Revision: https://reviews.llvm.org/D66985 (detail/ViewSVN)
    by Vedant Kumar
  14. [InstrProf] Tighten a check for malformed data records in raw profiles

    The check needs to validate a counter offset before performing pointer
    arithmetic with the (potentially corrupt) offset.

    Found by UBSan's pointer overflow check.

    rdar://54843625

    Differential Revision: https://reviews.llvm.org/D66979 (detail/ViewSVN)
    by Vedant Kumar
  15. [libclang][test][NFC] Split off fixture from tests. (detail/ViewSVN)
    by Jan Korous
  16. [GVN] Remove a todo introduced w/rL370791

    When I dug into this, it turns out to be *much* more involved than I'd realized and doesn't actually simplify anything. 

    The general purpose of the leader table is that we want to find the most-dominating definition quickly.  The problem for equivalance folding is slightly different; we want to find the most dominating *value* whose definition block dominates our use quickly.

    To make this change, we'd end up having to restructure the leader table (either the sorting thereof, or maybe even introducing multiple leader tables per value) and that complexity is just not worth it. (detail/ViewSVN)
    by reames
  17. [AArch64][GlobalISel] Legalize 128 bit divisions to libcalls.

    Now that we have the infrastructure to support s128 types as parameters
    we can expand these to libcalls.

    Differential Revision: https://reviews.llvm.org/D66185 (detail/ViewSVN)
    by aemerson
  18. [GlobalISel][CallLowering] Add support for splitting types according to calling conventions.

    On AArch64, s128 types have to be split into s64 GPRs when passed as arguments.
    This change adds the generic support in call lowering for dealing with multiple
    registers, for incoming and outgoing args.

    Support for splitting for return types not yet implemented.

    Differential Revision: https://reviews.llvm.org/D66180 (detail/ViewSVN)
    by aemerson
  19. [MemorySSA] Disable MemorySSA use.

    Differential Revision: https://reviews.llvm.org/D58311 (detail/ViewSVN)
    by asbirlea
  20. [Attributor] Use the delete API for liveness

    Reviewers: uenoku, sstefan1

    Subscribers: hiraditya, bollu, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D66833 (detail/ViewSVN)
    by jdoerfert
  21. [Attributor] Deduce "no-capture" argument attribute

    Add the no-capture argument attribute deduction to the Attributor
    fixpoint framework.

    The new string attributed "no-capture-maybe-returned" is introduced to
    allow deduction of no-capture through functions that "capture" an
    argument but only by "returning" it. It is only used by the Attributor
    for testing.

    Differential Revision: https://reviews.llvm.org/D59922 (detail/ViewSVN)
    by jdoerfert
  22. [CodeGen] Use FSHR in DAGTypeLegalizer::ExpandIntRes_MULFIX

    Summary:
    Simplify the right shift of the intermediate result (given
    in four parts) by using funnel shift.

    There are some impact on lit tests, but that seems to be
    related to register allocation differences due to how FSHR
    is expanded on X86 (giving a slightly different operand order
    for the OR operations compared to the old code).

    Reviewers: leonardchan, RKSimon, spatel, lebedev.ri

    Reviewed By: RKSimon

    Subscribers: hiraditya, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, s.egerton, pzheng, bevinh, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67036 (detail/ViewSVN)
    by bjope
  23. Skip MCJIT unit tests if LLVM is not configured for native compilation

    Patch by Sergej Jaskiewicz!

    Differential Revision: D67089 (detail/ViewSVN)
    by dblaikie
  24. [MemorySSA] Re-enable MemorySSA use.

    Differential Revision: https://reviews.llvm.org/D58311 (detail/ViewSVN)
    by asbirlea
  25. [AMDGPU] Set default flat work group size to (1,256) for HIP

    Differential Revision: https://reviews.llvm.org/D67048 (detail/ViewSVN)
    by yaxunl
  26. Unbreak the build after r370798 (detail/ViewSVN)
    by d0k
  27. [MC] Pass through .code16/32/64 and .syntax unified for COFF

    These flags should simply be passed through to the target, which will do
    the right thing. Add an MC/X86 test that uses these directives with the
    three primary object file formats and shows that they disassemble the
    same everywhere.

    There is a missing test for .code32 on Windows ARM, since I'm not sure
    exactly how to construct one.

    Fixes PR43203 (detail/ViewSVN)
    by rnk
  28. Disable stack exhaustion test on NetBSD, where either the detection or
    recovery mechanism does not appear to work. (detail/ViewSVN)
    by rsmith
  29. [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

    There are some functions which can't be given a null pointer as parameter either
    because it has a nonnull attribute or it is declared to have undefined behavior
    (e.g. strcmp()). Sometimes it is hard to determine from the checker message
    which parameter is null at the invocation, so now this information is included
    in the message.

    This commit fixes https://bugs.llvm.org/show_bug.cgi?id=39358

    Reviewed By: NoQ, Szelethus, whisperity

    Patch by Tibor Brunner!

    Differential Revision: https://reviews.llvm.org/D66333 (detail/ViewSVN)
    by szelethus
  30. [libc++] Mark usage of _Atomic with __extension__

    An upcoming change in Clang will flag _Atomic as being a C11 extension.
    To avoid generating this warning in libc++, this commit marks the only
    use of _Atomic with the __extension__ extension, which suppresses such
    warnings. (detail/ViewSVN)
    by Louis Dionne
  31. [www] Mark items complete in Clang 9 as 'Clang 9' rather than 'SVN'.

    Don't turn the boxes green yet, since Clang 9 hasn't been released. (detail/ViewSVN)
    by rsmith
  32. [CUDA] Use activemask.b32 instruction to implement __activemask w/ CUDA-9.2+

    vote.ballot instruction is gone in recent CUDA versions and
    vote.sync.ballot can not be used because it needs a thread mask parameter.
    Fortunately PTX 6.2 (introduced with CUDA-9.2) provides activemask.b32
    instruction for this.

    Differential Revision: https://reviews.llvm.org/D66665 (detail/ViewSVN)
    by tra
  33. [GVN] Propagate simple equalities from assumes within the tail of the block

    This extends the existing logic for propagating constant expressions in an analogous manner for what we do across basic blocks. The core point is that we chose some order of operands, and canonicalize uses towards that one.

    The heuristic used is inspired by the one used across blocks; in a follow up change, I'd plan to common them so that the cross block version uses the slightly stronger ordering herein.

    As noted by the TODOs in the code, there's a good amount of room for improving the existing code and making it more powerful.  Some follow up work planned.

    Differential Revision: https://reviews.llvm.org/D66977 (detail/ViewSVN)
    by reames
  34. [AArch64][GlobalISel] Don't import i64imm_32bit pattern at -O0

    This pattern, when imported at -O0 adds an extra copy via the SUBREG_TO_REG.

    This is because the SUBREG_TO_REG is not eliminated. At all other opt levels,
    it is eliminated.

    This is a 1% geomean code size savings at -O0 on CTMark.

    Differential Revision: https://reviews.llvm.org/D67027 (detail/ViewSVN)
    by paquette
  35. Revert r370454 "[LoopIdiomRecognize] BCmp loop idiom recognition"

    https://bugs.llvm.org/show_bug.cgi?id=43206 was filed,
    claiming that there is a miscompilation.
    Reverting until i investigate.

    This reverts commit r370454 (detail/ViewSVN)
    by lebedevri
  36. [Tests/GVN] Precommit requested test additions from D66977 (detail/ViewSVN)
    by reames
  37. clang: default to DWARF 4 for FreeBSD 12.0 and later

    Older FreeBSD versions included GDB 6.1 and had other tools that were
    unable to handle debug information newer than DWARF 2.  Those tools have
    since been updated.  (An old version of GDB is still kept for kernel
    crash handling, but the kernel is compiled with an explicit -gdwarf2.)

    Reviewed by: dim
    Differential Revision: https://reviews.llvm.org/D66760 (detail/ViewSVN)
    by emaste
  38. [LifetimeAnalysis] Fix some false positives

    Differential Revision: https://reviews.llvm.org/D66806 (detail/ViewSVN)
    by xazax
  39. [cmake] Improve comment describing the C4245 warning. NFCI. (detail/ViewSVN)
    by rksimon
  40. [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in AArch64ISelLowering.cpp

    Summary: Adds break to 'x' case in getRegForInlineAsmConstraint added by D66302, fixing the unintentional fallthrough.

    Reviewers: sdesmalen, rovka, cameron.mcinally, greened, gribozavr, ruiu

    Reviewed By: sdesmalen

    Subscribers: bjope, javed.absar, tschuett, kristof.beyls, rkruppe, psnobl, llvm-commits, cfe-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67095 (detail/ViewSVN)
    by kmclaughlin
  41. [clangd] Move getBeginningOfIdentifier from ClangdUnit to SourceCode. Drop dependencies on ClangdUnit from some headers. NFC (detail/ViewSVN)
    by sammccall
  42. [analyzer] Add a checker option to detect nested dead stores

    Enables the users to specify an optional flag which would warn for more dead
    stores.
    Previously it ignored if the dead store happened e.g. in an if condition.

    if ((X = generate())) { // dead store to X
    }

    This patch introduces the `WarnForDeadNestedAssignments` option to the checker,
    which is `false` by default - so this change would not affect any previous
    users.
    I have updated the code, tests and the docs as well. If I missed something, tell
    me.

    I also ran the analysis on Clang which generated 14 more reports compared to the
    unmodified version. All of them seemed reasonable for me.

    Related previous patches:
    rGf224820b45c6847b91071da8d7ade59f373b96f3

    Reviewers: NoQ, krememek, Szelethus, baloghadamsoftware

    Reviewed By: Szelethus

    Patch by Balázs Benics!

    Differential Revision: https://reviews.llvm.org/D66733 (detail/ViewSVN)
    by szelethus
  43. [clangd] Remove redundant semi-colon. (detail/ViewSVN)
    by hliao
  44. [X86] Merge 2 consecutive HasInt256 branches. NFCI. (detail/ViewSVN)
    by rksimon
  45. [clang-tidy] Fix a false positive in unused-using-decl check

    The previous matcher "hasAnyTemplateArgument(templateArgument())" only
    matches the first template argument, but the check wants to iterate all
    template arguments. This patch fixes this.

    Also some refactorings in this patch (to make the code reusable). (detail/ViewSVN)
    by hokein
  46. [clangd] Decouple macro/decl-under-cursor finding. Don't pretend there can be multiple macros. NFC. (detail/ViewSVN)
    by sammccall

Started by upstream project Clang Stage 2: cmake, R -g Tsan, using Stage 1 RA build number 18255
originally caused by:

Started by upstream project Clang Stage 2: cmake, R -g Tsan, using Stage 1 RA build number 18256
originally caused by:

Started by upstream project Clang Stage 2: cmake, R -g Tsan, using Stage 1 RA build number 18257
originally caused by:

Started by upstream project Clang Stage 2: cmake, R -g Tsan, using Stage 1 RA build number 18258
originally caused by:

Started by upstream project Clang Stage 2: cmake, R -g Tsan, using Stage 1 RA build number 18259
originally caused by:

This run spent:

  • 17 hr waiting;
  • 17 hr build duration;
  • 1 day 10 hr total from scheduled to completion.

Identified problems

Regression test failed

This build failed because a regression test in the test suite FAILed. See the test report for details.
Indication 1

Ninja target failed

Below is a link to the first failed ninja target.
Indication 2

Missing test results

The test result file Jenkins is looking for does not exist after the build.
Indication 3

Compile Error

This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 4