FailedChanges

Summary

  1. [sancov] Accommodate sancov and coverage report server for use under Windows Summary: This patch makes the following changes to SanCov and its complementary Python script in order to resolve issues pertaining to non-UNIX file paths in JSON symbolization information: * Convert all paths to use forward slash. * Update `coverage-report-server.py` to correctly handle paths to sources which contain spaces. * Remove Linux platform restriction for all SanCov unit tests. All SanCov tests passed when ran on my local Windows machine. Patch by Douglas Gliner. Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman Reviewed By: vitalybuka Subscribers: vsk, Dor1s, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D51018
  2. [sancov] Use LLVM Support library JSON writer in favor of individual implementation Summary: In this diff, I've replaced the individual implementation of `JSONWriter` with `json::OStream` provided by `llvm/Support/JSON.h`. Important Note: The output format of the JSON is considerably different compared to the original implementation. Important differences include: * New line for each entry in an array (should make diffs cleaner) * No space between keys and colon in attributed object entries. * Attributes with empty strings will now print the attribute name and a quote pair rather than excluding the attribute altogether Examples of these differences can be seen in the changes to the sancov tests which compare the JSON output. Patch by Douglas Gliner. Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman Subscribers: mehdi_amini, dexonsmith, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D68752
  3. Slightly relax restriction on exact order arguments must appear.
  4. [asan] Return true from instrumentModule createSanitizerCtorAndInitFunctions always change the module.
Revision 374629 by Vitaly Buka:
[sancov] Accommodate sancov and coverage report server for use under Windows

Summary:
This patch makes the following changes to SanCov and its complementary Python script in order to resolve issues pertaining to non-UNIX file paths in JSON symbolization information:
* Convert all paths to use forward slash.
* Update `coverage-report-server.py` to correctly handle paths to sources which contain spaces.
* Remove Linux platform restriction for all SanCov unit tests. All SanCov tests passed when ran on my local Windows machine.

Patch by Douglas Gliner.

Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman

Reviewed By: vitalybuka

Subscribers: vsk, Dor1s, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D51018
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/sancov/blacklist.test (diff)llvm.src/test/tools/sancov/blacklist.test
The file was modified/llvm/trunk/test/tools/sancov/covered_functions.test (diff)llvm.src/test/tools/sancov/covered_functions.test
The file was modified/llvm/trunk/test/tools/sancov/merge.test (diff)llvm.src/test/tools/sancov/merge.test
The file was modified/llvm/trunk/test/tools/sancov/not_covered_functions.test (diff)llvm.src/test/tools/sancov/not_covered_functions.test
The file was modified/llvm/trunk/test/tools/sancov/print.test (diff)llvm.src/test/tools/sancov/print.test
The file was modified/llvm/trunk/test/tools/sancov/stats.test (diff)llvm.src/test/tools/sancov/stats.test
The file was modified/llvm/trunk/test/tools/sancov/symbolize.test (diff)llvm.src/test/tools/sancov/symbolize.test
The file was modified/llvm/trunk/test/tools/sancov/symbolize_noskip_dead_files.test (diff)llvm.src/test/tools/sancov/symbolize_noskip_dead_files.test
The file was modified/llvm/trunk/test/tools/sancov/validation.test (diff)llvm.src/test/tools/sancov/validation.test
The file was modified/llvm/trunk/tools/sancov/coverage-report-server.py (diff)llvm.src/tools/sancov/coverage-report-server.py
The file was modified/llvm/trunk/tools/sancov/sancov.cpp (diff)llvm.src/tools/sancov/sancov.cpp
Revision 374628 by Vitaly Buka:
[sancov] Use LLVM Support library JSON writer in favor of individual implementation

Summary:
In this diff, I've replaced the individual implementation of `JSONWriter` with `json::OStream` provided by `llvm/Support/JSON.h`.

Important Note: The output format of the JSON is considerably different compared to the original implementation. Important differences include:
* New line for each entry in an array (should make diffs cleaner)
* No space between keys and colon in attributed object entries.
* Attributes with empty strings will now print the attribute name and a quote pair rather than excluding the attribute altogether

Examples of these differences can be seen in the changes to the sancov tests which compare the JSON output.

Patch by Douglas Gliner.

Reviewers: kcc, filcab, phosek, morehouse, vitalybuka, metzman

Subscribers: mehdi_amini, dexonsmith, llvm-commits

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D68752
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/sancov/merge.test (diff)llvm.src/test/tools/sancov/merge.test
The file was modified/llvm/trunk/test/tools/sancov/symbolize.test (diff)llvm.src/test/tools/sancov/symbolize.test
The file was modified/llvm/trunk/test/tools/sancov/symbolize_noskip_dead_files.test (diff)llvm.src/test/tools/sancov/symbolize_noskip_dead_files.test
The file was modified/llvm/trunk/tools/sancov/sancov.cpp (diff)llvm.src/tools/sancov/sancov.cpp
Revision 374627 by dyung:
Slightly relax restriction on exact order arguments must appear.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Driver/openmp-offload.c (diff)clang.src/test/Driver/openmp-offload.c
Revision 374623 by Vitaly Buka:
[asan] Return true from instrumentModule

createSanitizerCtorAndInitFunctions always change the module.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (diff)llvm.src/lib/Transforms/Instrumentation/AddressSanitizer.cpp